songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
100,739 Commits 3 Branches 156 Tags 959 MiB
Commit Graph

210 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 8166579e55 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_master-GF 2021-10-11 19:58:07 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps: 
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
 2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé df560987a6 Whitespace & cleaning changes 2021-10-08 12:13:43 +02:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Dmitry Anisimov d82ca437c4 correctly handling wrong values in new classes 2021-08-20 11:19:22 +02:00
Dmitry Anisimov f2d9066aaf added more debug output for failure cases 2021-08-19 12:05:30 +02:00
Dmitry Anisimov c2a1f047eb fixed test suite errors in examples 2021-08-16 11:56:36 +02:00
Dmitry Anisimov 6d2a3894f6 fixed test suite warnings in fitting 2021-08-16 10:50:58 +02:00
Dmitry Anisimov 2246c4dcef Merge remote-tracking branch 'origin/master' into Shape_detection-Region_growing_on_spheres-GF 2021-08-16 10:27:39 +02:00
Sébastien Loriot de6d8c6cbd Merge pull request #5742 from danston/Shape_regularization-new_package-danston 
[Feature] Shape Regularization New Package
 2021-08-13 18:19:35 +02:00
Dmitry Anisimov 5f0ed6ba7b fixed missing param 2021-07-29 15:26:22 +02:00
Dmitry Anisimov 37dcf522de refactoring the clear function 2021-07-29 13:57:44 +02:00
Dmitry Anisimov ae0a1fd6d0 Merge remote-tracking branch 'origin/Shape_detection-fix_leaks_in_ransac-danston' into Shape_detection-Region_growing_on_spheres-GF 2021-07-08 17:31:45 +02:00
Dmitry Anisimov 5e616f74e6 fixed leaks in ransac related to callback 2021-07-08 17:30:26 +02:00
Dmitry Anisimov 73df51622f fixed errors and warnings from the test suite 2021-07-08 16:38:53 +02:00
Dmitry Anisimov afb138478d all plane regularization stuff in shape detection is now moved to shape regularization 2021-06-25 16:55:15 +02:00
Simon Giraudot 6fbc190c0d Fix includes 2021-05-04 11:06:48 +02:00
Simon Giraudot 4b313a50d7 Add missing include 2021-05-04 10:20:09 +02:00
Simon Giraudot ad17c0b562 Cylinder/circle sorting + documentation update 2021-05-04 08:47:08 +02:00
Simon Giraudot a85583387d Doc of sorting 2021-04-28 15:52:56 +02:00
Simon Giraudot ab18b6bb39 Region growing sphere sorting + test 2021-04-28 14:38:08 +02:00
Simon Giraudot dc4b2c94c5 Move sphere fit out of fitting class 2021-04-28 12:15:18 +02:00
Simon Giraudot 4080a8c32f Rebase 2021-04-28 08:20:24 +02:00
Simon Giraudot 8e7ea14f58 Fix conversion warning 2021-04-14 10:57:53 +02:00
Simon Giraudot e87747d082 Fix candidate counting 2021-04-14 09:20:17 +02:00
Simon Giraudot 10f6992b2a Rebase on master 2021-04-07 14:32:31 +02:00
Simon Giraudot 4ec9bd6c9a Optimize location of node 2021-04-07 14:26:19 +02:00
Simon Giraudot 4c0018791c Fix bbox, width and depth computations in Octree wrapper 2021-04-07 14:13:29 +02:00
Simon Giraudot 1794620ab9 Move index access property map to property map package 2021-04-01 09:43:14 +02:00
Simon Giraudot 616cd5a549 Apply corrections from review 2021-04-01 08:55:51 +02:00
Simon Giraudot 91de37ec3a Fix warning: std::pow(float, int) returns double instead of float in recent C++ 2021-03-23 11:25:53 +01:00
Simon Giraudot 987b177833 Fix conversion warning 2021-03-18 08:36:34 +01:00
Simon Giraudot 9fe8708fc2 Fix bug that created empty octrees 2021-03-15 10:18:55 +01:00
Simon Giraudot a5f139f9df Remove unused variables 2021-03-11 09:34:33 +01:00
Simon Giraudot 46b9452ef4 Rebase on master 2021-03-04 13:48:11 +01:00
Simon Giraudot bbcab8e56f Merge remote-tracking branch 'mine/Shape_detection-Region_growing_on_spheres-GF' into Shape_detection-Region_growing_on_spheres-GF 2021-03-03 11:52:14 +01:00
Simon Giraudot 244ca61261 Text corrections from review 2021-02-23 08:26:41 +01:00
Simon Giraudot 0cf9990bf0 Fix conversion warning in RANSAC 2021-02-04 08:33:54 +01:00
Simon Giraudot a19836bfb6 Fix RANSAC's use of outdated Octree API 2021-01-20 11:20:01 +01:00
Simon Giraudot 1dcf876679 Remove TODOs 2021-01-19 14:07:13 +01:00
Simon Giraudot ae8ec55eac Merge remote-tracking branch 'jackson/gsoc2020-Octree-campolattaro' into gsoc2020-Octree-campolattaro 2021-01-19 09:54:58 +01:00
Simon Giraudot 661fe3505e User + ref manual for new region growing classes 2021-01-05 10:35:05 +01:00
Simon Giraudot 74d01916e3 Document missing parts 2021-01-04 15:23:41 +01:00
Simon Giraudot 8a2029e233 Add possibility to restrict radius of sphere/circle/cylinder 2021-01-04 15:20:10 +01:00
Simon Giraudot 5e0487e455 Add region growing on cylinders for point_set_3 2020-12-31 13:26:57 +01:00
Simon Giraudot 31c577fc47 Add region growing on circles for point_set_2 2020-12-30 14:51:15 +01:00
Simon Giraudot da90b6ee4f Add region growing on spheres for point_set_3 2020-12-30 08:48:28 +01:00
Laurent Rineau 47c4fc8aa2 Merge pull request #5279 from sgiraudot/RANSAC-Fix_ptrdiff_overflow-GF 
[RANSAC] Fix ptrdiff overflow
 2020-12-16 17:49:07 +01:00
Laurent Rineau fe34a5aa04 Merge pull request #5279 from sgiraudot/RANSAC-Fix_ptrdiff_overflow-GF 
[RANSAC] Fix ptrdiff overflow
 2020-12-16 17:47:45 +01:00
Simon Giraudot a7b2ed13f4 Fix conversion warning 2020-12-15 15:44:11 +01:00