songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
113,978 Commits 3 Branches 156 Tags 973 MiB
Commit Graph

118 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 8ccce4c536 Avoid one useless facet check 
This doesn't bring any speed-up because it was a very fast exit
in push_facet(): the neighbor was necessarily outside (since we
come from it), and we are done.
 2023-09-29 11:19:52 +02:00
Mael Rouxel-Labbé be42e0fbe8 Minor debug code cleaning 2023-09-29 11:19:39 +02:00
Mael Rouxel-Labbé 7e2386f97e Use the real circumradius value to sort the facets 
Meaning, use the value that we compare against alpha, and not
simply the radius of the smallest circumscribing ball.

This strongly changes the order of the queue and thus thus results
are very different, but still the same (same guarantees, same
element quality, only a little bit more elements, etc.)

Also a massive, ~35% speed-up, that needs to be investigated.
 2023-09-29 11:14:42 +02:00
Mael Rouxel-Labbé cfae913d77 Complete the sort functor in AW3's main queue 2023-09-29 11:13:31 +02:00
Mael Rouxel-Labbé e3854f68e3 Expose useful typedefs from Alpha_wrapper_3 2023-09-29 11:12:31 +02:00
Mael Rouxel-Labbé 00f167a835 Add benchmarking scripts 2023-09-29 11:02:47 +02:00
Mael bc8351f156
Fix typo 2023-09-27 11:06:49 +02:00
Mael Rouxel-Labbé 62bb2a58d0 Put the warnings outside of verbosity macros (too important) 2023-09-27 10:13:39 +02:00
Mael Rouxel-Labbé c82f2a9d9c Update some variable names to reflect the genericity of the triangulation 2023-09-27 10:11:31 +02:00
Mael Rouxel-Labbé d3b66037bc Merge remote-tracking branch 'cgal/master' into AW3-Resume_aw3-GF 2023-09-20 14:23:07 +02:00
Mael Rouxel-Labbé 19cb693a1b Improve debug code 2023-09-20 12:59:46 +02:00
Mael Rouxel-Labbé 5304f739b9 Enable restarting from a previous wrap 2023-09-20 12:57:02 +02:00
Mael Rouxel-Labbé bff07b2fc9 Simplify the gate comparer: we can also sort artificial facets like normal facets 
Artificial facets are *not* infinite facets.
 2023-09-20 12:55:11 +02:00
Mael Rouxel-Labbé 4d50ec46b3 Consider all cases in facet_status 
In a normal run of the algorithm, we shall never ask the facet status
of a facet that is already outside, but it's better to be complete
and it costs nothing.
 2023-09-20 12:53:12 +02:00
Mael Rouxel-Labbé 4512b0e6f4 Rewrite the extraction of possibly non-manifold wraps 2023-09-20 12:52:20 +02:00
Mael Rouxel-Labbé 88bcd40966 Enable changing the oracle in the AW3 builder 2023-09-20 12:50:25 +02:00
Mael Rouxel-Labbé 57fe29fe4f Add some comments about failed speedup experiments 2023-08-04 11:27:41 +02:00
Mael 330ff2e657 Fix spelling 
Thanks @albert-github!
 2023-08-03 12:30:18 +02:00
Mael Rouxel-Labbé b4e207ab00 Add some comments on AW3 manifoldness heuristics criteria 2023-08-03 12:30:12 +02:00
Mael Rouxel-Labbé c7b9317a96 Simplify choice of cells to un-carve while enforcing manifoldness 
This combinatorial choice seemed like a good idea, but it can have
nasty cascading effects, adding very large tetrahedra. See this
issue: https://github.com/CGAL/cgal/issues/7625

In the end, the only thing we care about is small volumes being added.

I keep the artificial vertex for now, but I am not fully convinced
these should be actually kept too.
 2023-08-03 12:30:08 +02:00
Mael Rouxel-Labbé 8076e20b71 Add debug code 2023-08-03 12:30:03 +02:00
Mael Rouxel-Labbé 6949cdb40a Fix missing default initialization of the AW3 markers in the new Vb/Cb 2023-08-03 12:15:58 +02:00
Mael Rouxel-Labbé dab6394215 Introduce AW3 Vb/Cb to avoid using T3_Vb/Cb_with_info_3 2023-08-03 12:05:40 +02:00
Mael Rouxel-Labbé 5e8d59c4dd Make the triangulation a template parameter of the Alpha Wrap builder 
Advanced users only for now: you need to know what you're doing
as the geom traits need to define the Ball_3 (usually that means
wrapping your Gt with AABB_AW_geom_traits) and you need to have
Vb/Cb contain the AW Vb/Cb in the stack.
 2023-07-21 16:22:41 +02:00
Mael Rouxel-Labbé 7f85651e82 Merge remote-tracking branch 'cgal/master' into PMP-Remove_degen_faces-no-clear-GF 2023-07-19 13:55:35 +02:00
Laurent Rineau aca86b9d27 Merge pull request #7500 from MaelRL/AW3-Stop_demo-GF 
Add stop button for AW3 demo
 2023-07-05 16:32:39 +02:00
Sébastien Loriot 0ee31a5d4f remove extra parenthesis 2023-06-19 19:17:49 +02:00
Sébastien Loriot c8a88b9014 remove CGAL_static_assertion* 2023-06-15 10:42:10 +02:00
Mael Rouxel-Labbé 5c8acef035 Add the possibility to interrupt AW3 (whether iterative visu is used or not) 2023-06-07 10:29:42 +02:00
Mael Rouxel-Labbé 1c646c0db2 Do not take a const& to the oracle in AW3 
No changes to existing oracles as AW3's oracles use a shared ptr to AABB Tree
 2023-06-07 10:28:35 +02:00
Mael Rouxel-Labbé a69a2f54c6 Rename to avoid conflict with STL 2023-05-16 14:21:27 +02:00
Mael Rouxel-Labbé 7a3ad05e05 Replace some calls of clear() by empty() to preserve internal property maps 2023-05-15 12:41:39 +02:00
Sébastien Loriot 9242a810c4 Merge remote-tracking branch 'cgal/master' into Region_growing-revision-soesau 2023-02-07 11:31:55 +01:00
Sébastien Loriot 411560a33e add missing default value 2023-01-26 09:56:25 +01:00
Sébastien Loriot cd76994056 rename property map and deprecated old name 2023-01-18 13:45:37 +01:00
albert-github 014c06fd19 spelling corrections 
Some spelling corrections (Directories starting with `A`)
 2022-11-14 15:32:47 +01:00
Laurent Rineau 3379f9bf9c Merge pull request #6998 from sloriot/AW_3-AABB_GT 
Rename traits class to avoid confusion
 2022-11-07 10:08:13 +01:00
Mael 9c2d913636
Also update the name of the include guard 2022-11-01 19:48:55 +01:00
Sébastien Loriot 7a8f91b34c rename traits class to avoid confusion 2022-11-01 16:09:26 +01:00
Mael Rouxel-Labbé 728be94816 Move some input named parameters to in_np 2022-10-12 09:45:31 +02:00
Mael Rouxel-Labbé 46c9fa19ab Add clear() to oracles 2022-09-03 14:00:20 +02:00
Sébastien Loriot c9c6b30cf0 Merge sloriot/CGAL-std_type_traits into master 2022-06-23 16:35:37 +02:00
Sébastien Loriot 4f5f8341cc use std::enable_if_t 2022-06-10 07:37:53 +02:00
Mael Rouxel-Labbé beeae185a7 Add a basic visitor to AW3 2022-06-08 12:04:02 +02:00
Mael Rouxel-Labbé 965964e8b8 Visualization with a soup, some colors, alpha shading etc. 2022-06-02 14:25:43 +02:00
Mael Rouxel-Labbé ae581c865a Iterative visualization 2022-06-02 02:21:26 +02:00
Mael Rouxel-Labbé 964bcd83ec Fix unused parameter warning 2022-05-25 09:37:37 +02:00
Mael Rouxel-Labbé 3a64952314 Fix using outside information to erroneously filter bboxes during traversal 2022-05-24 14:31:00 +02:00
Mael Rouxel-Labbé d56584bf28 Misc minor fixes / improvements 2022-05-24 14:30:42 +02:00
Mael Rouxel-Labbé 9fbfd9ac39 AW3 oracle improvements (mostly no longer templated by the data) 2022-05-24 10:08:56 +02:00
Mael Rouxel-Labbé 06053d2186 Allow empty oracle levels 2022-05-24 10:02:57 +02:00
Mael Rouxel-Labbé 57cf9e0f6a Add 3D Alpha Wrapping authors 2022-04-19 14:55:15 +02:00
Mael Rouxel-Labbé f950a379e3 Rename internal functions (manifoldness > manifold) 2022-04-07 14:11:49 +02:00
Mael Rouxel-Labbé 612441d217 Update copyright holder 2022-04-04 11:33:28 +02:00
Mael Rouxel-Labbé 6c2a30d3e1 Fix include 2022-04-04 11:33:28 +02:00
Mael Rouxel-Labbé 4b1e17d071 Clean debug output 2022-04-04 11:33:28 +02:00
Mael Rouxel-Labbé 11c6020d44 Fix typedef visibility 2022-04-04 11:33:28 +02:00
Mael Rouxel-Labbé 3dc05de649 Fix comment 2022-04-04 11:33:28 +02:00
Mael Rouxel-Labbé 4352230619 Fix passing alpha to the point set oracle constructor 2022-04-04 11:33:28 +02:00
Mael Rouxel-Labbé 5af654af36 Fix std::size_t/int conversion warning 2022-04-04 11:33:28 +02:00
Mael Rouxel-Labbé aaec78d705 Add min max parentheses for Windows 2022-04-04 11:33:28 +02:00
Mael Rouxel-Labbé a7a9cc0660 Rework initial bbox construction 2022-04-04 11:33:28 +02:00
Mael Rouxel-Labbé 73990764db Return early if cavity initialization failed 2022-04-04 11:33:28 +02:00
Mael Rouxel-Labbé 46562f2fa6 Misc cleaning 2022-04-04 11:33:28 +02:00
Mael Rouxel-Labbé b5f9c10b56 Clean obsolete NP 2022-04-04 11:33:27 +02:00
Mael Rouxel-Labbé 49ef4e7107 Fix header / license 2022-04-04 11:33:27 +02:00
Mael Rouxel-Labbé 2bfeb426a8 Comment fixes 2022-04-04 11:33:27 +02:00
Mael Rouxel-Labbé a40a7572ac Add Alpha_wrap_3 2022-04-04 11:33:27 +02:00