songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
113,978 Commits 3 Branches 156 Tags 973 MiB
Commit Graph

603 Commits

Author SHA1 Message Date
Sébastien Loriot 061bc2dc29 Merge remote-tracking branch 'cgal/6.0.x-branch' into `cgal/6.1.x-branch` 2025-12-12 17:48:59 +01:00
Sebastien Loriot fed810284e
CH3: Make convex_hull_3 deterministic (order of vertices and indices) (#9160) 
## Summary of Changes

Adding timestamp to convex_hull_3 vertex

The reason why it makes it deterministic is because during the creation
of the hull some border edges are collected here:
[`find_visible_set(tds, farthest_pt, f_handle, visible_set, border,
traits);`](https://github.com/CGAL/cgal/blob/main/Convex_hull_3/include/CGAL/convex_hull_3.h#L659C6-L659C80)

with `border` being [`typedef std::map<typename TDS_2::Vertex_handle,
typename TDS_2::Edge>
Border_edges;`](https://github.com/CGAL/cgal/blob/main/Convex_hull_3/include/CGAL/convex_hull_3.h#L643).

Then another container `edges` is filled using `border.begin()`
[here](https://github.com/CGAL/cgal/blob/main/Convex_hull_3/include/CGAL/convex_hull_3.h#L678C1-L692C7).

The call to [`Vertex_handle vh = tds.star_hole(edges.begin(),
edges.end(), visible_set.begin(),
visible_set.end());`](https://github.com/CGAL/cgal/blob/main/Convex_hull_3/include/CGAL/convex_hull_3.h#L707)
then induced that the order of faces in the TDS depends on the order of
edges in `edges`. The timestamp makes that the first vertex is always
the same in `border_edges`.

## Release Management

* Affected package(s): Convex_hull_3
 2025-12-12 17:48:19 +01:00
Sven Oesau 7fbee84a0e remove timestamp from Convex_hull_face_base_2 2025-12-09 14:42:38 +01:00
Sébastien Loriot 4af12e7167 Merge remote-tracking branch 'cgal/6.0.x-branch' into 'cgal/6.1.x-branch' 2025-12-04 18:47:22 +01:00
Sven Oesau 4c1400d2fb fixing generated indices of coplanar convex_hull_3 
adding a small test
 2025-12-01 16:11:56 +01:00
Sven Oesau 638d12593f adding timestamp to convex_hull_3 vertex and face base 2025-12-01 15:51:21 +01:00
Sébastien Loriot b2ba32307c Merge remote-tracking branch 'cgal/6.0.x-branch' into 'cgal/6.1.x-branch' 2025-08-13 18:07:09 +02:00
Sébastien Loriot a9923e9e02 restore test 2025-08-04 09:41:42 +02:00
Sébastien Loriot e668cb9ae6 restore logic and use traits helper in the free function 2025-08-04 09:33:03 +02:00
Sven Oesau 6517c7f48a fix warning 2025-07-10 09:06:49 +02:00
Sven Oesau 6fb75112dd changing Default_traits_for_Chull_3 check 2025-07-09 16:08:50 +02:00
Sébastien Loriot 4b7df57bce rename test 2025-07-04 16:09:26 +02:00
Sven Oesau 47815db05e added test 2025-06-27 10:53:31 +02:00
Sven Oesau 327de417bb
Update convex_hull_3.h 
fix Default_traits_for_Chull_3
 2025-06-26 16:44:27 +02:00
Sven Oesau 6aaa37f3ef defaulting to Convex_hull_traits_3 instead of Kernel_traits<Point_3>::type 2025-06-26 16:26:12 +02:00
Sébastien Loriot 13609a6966 no need to repeat the package name as it is on the line above 2025-05-22 17:53:41 +02:00
Sébastien Loriot a4170b1fb9 Merge pull request #8586 from MaelRL/Kernel_23-Fix_dangling_ref_in_CC3-GF 
Do not rely on result_type definitions in kernels
 2025-04-03 16:12:09 +02:00
Sébastien Loriot b6719fc3be Merge remote-tracking branch 'cgal/6.0.x-branch' into cgal/master 2025-04-03 16:09:51 +02:00
Sébastien Loriot f516c12c5b Merge remote-tracking branch 'cgal/5.6.x-branch' into 6.0.x-branch 2025-04-03 16:09:15 +02:00
Sébastien Loriot 2ccb0f7320 add missing include directive 2025-04-02 09:06:49 +02:00
Sébastien Loriot 32ac9f22a7 work around overload resolution with recent gcc 2025-04-01 15:43:43 +02:00
Mael Rouxel-Labbé f9001833b1 Merge remote-tracking branch 'cgal/master' into Kernel_23-Fix_dangling_ref_in_CC3-GF 2025-03-15 14:09:28 +01:00
Sebastien Loriot 14b83f0d3e
boost::tie -> std::tie (#8715) 2025-02-12 19:36:19 +01:00
Laurent Rineau e5001d1a50 update our CMake version 3.18...3.31 
That will suppress the warnings about `CMP0167` (from CMake 3.30):

```
CMake Warning (dev) at cmake/modules/display-third-party-libs-versions.cmake:37 (find_package):
  Policy CMP0167 is not set: The FindBoost module is removed.  Run "cmake
  --help-policy CMP0167" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.
```
 2025-02-04 14:32:37 +01:00
Sébastien Loriot 107f3696dc boost::tie -> std::tie 2025-01-24 14:20:00 +01:00
Mael Rouxel-Labbé 3b7a4ed21e Merge remote-tracking branch 'cgal/master' into Kernel_23-Fix_dangling_ref_in_CC3-GF 2025-01-16 11:52:34 +01:00
Mael Rouxel-Labbé f26f41cff1 Minor CH3 test improvement 2024-12-29 23:39:21 +01:00
Sébastien Loriot 4cf1f4b214 CONFIG options is only needed if a FindXXX.cmake exists 2024-09-04 14:48:07 +02:00
Jane Tournois 3f6083e6ff use CGAL::OpenMesh_support in examples and tests 2024-08-27 14:06:16 +02:00
Laurent Rineau 3a223ebd1e cmake_minimum_required(VERSION 3.12...3.29) 2024-06-06 20:19:44 +02:00
Laurent Rineau 2a2031df3b Rename cgallab to CGALlab 
@janetournois (see https://github.com/CGAL/cgal/pull/8149#issuecomment-2066444180
 2024-04-23 15:09:51 +02:00
Laurent Rineau 621859b526 Rename Polyhedron demo to CGAL Lab 
And announce it in the `CHANGES.md`.
 2024-04-18 12:39:30 +02:00
Laurent Rineau 708711e7a7 Merge pull request #8018 from janetournois/PMP-add_bbox_to_face_graph-jtournois 
New function `PMP::add_bbox(face_graph)` that adds bbox to face graph
 2024-04-05 14:25:17 +02:00
Jane Tournois c21fc4f238 remove circular dependency and corresponding fwd declarations 
include in helpers.h was introduced by 0528592011
in 2019 for backward compatibility, it can now be removed
 2024-03-06 10:42:53 +01:00
Sébastien Loriot 647d26edaf actually core is now needed as it extends the gmp/boost arithmetic kernel 2024-02-27 17:55:05 +01:00
Sébastien Loriot 3b30756cd3 do not depend on CGAL_Core 2024-02-27 14:46:18 +01:00
Andreas Fabri e4558a4d4b Merge branch 'master' into CORE-boost_mp_number-GF 2024-02-23 17:04:37 +01:00
Sébastien Loriot 15aa810876 Merge remote-tracking branch 'cgal/5.6.x-branch' 2023-12-22 17:16:49 +01:00
Sébastien Loriot 47e728f2ef Merge remote-tracking branch 'cgal/5.5.x-branch' 2023-12-22 17:14:12 +01:00
Sébastien Loriot c36f0ac091 add a switch to get rid of QP_Solver dependency 2023-12-19 14:42:02 +01:00
Laurent Rineau 9ac6d64cbe Merge pull request #7803 from lrineau/CH_3-fix_typo-GF 
Convex_hull_3: fix a typo
 2023-10-30 17:13:23 +01:00
Laurent Rineau 0bf610aa8d Merge pull request #7803 from lrineau/CH_3-fix_typo-GF 
Convex_hull_3: fix a typo
 2023-10-30 17:12:29 +01:00
Laurent Rineau cd14420354 fix a typo 
(reported by email by Stefan Schirra)
 2023-10-16 18:03:50 +02:00
albert-github 93001308f4 Merge branch 'master' into feature/issue_7395 
# Conflicts:
#	Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Concepts/ArrangementPointLocation_2.h
#	Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Concepts/ArrangementVerticalRayShoot_2.h
 2023-08-18 11:10:42 +02:00
Sébastien Loriot eada3ee8ca Merge branch 'master' into 'sloriot/CGAL-using_c++17_stl' 2023-08-14 14:19:25 +02:00
albert-github ff3ff12a40 Merge remote-tracking branch 'upstream/master' into feature/issue_7395 2023-07-24 09:37:12 +02:00
Laurent Rineau d6ebf17baa Merge remote-tracking branch 'cgal/5.6.x-branch' 2023-07-20 10:12:26 +02:00
albert-github ad41766454 issue #7395 Improvement of layout of model relations 
Corrected `cgalModels` to `cgalHasModes` inside `cgalHasNodelsBegin` / `cgalHasModelsEnd`
 2023-07-18 13:23:37 +02:00
albert-github 4e5578d469 issue #7395 Improvement of layout of model relations 
- based on review
 2023-07-15 13:12:15 +02:00
albert-github a0320dd7b4 Merge branch 'master' into feature/issue_7395 
# Conflicts:
#	Polyhedron/doc/Polyhedron/Concepts/PolyhedronItems_3.h
 2023-07-13 10:33:18 +02:00