Commit Graph

446 Commits

Author SHA1 Message Date
Sébastien Loriot b9a14a447f Merge pull request #6426 from afabri/Kernel_23-Call_function_objects-GF
Kernel_23: Call function objects from CGAL::Segment_3
2022-03-29 17:47:06 +02:00
Sébastien Loriot 5e894656f5 Merge pull request #6422 from afabri/Nef_3-avoid_needless_tests-GF
Nef_3: Avoid needless tests
2022-03-29 17:46:42 +02:00
Andreas Fabri a7fc2c9bbb Remove unused parameter 2022-03-22 08:01:30 +01:00
Andreas Fabri 71bba3e226 Add Plane_3 constructor with Origin/Vector_3 2022-03-17 22:35:09 +01:00
Andreas Fabri d39c7742f1 Kernel_23: Call function objects from CGAL::Segment_3 2022-03-17 12:14:43 +01:00
Giles Bathgate 8445780e09 Merge remote-tracking branch 'afabri/Kernel_23-overload_for_origin-GF' into Nef_3-performance_sphere_circle-GilesBathgate 2022-03-14 21:44:36 +00:00
Andreas Fabri 9a2d782345 No need for parameter 2022-03-15 12:42:56 +01:00
Andreas Fabri 7a7e1d2724
Update Cartesian_kernel/include/CGAL/Cartesian/function_objects.h
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-03-11 11:13:42 +01:00
Andreas Fabri 6e4483a7d0 The same for Construct_orthogonal_vector_3 2022-03-10 14:18:48 +00:00
Andreas Fabri f01e24c75b Add Orientation_3::operator()(Origin,Point_3,Point_3,Point_3) 2022-03-10 10:55:44 +00:00
Mael Rouxel-Labbé 3a0a4a6067 Do not forbid any non-fundamental type conversion:
This is because kernel converters are required before type equality
is established, and so one needs conversion for e.g. PointC3.

That could be added and then non-fundamental types could be forbidden
in parameters of converters, but that's for another time...
2021-12-17 12:22:40 +01:00
Mael Rouxel-Labbé 71cbd212dc Converters now simply forward fundamental types, forbid others 2021-12-03 16:48:51 +01:00
Mael Rouxel-Labbé 5aa34c9106 Add Aff_transformation_2 conversion, simplify Aff_tr_3's 2021-12-02 20:11:18 +01:00
Mael Rouxel-Labbé caba3482a6 Disable fundamental type conversions (other than potentially K1::RT / K1::FT) 2021-11-16 16:38:49 +01:00
Mael Rouxel-Labbé ad0378b648 Remove superfluous const& 2021-11-15 08:13:04 +01:00
Mael Rouxel-Labbé 9f1fef3408 Add a test 2021-11-10 16:24:22 +01:00
Mael Rouxel-Labbé c39ea7965f Do not cast fundamental types into bool in NT_converter
Instead, try to construct a NT1 from them. If it fails, give a compilation error.

This is to avoid converters silently doing nasty things like
Cartesian_converter<SC<CORE::Expr>, SC<double> >(2.) ==> 1 (bool true)
because there is no implicit conversion from double to SC<CORE::Expr>, so it
preferes using Enum_converter(bool) (with a double -> Boolean implicit
conversion...).
2021-11-10 15:56:48 +01:00
Mael Rouxel-Labbé 57c240980f Use some const& to avoid copies 2021-11-10 15:40:18 +01:00
Laurent Rineau 1fb32e70b4 Merge pull request #5978 from janetournois/Mesh_2-add_predicate_for_lloyd-jtournois
Mesh 2 and Kernel - add predicate oriented_side_2(segment, triangle)
2021-10-27 17:20:28 +02:00
Sébastien Loriot 65ea1e3621 use initial code in the function 2021-09-29 16:55:36 +02:00
Mael Rouxel-Labbé e424356ffa Add Construct_projected_point_3(P3, P3) + correct parameter order
Not a kernel requirement
2021-09-28 15:34:51 +02:00
Jane Tournois b3a0beb366 make implementation more consistent with the other functions in the same file 2021-09-21 10:58:45 +02:00
Jane Tournois b9de94de93 add assertions to avoid degenerate inputs 2021-09-10 14:10:11 +02:00
Jane Tournois 8bb7e62c1c apply review 2021-09-10 13:56:12 +02:00
Jane Tournois 7e3af5cbda move the implementation of segment_hides_circumcenter() to the kernel
to use filtered predicates
2021-09-10 11:26:53 +02:00
Mael Rouxel-Labbé 8a92d51601 Merge branch 'Distance_3-Add_Tri_Tri-GF-old' into Distance_3-Add_Tri_Tri-GF 2021-09-02 17:26:44 +02:00
Sebastien Loriot e5279db7fb
Merge pull request #5777 from MaelRL/AABB-Dont_call_global_do_intersect-GF
Misc fixes for Intersections_3 + related
2021-09-02 15:44:53 +02:00
Sebastien Loriot 92d90a4a11
Merge pull request #5667 from afabri/Kernel-compare_slopes-GF
Kernel: Add compare_slope with 4 points
2021-08-12 10:12:26 +02:00
Laurent Rineau 0f906ae606 Merge pull request #5545 from Dig-Doug/segment-midpoint
Segment_2/Segment_3 midpoint()
2021-07-07 14:37:38 +02:00
Mael Rouxel-Labbé 03ab79899b Fix Construct_radical_plane_3 for Homogeneous_kernel 2021-06-29 09:24:53 +02:00
Mael Rouxel-Labbé 084a1efe2d Merge remote-tracking branch 'cgal/master' into Distance_3-Add_Tri_Tri-GF 2021-06-23 22:30:03 +02:00
Mael Rouxel-Labbé 4a301448fe Comment an assertion that requires an exact kernel 2021-06-23 17:37:47 +02:00
Laurent Rineau 4a2f016f6a Merge pull request #5617 from afabri/Nef_3-translation-GF
Nef_3: Add Aff_transformation_3::is_translation()
2021-05-18 18:14:17 +02:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Andreas Fabri 6aeb4eea08 remove trailing whitespace 2021-05-03 16:42:30 +02:00
Andreas Fabri 4e1ebec30a untabify 2021-05-01 17:04:52 +02:00
Andreas Fabri 20d1629e1b Add compare_slope with 4 points 2021-04-30 17:39:57 +02:00
Laurent Rineau c091c7f86e Merge pull request #5532 from lrineau/Kernel_23-Do_interesect__without_division-GF
Remove operator/ from CGAL::Mpzf and implement Do_intersect_3 with RT only (without division)
2021-04-28 15:24:15 +02:00
Andreas Fabri c238e9dab5 Merge remote-tracking branch 'cgal/master' into Nef_3-translation-GF 2021-04-27 15:23:56 +01:00
Andreas Fabri e73b8de89f Add the 2D stuff. In homogeneous add Scaling_repH3 2021-04-22 21:17:24 +01:00
Andreas Fabri d3b26a60cb The free function must call the functor 2021-04-22 17:35:27 +01:00
Sebastien Loriot b8bc56ca12
Merge pull request #4421 from MaelRL/Triangulation_on_sphere_2-GF
new package: Triangulation on the sphere
2021-04-21 15:24:45 +02:00
Mael 8226666398
Merge branch 'master' into Triangulation_on_sphere_2-GF 2021-04-17 11:22:30 +02:00
Andreas Fabri 153413e8d5 Add code for translation of Plane_3 and move generic code down to the rep 2021-04-15 13:58:33 +01:00
Andreas Fabri 91ea4909c2 Fixes 2021-04-15 13:36:58 +01:00
Andreas Fabri 01cc9ec653 Scaling a plane means scaling Plane_3::d() 2021-04-15 13:14:42 +01:00
Andreas Fabri ac9b5b2fbd Add Aff_transformation_3::is_translation() which checks the rep 2021-04-13 19:38:28 +01:00
Mael Rouxel-Labbé fba303341f Merge remote-tracking branch 'cgal/master' into Distance_3-Add_Tri_Tri-GF 2021-04-12 15:33:14 +02:00
Mael Rouxel-Labbé 5deb509374 Move to Distance_3/X_Y.h rather than squared_distance_X_Y.h (as Intersections) 2021-04-12 14:42:44 +02:00
Sébastien Loriot 68dc09b3d9 optimize filter failures
cmp_epeck_points.cpp runtime goes from 23s. to 5s.

based on mglisse suggestion
2021-04-10 07:12:25 +02:00
Maxime Gimeno fe5f6556b9 add a comment 2021-03-29 15:23:24 +02:00
Maxime Gimeno 2019309288 Replace Rep by a boost::tuple 2021-03-24 15:31:43 +01:00
Andreas Fabri a4c57e6f66 Keep the old solve() 2021-03-21 19:35:41 +01:00
Andreas Fabri ae945cd329 Avoid division for bounded side test 2021-03-18 14:18:11 +01:00
Andreas Fabri be39ec02fa Add a solve that 'returns' the denominator instead of making the division 2021-03-18 14:18:11 +01:00
Mael Rouxel-Labbé ede18b776c Merge remote-tracking branch 'cgal/master' into Triangulation_on_sphere_2-GF 2021-03-18 10:42:52 +01:00
Mael Rouxel-Labbé 596f3e3013 Fix namespaces 2021-03-12 14:34:36 +01:00
Mael Rouxel-Labbé 2adddeacc1 Add missing includes 2021-03-12 13:08:16 +01:00
Mael Rouxel-Labbé 6b0459c686 Re-organize squared_distance_3_x.h into squared_distance_O1_O2.h
+ minor improvements (missing overloads, obvious improvements, etc.)
2021-03-12 12:51:59 +01:00
Laurent Rineau 216560554e Merge pull request #5112 from sloriot/Kernel_23-bisector_sqrt
Allow an inexact version of bisector when no sqrt is available.
2021-02-18 15:26:51 +01:00
Laurent Rineau bb36a410f8 Merge pull request #5112 from sloriot/Kernel_23-bisector_sqrt
Allow an inexact version of bisector when no sqrt is available.
2021-02-18 15:18:11 +01:00
Mael Rouxel-Labbé 69d215a33e Fix erroneous description in Kernel_23::Coplanar_orienation_3 2021-01-27 10:06:03 +01:00
Sébastien Loriot 80af4b3e74 be more permissive for bisector with a FT with sqrt 2020-10-26 09:17:01 +01:00
Laurent Rineau 9a3e0387a7 Merge pull request #4705 from rgcv/Cartesian_kernel-fix_missing_print_AT3-rgcv
Add missing `Aff_transformationC3::print` and `Aff_transformationH2::operator<<`
2020-05-18 12:24:25 +02:00
Laurent Rineau 4c30c49231 Merge pull request #4705 from rgcv/Cartesian_kernel-fix_missing_print_AT3-rgcv
Add missing `Aff_transformationC3::print` and `Aff_transformationH2::operator<<`
2020-05-18 12:22:27 +02:00
Rui Ventura 53eb106f92
Add missing `print` method to `Aff_transformationC3` 2020-05-06 07:44:59 +01:00
Sebastien Loriot 98fafe4ef1
Merge pull request #4514 from MaelRL/CGAL-Fix_warnings-GF
Fix (some) testuite warnings
2020-04-16 18:15:11 +02:00
Maxime Gimeno 5c41857065 another try to make the pragma work 2020-04-08 13:03:50 +02:00
Maxime Gimeno 7beb631e77 Try another pragma to suppress warning 2020-04-07 09:28:57 +02:00
Sébastien Loriot fdb17cb3f1 extra run of the script to remove tabs and trailing whitespaces 2020-03-26 19:26:10 +01:00
Sébastien Loriot 38789af55d Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:25:47 +01:00
Sébastien Loriot 4527b1f52c extra run of the script to remove tabs and trailing whitespaces 2020-03-26 19:01:49 +01:00
Sébastien Loriot a943082eff Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:01:31 +01:00
Sébastien Loriot 8bb22d5b2c extra run of the script to remove tabs and trailing whitespaces
right after the merge of the 5.0 release branch

+ manual fix of the files (indentation was changed in the meantime):
   * Spatial_sorting/include/CGAL/Multiscale_sort.h
   * Spatial_sorting/test/Spatial_sorting/test_multiscale.cpp
2020-03-26 14:26:59 +01:00
Sébastien Loriot 8b153fb495 Merge branch 'cgal/releases/CGAL-5.0-branch'
whitespace+tab removal, merged with option -Xignore-space-change
2020-03-26 14:22:32 +01:00
Sébastien Loriot 0779373835 extra run of the script to remove tabs and trailing whitespaces
right after the  merge of 4.14 release branch

+ manual fix on one line in:
    * Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
    * .travis/generate_travis.sh
2020-03-26 14:16:06 +01:00
Sébastien Loriot 590612a563 run the script to remove tabs and trailing whitespaces 2020-03-26 13:25:16 +01:00
Marc Glisse 3ebe8839b6 swap for Point_2 and Point_d
and make the implementations more similar, in case someone wants to
replace it with a macro at some point.
2020-03-01 12:50:13 +01:00
Andreas Fabri 99eea7ac21 Add operator for line/point/point 2020-02-25 16:47:12 +00:00
Marc Glisse 1eed5a908c swap Simple_cartesian<Gmpq>::Point_3 2020-02-25 08:57:53 +01:00
Maxime Gimeno f7f43c65e8 add a pragma to mute an annoying warning in MSVC 2020-02-19 16:07:27 +01:00
Mael Rouxel-Labbé 48bf4c3f52 Fix warning about copying return value despite being passed by name 2020-02-10 18:18:26 +01:00
Mael Rouxel-Labbé 4536ea4f53 Clean whitespace (no changes) 2020-01-16 12:33:01 +01:00
Andreas Fabri 3bd0adf61f Adress Mael's review 2020-01-15 16:44:13 +01:00
Sébastien Loriot 52164b1fba First pass on removing license notice in header for LGPL files 2019-10-19 15:40:30 +02:00
Sébastien Loriot 7356421d80 introduce Commercial license SPDX tag 2019-10-19 12:15:19 +02:00
Sébastien Loriot 9bd9c68b83 update LGPL[23]+ and GPL[23]+ SPDX tags
ack -l --no-svg "SPDX-License-Identifier: GPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-3.0+/SPDX-License-Identifier: GPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-3.0+/SPDX-License-Identifier: LGPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: GPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-2.0+/SPDX-License-Identifier: GPL-2.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-2.0+/SPDX-License-Identifier: LGPL-2.0-or-later/"
2019-10-18 21:57:54 +02:00
Andreas Fabri 69a42baba6 remove typename 2019-09-02 08:46:50 +02:00
Andreas Fabri 0f267c53e3 Make 2d segment segment distance more robust for kernel without exact constructions 2019-08-29 14:54:03 +02:00
Laurent Rineau 3e4b177506 Merge pull request #4116 from MaelRL/Kernel_23-Generalize_ray_point_method-GF
Change ray_23 and line_23's point(int) function to point(FT)
2019-08-19 12:54:38 +02:00
Laurent Rineau 0d7fd463ff Merge pull request #4116 from MaelRL/Kernel_23-Generalize_ray_point_method-GF
Change ray_23 and line_23's point(int) function to point(FT)
2019-08-19 12:53:59 +02:00
Mael Rouxel-Labbé 27f7b48ec8 Remove obsolete comment 2019-07-26 16:02:37 +02:00
Mael Rouxel-Labbé 6c8a8f347d Change ray/line.point(int --> FT)
There is no real requirement on it being an 'int', except some symmetry with
the segment.
2019-07-26 15:59:52 +02:00
Maxime Gimeno b13bdadfa8 Fix conflicts 2019-06-17 15:33:33 +02:00
Andreas Fabri 4581f1b7a8 Morte replacements 2019-06-05 08:39:55 +02:00
Mael Rouxel-Labbé 2848158354 Fix typos 2019-05-20 08:54:04 +02:00
Laurent Rineau 90782d4b7f Revert the merge of two pull-requests that target CGAL-4.14-branch
- Revert "Merge pull request #3857 from MaelRL/CGAL-Fix_duplicate_non_manifold_vertices-GF"
- Revert "Merge pull request #3898 from lrineau/Mesh_3-stop_during_protection-lrineau"
2019-05-14 17:50:45 +02:00
Sébastien Loriot 124012d9f9 replace cpp11::array by std::array 2019-03-29 13:28:33 +01:00
Laurent Rineau 80717c6f41 Merge pull request #3406 from mglisse/cgal-public-dev/Number_types-boost_mp-glisse-2
Support Boost.Multiprecision
2019-01-18 16:37:49 +01:00
Maxime Gimeno f9ff07de81 Fix warning 2019-01-15 09:01:31 +01:00