remove mentions to CMAKE_GENERATOR in test scripts
# Conflicts:
# CGAL_ipelets/demo/CGAL_ipelets/cgal_test_with_cmake
# Set_movable_separability_2/test/Set_movable_separability_2/cgal_test_with_cmake
right after the merge of 4.14 release branch
+ manual fix on one line in:
* Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
* .travis/generate_travis.sh
That fixes the following CMake warning:
-- Configuring test in test/Snap_rounding_2
Requested component: Core
Requested component: MPFR
Requested component: GMP
CMake Warning (dev) at
Installation/cmake/modules/CGAL_CreateSingleSourceCGALProgram.cmake:19
(add_executable):
Policy CMP0037 is not set: Target names should not be reserved and should
match a validity pattern. Run "cmake --help-policy CMP0037" for policy
details. Use the cmake_policy command to set the policy and suppress this
warning.
The target name "test" is reserved or not valid for certain CMake features,
such as generator expressions, and may result in undefined behavior.
Call Stack (most recent call first):
buildEX/test/Snap_rounding_2/CMakeLists.txt:19
(create_single_source_cgal_program)
This warning is for project developers. Use -Wno-dev to suppress
it.
bad() implies fail() but std::basic_ios::operator! is actually equivalent
to std::basic_ios::fail(), not bad().
For example,
std::ifstream is(argv[1]);
if (is.bad()) {
is probably wrong because, in case the file does not exist, only the failbit it set,
and not the badbit.
Other example:
double x;
is >> x;
If the stream 'is' does not contains a string that can represent a double,
then failbit is set (and maybe the eofbit if the stream is actually too
short), but not the badbit.
bad() can be used, in case fail() returned true, to discriminate between a
I/O error and a logical error.
See:
http://en.cppreference.com/w/cpp/io/basic_ios/operator_boolhttp://en.cppreference.com/w/cpp/io/ios_base/iostate