Commit Graph

591 Commits

Author SHA1 Message Date
Dmitry Anisimov 930278ec50 Merge remote-tracking branch 'origin/master' into Region_growing-revision-danston 2021-11-16 14:57:16 +01:00
Dmitry Anisimov 86b26e44d3 added access to circle/sphere/cylinder shapes 2021-11-16 14:51:00 +01:00
Sébastien Loriot ab48f63e30 update latest cmake version tested 2021-11-09 10:58:47 +01:00
Sébastien Loriot 58181afcdb remove useless include directives 2021-11-09 10:16:12 +01:00
Dmitry Anisimov f6144e09ed fixed some paths to data 2021-10-21 17:14:03 +02:00
Dmitry Anisimov 634b961b1c Merge remote-tracking branch 'origin/master' into Region_growing-revision-danston 2021-10-21 16:29:48 +02:00
Dmitry Anisimov 43d4d27c5b added two utility operators to neighbor queries 2021-10-14 15:18:44 +02:00
Dmitry Anisimov 61a6dff624 added functions to update parameters 2021-10-14 12:03:42 +02:00
Mael Rouxel-Labbé 8166579e55 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_master-GF 2021-10-11 19:58:07 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé df560987a6 Whitespace & cleaning changes 2021-10-08 12:13:43 +02:00
Sébastien Loriot efbd86df7f extra manual fixes 2021-10-05 17:42:21 +02:00
Sébastien Loriot 8350dea94a char* -> std::string 2021-10-04 09:49:24 +02:00
Sébastien Loriot 47028cd184 automatically move data files in data dir + update paths
Done for OFF/OBJ/STL/XYZ/PWN/PLY
2021-10-04 09:42:49 +02:00
Dmitry Anisimov 9d251eef0f fixed example naming for docs 2021-09-27 17:32:08 +02:00
Dmitry Anisimov 9246c1389e remove unnecessary conversions in utils for circles and spheres 2021-09-27 17:03:44 +02:00
Dmitry Anisimov c63d41d0e3 more precision for cylinder fitting and sorting 2021-09-27 16:39:11 +02:00
Dmitry Anisimov 02edd6d2cb more precise sphere fitting and sorting 2021-09-27 15:10:54 +02:00
Dmitry Anisimov c093f84ac9 cleanup 2021-09-27 14:45:31 +02:00
Dmitry Anisimov 1222be73b0 more precise circle fitting and sorting 2021-09-27 13:53:57 +02:00
Dmitry Anisimov 7465e7caac added constructors with np set to all_default 2021-09-27 12:40:08 +02:00
Dmitry Anisimov 6aab0f8530 added status to cmakelists 2021-09-27 12:39:42 +02:00
Dmitry Anisimov d6004297f1 added cgal no deprecated code 2021-09-27 12:03:25 +02:00
Sébastien Loriot bd345c7f83 remove .cmd files for examples 2021-09-23 18:54:46 +02:00
Dmitry Anisimov 569b6a3b5c fixed tests 2021-09-23 16:48:45 +02:00
Dmitry Anisimov 8c0b6f14d6 fixed wrong np 2021-09-23 14:26:30 +02:00
Dmitry Anisimov ae50a0beae fixed examples + some other small stuff 2021-09-22 17:36:32 +02:00
Dmitry Anisimov 7a068f227a adding np to cylinder classes 2021-09-22 16:10:31 +02:00
Dmitry Anisimov 2c16e6f9bf adding np to sphere classes 2021-09-22 15:27:01 +02:00
Dmitry Anisimov 0fbc3ea1bb removed fitting.h and using np in circle classes 2021-09-22 14:59:01 +02:00
Dmitry Anisimov b28f32269b make everything compile 2021-09-22 13:04:59 +02:00
Dmitry Anisimov 0d86275191 Merge remote-tracking branch 'origin/master' into Region_growing-revision-danston 2021-09-22 12:20:28 +02:00
Maxime Gimeno 499301c759 More fixes 2021-08-31 16:00:37 +02:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Dmitry Anisimov d82ca437c4 correctly handling wrong values in new classes 2021-08-20 11:19:22 +02:00
Dmitry Anisimov c018af84bf fixed test values 2021-08-20 11:18:18 +02:00
Dmitry Anisimov f2d9066aaf added more debug output for failure cases 2021-08-19 12:05:30 +02:00
Dmitry Anisimov 460c50b142 Merge remote-tracking branch 'origin/master' into Region_growing-revision-danston 2021-08-16 12:28:34 +02:00
Dmitry Anisimov 850776533e fixed test suite errors in tests 2021-08-16 12:20:15 +02:00
Dmitry Anisimov c2a1f047eb fixed test suite errors in examples 2021-08-16 11:56:36 +02:00
Dmitry Anisimov ec13e880a4 fixed warnings in docs 2021-08-16 11:11:40 +02:00
Dmitry Anisimov 6d2a3894f6 fixed test suite warnings in fitting 2021-08-16 10:50:58 +02:00
Dmitry Anisimov d41072d7a9 removed old target 2021-08-16 10:40:40 +02:00
Dmitry Anisimov 2246c4dcef Merge remote-tracking branch 'origin/master' into Shape_detection-Region_growing_on_spheres-GF 2021-08-16 10:27:39 +02:00
Sébastien Loriot de6d8c6cbd Merge pull request #5742 from danston/Shape_regularization-new_package-danston
[Feature] Shape Regularization New Package
2021-08-13 18:19:35 +02:00
Dmitry Anisimov 8043e62f62 removed erroneous assert 2021-08-03 16:57:18 +02:00
Dmitry Anisimov 5f0ed6ba7b fixed missing param 2021-07-29 15:26:22 +02:00
Dmitry Anisimov 37dcf522de refactoring the clear function 2021-07-29 13:57:44 +02:00
Dmitry Anisimov ae0a1fd6d0 Merge remote-tracking branch 'origin/Shape_detection-fix_leaks_in_ransac-danston' into Shape_detection-Region_growing_on_spheres-GF 2021-07-08 17:31:45 +02:00
Dmitry Anisimov 5e616f74e6 fixed leaks in ransac related to callback 2021-07-08 17:30:26 +02:00
Dmitry Anisimov 73df51622f fixed errors and warnings from the test suite 2021-07-08 16:38:53 +02:00
Dmitry Anisimov c1aa66f0fa renamed max to maximum and min to minimum and cos to cosine to be consistent with other NP in CGAL 2021-06-30 13:15:06 +02:00
Dmitry Anisimov 1c7ba09863 undocumented useless headers from convenience headers 2021-06-30 12:46:41 +02:00
Dmitry Anisimov 523e1117e6 removed todo 2021-06-30 12:42:32 +02:00
Dmitry Anisimov c5bea93e58 renamed max to maximum and min to minimum in NP to be consistent with other packages 2021-06-30 12:39:01 +02:00
Dmitry Anisimov 516617d322 removed tmp modifs 2021-06-29 16:36:45 +02:00
Dmitry Anisimov bc97030bd6 removed outdated example 2021-06-29 16:33:23 +02:00
Dmitry Anisimov ed027edea0 turn off deprecated warnings 2021-06-29 16:28:56 +02:00
Dmitry Anisimov 5c940b1b4e added explicit test for deprecated constructors 2021-06-29 12:17:46 +02:00
Dmitry Anisimov 478178a923 added docs for convenience headers 2021-06-28 18:59:16 +02:00
Dmitry Anisimov e3c6ff7c2f remark on the change from void to bool in the concept 2021-06-28 18:54:58 +02:00
Dmitry Anisimov 3263e54a3a added missing deprecated constructors for old classes 2021-06-28 18:42:32 +02:00
Dmitry Anisimov b7e0e37ba3 fixed regularization in the polyhedron demo 2021-06-25 18:02:05 +02:00
Dmitry Anisimov d33559c3fc fixed unspecified doxygen types 2021-06-25 17:16:38 +02:00
Dmitry Anisimov afb138478d all plane regularization stuff in shape detection is now moved to shape regularization 2021-06-25 16:55:15 +02:00
Dmitry Anisimov 23c938aba5 marked docs modifications 2021-06-25 14:16:39 +02:00
Dmitry Anisimov 2a932f6606 Merge remote-tracking branch 'origin/master' into Shape_detection-Region_growing_on_spheres-GF 2021-06-25 13:30:08 +02:00
Dmitry Anisimov b9d14ed07f Merge remote-tracking branch 'origin/master' into Region_growing-revision-danston 2021-06-14 16:42:42 +02:00
Dmitry Anisimov 7119273fb1 simon's review 2021-06-14 16:31:23 +02:00
Dmitry Anisimov 1524a0f48f renamed params 2021-06-14 16:31:09 +02:00
Dmitry Anisimov 68b86a47b0 better naming for parameters 2021-06-14 12:43:04 +02:00
Dmitry Anisimov 6453d49c23 fixed errors in the docs 2021-06-01 16:42:44 +02:00
Dmitry Anisimov beef78cab7 missing IO namespace 2021-06-01 16:34:55 +02:00
Dmitry Anisimov 4f1fc20e22 Merge remote-tracking branch 'origin/master' into Region_growing-revision-danston 2021-06-01 16:06:16 +02:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Sébastien Loriot fb6f703b55 IO namespace for files in IO directories 2021-05-04 14:36:06 +02:00
Simon Giraudot 6fbc190c0d Fix includes 2021-05-04 11:06:48 +02:00
Simon Giraudot 4b313a50d7 Add missing include 2021-05-04 10:20:09 +02:00
Simon Giraudot ad17c0b562 Cylinder/circle sorting + documentation update 2021-05-04 08:47:08 +02:00
Simon Giraudot a85583387d Doc of sorting 2021-04-28 15:52:56 +02:00
Simon Giraudot ab18b6bb39 Region growing sphere sorting + test 2021-04-28 14:38:08 +02:00
Simon Giraudot dc4b2c94c5 Move sphere fit out of fitting class 2021-04-28 12:15:18 +02:00
Simon Giraudot 4080a8c32f Rebase 2021-04-28 08:20:24 +02:00
Sebastien Loriot 77e5d1d26f
Merge pull request #4852 from JacksonCampolattaro/gsoc2020-Octree-campolattaro
Add Octree Package
2021-04-17 14:26:01 +02:00
Sebastien Loriot b7323389c7
Merge pull request #5622 from maxGimeno/CMake-Update_versions_in_scripts-maxGimeno
Update maximum cmake versions
2021-04-17 10:58:14 +02:00
Dmitry Anisimov 04f385687d fixed several tests and memory management 2021-04-16 15:37:00 +02:00
Maxime Gimeno c49152359c update max version of cmake and announce the new minimal in CHANGE.md 2021-04-15 15:08:54 +02:00
Dmitry Anisimov f7deb31166 added multiple strict tests 2021-04-14 18:12:34 +02:00
Dmitry Anisimov 5a0587a315 updated tests + new tests 2021-04-14 16:22:23 +02:00
Dmitry Anisimov 17bcbfc38d fixed another missing include 2021-04-14 14:12:43 +02:00
Dmitry Anisimov 55cc13bc5a fixed bug with missing includes for undocumented free functions 2021-04-14 13:11:05 +02:00
Simon Giraudot 8e7ea14f58 Fix conversion warning 2021-04-14 10:57:53 +02:00
Dmitry Anisimov d10c72f7d3 Merge remote-tracking branch 'upstream/master' into Region_growing-revision-danston 2021-04-14 10:57:01 +02:00
Simon Giraudot 3de09ad3da Fix consistency assertions/comments 2021-04-14 09:20:40 +02:00
Simon Giraudot e87747d082 Fix candidate counting 2021-04-14 09:20:17 +02:00
Dmitry Anisimov 1a542135d1 now works with default maps 2021-04-13 13:47:18 +02:00
Dmitry Anisimov fe5e3415e8 changed API of Polyline_graph 2021-04-13 11:59:34 +02:00
Dmitry Anisimov fa5d4b251a remved some useless internal code 2021-04-13 09:24:45 +02:00
Dmitry Anisimov f9bdb150a6 removed deprecated code 2021-04-13 09:20:19 +02:00
Dmitry Anisimov b6e2ea61ea named parameters now include point/normal/segment maps 2021-04-12 18:02:57 +02:00
Dmitry Anisimov c1f27fb0c5 relaxed constraints on property maps 2021-04-12 15:27:55 +02:00
Dmitry Anisimov 3c48e35138 review Sebastien 2021-04-12 14:02:14 +02:00
Simon Giraudot 10f6992b2a Rebase on master 2021-04-07 14:32:31 +02:00
Simon Giraudot 8f4dec8107 Avoid timeouts in testsuite 2021-04-07 14:27:44 +02:00
Simon Giraudot 4ec9bd6c9a Optimize location of node 2021-04-07 14:26:19 +02:00
Simon Giraudot 4c0018791c Fix bbox, width and depth computations in Octree wrapper 2021-04-07 14:13:29 +02:00
Maxime Gimeno 17602e589e Merge remote-tracking branch 'cgal/master' into CGAL-clang_tidy__nullptr_on_Mesh_2-GF 2021-04-07 09:17:51 +02:00
Laurent Rineau 343ef10367 Merge pull request #5547 from sgiraudot/Fix_stdpow_related_warnings-GF
Fix warning: std::pow(float, int) returns double instead of float in recent C++
2021-04-06 15:13:00 +02:00
Simon Giraudot 1794620ab9 Move index access property map to property map package 2021-04-01 09:43:14 +02:00
Simon Giraudot 616cd5a549 Apply corrections from review 2021-04-01 08:55:51 +02:00
Dmitry Anisimov f0a667d7be docs cleanup 2021-03-29 17:14:06 +02:00
Dmitry Anisimov 0072ad7a77 updated ref docs + added sections in the user manual 2021-03-29 16:55:53 +02:00
Dmitry Anisimov c7d9f007ce updated docs, region growing now properly handles the first time call for all regions 2021-03-29 15:01:40 +02:00
Dmitry Anisimov 424405bcfd added polyline ref docs 2021-03-26 17:18:21 +01:00
Dmitry Anisimov a1af0e9bb3 added segment set region type + better polyline graph 2021-03-26 16:53:15 +01:00
Dmitry Anisimov d881117b41 fitting now works both on points and segments, added segment set sorting 2021-03-26 15:51:23 +01:00
Dmitry Anisimov 8cc513e935 added internal region growing traits and polyline graph based on segments 2021-03-26 14:48:53 +01:00
Dmitry Anisimov 35648ab3d6 cleanup, move some stuff to internal, updated docs 2021-03-26 11:12:46 +01:00
Dmitry Anisimov c502a39ea9 added empty segment set classes + updated several docs 2021-03-25 17:16:27 +01:00
Dmitry Anisimov 462817c48e added polyline graph test 2021-03-25 14:55:01 +01:00
Dmitry Anisimov 8a0996b671 added polyline graph query 2021-03-25 11:33:35 +01:00
Dmitry Anisimov 3ca82f638c added empty polyline graph 2021-03-24 17:36:52 +01:00
Dmitry Anisimov 793037c3d7 more precise tests, point set free function, better plane detection on points 2021-03-24 17:28:22 +01:00
Dmitry Anisimov 664bc73149 better old tests 2021-03-24 14:08:28 +01:00
Dmitry Anisimov da8e1a66a3 cleanup (new assertions, removed useless code, etc.) + better examples 2021-03-24 12:25:22 +01:00
Dmitry Anisimov ca8c7f0470 added polyline classes, both 2D and 3D, fixed a few small things in other classes 2021-03-23 18:51:40 +01:00
Dmitry Anisimov b31c9016f9 internal code is unified, added utility functions, added normal orientation 2021-03-23 15:29:42 +01:00
Dmitry Anisimov 1ff8c00af4 several repeating functions are moved to internal 2021-03-23 12:29:22 +01:00
Simon Giraudot 91de37ec3a Fix warning: std::pow(float, int) returns double instead of float in recent C++ 2021-03-23 11:25:53 +01:00
Dmitry Anisimov 25cd87cce3 better precision in all shapes, no approximations now, added iota to sorting 2021-03-22 17:37:25 +01:00
Dmitry Anisimov b971f6a0e2 added free functions and new examples 2021-03-22 13:22:32 +01:00
Dmitry Anisimov 3ae46dd890 added new examples with free functions + new data 2021-03-19 17:15:54 +01:00
Dmitry Anisimov b29db4ca7d simplified region growing examples 2021-03-19 16:11:37 +01:00
Dmitry Anisimov 2d0b31b7f7 added named parameters 2021-03-19 14:32:14 +01:00
Dmitry Anisimov 4a9b7c7c9a better incapsulation, naming, and added access to internal property maps 2021-03-19 12:20:03 +01:00
Dmitry Anisimov 05a8105ff8 added polyline headers and updated CGAL-style docs + fixed warnings in the Generic_facegraph_printer 2021-03-19 11:29:03 +01:00
Simon Giraudot 987b177833 Fix conversion warning 2021-03-18 08:36:34 +01:00
Simon Giraudot 9fe8708fc2 Fix bug that created empty octrees 2021-03-15 10:18:55 +01:00
Simon Giraudot a5f139f9df Remove unused variables 2021-03-11 09:34:33 +01:00
Simon Giraudot b22bd4e498 Update dependencies 2021-03-08 11:11:36 +01:00
Simon Giraudot 46b9452ef4 Rebase on master 2021-03-04 13:48:11 +01:00
Laurent Rineau 3621aaaf3e Merge pull request #5426 from sgiraudot/PSP-RANSAC-Fix_warnings-GF
[PSP/RANSAC] Fix warnings
2021-03-03 17:33:05 +01:00
Laurent Rineau 05d0f01fc4 Merge pull request #5487 from sgiraudot/Shape_detection-Disable_long_tests-GF
Shape Detection: Disable expensive tests by default
2021-03-03 17:21:27 +01:00
Laurent Rineau 45373bef84 Merge pull request #5426 from sgiraudot/PSP-RANSAC-Fix_warnings-GF
[PSP/RANSAC] Fix warnings
2021-03-03 17:10:18 +01:00
Simon Giraudot 6e811d6a8f Rebase on master 2021-03-03 12:56:57 +01:00
Simon Giraudot bbcab8e56f Merge remote-tracking branch 'mine/Shape_detection-Region_growing_on_spheres-GF' into Shape_detection-Region_growing_on_spheres-GF 2021-03-03 11:52:14 +01:00
Simon Giraudot dc858ba722 Clean up namings according to review 2021-02-23 08:34:15 +01:00
Simon Giraudot 244ca61261 Text corrections from review 2021-02-23 08:26:41 +01:00
Simon Giraudot 5955028010 Disable expensive tests by default 2021-02-23 08:18:47 +01:00
Maxime Gimeno b80daff6fb Fixes 2021-02-19 11:31:52 +01:00
Maxime Gimeno 7f189620d8 Remove CMAKE_CXX_STANDARD commands in cmake scripts 2021-02-08 10:06:23 +01:00
Simon Giraudot 0cf9990bf0 Fix conversion warning in RANSAC 2021-02-04 08:33:54 +01:00
Laurent Rineau f176529041 Merge pull request #5357 from sloriot/CGAL-boost_function_output-master
Include non-deprecated header (master)
2021-01-21 16:22:39 +01:00
Laurent Rineau 52bb68c012 Merge pull request #5356 from sloriot/CGAL-boost_function_output-5.2
Include non-deprecated header (5.2)
2021-01-21 16:18:55 +01:00
Simon Giraudot a19836bfb6 Fix RANSAC's use of outdated Octree API 2021-01-20 11:20:01 +01:00
Simon Giraudot 1dcf876679 Remove TODOs 2021-01-19 14:07:13 +01:00
Simon Giraudot ae8ec55eac Merge remote-tracking branch 'jackson/gsoc2020-Octree-campolattaro' into gsoc2020-Octree-campolattaro 2021-01-19 09:54:58 +01:00
Sébastien Loriot bc161f2ae9 Merge 'CGAL-Eigen3_support-5.2' 2021-01-15 10:59:20 +01:00
Sébastien Loriot f4935dc199 Merge branch 'CGAL-Eigen3_support-5.1' 2021-01-15 10:54:02 +01:00
Sébastien Loriot eecb00534e fix macro name to be consistent with find_package 2021-01-15 10:43:34 +01:00
Sébastien Loriot ad911271a9 Merge commit '6594e7549bd70923990d86c31e2aa267a79bb629' into HEAD 2021-01-15 10:12:17 +01:00
Sébastien Loriot 6594e7549b do no include a deprecated header 2021-01-15 10:07:59 +01:00
Sébastien Loriot bdd4efe3b3 Merge commit 'efc0c525e8b' into HEAD 2021-01-15 10:06:56 +01:00
Sébastien Loriot efc0c525e8 include non-deprecated header 2021-01-15 10:02:00 +01:00
Maxime Gimeno 5948bc846e Try to remove Filtered_kernel from the dependencies of BGL 2021-01-11 14:11:30 +01:00
Maxime Gimeno 5d2ad68148 Add new Dependences. ATTENTION BGL is propagated through the NPs in Stream_support 2021-01-08 15:58:46 +01:00
Maxime Gimeno 3d1c41fd14 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2021-01-07 15:05:28 +01:00
Simon Giraudot 773642e9dc Fix Boost include 2021-01-06 07:59:14 +01:00
Simon Giraudot 661fe3505e User + ref manual for new region growing classes 2021-01-05 10:35:05 +01:00
Simon Giraudot 74d01916e3 Document missing parts 2021-01-04 15:23:41 +01:00
Simon Giraudot 8a2029e233 Add possibility to restrict radius of sphere/circle/cylinder 2021-01-04 15:20:10 +01:00
Simon Giraudot 5e0487e455 Add region growing on cylinders for point_set_3 2020-12-31 13:26:57 +01:00
Simon Giraudot 31c577fc47 Add region growing on circles for point_set_2 2020-12-30 14:51:15 +01:00
Simon Giraudot da90b6ee4f Add region growing on spheres for point_set_3 2020-12-30 08:48:28 +01:00
Laurent Rineau 47c4fc8aa2 Merge pull request #5279 from sgiraudot/RANSAC-Fix_ptrdiff_overflow-GF
[RANSAC] Fix ptrdiff overflow
2020-12-16 17:49:07 +01:00
Laurent Rineau fe34a5aa04 Merge pull request #5279 from sgiraudot/RANSAC-Fix_ptrdiff_overflow-GF
[RANSAC] Fix ptrdiff overflow
2020-12-16 17:47:45 +01:00
Laurent Rineau cf5aaeba5c Merge pull request #5279 from sgiraudot/RANSAC-Fix_ptrdiff_overflow-GF
[RANSAC] Fix ptrdiff overflow
2020-12-16 17:46:45 +01:00
Simon Giraudot a7b2ed13f4 Fix conversion warning 2020-12-15 15:44:11 +01:00
Laurent Rineau 863cc4b816 Merge pull request #5238 from albert-github/feature/bug_space_link
Superfluous space in link
2020-12-15 09:07:46 +01:00
Laurent Rineau 3301a47c44 Merge pull request #5255 from sgiraudot/Shape_detection-Fix_auto_param_detection-GF
[RANSAC] Fix detection of automatic parameter selection
2020-12-15 09:07:44 +01:00
Laurent Rineau a0e1b15da3 Merge branch '5.1.x-branch' into 5.2.x-branch 2020-12-15 09:07:21 +01:00
Laurent Rineau 1ecc57b367 Merge pull request #5238 from albert-github/feature/bug_space_link
Superfluous space in link
2020-12-15 09:04:58 +01:00
Laurent Rineau 91b1ab221f Merge pull request #5255 from sgiraudot/Shape_detection-Fix_auto_param_detection-GF
[RANSAC] Fix detection of automatic parameter selection
2020-12-15 09:04:55 +01:00
Simon Giraudot 360040dfd6 Fix ptrdiff_t overflow 2020-12-14 15:18:56 +01:00
Maxime Gimeno 00edae2400 More fixes 2020-12-10 12:55:04 +01:00
Maxime Gimeno 1d98f0f71d Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-12-09 14:40:02 +01:00
Simon Giraudot 8c7d012297 Fix detection of automatic parameter selection + early exit if no shape can be detected 2020-12-08 15:35:22 +01:00
albert-github 1fd47a68fa Superfluous space in link
The texts in the ALIASES are taken literally and therefore should be (in this case) no space after the comma as this results in a space ion the resulting link and thus a file not found.
2020-12-08 15:19:50 +01:00
Laurent Rineau 5e53e0e70a Merge branch '5.2.x-branch' 2020-12-07 16:33:01 +01:00
Laurent Rineau 89eea037da
Merge pull request #5234 from sgiraudot/Shape_detection-Add_validity_tests-GF 2020-12-07 16:32:07 +01:00
Laurent Rineau b03399cc6c Merge pull request #5208 from maxGimeno/Shape_detection-Fix_warnings-maxGimeno
Shape_detection: Fix warnings.
2020-12-04 17:16:07 +01:00
Laurent Rineau 81dc3bf892 Merge pull request #5208 from maxGimeno/Shape_detection-Fix_warnings-maxGimeno
Shape_detection: Fix warnings.
2020-12-04 17:08:28 +01:00
Simon Giraudot b2573a7b38 Fix Windows min/max garbage 2020-12-03 09:34:31 +01:00
Simon Giraudot 873aa26a8f Avoid testsuite timeouts 2020-12-03 09:27:01 +01:00
Simon Giraudot 09b61c13d9 Fix assertion 2020-12-02 09:23:03 +01:00
Simon Giraudot 9294461c64
Call ctest on new validity test
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
2020-12-01 14:56:17 +01:00
Simon Giraudot e21d019c05 Finalize validity test 2020-12-01 14:28:00 +01:00
Simon Giraudot 4a3ad83f21 Small optimization: pick several candidates at each loop 2020-12-01 14:28:00 +01:00
Simon Giraudot d2d766a38e Fix stop probability to take into account different shapes 2020-12-01 14:28:00 +01:00
Simon Giraudot 37d38da190 Add validity tests with sampled data 2020-12-01 14:28:00 +01:00
Simon Giraudot 60f85259cd Add validity test to shape detection 2020-12-01 14:28:00 +01:00
albert-github 6b0cba883b Typo in list of documentation typedefs
I get a double defined ID (when running xmllint on the output) regarding the Vector_3 typedef.
In my opinion the second definition should be Vector_2 and not Vector_3.
2020-11-29 12:57:31 +01:00
Maxime Gimeno 393f547abf Fix size_t always >=0 warnings. 2020-11-27 09:10:24 +01:00
Maxime Gimeno 3b70343590 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-11-16 16:19:43 +01:00
Simon Giraudot f30b1e5c06 Update RANSAC with octree changes 2020-10-27 14:06:12 +01:00
Maxime Gimeno bebd60c12b Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-10-20 09:53:54 +02:00
Jackson Campolattaro 943183490d Replace hardcoded bounding box with a method for determining the actual bounds of the tree 2020-10-19 16:20:45 -04:00
Mael Rouxel-Labbé f55ef7dd50 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-10-09 18:36:17 +02:00
Laurent Rineau 0b2528c8b0 Merge branch 'releases/CGAL-5.0-branch' into 5.1.x-branch 2020-09-24 16:41:45 +02:00
Simon Giraudot c717fdaab6 Fix index access in RANSAC octrees 2020-09-17 14:51:04 +02:00
Simon Giraudot fb86a45d47 Adapt max level to old version 2020-09-17 14:19:04 +02:00
Simon Giraudot 64693edffa Fix RANSAC Octree wrapper: now Octrees are exactly the same as with old version 2020-09-17 11:45:34 +02:00
Simon Giraudot 604c793ba7 Fix nonnull warning 2020-09-01 09:14:10 +02:00
Jackson Campolattaro f1144724dd Rename Direct_octree to RANSAC_octree 2020-08-17 15:01:55 -04:00
Jackson Campolattaro 9e1505ad8a Eliminate Indexed_octree 2020-08-17 14:59:56 -04:00
Jackson Campolattaro 3252f82498 Update function invocations 2020-08-14 14:06:02 -04:00
Jackson Campolattaro ee2a93e8e1 Update refine method of Direct octree to match indexed 2020-08-10 12:39:19 -04:00
Jackson Campolattaro 939ba23f39 Add brackets to do-while loop for clarity 2020-08-08 14:14:06 -04:00
Jackson Campolattaro 87af9e7951 Add brackets to keep_searching check for clarity 2020-08-08 13:20:42 -04:00
Jackson Campolattaro 4c3c6c5140 Force bbox value to make sure it's not causing issues 2020-08-08 13:01:27 -04:00
Jackson Campolattaro 9d10429df5 Disable randomness in scene test 2020-08-08 12:18:27 -04:00
Jackson Campolattaro 5537e27696 Remove fixed seed for random generator 2020-08-07 19:04:18 -04:00
Jackson Campolattaro 2a6ce57648 Re-enable all cone parameter tests 2020-08-07 19:02:48 -04:00
Jackson Campolattaro 7b74d5bcbe Remove printouts 2020-08-07 18:57:05 -04:00
Jackson Campolattaro e8b4d56aad Remove printouts from Efficient_RANSAC.h 2020-08-07 18:56:21 -04:00
Jackson Campolattaro fa61c44d73 Return to independently defined Direct octree 2020-08-07 18:52:48 -04:00
Jackson Campolattaro dd9878a20d Add reminder to replace fixed side length map size 2020-08-07 18:41:41 -04:00
Jackson Campolattaro c53790776c Give indexed octree consistent api with direct 2020-08-07 18:26:15 -04:00
Jackson Campolattaro 49baf4ce36 Mark location of issue 2020-08-07 17:17:22 -04:00
Jackson Campolattaro 7b7a4e2b6a Print out first input iterator value at multiple points in the code 2020-08-07 16:37:19 -04:00
Jackson Campolattaro 7f57f18a55 Force random seed for deterministic testing 2020-08-07 16:06:03 -04:00
Jackson Campolattaro 275feb0d3f Refactor check for enough samples 2020-08-07 11:03:23 -04:00
Jackson Campolattaro 6084084f3a Add more printouts to sample drawing 2020-08-07 10:47:25 -04:00
Jackson Campolattaro 1d19bca766 Remove printouts from refine() 2020-08-06 17:00:54 -04:00
Jackson Campolattaro 6905a65127 Add logic changing max level based on cluster epsilon 2020-08-06 16:05:10 -04:00
Jackson Campolattaro aa7b8114cf Implement node_containing_point using older version's logic 2020-08-06 15:07:03 -04:00
Jackson Campolattaro ba79b9ecc6 Refactor logic confirming the node was found 2020-08-06 14:56:17 -04:00
Jackson Campolattaro 8747114f72 Add printout whether the relevant node was found 2020-08-06 14:37:18 -04:00
Jackson Campolattaro 7337443b6f Include IO.h for printing octree nodes 2020-08-06 14:31:29 -04:00
Jackson Campolattaro 528918cf4f Reduce printouts to most relevant information 2020-08-06 14:22:54 -04:00
Jackson Campolattaro 6a36493744 Add printouts for loop information 2020-08-06 11:43:56 -04:00
Jackson Campolattaro 7a9d06d50e Add printouts for relevant functions 2020-08-06 10:50:00 -04:00
Jackson Campolattaro b0e703b9d1 Add printouts for detecting and preprocessing 2020-08-06 10:42:08 -04:00
Jackson Campolattaro 976af7e816 Add printouts when building and deleting Efficient_RANSAC 2020-08-06 10:38:03 -04:00
Jackson Campolattaro 718ce05be4 Rename boundingBox to bbox 2020-08-05 13:49:18 -04:00
Jackson Campolattaro 310481b456 Don't return bounding box by reference 2020-08-05 12:05:40 -04:00
Jackson Campolattaro 5e1c087b0f Make Direct_octree more similar to Indexed_octree 2020-08-05 10:49:49 -04:00
Jackson Campolattaro f01061858a Rename createTree to refine 2020-08-05 09:48:51 -04:00
Simon Giraudot 93b3f18275 Use indexed property map for Indexed octree 2020-08-05 11:23:48 +02:00
Jackson Campolattaro d02e2bef1f Update width to avoid access to private octree members 2020-08-04 22:59:06 -04:00