Commit Graph

80 Commits

Author SHA1 Message Date
Laurent Rineau 2f59b23d30 Merge pull request #7056 from MaelRL/BGL-Clarify_pmap_value_type-GF
Fix implicit conversion from `std::size_t` to `bool` creating ambiguous calls
2022-11-25 10:15:02 +01:00
Mael Rouxel-Labbé 8437eec29d Fix implicit conversion from std::size_t to bool creating ambiguous calls 2022-11-17 11:17:54 +01:00
Laurent Rineau 5239daab19
Merge pull request #7010 from afabri/PMP-BGL-shrunk-GF 2022-11-04 10:27:19 +01:00
Andreas Fabri f605c347ae Fixed typo: shrinked -> shrunk 2022-11-04 10:01:53 +01:00
Andreas Fabri 5392c3f8f7 selection 2022-10-12 08:10:47 +01:00
Laurent Rineau 258d704a90 Merge pull request #6209 from sloriot/PMP-std_instead_of_boost
Use features available in std instead of boost
2022-02-24 19:57:17 +01:00
Sébastien Loriot 4ffc949199 replace boost::unordered by std::unordered
but in T3, Mesh_3, TDS_3, P3[TM]3
2022-02-03 19:11:12 +01:00
Andreas Fabri 440a8dfb7b Fix file name 2022-02-03 08:41:04 +00:00
Andreas Fabri 735752bec9 Do the remaining changes after Laurent's check 2022-02-03 08:02:11 +00:00
Sébastien Loriot 75b03e6c0a use_default_values() -> default_values() 2022-01-10 18:36:37 +01:00
Sébastien Loriot e2a24f8ca3 replace overloads with default parameters (BGL) 2022-01-05 11:04:25 +01:00
Mael Rouxel-Labbé 8166579e55 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_master-GF 2021-10-11 19:58:07 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé 12805b47e8 Uniformize expansion term 2021-10-05 11:33:47 +02:00
Sébastien Loriot 79057f3cdd allow to remesh a patch with boundary cycles of edges if genus is not to be preserved 2021-05-06 14:32:32 +02:00
Sébastien Loriot 27de834e30 move non-documented/exp function in experimental namespace 2021-01-18 11:30:02 +01:00
Laurent Rineau a84927d380 Merge pull request #4849 from MaelRL/PMP-No_caps_on_doc-GF
Use lower case for function documentation starting with a verb (BGL/PMP)

# Conflicts:
#	Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/connected_components.h
2020-07-23 17:15:44 +02:00
Mael Rouxel-Labbé ebd65c9637 Use lower case for function doc starting with a verb (BGL/PMP) 2020-07-20 11:47:30 +02:00
Mael Rouxel-Labbé 038869cab9 Merge remote-tracking branch 'cgal/master' into CGAL-Improve_NP_doc_presentation-GF 2020-05-12 15:12:21 +02:00
Maxime Gimeno e9d41d7b7d Fixes for min/max 2020-04-21 11:38:37 +02:00
Sébastien Loriot c253679b2d unify np sentence 2020-04-18 16:27:58 +02:00
Sébastien Loriot 716d8011e1 update np to new format 2020-04-18 14:47:58 +02:00
Simon Giraudot d3e9b3b56b Fix outdated variable name 2020-04-08 14:24:51 +02:00
Simon Giraudot 06de83628c Fix missing inclusion 2020-04-07 08:57:59 +02:00
Mael 970119b2c2
Remove unused typedefs 2020-04-03 09:13:59 +02:00
Simon Giraudot abc0a578c3 Fix unused typedef 2020-04-02 15:33:06 +02:00
Simon Giraudot bb95599ae2 Remove trailing whitespace 2020-04-02 13:45:25 +02:00
Simon Giraudot 238d5e7c54 Update from latest remarks 2020-04-02 13:45:03 +02:00
Simon Giraudot f64d2c4585 Add missing geom_trait parameters 2020-04-02 13:45:03 +02:00
Sébastien Loriot dba7c3eb73 extra run of the script to remove tabs and trailing whitespaces 2020-04-02 13:45:03 +02:00
Simon Giraudot 3b8c8f200e Fix capitalization 2020-04-02 13:45:03 +02:00
Simon Giraudot 7792514a32 Fix missing word 2020-04-02 13:45:02 +02:00
Simon Giraudot 06999247de Fix typo 2020-04-02 13:45:02 +02:00
Simon Giraudot c1259c8408 Fix facets -> faces 2020-04-02 13:45:02 +02:00
Simon Giraudot abae12955b Fix type 2020-04-02 13:45:01 +02:00
Simon Giraudot eba52f2a70 Finalize doc 2020-04-02 13:45:01 +02:00
Simon Giraudot c2a7dd51f3 Use named parameters 2020-04-02 13:45:01 +02:00
Simon Giraudot 5afc4bbc59 Update with new alpha expansion API 2020-04-02 13:45:01 +02:00
Simon Giraudot 86d5788480 Improve vertex label map 2020-04-02 13:45:01 +02:00
Simon Giraudot 80a4b95f01 Use identity face map 2020-04-02 13:45:01 +02:00
Simon Giraudot bdbd360490 Change weights normalization if deselection is not prevented 2020-04-02 13:45:01 +02:00
Simon Giraudot dc54b326f4 Separate regularization functions 2020-04-02 13:45:01 +02:00
Simon Giraudot 1c5bc70b7b Start working on public API for alpha expansion 2020-04-02 13:45:00 +02:00
Simon Giraudot 461bb19e2d Use BGL API in regularize_selection 2020-04-02 13:45:00 +02:00
Simon Giraudot 6b79764dbb Add alternative algorithm for regularization using local minimization 2020-04-02 13:45:00 +02:00
Simon Giraudot f64702e640 Make API weight between 0 and 1 2020-04-02 13:45:00 +02:00
Simon Giraudot 8bcbc8ea5e Remove useless parameter 2020-04-02 13:45:00 +02:00
Simon Giraudot 67ac0d80b1 Normalize weights 2020-04-02 13:45:00 +02:00
Simon Giraudot d505837264 First version of selection regularization via graphcut 2020-04-02 13:45:00 +02:00
Simon Giraudot 8089907795 Remove trailing whitespace 2020-04-02 13:44:17 +02:00