songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
cgal/Arrangement_on_surface_2/include/CGAL
History
Sebastien Loriot 18ee149f2e
Aos 2 fixes efif (#9133) 
## Summary of Changes

This addresses issue #9084. In particular, I replaced `Cartesian` with
`Simple_cartesian` in all traits.
I also defined Multiplicity to be `std::size_t` in all traits. In
addition, I replaced `typedef` with `using` and properly indented and
cleaned up the code in the source files I touched. I simplified the code
that approximates a point of the traits classes `Arr_linear_traits_2`,
`Arr_segment_traits_2`, and `Arr_non_caching_segment_basic_traits_2.h`.
I did not use the
[GAL::Cartesian_coverter](https://doc.cgal.org/latest/Kernel_23/classCGAL_1_1Cartesian__converter.html)
(mentioned in issue #9084) because the code is now simple as it is(just
one line in each traits class).

I also added a missing `inline` in draw_arrangement_2. This is unrelated
to the above.

## Release Management

* Affected package(s): Arrangement_on_surface_2
* Issue(s) solved (if any): fix #9084
* Feature/Small Feature (if any):
* Link to compiled documentation (obligatory for small feature) [*wrong
link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg)
* License and copyright ownership: TAU
 		2025-12-03 11:45:33 +01:00
..
Arr_geometry_traits Changed Cartesian to Simple_cartesian. Used size_t for Multiplicity. Properly indented and cleaned up. 2025-11-13 11:10:49 +02:00
Arr_point_location dont > don't 2025-03-28 20:52:22 +01:00
Arr_rat_arc issue #8515 Spelling mistakes found checking `en-GB` to `en-US` 2024-10-05 11:28:29 +02:00
Arr_spherical_gaussian_map_3 Fixed typo 2024-11-13 03:25:54 +02:00
Arr_topology_traits dont > don't 2025-03-28 20:52:22 +01:00
Arrangement_2 Cleaned up and removed unused variables and types 2025-10-25 10:52:25 +03:00
Curved_kernel_via_analysis_2 Changed Cartesian to Simple_cartesian. Used size_t for Multiplicity. Properly indented and cleaned up. 2025-11-13 11:10:49 +02:00
Draw_aos Spelling correction 2025-11-04 11:15:57 +01:00
IO Fixed typo 2024-11-13 03:25:54 +02:00
Qt First pass on removing license notice in header for GPL files 2019-10-19 15:23:19 +02:00
Surface_sweep_2 Fixed do_intersect() and cleaned up 2025-09-06 20:41:49 +03:00
boost/graph add missing license include directives 2024-01-04 13:45:39 +01:00
Aos_observer.h Fixed typo 2024-11-13 03:25:54 +02:00
Arr_Bezier_curve_traits_2.h Fixed typo 2024-11-13 03:25:54 +02:00
Arr_accessor.h Fixed typo 2024-11-13 03:25:54 +02:00
Arr_algebraic_segment_traits_2.h Merge branch 'master' into Aos_2-traits_concept-efif 2025-01-21 21:30:42 +02:00
Arr_batched_point_location.h later > latter 2025-03-28 20:41:37 +01:00
Arr_bounded_planar_topology_traits_2.h Fixed typo 2024-11-13 03:25:54 +02:00
Arr_circle_segment_traits_2.h Changed Cartesian to Simple_cartesian. Used size_t for Multiplicity. Properly indented and cleaned up. 2025-11-13 11:10:49 +02:00
Arr_circular_arc_traits_2.h Changed Cartesian to Simple_cartesian. Used size_t for Multiplicity. Properly indented and cleaned up. 2025-11-13 11:10:49 +02:00
Arr_circular_line_arc_traits_2.h Changed Cartesian to Simple_cartesian. Used size_t for Multiplicity. Properly indented and cleaned up. 2025-11-13 11:10:49 +02:00
Arr_conic_traits_2.h Changed Approximate_curve_length_2 => Approximate_length_2, and added missing const 2025-11-26 16:48:30 +02:00
Arr_consolidated_curve_data_traits_2.h
…
Arr_counting_traits_2.h Merge pull request #8713 from efifogel/Aos_2-traits_concept-efif 2025-03-24 11:45:17 +01:00
Arr_curve_data_traits_2.h Fixed typo 2024-11-13 03:25:54 +02:00
Arr_dcel.h Introduced Arr_dcel and fixed Arr_default_dcel 2023-11-15 18:54:21 +02:00
Arr_dcel_base.h Cleaned up 2025-01-22 12:43:19 +02:00
Arr_default_dcel.h Introduced Arr_dcel and fixed Arr_default_dcel 2023-11-15 18:54:21 +02:00
Arr_default_overlay_traits.h Introduced Arr_dcel and fixed Arr_default_dcel 2023-11-15 18:54:21 +02:00
Arr_directional_non_caching_segment_basic_traits_2.h Merge branch 'master' into Aos_2-traits_concept-efif 2025-01-21 21:30:42 +02:00
Arr_do_intersect_overlay_2.h Removed printout 2025-08-26 14:55:14 +03:00
Arr_enums.h move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Arr_extended_dcel.h Fixed extending DCEL records for arrangements with history (and similar derivations of Arrangement_2). 2025-01-22 12:43:33 +02:00
Arr_face_index_map.h Fixed typo 2024-11-13 03:25:54 +02:00
Arr_face_map.h moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Arr_geodesic_arc_on_sphere_partition_traits_2.h Fixed typo 2024-11-13 03:25:54 +02:00
Arr_geodesic_arc_on_sphere_traits_2.h Changed Cartesian to Simple_cartesian. Used size_t for Multiplicity. Properly indented and cleaned up. 2025-11-13 11:10:49 +02:00
Arr_has.h Added support for construct_point_2 2024-09-11 10:45:09 +03:00
Arr_landmarks_point_location.h Fixed for arrangement on sphere; cleaned up. 2024-11-16 22:12:56 +02:00
Arr_line_arc_traits_2.h Changed Cartesian to Simple_cartesian. Used size_t for Multiplicity. Properly indented and cleaned up. 2025-11-13 11:10:49 +02:00
Arr_linear_traits_2.h Slightly simplified the code of Approximate_2::operator()(xcv...) 2025-11-13 15:10:17 +02:00
Arr_naive_point_location.h
…
Arr_non_caching_segment_basic_traits_2.h Slightly simplified the code of Approximate_2::operator()(xcv...) 2025-11-13 15:10:17 +02:00
Arr_non_caching_segment_traits_2.h Merge branch 'master' into Aos_2-traits_concept-efif 2025-01-21 21:30:42 +02:00
Arr_observer.h Cleaned up 2023-12-13 13:41:51 +02:00
Arr_overlay.h moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Arr_overlay_2.h Cleaned up; replaced `typedef` with `using`, etc. 2025-08-26 21:58:34 +03:00
Arr_point_location_result.h add missing includes 2023-06-29 18:07:48 +02:00
Arr_polycurve_basic_traits_2.h more cleanups, align with code conventions and refactor 2025-07-23 19:28:56 +08:00
Arr_polycurve_traits_2.h Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface 2024-12-16 11:47:34 +01:00
Arr_polyline_traits_2.h more cleanups, align with code conventions and refactor 2025-07-23 19:28:56 +08:00
Arr_rational_function_traits_2.h Fixed typo 2024-11-13 03:25:54 +02:00
Arr_segment_traits_2.h Slightly simplified the code of Approximate_2::operator()(xcv...) 2025-11-13 15:10:17 +02:00
Arr_simple_point_location.h use std::get_if, get()->value() and remove CGAL::Object usage in Envelope 2023-06-20 18:32:13 +02:00
Arr_spherical_topology_traits_2.h Fixed typo 2024-11-13 03:25:54 +02:00
Arr_tags.h replace boost::mpl::not_ 2023-11-10 16:38:24 +01:00
Arr_tracing_traits_2.h Aos 2 fixes efif (#8666) 2025-01-20 10:05:42 +01:00
Arr_trapezoid_ric_point_location.h Fixed typo 2024-11-13 03:25:54 +02:00
Arr_triangulation_point_location.h Spelling correction 2024-05-30 18:32:30 +02:00
Arr_unb_planar_topology_traits_2.h Fixed typo 2024-11-13 03:25:54 +02:00
Arr_vertex_index_map.h Fixed typo 2024-11-13 03:25:54 +02:00
Arr_vertex_map.h moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Arr_vertical_decomposition_2.h later > latter 2025-03-28 20:41:37 +01:00
Arr_walk_along_line_point_location.h Some obvious missing quotes and typos 2022-09-24 18:47:33 +02:00
Arrangement_2.h Fixed typo 2024-11-13 03:25:54 +02:00
Arrangement_on_surface_2.h Fixed typo 2024-11-13 03:25:54 +02:00
Arrangement_on_surface_with_history_2.h Fixed typo 2024-11-13 03:25:54 +02:00
Arrangement_with_history_2.h Fixed typo 2024-11-13 03:25:54 +02:00
Arrangement_zone_2.h Introduced is_to_left() for points and used it to handle intersection spoints on the boundary 2025-10-21 14:49:42 +03:00
CORE_algebraic_number_traits.h Merge remote-tracking branch 'cgal/master' into HEAD 2024-03-27 22:25:41 +01:00
draw_arrangement_2.h Added missing inline 2025-11-13 09:33:58 +02:00
graph_traits_Arrangement_2.h Fixed typo 2024-11-13 03:25:54 +02:00
graph_traits_dual_arrangement_2.h move Named_parameters class in STL_extension 2022-01-07 15:12:22 +01:00
graph_traits_dual_arrangement_on_surface_2.h move Named_parameters class in STL_extension 2022-01-07 15:12:22 +01:00
graph_traits_dual_arrangement_on_surface_with_history_2.h move Named_parameters class in STL_extension 2022-01-07 15:12:22 +01:00
graph_traits_dual_arrangement_with_history_2.h move Named_parameters class in STL_extension 2022-01-07 15:12:22 +01:00