mirror of https://github.com/CGAL/cgal
dfc5fb5065
## Summary of Changes As reported in #7868 the function `CGAL::IO::write_PLY()` used in binary mode does not correctly write the coordinates if the points are from a kernel with exact constructions. ~~This PR applies `to_double()" to the coordinates.~~ ~~After a discussion with @MaelRL we decided that the user is in charge to pass a `vertex_point_map` as named parameter that does the conversion. This is straightforward as we offer the [`Cartesian_converter_property_map`](https://doc.cgal.org/latest/Property_map/structCGAL_1_1Cartesian__converter__property__map.html).~~ Moving back to the previous proposal: hardcode some to_double and to_float casts such that we meet the requirements of the file format, whatever the input. As the problem is the same for the vertex normals we add a named parameter `vertex_normal_map`. ### Todo - [x] Fix the generic function `write_polygon_mesh()`. Currently it is fixed for `Surface_mesh` ## Release Management * Affected package(s): Stream_support * Issue(s) solved (if any): fix #7868 and fix https://github.com/CGAL/cgal/issues/7327 * License and copyright ownership: unchanged * upcoming integration, update #9072 and test it |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| SM_common.h | ||
| issue_7327.cpp | ||
| issue_9086.cpp | ||
| sm_circulator_concept_checks.cpp | ||
| sm_circulator_test.cpp | ||
| sm_join_test.cpp | ||
| sm_open_colored_off.cpp | ||
| sm_ply_io.cpp | ||
| sm_remove.cpp | ||
| surface_mesh_test.cpp | ||
| test.3mf | ||
| test2.off | ||
| test3.off | ||
| tetra.ply | ||