songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
cgal/Cartesian_kernel/include/CGAL/Cartesian
History
Laurent Rineau 6b51b12ab5 Fix the case when FT is mpq_class 
If x and w are mpq_class objects, then the type of x/w is not mpq_class,
but only a proxy type that is implicitly convertible to
mpq_class. With the type deduction, CGAL::make_array(x/w, y/w,
z/w) will not create an array<mpq_class> but an array of the proxy type.

That creates the following compilation error, in a ternary operator:

- with clang:
include/CGAL/Cartesian/Vector_3.h:78:25: error: incompatible operand types ('array<__gmp_expr<[...], struct __gmp_binary_expr<class __gmp_expr<mpq_t, mpq_t>, class __gmp_expr<mpq_t, mpq_t>, struct __gmp_binary_divides>>, [...]>' and 'array<__gmp_expr<[...], __mpq_struct [1]>, [...]>')
    : base( w != FT_(1) ? CGAL::make_array(x/w, y/w, z/w)
                        ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- with g++:
include/CGAL/Cartesian/Vector_3.h:78:25: error: no match for ternary 'operator?:' (operand types are 'bool', 'std::array<__gmp_expr<__mpq_struct [1], __gmp_binary_expr<__gmp_expr<__mpq_struct [1], __mpq_struct [1]>, __gmp_expr<__mpq_struct [1], __mpq_struct [1]>, __gmp_binary_divides> >, 3ul>', and 'std::array<__gmp_expr<__mpq_struct [1], __mpq_struct [1]>, 3ul>')
     : base( w != FT_(1) ? CGAL::make_array(x/w, y/w, z/w)
                         ^

The fix is to specify the template argument of CGAL::make_array.
 		2013-10-04 16:42:13 +02:00
..
Aff_transformation_2.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Aff_transformation_3.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Aff_transformation_rep_2.h Fix last errors in headers of CGAL foundations 2012-10-08 09:03:50 +00:00
Aff_transformation_rep_3.h Fix last errors in headers of CGAL foundations 2012-10-08 09:03:50 +00:00
Cartesian_base.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Circle_2.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Circle_3.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Data_accessor_2.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Direction_2.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Direction_3.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Iso_cuboid_3.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Iso_rectangle_2.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Line_2.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Line_3.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Plane_3.h In the implementation details of PlaneC3, Point_3 is not necessarily PointC3 2013-02-08 09:27:02 +01:00
Point_2.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Point_3.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Ray_2.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Ray_3.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Rotation_rep_2.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Scaling_rep_2.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Scaling_rep_3.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Segment_2.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Segment_3.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Sphere_3.h Fix last errors in headers of CGAL foundations 2012-10-08 09:03:50 +00:00
Tetrahedron_3.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Translation_rep_2.h Fix last errors in headers of CGAL foundations 2012-10-08 09:03:50 +00:00
Translation_rep_3.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Triangle_2.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Triangle_3.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Vector_2.h apply the cpp0x namespace renaming in all files 2012-12-19 11:33:17 +01:00
Vector_3.h Fix the case when FT is mpq_class 2013-10-04 16:42:13 +02:00
basic_constructions_2.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
basic_constructions_3.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
ft_constructions_2.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
ft_constructions_3.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
function_objects.h Merged ^/branches/next here 2012-04-16 08:53:21 +00:00
line_constructions_2.h Fix last errors in headers of CGAL foundations 2012-10-08 09:03:50 +00:00
plane_constructions_3.h In the implementation details of PlaneC3, Point_3 is not necessarily PointC3 2013-02-08 09:27:02 +01:00
point_constructions_2.h Fix last errors in headers of CGAL foundations 2012-10-08 09:03:50 +00:00
point_constructions_3.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
predicates_on_directions_2.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
predicates_on_planes_3.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
predicates_on_points_2.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
predicates_on_points_3.h Fix last errors in headers of CGAL foundations 2012-10-08 09:03:50 +00:00
solve_3.h change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00