songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add comments

This commit is contained in:
Marc Glisse 2020-04-09 23:50:26 +02:00 committed by Mael Rouxel-Labbé
parent 556731d5be
commit 0e1a871b0c
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
NewKernel_d/include/CGAL/NewKernel_d/Cartesian_filter_K.h
View File

@ -50,6 +50,10 @@ template<> struct Functors_without_division<Dimension_tag<6> > {
typedef typeset<Orientation_of_points_tag, Side_of_oriented_sphere_tag> type;
};
// FIXME:
// - Is_exact (which should be renamed to Uses_no_arithmetic) predicates should not be filtered
// - Functors_without_division should be defined near/in the actual functors
template < typename Base_, typename AK_, typename EK_, typename Pred_list = typeset_all >
struct Cartesian_filter_K : public Base_
{

3
NewKernel_d/include/CGAL/NewKernel_d/LA_eigen/LA.h
View File

@ -122,6 +122,9 @@ template<class NT_,class Dim_,class Max_dim_=Dim_> struct LA_eigen {
return m.determinant();
}
// TODO: https://gitlab.com/libeigen/eigen/-/issues/1782
// Implement a version of (sign_of_)determinant that works
// without (inexact) division in any dimension
template<class Mat_> static NT determinant(Mat_ const&m,bool=false){
switch(m.rows()){
//case 0: