songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove some assertions, as they must not pop-up, since they are 

used by Cartesian_converter/Homogeneous_converter, where we
absolutely must not throw.

TODO : find a way to keep the assertion while having the
       converters still work.  (should types come with their
       own conversions, like they all have .bbox() ?)
This commit is contained in:
Sylvain Pion 2006-08-03 11:29:12 +00:00
parent 15929ddde9
commit 9424d0e9d8
5 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Cartesian_kernel/include/CGAL/Cartesian/Iso_cuboid_3.h
View File

@ -52,9 +52,10 @@ public:
Iso_cuboidC3(const Point_3 &p, const Point_3 &q, int) Iso_cuboidC3(const Point_3 &p, const Point_3 &q, int)
: base(p, q) : base(p, q)
{ {
CGAL_kernel_assertion(p.x()<=q.x()); // I have to remove the assertions, because of Cartesian_converter.
CGAL_kernel_assertion(p.y()<=q.y()); // CGAL_kernel_assertion(p.x()<=q.x());
CGAL_kernel_assertion(p.z()<=q.z()); // CGAL_kernel_assertion(p.y()<=q.y());
// CGAL_kernel_assertion(p.z()<=q.z());
} }
Iso_cuboidC3(const Point_3 &p, const Point_3 &q) Iso_cuboidC3(const Point_3 &p, const Point_3 &q)

3
Cartesian_kernel/include/CGAL/Cartesian/Iso_rectangle_2.h
View File

@ -52,7 +52,8 @@ public:
Iso_rectangleC2(const Point_2 &p, const Point_2 &q, int) Iso_rectangleC2(const Point_2 &p, const Point_2 &q, int)
: base(p, q) : base(p, q)
{ {
CGAL_kernel_assertion(p<=q); // I have to remove the assertions, because of Cartesian_converter.
// CGAL_kernel_assertion(p<=q);
} }
const Point_2 & min() const const Point_2 & min() const

5
Cartesian_kernel/include/CGAL/Cartesian/function_objects.h
View File

@ -1955,8 +1955,9 @@ namespace CartesianKernelFunctors {
Iso_rectangle_2 Iso_rectangle_2
operator()(const Point_2& p, const Point_2& q, int) const operator()(const Point_2& p, const Point_2& q, int) const
{ {
CGAL_kernel_assertion(p.x()<=q.x()); // I have to remove the assertions, because of Cartesian_converter.
CGAL_kernel_assertion(p.y()<=q.y()); // CGAL_kernel_assertion(p.x()<=q.x());
// CGAL_kernel_assertion(p.y()<=q.y());
return Rep(p, q, 0); return Rep(p, q, 0);
} }

5
Homogeneous_kernel/include/CGAL/Homogeneous/Iso_rectangleH2.h
View File

@ -51,8 +51,9 @@ public:
Iso_rectangleH2(const Point_2& p, const Point_2& q, int) Iso_rectangleH2(const Point_2& p, const Point_2& q, int)
: base(p, q) : base(p, q)
{ {
CGAL_kernel_assertion(p.x()<=q.x()); // I have to remove the assertions, because of Homogeneous_converter.
CGAL_kernel_assertion(p.y()<=q.y()); // CGAL_kernel_assertion(p.x()<=q.x());
// CGAL_kernel_assertion(p.y()<=q.y());
} }
const Point_2 & min() const; const Point_2 & min() const;

5
Homogeneous_kernel/include/CGAL/Homogeneous/function_objects.h
View File

@ -2523,8 +2523,9 @@ namespace HomogeneousKernelFunctors {
Iso_rectangle_2 Iso_rectangle_2
operator()(const Point_2& p, const Point_2& q, int) const operator()(const Point_2& p, const Point_2& q, int) const
{ {
CGAL_kernel_assertion(p.x()<=q.x()); // I have to remove the assertions, because of Cartesian_converter.
CGAL_kernel_assertion(p.y()<=q.y()); // CGAL_kernel_assertion(p.x()<=q.x());
// CGAL_kernel_assertion(p.y()<=q.y());
return Rep(p, q, 0); return Rep(p, q, 0);
} }