Sébastien Loriot
061bc2dc29
Merge remote-tracking branch 'cgal/6.0.x-branch' into `cgal/6.1.x-branch`
2025-12-12 17:48:59 +01:00
Sebastien Loriot
fed810284e
CH3: Make convex_hull_3 deterministic (order of vertices and indices) ( #9160 )
...
## Summary of Changes
Adding timestamp to convex_hull_3 vertex
The reason why it makes it deterministic is because during the creation
of the hull some border edges are collected here:
[`find_visible_set(tds, farthest_pt, f_handle, visible_set, border,
traits);`](https://github.com/CGAL/cgal/blob/main/Convex_hull_3/include/CGAL/convex_hull_3.h#L659C6-L659C80 )
with `border` being [`typedef std::map<typename TDS_2::Vertex_handle,
typename TDS_2::Edge>
Border_edges;`](https://github.com/CGAL/cgal/blob/main/Convex_hull_3/include/CGAL/convex_hull_3.h#L643 ).
Then another container `edges` is filled using `border.begin()`
[here](https://github.com/CGAL/cgal/blob/main/Convex_hull_3/include/CGAL/convex_hull_3.h#L678C1-L692C7 ).
The call to [`Vertex_handle vh = tds.star_hole(edges.begin(),
edges.end(), visible_set.begin(),
visible_set.end());`](https://github.com/CGAL/cgal/blob/main/Convex_hull_3/include/CGAL/convex_hull_3.h#L707 )
then induced that the order of faces in the TDS depends on the order of
edges in `edges`. The timestamp makes that the first vertex is always
the same in `border_edges`.
## Release Management
* Affected package(s): Convex_hull_3
2025-12-12 17:48:19 +01:00
Sebastien Loriot
bae3d52e1e
Installation: Adapting testing for MSVC 2026 ( #9169 )
...
## Summary of Changes
MSVC 2026 solutions have slnx file ending
## Release Management
* Affected package(s): Installation
2025-12-12 13:55:15 +01:00
Sebastien Loriot
346a2dec61
Misc PMP doc fixes ( #9172 )
...
## Release Management
* Affected package(s): `Polygon_mesh_processing`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2025-12-12 13:54:48 +01:00
Sebastien Loriot
409b5f14e2
Workaround wrong overload pick by at least clang 21.1.6 ( #9181 )
...
Fixes [this
error](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0.3-I-411/Triangulation_3/TestReport_gimeno_ArchLinux-clang-CXX17-Release.gz )
2025-12-12 13:50:58 +01:00
Sébastien Loriot
66fa84d3ea
workaround wrong overload pick by at least clang 21.1.6
2025-12-10 17:57:41 +01:00
Sven Oesau
960b646074
removing directory from TAG_DIR
2025-12-09 15:57:25 +01:00
Sven Oesau
7fbee84a0e
remove timestamp from Convex_hull_face_base_2
2025-12-09 14:42:38 +01:00
Laurent Rineau
72c8cc152a
new way to search for TAG_DIR
2025-12-08 15:59:06 +01:00
Mael Rouxel-Labbé
f4c3ef092a
Misc PMP doc fixes
2025-12-05 22:08:45 +01:00
Sébastien Loriot
4af12e7167
Merge remote-tracking branch 'cgal/6.0.x-branch' into 'cgal/6.1.x-branch'
2025-12-04 18:47:22 +01:00
Sebastien Loriot
c9285d3def
Number_types: Document boost::multiprecision number types ( #9164 )
...
## Summary of Changes
Add documentation of `boost::multiprecision::cpp_int` and other types.
## Release Management
* Affected package(s): Number_types
* Issue(s) solved (if any): fix #9163
* Documentation:
[link](https://cgal.github.io/9164/v0/Number_types/group__nt__boost.html )
* License and copyright ownership: unchanged
2025-12-04 18:40:03 +01:00
Sebastien Loriot
56e8e6235b
CH3: Fixing generated indices of coplanar convex_hull_3 ( #9161 )
...
## Summary of Changes
Fixed generated indices of coplanar convex_hull_3
Added a small test
## Release Management
* Affected package(s): Convex_hull_3
2025-12-04 18:38:50 +01:00
Sebastien Loriot
0a215ea65c
Add missing license of GPL file ( #9166 )
...
## Release Management
* Affected package(s): `Constrained_triangulation_3`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2025-12-04 18:37:21 +01:00
Sebastien Loriot
163c35c53e
Workaround API update of Qt6 ( #9165 )
...
Should fix errors
[here](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-53/Lab_Demo/TestReport_gimeno_ArchLinux-clang-Release.gz )
2025-12-04 18:36:26 +01:00
Laurent Rineau
e9e7cf4913
avoid duplicated lines of code ( sln vs slnx)
2025-12-04 15:57:27 +01:00
Sven Oesau
95a51b186e
testing: msvc 2026 solutions have slnx file ending
2025-12-04 15:08:20 +01:00
Sébastien Loriot
39dd7c5028
Merge remote-tracking branch 'cgal/6.0.x-branch' into 'cgal/6.1.x-branch'
2025-12-03 11:54:12 +01:00
Sebastien Loriot
def6c38d76
Lab: Use Results to Avoid Warning ( #9156 )
...
## Summary of Changes
Check that `open()` worked to avoid warnings
[here](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-50/Lab_Demo/TestReport_cgaltest_ArchLinux-clang-CXX20-Release.gz ).
## Release Management
* Affected package(s): Lab
* License and copyright ownership: unchanged
2025-12-03 11:52:48 +01:00
Andreas Fabri
f503ce9359
Lab: use results
2025-12-03 11:51:43 +01:00
Sebastien Loriot
15d96571a1
CDT3: Fix face_constraint_index() ( #9155 )
...
## Summary of Changes
Fix the function and add it in an example so that it gets tested.
## Release Management
* Affected package(s): Constraind_triangulation_3
* License and copyright ownership: unchanged
2025-12-03 11:37:59 +01:00
Sebastien Loriot
5f8a8fe359
Periodic_3_triangulation_3: Fix warning in demo ( #9147 )
...
## Summary of Changes
Fix warning in
[CGAL-6.2-Ic-46](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-46/Periodic_3_triangulation_3_Demo/TestReport_cgaltest_Fedora-rawhide.gz )
## Release Management
* Affected package(s): Periodic_3_triangulation_3
* License and copyright ownership: unchanged
2025-12-03 11:37:34 +01:00
Andreas Fabri
543d424f58
Periodic_triangulation_3: Fix warning in demo
2025-12-03 11:36:14 +01:00
Mael Rouxel-Labbé
53ea50a64a
Add include guard and license
2025-12-03 11:33:33 +01:00
Sébastien Loriot
65e7050131
workaround API update of Qt6
2025-12-03 11:24:53 +01:00
Andreas Fabri
ee41a0cbad
Add gmp_int
2025-12-02 22:01:00 +00:00
Andreas Fabri
29573638c3
forgot to save
2025-12-02 21:44:59 +00:00
Andreas Fabri
52e4bb845e
Number_types: Document boost::mp::cpp_int
2025-12-02 21:35:18 +00:00
Sven Oesau
4c1400d2fb
fixing generated indices of coplanar convex_hull_3
...
adding a small test
2025-12-01 16:11:56 +01:00
Sven Oesau
638d12593f
adding timestamp to convex_hull_3 vertex and face base
2025-12-01 15:51:21 +01:00
Laurent Rineau
8e3a59a27b
simplify the code
2025-11-28 14:41:18 +01:00
Andreas Fabri
40ac746be7
CDT3: Fix face_constraint_index()
2025-11-27 13:54:50 +00:00
Sebastien Loriot
85ef57ffa1
CDT_3 bug-fix: throw exceptions instead of raw crashs (like segfaults) ( #9089 )
...
## Summary of Changes
Bug-fix for `CGAL::Conforming_constrained_Delaunay_triangulation_3` in
CGAL-6.1.
## Release Management
* Affected package(s): Constrained_triangulation_3
* License and copyright ownership: GeometryFactory
2025-11-21 17:40:00 +01:00
Sebastien Loriot
aefbc23955
precompiled demos for CGAL-6.1 ( #9132 )
...
## Summary of Changes
Small fixes for precompiled demos
## Release Management
* Affected package(s): Maintenance
* License and copyright ownership: N/A
2025-11-21 17:39:12 +01:00
Laurent Rineau
7bf5687d5d
Remove -fexperimental-library
2025-11-21 10:42:35 +01:00
Laurent Rineau
cda931ec46
fix a warning
2025-11-20 15:23:40 +01:00
Andreas Fabri
e98fa21cc9
Fix warning in CGAL-6.2-Ic-41
2025-11-20 11:35:50 +01:00
Laurent Rineau
e0a720452d
fix a warning
2025-11-20 11:35:24 +01:00
Laurent Rineau
c856e40662
re-add <version> to fix clangd warnings
2025-11-20 11:35:17 +01:00
Laurent Rineau
ef6f9d8c3c
fix compilation error without C++20
2025-11-20 11:35:11 +01:00
Laurent Rineau
18e5836373
fix usage of <version>
...
That C++20 header is already conditionally included bu `<CGAL/config.h>`.
See e6b4d83cff/Installation/include/CGAL/config.h (L322)
2025-11-20 11:35:02 +01:00
Andreas Fabri
3e1a8c110d
(std::numeric_limits<std::size_t>::max)()
2025-11-20 11:34:38 +01:00
Sebastien Loriot
3ebe9203a7
Fix PMP on i386/i686 (32 bits, with the x87 FPU) ( #8911 )
...
## Summary of Changes
Fix PMP on i386/i686 (32 bits, with the x87 FPU).
## Release Management
* Affected package(s): PMP, Number_types
2025-11-20 10:28:31 +01:00
Sébastien Loriot
9bd1705bf8
Merge remote-tracking branch 'cgal/6.0.x-branch' into 'cgal/6.1.x-branch'
2025-11-19 14:45:21 +01:00
Sebastien Loriot
0fc710e95d
Fix bad 'if' condition & warning ( #9126 )
...
## Summary of Changes
```
Building CXX object test/Stream_support/CMakeFiles/issue8155.dir/issue8155.cpp.o
cd /home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/test/Stream_support && /bin/clang++ -DCGAL_DATA_DIR=\"/mnt/testsuite/data\" -DCGAL_TEST_SUITE=1 -DCGAL_USE_GMPXX=1 -I/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/include -I/mnt/testsuite/include -isystem /usr/local/boost/include -Wall -O3 -std=c++20 -DCGAL_NDEBUG -MD -MT test/Stream_support/CMakeFiles/issue8155.dir/issue8155.cpp.o -MF CMakeFiles/issue8155.dir/issue8155.cpp.o.d -o CMakeFiles/issue8155.dir/issue8155.cpp.o -c /mnt/testsuite/test/Stream_support/issue8155.cpp
/mnt/testsuite/test/Stream_support/issue8155.cpp:27:17: warning: overlapping comparisons always evaluate to true [-Wtautological-overlap-compare]
27 | if (len > 0 || len != 1.0) {
| ~~~~~~~~^~~~~~~~~~~~~
1 warning generated.
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-36/Stream_support/TestReport_cgaltest_ArchLinux-clang-CXX20-Release.gz
## Release Management
* Affected package(s): `Stream_support`
* Issue(s) solved (if any): n/a
* Feature/Small Feature (if any): n/a
* License and copyright ownership: no change
2025-11-19 14:43:26 +01:00
Sebastien Loriot
dee5ed8cc2
Fix edge collapse with incident non-triangular faces ( #9117 )
...
Make collapse able to handle non-triangular faces. The fix is easy as
you simply don't need to join faces in case the face won't disappear
after collapse
**TODO:**
update doc and constrained version
2025-11-19 14:42:28 +01:00
Sebastien Loriot
737bcb264e
Doc: fixing thirdparty links ( #9134 )
...
## Summary of Changes
fixed Metis/Eigen3/Qt6 links in Thirdparty
removed LEDA from doc as it is outdated
## Release Management
* Affected package(s): Documentation
2025-11-19 14:41:58 +01:00
Sebastien Loriot
2f9854b422
Fix warning about discarding return type of function with [[nodiscard]] ( #9127 )
...
## Summary of Changes
```
Building CXX object test/Generator_Demo/CMakeFiles/Generator_2.dir/Generator_2.cpp.o
cd /home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/test/Generator_Demo && /bin/clang++ -DCGAL_TEST_SUITE=1 -DCGAL_USE_GMPXX=1 -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_KEYWORDS -DQT_OPENGLWIDGETS_LIB -DQT_OPENGL_LIB -DQT_WIDGETS_LIB -I/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/test/Generator_Demo -I/mnt/testsuite/test/Generator_Demo -I/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/include -I/mnt/testsuite/include -I/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/test/AABB_tree_Demo -isystem /home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/test/Generator_Demo/Generator_2_autogen/include -isystem /usr/include/qt6/QtCore -isystem /usr/include/qt6 -isystem /usr/lib/qt6/mkspecs/linux-g++ -isystem /usr/include/qt6/QtOpenGLWidgets -isystem /usr/include/qt6/QtOpenGL -isystem /usr/include/qt6/QtGui -isystem /usr/include/qt6/QtWidgets -Wall -fno-direct-access-external-data -MD -MT test/Generator_Demo/CMakeFiles/Generator_2.dir/Generator_2.cpp.o -MF CMakeFiles/Generator_2.dir/Generator_2.cpp.o.d -o CMakeFiles/Generator_2.dir/Generator_2.cpp.o -c /mnt/testsuite/test/Generator_Demo/Generator_2.cpp
In file included from /mnt/testsuite/test/Generator_Demo/Generator_2.cpp:27:
In file included from /mnt/testsuite/include/CGAL/Qt/DemosMainWindow.h:130:
/mnt/testsuite/include/CGAL/Qt/DemosMainWindow_impl.h:224:3: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
224 | about_CGAL.open(QIODevice::ReadOnly);
| ^~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-36/Generator_Demo/TestReport_gimeno_ArchLinux-clang.gz
## Release Management
* Affected package(s): `GraphicsView`
* Issue(s) solved (if any): n/a
* Feature/Small Feature (if any): n/a
* License and copyright ownership: no change
2025-11-19 14:41:07 +01:00
Sven Oesau
e12a760f03
fixed Metis/Eigen3/Qt6 links in Thirdparty
...
removed LEDA from doc as it is outdated
2025-11-13 16:32:40 +01:00
Laurent Rineau
1602be1348
precompiled demos for CGAL-6.1
2025-11-13 13:29:35 +01:00