Commit Graph

389 Commits

Author SHA1 Message Date
Sébastien Loriot c1fa838e1e move examples using undocumented features to test 2024-03-28 08:19:44 +01:00
Sébastien Loriot c7f2e9d263 hide unused function 2024-03-28 08:11:25 +01:00
Sébastien Loriot 60a90c70d8 replace auto with type 2024-03-28 08:11:08 +01:00
Sébastien Loriot d6c4947e21 accomodate API changes in the Orthtree package 2024-03-28 07:40:42 +01:00
ange-clement a1e9a08905 added vtk image 2024-03-27 20:06:13 +01:00
Mael Rouxel-Labbé 53eaf67c06 Try to fix "no declaration" error 2024-03-27 10:43:38 +01:00
Mael Rouxel-Labbé e73380f647 Fix unused variable warnings by disabling not-yet-implemented function 2024-03-27 10:41:08 +01:00
Mael Rouxel-Labbé cb1fed2ac8 Add some documentation about "compute_discrete_gradients()" 2024-03-25 10:49:29 +01:00
Mael Rouxel-Labbé de9c1f3dc9 Safeguard against division by zero 2024-03-25 10:44:52 +01:00
Mael Rouxel-Labbé 8677a81439 Implement convenience function 2024-03-25 10:44:37 +01:00
Mael Rouxel-Labbé f605c3bae5 Fixes after review 2024-03-22 17:35:03 +01:00
Mael Rouxel-Labbé 5e38ed54df Fix double "Figure" in doc 2024-03-22 17:33:43 +01:00
Andreas Fabri 27ed583ac6 int -> std::size_t to avoid warning 2024-03-22 08:24:55 +01:00
Sébastien Loriot a6d375c6c5 fix warnings 2024-03-21 16:12:24 +01:00
Mael Rouxel-Labbé 217de048f0 Fix warning 2024-03-05 15:36:17 +01:00
Mael Rouxel-Labbé 6c91c5af1e Always use Parallel_if_available_tag in examples 2024-03-05 15:27:50 +01:00
Mael Rouxel-Labbé 1d251d57db Remove obsolete code 2024-03-05 15:17:01 +01:00
Sébastien Loriot 4d842ab2da fix doc warnings 2024-03-05 14:15:51 +01:00
Mael Rouxel-Labbé 90c50f47dc Update dependencies 2024-03-05 14:05:36 +01:00
Mael Rouxel-Labbé 8e9f9b9459 Minor doc fixes 2024-03-05 13:57:25 +01:00
Mael Rouxel-Labbé f83b17196f Add missing image 2024-03-05 13:51:18 +01:00
Mael Rouxel-Labbé 031eb050c7 Doc improvements 2024-03-05 13:40:39 +01:00
Mael Rouxel-Labbé 51d46d5853 Update copyright 2024-03-05 13:12:20 +01:00
Mael Rouxel-Labbé d765d49f58 Minor fixes for the implicit function example 2024-03-05 13:03:22 +01:00
Mael Rouxel-Labbé 6355dbcd10 Use a more interesting implicit function in the DC example 2024-03-05 13:02:23 +01:00
Mael Rouxel-Labbé 4bfbb83d7c Add more VTK readers for the VTK image example 2024-03-05 13:01:56 +01:00
Andreas Fabri ff0d56db46 Fix VC++ max 2024-03-05 09:34:08 +01:00
Mael Rouxel-Labbé 45777165eb Use an array instead of a fixed size vector 2024-03-01 12:29:54 +01:00
Mael Rouxel-Labbé 435f42c113 Update user manual 2024-03-01 12:29:35 +01:00
Mael Rouxel-Labbé 689d69533b Add an example with VTK images 2024-03-01 12:28:24 +01:00
Mael Rouxel-Labbé d5f053a482 Rename image example
Preparation for VTK example
2024-02-29 15:50:26 +01:00
Mael Rouxel-Labbé ba82f25c15 Improve doc phrasing 2024-02-29 12:16:12 +01:00
Mael Rouxel-Labbé 093cc2f93f use lower case for partition traits descriptors 2024-02-29 12:10:29 +01:00
Mael Rouxel-Labbé d1820195cc Fix output filename 2024-02-29 12:08:06 +01:00
Mael Rouxel-Labbé 20e0d45f70 Avoid computing points when the cell is trivial 2024-02-29 11:27:59 +01:00
Mael Rouxel-Labbé 1a12f53932 Clean CMakeLists.txt 2024-02-29 11:14:08 +01:00
Mael Rouxel-Labbé c0cbaa1e15 Do not provide a default value for finite difference-based gradients
Since there is no domain being passed, a hardcoded default has
no reason to be a good choice.
2024-02-29 11:13:15 +01:00
Mael Rouxel-Labbé 49cb69fae7 Add some assertions to ensure that arrays of correct size are used in MC 2024-02-29 10:53:37 +01:00
Mael Rouxel-Labbé 33c0079e85 Add 'Isosurfacing' to some concept names 2024-02-29 10:52:55 +01:00
Mael Rouxel-Labbé 2b8bb720c7 Add a comment 2024-02-28 13:34:48 +01:00
Mael Rouxel-Labbé c39acf7d85 Minor benchmark tweak 2024-02-28 13:34:09 +01:00
Mael Rouxel-Labbé 53d6d8cd68 Add missing header includes 2024-02-28 10:42:01 +01:00
Mael Rouxel-Labbé 7d4d0626fa Work on user manual 2024-02-28 10:25:43 +01:00
Mael Rouxel-Labbé 74babc8eb7 Fix typo (tparam > param) 2024-02-28 00:48:21 +01:00
Mael Rouxel-Labbé 2145430bf1 Tiny CMakeLists fix 2024-02-28 00:48:12 +01:00
Mael Rouxel-Labbé 5c808da22a Fix example name 2024-02-28 00:47:54 +01:00
Mael Rouxel-Labbé 6a55f88323 Misc minor changes 2024-02-27 16:00:45 +01:00
Mael Rouxel-Labbé b9411822a4 Revert "Follow the OG paper's prescription of the SVD threshold"
This reverts commit 913f8796c9.

While a larger epsilon bound gave better results for non-manifold
pinched configurations, it also resulted in a lot of sharpness
loss.

For now, I'd rather it does not do well at non-manifold configurations.

Improving results on those configurations is todo.
2024-02-27 15:57:49 +01:00
Mael Rouxel-Labbé ed1e4fb806 Use a more generic API to tolerate ranges of arrays 2024-02-27 15:56:56 +01:00
Mael Rouxel-Labbé c79b36bfdb Tests for Isosurfacing_3 2024-02-27 15:54:47 +01:00
Mael Rouxel-Labbé 4315a87beb Make some minor hardcoded value parameters 2024-02-27 13:28:27 +01:00
Mael Rouxel-Labbé b4bc7ee168 Remove useless parameter simplify API call 2024-02-26 17:55:26 +01:00
Mael Rouxel-Labbé b905a8f41a Add missing function in IsosurfacingDomain_3 concept 2024-02-26 17:54:17 +01:00
Mael Rouxel-Labbé 472c4c6e35 Use the free functions to construct domains in the most basic examples 2024-02-26 16:30:55 +01:00
Mael Rouxel-Labbé f012ff930d Fix creating isolated vertices in MC 2024-02-26 16:17:21 +01:00
Mael Rouxel-Labbé 001a6a186c Use a hash map in TBB-less Marching Cubes 2024-02-26 16:16:28 +01:00
Mael Rouxel-Labbé b60de052f1 Remove tmp code 2024-02-26 16:15:38 +01:00
Mael Rouxel-Labbé 99f07e7f96 Remove accidental (and pointless) usages of NPs meant for DC in MC 2024-02-26 16:14:42 +01:00
Mael Rouxel-Labbé f686fae8ef Tiny iostream change 2024-02-26 14:20:18 +01:00
Mael Rouxel-Labbé f22de55113 Add point caching 2024-02-26 13:45:31 +01:00
Mael Rouxel-Labbé 125ae6377a Benchmarks fixes 2024-02-25 01:54:43 +01:00
Mael Rouxel-Labbé d72d150f65 Silence warnings 2024-02-25 01:07:00 +01:00
Mael Rouxel-Labbé d5a7e902b4 Use traits functors, not CGAL object class member functions 2024-02-25 00:54:59 +01:00
Mael Rouxel-Labbé f45a2bf0ff Minor doc change 2024-02-25 00:30:33 +01:00
Mael Rouxel-Labbé 61e435c9c6 Fix bitset checks and type consistency 2024-02-25 00:30:10 +01:00
Mael Rouxel-Labbé 2d8b0e4d03 Fix compilation of benchmarks, remove obsolete includes 2024-02-24 23:56:19 +01:00
Mael Rouxel-Labbé 225fe9f89d Doc improvements 2024-02-24 23:11:58 +01:00
Mael Rouxel-Labbé 4ca692378b Minor API update for Cartesian_grid_3 2024-02-24 22:25:27 +01:00
Mael Rouxel-Labbé f6c22b9223 Remove obsolete files 2024-02-24 01:31:40 +01:00
Mael Rouxel-Labbé b1a5cb0d98 Update benchmarks 2024-02-24 01:27:42 +01:00
Mael Rouxel-Labbé ce7761d00b Use unordered maps 2024-02-24 00:15:49 +01:00
Mael Rouxel-Labbé 6e463a0f69 Simplify dichotomy + add proper error check 2024-02-24 00:15:09 +01:00
Mael Rouxel-Labbé 440122c1f6 Fix some warnings 2024-02-24 00:14:48 +01:00
Mael Rouxel-Labbé 7d3406a462 Misc minor changes 2024-02-23 16:19:19 +01:00
Mael Rouxel-Labbé aa3925d829 Follow the OG paper's prescription of the SVD threshold
It makes it less likely to have wild stuff happens on spiky geometry
2024-02-23 16:18:20 +01:00
Mael Rouxel-Labbé 5799dc8d15 Make DC Octree work (again) 2024-02-23 16:16:46 +01:00
Mael Rouxel-Labbé ad810b7db2 Add an undocumented example to compare MC and TMC 2024-02-23 10:43:27 +01:00
Mael Rouxel-Labbé a15340d061 Adjust input validity checks 2024-02-23 10:43:20 +01:00
Mael Rouxel-Labbé 2e4d3a7a07 Actually call MC 2024-02-23 10:43:13 +01:00
Mael Rouxel-Labbé 1d42bc58a9 Add missing header include 2024-02-23 10:43:06 +01:00
Mael Rouxel-Labbé f87b61234f Homogenize \return, gets, returns, etc. 2024-02-23 10:43:00 +01:00
Mael Rouxel-Labbé a23f15df28 Add two benchmarks for parallelism of implicit/image data 2024-02-23 10:42:52 +01:00
Mael Rouxel-Labbé 35cc806d59 Hide warning message behind macro 2024-02-23 10:42:46 +01:00
Mael Rouxel-Labbé 9a7c6b4573 Update examples following Image_3 IO changes 2024-02-23 10:42:38 +01:00
Mael Rouxel-Labbé 9841d9755c Minor doc fixes 2024-02-23 10:42:31 +01:00
Mael Rouxel-Labbé 8fc0e08356 Fix Isosurfacing_3's Image_3 IO: ref to 'grid' in 'values' must be stable 2024-02-23 10:42:20 +01:00
Mael Rouxel-Labbé a7c25006e0 Add some clamping 2024-02-23 10:42:10 +01:00
Mael Rouxel-Labbé 5383eda434 Allow resizing of the underlying data vector 2024-02-23 10:42:03 +01:00
Andreas Fabri bc05bcaca5 quiet the CI 2024-02-23 10:41:56 +01:00
Andreas Fabri 28d9c52591 Address some CI errors 2024-02-23 10:41:49 +01:00
Andreas Fabri d855831cab Address some CI errors 2024-02-23 10:41:38 +01:00
Andreas Fabri 3f0082dd97 change #includes in examples 2024-02-23 10:41:30 +01:00
Andreas Fabri ab244651e3 static_cast 2024-02-23 10:41:23 +01:00
Mael Rouxel-Labbé 2b32a81f30 Add missing header include 2024-02-23 10:41:17 +01:00
Mael Rouxel-Labbé 44c5f726e3 Update doc (new concepts, examples) 2024-02-23 10:40:46 +01:00
Mael Rouxel-Labbé 2ee864c7b0 Rewrite examples to emphasis data type and not contouring method 2024-02-23 10:40:37 +01:00
Mael Rouxel-Labbé 8e0140e641 New version of Isosurfacing_3:
- Completely restructure the domain classes to separate what is
  spatial partitioning, and what is value/gradient field definition.
- Improve DC edge-isosurfacing intersection, factorize code
- Refactor DC implementation to make it easier to use new (better)
  oracles
- Add concepts for these oracles, and document their models
2024-02-23 10:40:29 +01:00
Mael Rouxel-Labbé f9421efc89 Misc minor changes 2024-02-06 09:42:05 +01:00
Mael Rouxel-Labbé f4653e21a7 Precise comment 2024-02-06 09:36:21 +01:00
Mael Rouxel-Labbé 356c597e0e Fix narrowing conversion error 2024-01-31 16:38:04 +01:00
Mael Rouxel-Labbé 0549c36aaf Add a helper function to visualize a Cartesian_grid_3 object 2024-01-31 16:37:41 +01:00
Mael Rouxel-Labbé 22c8ae9169 Add default values for the parallel template parameter 2024-01-31 16:36:24 +01:00
Mael Rouxel-Labbé 7ac5b037a8 Type-erase the point function in Finite_diff_gradients_3 2024-01-31 16:34:54 +01:00
Mael Rouxel-Labbé 293f8ca146 Normalize gradients produced by Finite_diff_gradient_3 2024-01-31 16:33:53 +01:00
Mael Rouxel-Labbé 1530cd727b Misc minor changes 2024-01-25 11:44:41 +01:00
Mael Rouxel-Labbé ebe56a52ff Misc minor changes 2024-01-23 22:40:53 +01:00
Mael Rouxel-Labbé 00a6efef6b Don't compute placement if the cell is irrelevant 2024-01-23 22:40:16 +01:00
Mael Rouxel-Labbé fde721c471 Fix compilation after Eigen type changes 2024-01-23 22:29:06 +01:00
Mael Rouxel-Labbé 5aaf910d68 Change bounding box type
And other code improvements
2024-01-23 22:28:58 +01:00
Mael Rouxel-Labbé b2a98cbb7b Also rework the Octree domain to avoid aliases 2024-01-23 21:50:04 +01:00
Mael Rouxel-Labbé 449a5dc111 Misc minor doc / code fixes 2024-01-23 21:50:04 +01:00
Mael Rouxel-Labbé ddacceb7a7 Make implicit / explicit Cartesian domains inherit rather than aliases
+ document the constructor
2024-01-23 21:50:04 +01:00
Mael Rouxel-Labbé 23687c02ae Rework image from/to operators 2024-01-23 21:50:04 +01:00
Mael Rouxel-Labbé 932098c897 Fix range requirements 2024-01-23 21:50:04 +01:00
Julian Stahl c4002be297 Fix inrimage example 2024-01-23 13:54:09 +01:00
Mael Rouxel-Labbé f5b6b5934f Changes after R1 review 2024-01-17 16:58:35 +01:00
Andreas Fabri 3adf0d9484 fix tests 2024-01-16 11:26:31 +00:00
Andreas Fabri c558ba05a5 Update Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/topologically_correct_marching_cubes_functors.h 2024-01-16 11:20:00 +01:00
Andreas Fabri f083aa4520 typo: face -> cell 2024-01-16 09:12:30 +00:00
Andreas Fabri 2baba7c94d typo 2024-01-16 08:23:20 +00:00
Andreas Fabri f61facedae polish and make the todos more readable 2024-01-16 08:15:45 +00:00
Andreas Fabri 7aba8d344d Fix dependencies and some backticks 2024-01-15 16:20:23 +00:00
Mael Rouxel-Labbé ae265012e3 Add missing citation 2024-01-15 17:00:38 +01:00
Mael Rouxel-Labbé aadc08b6f2 fix doc 2024-01-15 16:46:12 +01:00
Andreas Fabri f78e9ce819 doxygen warnings 2024-01-15 14:01:04 +00:00
Andreas Fabri 90fbd3bb04 doxygen warnings 2024-01-15 13:58:01 +00:00
Andreas Fabri 816a25895b Unify input and make that output can be written simultaneously (for example during the testsuite) 2024-01-15 13:46:15 +00:00
Julian Stahl 9a39ac9b61 Revert "Change comments"
This reverts commit b9bbc93d5b.
2024-01-15 11:30:21 +01:00
Julian Stahl a7e89b81ba Revert "Deduct GeomTraits template type"
This reverts commit ca1c78bbd0.
2024-01-15 11:29:23 +01:00
Julian Stahl 436cfe372c Deduct GeomTraits template type 2024-01-14 17:45:55 +01:00
Julian Stahl db58ee1e93 Change comments 2024-01-14 17:45:09 +01:00
Andreas Fabri 368be05c8a tiny fixes in user manual 2024-01-12 17:37:49 +00:00
Andreas Fabri decb99a624 Polygon -> Triangle 2024-01-12 17:37:10 +00:00
Andreas Fabri 46eaa3f145 example uses TBB 2024-01-12 16:55:45 +00:00
Mael Rouxel-Labbé 967dd08ec0 Fix some compilation errors 2024-01-09 12:04:57 +01:00
Mael Rouxel-Labbé 237940883d Add remarks 2024-01-09 10:59:48 +01:00
Pierre Alliez 7b18855e0c Example : Parallel vs sequential Marching cubes 2024-01-05 15:50:11 +01:00
Pierre Alliez 254818cf70 added example that compares parallel with sequential MC 2024-01-05 14:39:47 +01:00
Pierre Alliez 5d3859505a Merge branch 'gsoc2022-isosurface' of https://github.com/JulyCode/cgal into gsoc2022-isosurface
# Conflicts:
#	Isosurfacing_3/examples/Isosurfacing_3/dual_contouring_octree.cpp
2024-01-05 14:15:27 +01:00
Pierre Alliez 26848f3d67 Example DC on octree (still uses the octree wrapper) 2024-01-05 14:10:41 +01:00
Julian Stahl 8f85ff8844 Small doc change 2024-01-02 20:53:27 +01:00
Julian Stahl 3f3f08f977 Small fixes in examples 2024-01-02 20:52:07 +01:00
Julian Stahl 56ebc7b17b Remove unused imports 2024-01-02 20:03:39 +01:00
Julian Stahl ea95b6c3b6 Use eigen wrapper 2024-01-02 19:46:12 +01:00
Julian Stahl 86ac3311e8 Cast literals to correct type 2024-01-02 18:29:34 +01:00
Julian Stahl 2357d23d76 Change Eigen matrix to use correct type 2024-01-02 18:28:23 +01:00
Pierre Alliez d2c94538ae Few more minor changes to examples 2023-12-25 18:46:33 +01:00
Pierre Alliez d83fcf752c DC - iwp
updated figure
2023-12-25 18:34:59 +01:00
Pierre Alliez 60ed632e50 use CGAL timer instead of TBB 2023-12-25 18:17:04 +01:00
Pierre Alliez 4fd413619e Figure MC vs DC 2023-12-25 14:27:59 +01:00