Commit Graph

100978 Commits

Author SHA1 Message Date
Jane Tournois 0a43b5ff7d has_normals is const 2022-11-07 14:55:17 +01:00
Jane Tournois 826b2a19c4 Merge branch 'PSP-fix_has_normal_map-GF' of https://github.com/janetournois/cgal into PSP-fix_has_normal_map-GF 2022-11-07 13:15:55 +00:00
Jane Tournois 32486e4be8 precise default normal 2022-11-07 14:14:30 +01:00
Jane Tournois 6555faf73f this is only for ranges, not for Point_set_3 2022-11-07 14:14:16 +01:00
Jane Tournois a24c6ac84c
Apply suggestions from Mael's code review
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-11-07 14:13:18 +01:00
Sebastien Loriot 04e4eec6fd
reuse static assertions 2022-11-07 10:44:02 +01:00
Sebastien Loriot 1a226ed877
Restore [revious API 2022-11-07 10:41:22 +01:00
Jane Tournois 9ed334bcf9 now normal_map is always valid
since it is created before it's used, when not available
2022-11-04 14:27:09 +01:00
Jane Tournois dcf0ea09b3 create normal_map when not already created before usage 2022-11-04 14:12:52 +01:00
Jane Tournois 0ee5493f02 revert unintended change 2022-10-25 12:53:39 +02:00
Jane Tournois e99f442830 NP_helper::has_normal_map should not always return true
look for a normal_map in the point set, and in the named parameters

# Conflicts:
#	BGL/include/CGAL/boost/graph/named_params_helper.h
#	Point_set_processing_3/include/CGAL/jet_estimate_normals.h
2022-10-25 12:12:29 +02:00
Laurent Rineau 50d81e5c4c Merge branch '5.4.x-branch' into 5.5.x-branch 2022-10-13 15:16:34 +02:00
Laurent Rineau 1a8e03cc85 Merge pull request #6864 from janetournois/Mesh_3-fix_weighted_images-GF
Mesh 3 - fix construction of weights image for labeled image input
2022-10-13 15:15:22 +02:00
Laurent Rineau 2b5b4be5d4 Merge pull request #6931 from MaelRL/PMP-remove_degen_fix_bad_removal-GF
Purge to-be-border halfedges from edges-to-collapse sets
2022-10-13 15:15:19 +02:00
Laurent Rineau 49635d2482 Merge pull request #6959 from lrineau/Number_types-fix_testsuite_with_min_max-GF
test/Number_types/to_interval_test_boost.cpp: parenthesis to fix testsuite on Window (min/max)
2022-10-13 15:15:17 +02:00
Laurent Rineau adc5bd4677 Merge pull request #6864 from janetournois/Mesh_3-fix_weighted_images-GF
Mesh 3 - fix construction of weights image for labeled image input
2022-10-13 15:14:11 +02:00
Laurent Rineau ae8101d615 Merge pull request #6931 from MaelRL/PMP-remove_degen_fix_bad_removal-GF
Purge to-be-border halfedges from edges-to-collapse sets
2022-10-13 15:14:09 +02:00
Laurent Rineau 087cc812cb Merge branch '5.4.x-branch' into 5.5.x-branch 2022-10-12 15:30:52 +02:00
Laurent Rineau 755bfe4dc6 5.5.x-branch now targets CGAL-5.5.2 2022-10-12 15:30:32 +02:00
Laurent Rineau 28e6e7249f 5.4.x-branch now targets CGAL-5.4.4 2022-10-12 15:28:35 +02:00
Laurent Rineau 382df9d9c2 parenthesis to fix testsuite on Window (min/max) 2022-10-11 17:38:24 +02:00
Laurent Rineau a1ae234fa2 Merge branch '5.4.x-branch' into 5.5.x-branch 2022-10-07 15:46:49 +02:00
Laurent Rineau 73d9b4dd46 Merge pull request #6918 from lcaraffa/Triangulation-is_valid-lc
Triangulation_d: fix invalid triangulation after I/O
2022-10-07 15:46:40 +02:00
Laurent Rineau 2c6d70ef99 Merge pull request #6925 from MaelRL/OBB-Do_not_use_void_as_default-GF
Do not use `void` as default for the geometric traits if Eigen is not present
2022-10-07 15:46:37 +02:00
Laurent Rineau d18af6e369 Merge pull request #6927 from lrineau/Mesh_3-fix_leaks-GF
Mesh_3: Fix a memory leak in the parallel code
2022-10-07 15:46:34 +02:00
Laurent Rineau e5687eb69f Merge pull request #6918 from lcaraffa/Triangulation-is_valid-lc
Triangulation_d: fix invalid triangulation after I/O
2022-10-07 15:46:11 +02:00
Laurent Rineau 437dbf82a9 Merge pull request #6925 from MaelRL/OBB-Do_not_use_void_as_default-GF
Do not use `void` as default for the geometric traits if Eigen is not present
2022-10-07 15:46:08 +02:00
Laurent Rineau 7db002804c Merge pull request #6927 from lrineau/Mesh_3-fix_leaks-GF
Mesh_3: Fix a memory leak in the parallel code
2022-10-07 15:46:06 +02:00
Jane Tournois 9bb4fb4d15 protect debug code with macro
and remove default filename ""
2022-10-06 15:10:37 +02:00
Jane Tournois c64a0d8648 add more details about how to choose sigma 2022-10-06 10:44:26 +02:00
Sébastien Loriot d6d2188cc7 fix warning 2022-10-05 19:33:00 +02:00
Mael Rouxel-Labbé 60d50a8b57 Fix not purging to-be-border halfedges from edges-to-collapse sets 2022-10-04 22:57:37 +02:00
Laurent Rineau dbf3c0ec71 Merge branch '5.4.x-branch' into 5.5.x-branch 2022-10-04 13:50:48 +02:00
Laurent Rineau d345d93bbb Merge pull request #6796 from janetournois/Mesh_3-compare_distance_performance_issue-jtournois
Mesh_3 speedup (filter failures in `Compare_distance_3(Point_3, Segment_3, Point_3)` )
2022-10-04 13:50:27 +02:00
Laurent Rineau a4f6f58e25 Merge pull request #6845 from sloriot/PMP-coref_open_mesh_case
PMP corefinement: Handle inconsistency with open mesh as input
2022-10-04 13:50:24 +02:00
Laurent Rineau 9742b3ec70 Merge pull request #6850 from janetournois/CGAL-boost_min_version-GF
Installation - update minimal valid Boost version
2022-10-04 13:50:22 +02:00
Laurent Rineau 3a0a7fe34e Merge pull request #6863 from lrineau/Polyhedron-demo_fix_display_of_protecting_spheres-GF
Polyhedron demo - Fix the display of protecting balls (second version)
2022-10-04 13:50:20 +02:00
Laurent Rineau 23678d0f7d Merge pull request #6867 from sloriot/PMP-collision_detection_copy
Add default copy constructor and operator=
2022-10-04 13:50:18 +02:00
Laurent Rineau 87f16af6e2 Merge pull request #6872 from MaelRL/PMP-Fix_keep_LCC-GF
Fix dry-run of keep_largest_CCs dumping the wrong faces
2022-10-04 13:50:15 +02:00
Laurent Rineau 207a1e896b Merge pull request #6796 from janetournois/Mesh_3-compare_distance_performance_issue-jtournois
Mesh_3 speedup (filter failures in `Compare_distance_3(Point_3, Segment_3, Point_3)` )
2022-10-04 13:48:18 +02:00
Laurent Rineau de80833223 Merge pull request #6845 from sloriot/PMP-coref_open_mesh_case
PMP corefinement: Handle inconsistency with open mesh as input
2022-10-04 13:48:16 +02:00
Laurent Rineau fef4d1b43b Merge pull request #6863 from lrineau/Polyhedron-demo_fix_display_of_protecting_spheres-GF
Polyhedron demo - Fix the display of protecting balls (second version)
2022-10-04 13:48:13 +02:00
Laurent Rineau ff2bab36b0 Merge pull request #6867 from sloriot/PMP-collision_detection_copy
Add default copy constructor and operator=
2022-10-04 13:48:11 +02:00
Laurent Rineau b8b8d98281 Merge pull request #6872 from MaelRL/PMP-Fix_keep_LCC-GF
Fix dry-run of keep_largest_CCs dumping the wrong faces
2022-10-04 13:48:08 +02:00
Sébastien Loriot 29d543c9f4 remove tabs 2022-10-04 09:16:32 +02:00
Sébastien Loriot 96b205d9b0 add test from issue #5275 2022-10-03 18:55:44 +02:00
Laurent Caraffa 18ed302d84 set full_cell of a vertex in I/O 2022-10-03 18:48:43 +02:00
Laurent Caraffa 31714289b5 testing validity shows that td i/o is not valid 2022-10-03 18:48:43 +02:00
Laurent Rineau 8fddaa6baa Mesh_3: Fix a memory leak in the parallel code 2022-10-03 17:15:27 +02:00
Mael Rouxel-Labbé 71e51b5678 Do not use `void` as default for the geom_traits
This change is caused by the improvement of Lookup_named_param_def which added
support for reference named parameters:
aaa3947e40
Despite not being required, compilers will try to compile the `::reference`
branch if Eigen is not present, and complain about the type `Default& == void&`

Changing it to `CGAL::Default` will solve that, and align it with what
is done in other packages such as Surface_mesh_parameterization
2022-10-03 15:08:12 +02:00