Commit Graph

112083 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 0a9047a9d3 Use more iterations in tetrahderal remeshing 2025-05-22 11:02:12 +02:00
Laurent Rineau 3610121c03
Update build_doc.yml 2025-05-16 15:33:53 +02:00
Laurent Rineau bef2cf4c83 build_doc should be marked as skipped most of the time 2025-05-16 15:24:11 +02:00
Sébastien Loriot b1c8200387 Merge remote-tracking branch 'cgal/6.0.x-branch' into 'cgal/master' 2025-05-16 13:25:40 +02:00
Sébastien Loriot 9d1f4c9273 Merge remote-tracking branch 'cgal/5.6.x-branch' into 'cgal/6.0.x-branch' 2025-05-16 13:25:10 +02:00
Sebastien Loriot f702189ce0
Tetrahedral_remeshing - fix `operator<()` for `Dihedral_angle_cosine` (#8886)
## Summary of Changes

using <= makes possible to have
`dh1 < dh2 && dh2 < dh1 == true`
which is not valid!

This PR fixes [this
testsuite](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-Ic-153/Constrained_triangulation_3_Examples/TestReport_Christo_MSVC2017-Debug-64bits.gz)
(running remesh_constrained_Delaunay_triangulation_3)

## Release Management

* Affected package(s): Tetrahedral_remeshing
* License and copyright ownership: unchanged
2025-05-16 13:04:32 +02:00
Sebastien Loriot 7b37a89728
Fix range issue in weights (#8888)
## Summary of Changes

Outward construction does an inward construction for each hole, but the
hole weights start at [1] in the weight range, not [0].

## Release Management

* Affected package(s): `Straight_skeleton_extrusion_2`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2025-05-16 13:04:13 +02:00
Sebastien Loriot 6eb1d4891b
Add note about CGAL and pragma license messages (#8884)
Fixes https://github.com/CGAL/cgal/issues/7346 (lazily)
2025-05-16 13:03:36 +02:00
Sebastien Loriot 0392062827
Developer Manual: trivial fixes (#8883)
## Summary of Changes

Fix that functions shall be written with  `()`.     
Removed an example with the no longer existing `Window_stream`

This part of the manual needs a real review, as a lot is now directly on
github.


* License and copyright ownership: unchanged
2025-05-16 13:02:56 +02:00
Sebastien Loriot c6aa4fea5f
Kernel: Concepts are CamelCase (#8875)
## Summary of Changes

When `CGAL::Weighted_point_3` was moved into `Kernel::` we forgot to
switch to CamelCase, for example
[here](https://cgal.geometryfactory.com/CGAL/doc/master/Kernel_23/classKernel_1_1ConstructPoint__3.html).
The same for `Iso_rectangle_2`  and `Iso_cuboid_3`

## Release Management

* Affected package(s): Kernel_23
* License and copyright ownership: unchanged
2025-05-16 13:02:15 +02:00
Sebastien Loriot 11ba7aab68
Do not use deprecated function (#8882)
Fix [this
warning](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-I-152/Lab_Demo/TestReport_gimeno_Debian-testing-clang-main.gz)
2025-05-16 13:01:02 +02:00
Sebastien Loriot 8978dde2e5
Mark variables declared at global scope in headers as 'inline'. (#8874)
## Summary of Changes

`const` variables declared at global scope have internal linkage, and so
if they are declared in a header file, they are replicated in every file
that `#include` the header. They also can't be the target of `using`
declarations that exports the variable into a C++20 module. This change
marks a number of variables with `inline`, which gives these variables
external linkage, allows the linker to unify all of these variables
between different `.o` files, and also allows for their use in C++20
modules.

There is a separate question whether these variables could or should be
`constexpr` instead of just `const`. The difference between `constexpr`
and `const` has no effect on linkage, and so in the spirit of taking one
step at a time, this patch does not address the `constexpr` vs `const`
question.

This patch fixes #8871. Related to
https://github.com/dealii/dealii/issues/18071.

## Release Management

* Affected package(s): 5.6.1
* Issue(s) solved (if any): #8871
* License and copyright ownership: Same license as used throughout CGAL.
2025-05-16 13:00:02 +02:00
Sebastien Loriot e811ba2f72
Spelling correction (#8889)
Spelling correction
2025-05-14 11:36:22 +02:00
albert-github d320a30df0 Spelling correction
Spelling correction
2025-05-14 11:32:26 +02:00
Mael Rouxel-Labbé 3cc322981e Fix range issue in weights 2025-05-14 10:57:09 +02:00
Jane Tournois e7aec72cdb fix operator<() for Dihedral_angle_cosine
using <= makes possible to have
dh1 < dh2 && dh2 < dh1 valid
2025-05-13 15:39:18 +02:00
Andreas Fabri 2a1b99ba5e Revert in FunctionObjectConcepts.h 2025-05-12 14:41:07 +01:00
Sébastien Loriot d60f2ce443 Merge remote-tracking branch 'cgal/6.0.x-branch' into `cgal/master` 2025-05-12 14:58:19 +02:00
Sébastien Loriot 149d1c2a3a add note about CGAL and pragma license messages 2025-05-12 14:47:25 +02:00
Andreas Fabri 206be8d951 more small fixes 2025-05-12 13:41:42 +01:00
Sebastien Loriot c6c9f77ae4
SMDS_3 - add `c3t3.set_triangulation()` (#8851)
When loading a .mesh file to a `Triangulation_3`, and then a `C3t3`, as
done in [this
example](https://doc.cgal.org/latest/SMDS_3/SMDS_3_2tetrahedron_soup_to_c3t3_example_8cpp-example.html)
leads to a `C3t3` for which `number_of_facets()` and `number_of_cells()`
return 0, because the internal counters have not been updated by
`c3t3.triangulation() = tr`.

It is not clear to the user why these numbers are 0, and the function
`rescan_after_load_of_triangulation()` (which fixes the counters) is not
documented.

## Summary of Changes

~~Add the use of `rescan_after_load_of_triangulation()` in an example.~~

~~The other option would be to use it automatically in the functions
that load a triangulation.~~

~~@lrineau @MaelRL do you have an opinion?~~

~~Todo : discuss the API~~

Add and document a function `c3t3.set_triangulation(const Tr& tr)` that
internally calls `rescan_after_load_of_triangulation()`, and is easier
to use

## Release Management

* Affected package(s): SMDS_3
* Link to compiled documentation (obligatory for small feature) [*wrong
link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg)
* License and copyright ownership: unchanged
2025-05-12 14:33:32 +02:00
Sébastien Loriot c1f034312d hide non-const version of the function in the doc 2025-05-12 14:31:43 +02:00
Andreas Fabri 56f3e7a278 For testing refer to the wiki on github 2025-05-12 13:07:38 +01:00
Sebastien Loriot 88b04384ba
Basic viewer improvements (#8850)
_Please use the following template to help us managing pull requests._

## Summary of Changes

Some improvements to the basic viewer.

Following the GSOC 2024 project, see PR #8444, extract all the
modifications that concern the current basic_viewer qt (and keep in the
original PR the new basic viewer glfw that could be considered later).

## Changes to the documentation

- in `Graphics_scene`, functions to set/get default colors:
[diff](https://github.com/CGAL/cgal/pull/8850/files#diff-74c5383fef398c7cb3dbfaa8cbc836dbc5a3ad0a7b450442948e7e32d54ced47),
and
[documentation](https://cgal.github.io/8850/doc/Basic_viewer/classCGAL_1_1Graphics__scene.html)
- in `Basic_viewer`, same functions, plus functions for sizes:
[diff](https://github.com/CGAL/cgal/pull/8850/files#diff-cc9bfe7d72d61000248f90b7648c07decb71fd8a400ca54e3ecc8c808b0f70fa),
and
[documentation](https://cgal.github.io/8850/doc/Basic_viewer/classCGAL_1_1Qt_1_1Basic__viewer.html).

## Release Management

* Affected package(s): Basic_viewer
2025-05-12 14:06:35 +02:00
Andreas Fabri eaedf7661b Fix in Tutorial 2025-05-12 11:52:26 +01:00
Andreas Fabri 914b86b6b5 More trivial changes 2025-05-12 11:44:55 +01:00
Andreas Fabri bb9ebdff5a Developer Manual: trivial fixes 2025-05-12 11:14:13 +01:00
Sebastien Loriot 25d7076791
Avoid ambiguous overloads of operator= with optional and variant (#8879)
Does not replace #8854 that is a better implementation but currently not
fully compatible with older compilers.

Also loops around the issue with gcc-15, and fixes issue #8827.

See:
  - the CGAL https://github.com/CGAL/cgal/issues/8827,
- and the upstream gcc bug entry
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119859
2025-05-12 11:58:05 +02:00
Sébastien Loriot 190313e12a avoid ambiguous overloads of operator= with optional and variant
was showing up in inheritance of _or_drop_ version
2025-05-12 11:56:36 +02:00
Sébastien Loriot 50716b777f do not use deprecated function 2025-05-12 11:36:53 +02:00
Sébastien Loriot 59921c1eb8 Merge remote-tracking branch 'cgal/6.0.x-branch' into 'master' 2025-05-07 15:58:42 +02:00
Sébastien Loriot 70d5fce9b7 Merge remote-tracking branch 'cgal/5.6.x-branch' into 'cgal/6.0.x-branch' 2025-05-07 15:58:04 +02:00
Sebastien Loriot 7a07844efc
BGL: Fix Issue 8877 (#8878)
## Summary of Changes

`f` -> `e`

## Release Management

* Affected package(s): BGL
* Issue(s) solved (if any): fix #8877
* License and copyright ownership: unchanged
2025-05-07 15:42:50 +02:00
Andreas Fabri 68b64b0c56 BGL: Fix Issue 8877 2025-05-07 14:29:04 +01:00
Sebastien Loriot ac763ef561
Mesh_3: Specific domain for Poisson reconstruction (#8771)
## Summary of Changes

Creating Poisson_mesh_domain including optimizations for Poisson from
Surface_mesher

## Release Management

* Affected package(s): Mesh_3, Poisson_reconstruction_3
* small feature:
https://cgalwiki.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Poisson_mesh_domain
-- pre-approved 18 April 2025
* Issue(s) solved (if any): fix #8266
2025-05-07 09:42:25 +02:00
Sebastien Loriot c6dc9397f2
fixed some typos (#8853)
_Please use the following template to help us managing pull requests._

## Summary of Changes

Fixed some typos
2025-05-07 09:27:15 +02:00
Sebastien Loriot 8c9f53cdc5
Double use of citation name (#8504)
Based on #8320 and https://github.com/doxygen/doxygen/pull/11157
creating an assertion for builds from scratch when a citation name is
used multiple times.
2025-05-07 09:24:14 +02:00
Sébastien Loriot 47dfb09f70 fix double citation 2025-05-07 09:23:32 +02:00
albert-github 837be259dc Double use of citation name
Based on #8320 and https://github.com/doxygen/doxygen/pull/11157 creating an assertion for builds from scratch when a citation name is used multiple times.
(doxygen cannot catch these here as they are directly written into html code).
2025-05-07 09:19:15 +02:00
Sebastien Loriot c6197a96bc
add a version with move
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
2025-05-07 09:12:07 +02:00
Andreas Fabri ebc2cbf974 Simplify doc 2025-05-06 14:13:35 +01:00
Andreas Fabri 653a835d4d Fix doc dependencies 2025-05-06 14:09:44 +01:00
Andreas Fabri 0a357ee061 and more 2025-05-06 14:02:17 +01:00
Andreas Fabri 073a4dbbb2 and more 2025-05-06 13:57:01 +01:00
Andreas Fabri 33c05d40c2 Fixes in Periodic_2/3 2025-05-06 13:45:10 +01:00
Andreas Fabri 1440e46c2c Kernel: Concepts are CamelCase 2025-05-06 12:59:11 +01:00
Wolfgang Bangerth b6af36028d Mark variables declared at global scope in headers as 'inline'. 2025-05-05 05:29:58 -06:00
Laurent Rineau 010adccdec fix the mentions of CGAL_USE_BASIC_VIEWER_QT (with the Qt suffix) 2025-05-02 09:22:38 +02:00
Sebastien Loriot 9601e96724
Spelling corrections (#8869)
Spelling corrections.
2025-04-30 10:24:47 +02:00
Sébastien Loriot 991418e64e fix compatibility and use generic macro in generic contexts 2025-04-30 10:17:14 +02:00