Commit Graph

353 Commits

Author SHA1 Message Date
Sébastien Loriot 4ab3c37b64 missing parameter after update from master 2013-09-04 12:01:48 +02:00
Sébastien Loriot 4005e2bc79 add missing bool in function call 2013-09-04 11:58:52 +02:00
Sébastien Loriot a69f9189b3 enhance user manual: User interface 2013-09-04 11:49:55 +02:00
Sébastien Loriot 5258298687 enhance user manual: clustering 2013-09-04 11:36:55 +02:00
Sébastien Loriot 37c6ccd0cc enhance user manual: sdf value computation description 2013-09-04 11:22:48 +02:00
Sébastien Loriot eeeed29a82 enhance user manual: introduction 2013-09-04 09:26:47 +02:00
Sébastien Loriot ba68d06ad6 fix usage of which are where in the doc 2013-09-04 08:42:31 +02:00
Sébastien Loriot a97f340f68 using cgalCite macro 2013-09-04 08:24:46 +02:00
iyaz 914ee9e6b4 fix warnings (std::size_t to int conversions),
MAD : 1 -> 1.5,
2013-08-28 17:18:05 +03:00
iyaz 1cae7388d0 simplify sentence in graph cut 2013-08-09 00:03:00 +03:00
iyaz c20b02be58 remove notes about related to segment since:
- they are repetitive
- with the addition of the new figure, distinction should be clear (or we should make it more clear in just one place)
2013-08-08 21:20:15 +03:00
iyaz e234886f36 introduce postprocess_sdf_values in sdf values example 2013-08-08 21:12:07 +03:00
iyaz ed7218ae84 do not use epsilon for min since it does not effect the results,
and this also fix the optimization bug in MSVC-64
2013-08-08 21:06:22 +03:00
iyaz 322cf090b8 rephrase sentence in graph-cut about segment-cluster. 2013-08-08 18:56:32 +03:00
iyaz a0bf04f654 remove one-ring (just leave edge-adjacent) both in ref and user manual 2013-08-08 17:14:57 +03:00
iyaz 60936e12e5 cluster-id segment-id related changes in API part of the doc 2013-08-08 03:48:11 +03:00
iyaz d58febb8c6 rephrase "That way" 2013-08-08 02:42:39 +03:00
iyaz 6bedf47360 add postprocess function to the API (doc related) 2013-08-08 02:34:21 +03:00
iyaz dd5bf0ec3e add postprocess function to the API (code related changes) 2013-08-08 02:33:20 +03:00
iyaz 36d50d9477 add another parameter to API which lets user to get either cluster or segment ids as output 2013-08-06 23:23:56 +03:00
iyaz 2f8052312c add figure segment vs cluster 2013-08-06 23:21:03 +03:00
iyaz a2b4984361 caption change on Segmentation_pose_changes figure 2013-08-06 16:59:49 +03:00
iyaz 257ae2c781 Create another section called Implementation Details, and move ray sampling details under it 2013-08-06 13:01:43 +03:00
iyaz d4b347fccc clear exp on postprocessing step 2013-08-06 12:32:22 +03:00
iyaz 317ee4a7ea Function Documentation related changes (based on comments of reviewer-1) 2013-08-06 12:31:28 +03:00
iyaz 723e4593dc API(explanations) related changes (based on comments of reviewer-1) 2013-08-06 11:52:04 +03:00
iyaz 2996be191f improve formatting 2013-08-06 01:18:19 +03:00
iyaz 41d59aae2b 2.2. and 2.3 related changes (based on comments of reviewer-1) 2013-08-06 01:17:12 +03:00
iyaz 0bc3c61e13 simplify by reading one predefined off file 2013-08-06 01:01:52 +03:00
iyaz 5544dc6a8d 2.1. related changes (based on comments of reviewer-1) 2013-08-05 18:55:34 +03:00
iyaz ddd156bf7b Introduction related changes (based on comments of reviewer-1) 2013-08-05 17:54:25 +03:00
Sébastien Loriot d2e4678e43 update figure caption 2013-08-05 07:39:14 +02:00
Sébastien Loriot 0a651d4a88 add a link to the equation to explain a parameter 2013-07-26 17:29:08 +02:00
Sébastien Loriot 5ce5a5fad4 remove latex dedicated image command (they are now handled in the cgal macro) 2013-07-26 17:05:43 +02:00
Sébastien Loriot fc64c61cf2 accomodate changes to build doc with cmake 2013-07-26 13:36:43 +02:00
Sébastien Loriot 1615b15579 accomodate the changes of the AABB tree package 2013-07-26 13:27:04 +02:00
Sébastien Loriot 33aecff166 add missing template keyword 2013-07-25 18:39:18 +02:00
iyaz c919081e16 Revert "Use BOYKOV_KOLMOGOROV for test - will be reversed"
This reverts commit 0364b9f4f0d134563749216460aa9abf6b8389ee.
2013-07-22 11:44:17 +03:00
iyaz 7545de5539 Use BOYKOV_KOLMOGOROV for test - will be reversed 2013-07-22 11:15:25 +03:00
iyaz 4d5f8a0e54 Fixing ambiguous call - gcc 2013-05-20 16:02:35 +03:00
iyaz bab9218257 Fixing warning - gcc 2013-05-20 15:25:56 +03:00
Sébastien Loriot bfb2b44f3a forward types to satisfy gcc 2013-05-20 13:47:20 +02:00
Sébastien Loriot ef9ea573d4 add missing typename 2013-05-20 13:10:55 +02:00
Sébastien Loriot 9e6fb6f355 fix typos in doc 2013-05-15 09:56:03 +02:00
Sébastien Loriot 6de820ac0a add release number in benchmark section 2013-05-15 09:55:12 +02:00
Sébastien Loriot b0ca4b5d05 fix link issue 2013-05-15 09:52:16 +02:00
iyaz 5410a21049 ms -> milliseconds 2013-05-14 19:01:25 +03:00
iyaz e5c26f6fe3 Documentation improvements (from Andreas's comments) 2013-05-14 18:44:08 +03:00
iyaz 2f844f5dbc remove CGAL:: from functions and add () at the end 2013-05-14 15:39:09 +03:00
Sébastien Loriot 41e1b9c120 center tables in doc and fix typos 2013-05-14 09:05:42 +02:00
iyaz c2dbdcec8f Adding performance section 2013-05-14 02:00:48 +03:00
iyaz 7b7417780a new implemenation using boost CSR graph, it can be 1.5x faster from prev implementation but there is a performance problem that I couldn't solve using public functionality of graph (however there might be a solution)
will look it back.
2013-05-13 23:00:37 +03:00
iyaz 9c026f14ba remove unrelated code (remaining from debug related purposes) 2013-05-12 17:49:57 +03:00
iyaz ea4ebfa17e forgotten name changed in documentation
(from nontype template parameter name is changed from fast_bbox_intersection to Fast_sdf_calculation_mode)
2013-05-11 21:15:33 +03:00
iyaz e24653a617 Add new test for fast_sdf_calculation_mode,
change disk sampler test, mesh segmentation test (due to interface changes)
untabify
2013-05-10 17:14:17 +03:00
iyaz 789ee361cb nontype template parameter name is changed from fast_bbox_intersection to Fast_sdf_calculation_mode 2013-05-10 15:42:01 +03:00
iyaz 50c6542740 doc - lowercase -> uppercase after dot 2013-05-10 15:27:35 +03:00
iyaz a3fba15c95 untabify examples 2013-05-10 15:26:43 +03:00
iyaz 67047affcd making fast_bbox_intersection optional 2013-05-09 18:45:28 +03:00
iyaz d46a29af46 dummy element forgotten from prev version, removed. 2013-04-24 22:31:47 +03:00
iyaz f269e1fd21 use CGAL Random instead of rand(),
update plus plus initialization so that there is no need to extra temp for swap etc
2013-04-24 17:36:09 +03:00
iyaz b22fe586d2 Updated test cases 2013-04-19 02:04:37 +03:00
iyaz 1c390474ff Various refinements on k-means and EM,
Selectors are moved to its own class and shared by k-means and EM (hence previous partially code duplication is prevented)
2013-04-19 02:04:09 +03:00
iyaz e9cc8bcd5e Slightly improved performance, and small refinements 2013-04-17 01:55:21 +03:00
iyaz c3b842dc46 Using diagonal of AABB box to convert rays to segments 2013-04-16 20:58:40 +03:00
iyaz 65fc0a0b6b Changes to guarantee there will be no border case problems with cone angle in [0, PI]. 2013-04-16 18:19:56 +03:00
iyaz 68197c0352 SDF calculation is enriched to be more generic by accepting sdf calculation over points with normals 2013-04-15 13:58:50 +03:00
iyaz 6877a532ab Adding <= 0 check for cone angle 2013-04-12 15:55:20 +03:00
Sébastien Loriot ddc7fe2d77 add missing typenames and remove warning 2013-04-12 09:31:45 +02:00
Sébastien Loriot 9ffbbe3a05 smooth doc 2013-04-09 08:33:06 +02:00
iyaz a3a3660782 Examples are named and section/subsection'ing is better now. 2013-04-08 02:07:59 +03:00
iyaz 664a736675 Small improvements on ref-man. 2013-04-08 02:05:40 +03:00
iyaz 5c093049f5 Remove [0, 1] clipping of smoothing_lambda, and just suggest that in ref-man comments. 2013-04-08 01:16:55 +03:00
iyaz 0c243507a2 Clearing unnecessary typedefs,
Fixing warnings raised by FT float kernels.
2013-04-05 15:56:29 +03:00
Sébastien Loriot cd6fd3dae1 update figure caption 2013-04-03 06:58:57 +02:00
iyaz ab409c8bac Clarify window size,
clarify same colors for different segments.
2013-04-02 20:59:33 +03:00
iyaz 060bb3e3ff update comments,
add missing explicit namespace qualifier for tie (boost)
2013-04-02 20:02:38 +03:00
Sébastien Loriot 6cde7ffc65 remove todos 2013-04-02 15:11:57 +02:00
Sébastien Loriot be02ee3a39 better comment in an example 2013-04-02 15:11:41 +02:00
Sébastien Loriot eac22e273d add comments on number of rays 2013-04-02 15:11:09 +02:00
iyaz 302bab632e Some todo's are answered. Some remain to be discussed. 2013-04-01 17:57:39 +03:00
iyaz 36a26b328d Make 'spatial & range parameters' parameters to bilateral filtering 2013-04-01 17:56:28 +03:00
iyaz 0c77beb2b1 Handle <= 0 levels while BFT 2013-04-01 15:37:08 +03:00
Sébastien Loriot e26b97d9d7 update property map linking 2013-03-14 17:05:19 +01:00
Sébastien Loriot eeb7807da5 add a filter adaptor to have several smoothing steps 2013-02-15 12:46:44 +01:00
Sébastien Loriot 6ec442e864 add more documentation for the disk sampling 2013-02-14 17:04:59 +01:00
Sébastien Loriot 015b9ca4f9 make range_parameter explicit 2013-02-14 17:04:35 +01:00
Sébastien Loriot c6da40a8fa add a question 2013-02-14 17:04:18 +01:00
Sébastien Loriot 949e102661 add the possibility to set the window size 2013-02-13 19:08:38 +01:00
Sébastien Loriot bb165e8e15 add a remark 2013-02-13 19:00:23 +01:00
Sébastien Loriot e473938124 add a dummy filter to switch sdf value filtering off 2013-02-13 18:57:01 +01:00
Sébastien Loriot 2105474563 doc: add backticks and () to function calls 2013-02-13 18:54:49 +01:00
Sébastien Loriot 0adf55363f document implementation detail 2013-02-13 08:04:00 +01:00
Sébastien Loriot 32cad3821b improve phrasing 2013-02-13 07:37:16 +01:00
Sébastien Loriot 0b6cebeac1 add a set of definitions in the introduction 2013-02-12 18:54:08 +01:00
Sébastien Loriot 4a0e6b7707 use the note doxygen command to emphase 2013-02-12 18:35:21 +01:00
Sébastien Loriot d86193ab09 NT is not used in the code. Remove it from the concept 2013-02-12 17:16:49 +01:00
Sébastien Loriot 2f43a47554 prevent linking 2013-02-11 19:22:53 +01:00
Sébastien Loriot 7fd9c015a0 using macros for figures 2013-02-11 19:20:36 +01:00
Sébastien Loriot c756793c93 add todos 2013-02-11 19:04:41 +01:00
Sébastien Loriot 60436ac16c polish the segmentation user manual 2013-02-11 18:43:10 +01:00
Sébastien Loriot a82c1456c5 adding me as author 2013-02-11 18:11:40 +01:00
Sébastien Loriot a67b7d7f8b add example file for segmentation doc 2013-02-11 18:11:01 +01:00
Sébastien Loriot a2f7b1e07c adding backticks 2013-02-08 14:57:19 +01:00
Sébastien Loriot 82cb79fb50 rephrasing 2013-02-08 14:37:48 +01:00
Sébastien Loriot 63de1129d1 update code for plugin compilation 2013-01-16 18:54:59 +01:00
Sébastien Loriot b9a42236d5 port the documention to the latest CGAL doxygen setup 2013-01-16 18:05:13 +01:00
Sébastien Loriot bdf9e75c04 recoding crlf end of line 2013-01-14 19:49:00 +01:00
Sébastien Loriot 82eec48453 Merge branch 'gsoc2012-segmentation-iyaz-old' into gsoc2012-segmentation-iyaz
Conflicts:
	.gitattributes
	Polyhedron/demo/Polyhedron/CMakeLists.txt
2013-01-14 19:48:08 +01:00
iyaz 80521d65a4 A comment on cone-angle was forgotten, fixed. 2013-01-14 18:57:01 +02:00
iyaz 2b51adca20 Small changes on documentation 2013-01-14 18:55:31 +02:00
iyaz cb5e7b0edb Shorten the example, now default call is placed inside a comment. 2013-01-13 00:34:19 +02:00
iyaz e440cb2c1d AABB_traversal_traits.h & Alpha_expansion_graph_cut.h & SDF_calculation.h: Removal of unused code sections.
SDF_calculation.h: MAD for removing outlier approach
2013-01-12 21:55:34 +02:00
iyaz c6cc177bfa API function names are changed:
old name                                  -> new name
sdf_values_computation                    -> compute_sdf_values
surface_mesh_segmentation_from_sdf_values -> segment_from_sdf_values
surface_mesh_segmentation                 -> compute_sdf_values_and_segment

Also example code files are changed accordingly.
2013-01-12 15:59:58 +02:00
iyaz 03910a86ce Update on documentation, considering reviews. 2013-01-11 00:53:44 +02:00
Ílker Yaz 03e0952c96 -code review in outlier-removal
-use make_pair & make_tuple
-handles are passed by value
2012-09-05 17:25:44 +00:00
Sébastien Loriot 5cd9c2ce74 do not document internal namespace 2012-09-03 08:52:34 +00:00
Ílker Yaz 5ff1aed804 changing dft to bft (for segment extracting)
and review.
2012-09-01 02:26:02 +00:00
Ílker Yaz ab6b5ebb57 Code & comment review. 2012-08-30 18:18:40 +00:00
Ílker Yaz 7064d52d63 Integrating MAXFLOW software. 2012-08-30 14:58:37 +00:00
Ílker Yaz 42e8424912 Taking traits object as parameter. 2012-08-30 11:41:00 +00:00
Sébastien Loriot f45a163cf2 add another functor requirement 2012-08-29 05:52:13 +00:00
Ílker Yaz 3b121490a4 small change (convert substraction of points to vector construction) 2012-08-29 02:37:51 +00:00
Ílker Yaz 92a49835d8 Integrating Construct_centroid_3 2012-08-29 02:26:09 +00:00
Ílker Yaz 83d2f4d8b6 Integrating Construct_translated_point_3 2012-08-29 02:23:43 +00:00
Ílker Yaz fe60f52cd3 Integrating Construct_normal_3 & Construct_unit_normal_3 2012-08-29 02:16:54 +00:00
Ílker Yaz d114ec42d8 Intergating Construct_sum_of_vectors_3 2012-08-29 02:11:52 +00:00
Ílker Yaz 223ed06159 Integrating Construct_scaled_vector_3 2012-08-29 02:05:04 +00:00
Ílker Yaz 4feaec7dba Change Polyhedron::Traits with SegmentationGeomTraits
- integrate Angle_3
2012-08-29 01:58:54 +00:00
Ílker Yaz 27b6cb1507 Integrating SegmentationGeomTraits into Surface_mesh_segmentation 2012-08-29 01:14:43 +00:00
Ílker Yaz 298f168346 Integrating SegmentationGeomTraits
- New template parameter is added to SDF_calculation and Surface_mesh_segmentation
- mesh_segmentation.h is changed according to passing trait parameter to Surface_mesh_segmentation
2012-08-29 00:57:38 +00:00
Ílker Yaz 445e63c40c Added test files, and code review. 2012-08-29 00:16:44 +00:00
Sébastien Loriot 38a712b5cf introduce the geometric traits in the code and
in the documentation, but did not really change something in the code.
2012-08-28 15:28:37 +00:00
Sébastien Loriot 7fb3bfaaa2 avoid conflict with CGAL::internal::sqrt 2012-08-28 13:21:47 +00:00
Sébastien Loriot 98ec2762eb use CGAL's sqrt function 2012-08-28 13:18:54 +00:00
Sébastien Loriot aa3a0b0cdf fix initialization order 2012-08-28 13:16:26 +00:00
Sébastien Loriot 8e3b75cf22 typo 2012-08-28 06:10:24 +00:00
Ílker Yaz d92e7ecebd Small correction for comments. 2012-08-28 02:49:42 +00:00
Ílker Yaz ab9cb4b250 Code review. 2012-08-28 02:44:30 +00:00
Sébastien Loriot 6956642f14 remove TODO 2012-08-27 08:59:13 +00:00
Sébastien Loriot 6769e99426 aspell check 2012-08-27 08:58:48 +00:00
Sébastien Loriot 1a62f79ae1 rephrase doc 2012-08-27 08:57:28 +00:00
Ílker Yaz 6b8835b9b1 User manual is updated.
Code review (unused includes are removed)
(Added an experimental filtering)
2012-08-27 02:40:34 +00:00
Ílker Yaz c001aa1662 Now, returned segment-ids are ordered by average sdf value of the segment (facets that construct that segment). 2012-08-24 19:33:41 +00:00
Sébastien Loriot 11042094a9 update TODOs 2012-08-24 06:00:41 +00:00
Ílker Yaz 58fccbef0a Fix a copy-paste error. 2012-08-24 02:53:25 +00:00
Ílker Yaz b093a9a7c7 Small changes on Surface_mesh_segmentation 2012-08-24 02:29:00 +00:00
Ílker Yaz e09404c202 Update on demo for coloring SDF and segmentation. 2012-08-24 01:49:47 +00:00
Ílker Yaz d6f1d70ebe Fix (copy/paste error) 2012-08-23 13:37:51 +00:00
Ílker Yaz 83d5a268c8 remove unused functions 2012-08-23 12:27:21 +00:00