Commit Graph

1044 Commits

Author SHA1 Message Date
Sébastien Loriot bbc4d08ee0 Merge remote-tracking branch 'cgal/master' into HEAD 2023-06-15 10:47:07 +02:00
Sébastien Loriot c8a88b9014 remove CGAL_static_assertion* 2023-06-15 10:42:10 +02:00
Laurent Rineau 01e22be3b6 Merge pull request #7496 from lrineau/Triangulation_3-fix_regular_with_TBB-GF
Regular_triangulation_3: fix another race-condition
2023-06-07 17:36:41 +02:00
Laurent Rineau 8cd8bc7b06 another fix of a race-condition 2023-06-04 20:49:02 +02:00
Sebastien Loriot b1b02d64fe
P3M3: Non-cubic domains, fixes, improvements (#7062)
## Summary of Changes

- Add a dummy point generator that is agnostic to the periodic domain's
geometry, allowing P3M3 to handle non-cubic domain.
- Add an example of P3M3 running on polyhedral domains.
- Fix a few issues in SMDS_3's tet soup reading relating to
non-manifoldness + general IO code speed improvements.
- Fix a few issues in P3M3's medit output and always duplicate facets to
reduce the quantity of non-manifoldness occurences.
- Fix an issue with including Mesh_3 headers before P3M3's.
- Fix periodic point projection (for Mesh_3 optimizers) badly computing
the projection direction
- Robustify a handful of P3M3 functions that were using intermediate
constructions rather than the <Point, Offset> API (which uses filtered
predicates and thus yields proper robustness)
- Misc minor code cleaning / modernization

ToDo:
- [x] Check if some medit IO issues are fixed
- [x] Add non-manifoldness flag to read_MEDIT
- [x] Fix value of orthosphere_radius_threshold
- [x] Check calls of insert_dummy_points() (use generic)
- [x] Check doc of P3M3 about cubic domains requirement

Not done:
- [ ] Fix sharp features for periodic polyhedral domains (problems due
to changing weights creating cover change...). Code:
https://gist.github.com/MaelRL/357c52dc04e16a162f13a3c6860a1398; WIP
diff: https://gist.github.com/MaelRL/f98809964acffbacb6d3f42793e2654e

## Release Management

* Affected package(s): `Mesh_3`,  `P3M3`, `P3T3`, `SMDS3`
* Issue(s) solved (if any): Fix #6997, Fix #7214
* Feature/Small Feature (if any): TODO
* License and copyright ownership: no change
2023-05-30 19:13:45 +02:00
Laurent Rineau 2d324a2f09 Merge branch '5.5.x-branch' 2023-05-19 18:27:20 +02:00
Laurent Rineau f09c70bb96 Merge branch '5.4.x-branch' into 5.5.x-branch 2023-05-19 18:26:49 +02:00
Laurent Rineau 5a85381d4c remove a trailing whitespace
This time I think I managed to fix my VS Code  Insiders settings to fix that
issue permanently.
2023-05-16 16:13:05 +02:00
Laurent Rineau 97262bf0e9 Triangulation_3: fix a race-condition in regular
The race condition is in the batch insertion of a range
of points, with or without info.
2023-05-16 15:56:32 +02:00
Mael 532b82cb9b
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-05-04 17:28:47 +02:00
Laurent Rineau 3b79468b13 another USBAN error, about uninitialized bool 2023-04-13 17:26:44 +02:00
Mael Rouxel-Labbé cd0c81a98a Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-03-20 10:14:27 +01:00
Laurent Rineau 029b5bead5 Triangulation_3.h: Rewrite/factorize
New functions:
  - `create_hole_outer_map`,
  - `create_triangulation_inner_map`.
  - `copy_triangulation_into_hole`,
  - `fill_auxiliary_triangulation_with_vertices_around_v`
2023-02-06 10:02:25 +01:00
Laurent Rineau 686aff651d Triangulation_3.h: Factorize the two versions of make_hole_3D 2023-02-06 10:02:20 +01:00
Laurent Rineau d940c3ae3f Triangulation_3.h: make_vertex_triple can be static 2023-02-06 10:02:15 +01:00
Mael 8f703b54cb
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-01-27 21:48:32 +01:00
Mael 0ff7882997
Merge branch 'master' into feature/bug_documentation_spell_20221113 2022-12-06 22:21:06 +01:00
Mael Rouxel-Labbé 06d272169f Fix sometimes creating holes in the C3T3
Example here: https://stackoverflow.com/questions/74403892/missing-elements-in-periodic-c3t3-mesh

See details in the comments (diff)
2022-12-06 11:37:41 +01:00
Mael Rouxel-Labbé b5c21e1f5d Http -> https + update some dead links 2022-11-23 18:54:37 +01:00
albert-github c32b1f4127 spelling corrections
Some spelling corrections (Directories starting with `S` rest - `W`),
2022-11-16 13:22:39 +01:00
albert-github 45478184de spelling corrections
Some spelling corrections (Directories starting with `E`-` L`),
some backward work
some forward work
2022-11-15 13:39:40 +01:00
Andreas Fabri d3fca65ae5 CGAL: No longer per package assertions 2022-09-23 12:49:40 +01:00
Mael Rouxel-Labbé 43378edd1f Minor speed up for T3::operator== 2022-09-02 14:29:15 +02:00
Mael Rouxel-Labbé 7d9d7844b1 Fix T23::operator== for dimension 0 2022-09-02 13:42:33 +02:00
Sébastien Loriot 861588abe1 Merge 'sloriot/CGAL-std_type_traits' into master 2022-08-03 20:19:51 +02:00
Guillaume Damiand f2630fa4b9
Merge branch 'master' into CMap_index-gdamiand 2022-07-19 09:44:16 +02:00
Sébastien Loriot c9c6b30cf0 Merge sloriot/CGAL-std_type_traits into master 2022-06-23 16:35:37 +02:00
Laurent Rineau 782bd1b106 Merge pull request #6622 from kda/initialize
initialize some stack variables
2022-06-15 10:20:55 +02:00
Laurent Rineau 2feb9a29ce Merge pull request #6655 from lrineau/Triangulation_3-fix_use_after_free-GF
Triangulation_3: fix a use-after-free in `T3::remove` and `T3::move*` methods
2022-06-15 10:20:48 +02:00
Laurent Rineau c2fa2cb9fe Merge pull request #6655 from lrineau/Triangulation_3-fix_use_after_free-GF
Triangulation_3: fix a use-after-free in `T3::remove` and `T3::move*` methods
2022-06-15 10:18:57 +02:00
Laurent Rineau 14b582f83d More use our free of `outer_map` 2022-06-10 09:15:11 +02:00
Sébastien Loriot ac8b6d4731 boost::is_same --> std::is_same 2022-06-10 08:18:20 +02:00
Sébastien Loriot 4f5f8341cc use std::enable_if_t 2022-06-10 07:37:53 +02:00
Kevin Athey d6b0efbea4 initialize members of 'loc' instead of the array. 2022-06-08 16:06:20 -07:00
Kevin Athey a40be70ff7 change initialized value to -1. 2022-06-08 15:28:25 -07:00
Laurent Rineau f438a2ed3a Fix a use-after-free
In an `unordered_map`, any insertion can invalidate iterators,
when the load factor triggers a rehashing.
2022-06-08 15:52:01 +02:00
Kevin Athey ff749f7fd6 initialize some stack variables 2022-05-27 11:46:34 -07:00
Guillaume Damiand 999a813b35 Rename XXX_handle into XXX_descriptor for CMap, GMap, LCC 2022-05-05 13:34:19 +02:00
Laurent Rineau ceb41bf206 Fix crash during binary I/O of Triangulation_3 2022-04-27 14:19:21 +02:00
Mael Rouxel-Labbé 19162905eb Clean and factorize robust circumcenter filtered traits 2022-04-04 11:33:27 +02:00
Mael Rouxel-Labbé e7d240e7de Add robust_filtered_(non-weighted)_circumcenter + split the traits
Splitting as to not force the base traits to require weighted point predicates
and constructions if we only need the non-weighted version
2022-04-04 11:33:27 +02:00
Mael Rouxel-Labbé 4df8440f15 Add a set_circumcenter() to DTCb_with_circumcenter: useful for infinite cells 2022-04-04 11:33:27 +02:00
Andreas Fabri 115fa5ab39 Remove Geomview from the manual and the demos 2021-12-14 14:01:21 +00:00
Guillaume Damiand 2bbcabe71b The size of argv array is now 2, ending with nullptr. 2021-11-11 17:23:37 +01:00
Guillaume Damiand ee11c858b5 The size of argv array is changed to 1 in all basic viewers. 2021-11-10 09:59:48 +01:00
Laurent Rineau bac0822298 Merge pull request #5199 from GilesBathgate/fix-uninitialized-member-triangulation3
Fix uninitialized member in Triangulation_3.h
2021-09-29 11:46:53 +02:00
Sébastien Loriot 5945e48a3e restore sub-directories accidently removed in 98e471849b 2021-09-17 08:14:06 +02:00
Maxime Gimeno d4b0b49f33 Use "real" extensions and fix loading. 2021-08-30 15:41:52 +02:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Laurent Rineau d6b2c8d9dc Merge pull request #5671 from maxGimeno/CGAL_IO-Add_missing-deprecated_functions-maxGimeno
CGAL_IO: Add missing fallbacks

# Conflicts:
#	BGL/include/CGAL/boost/graph/IO/INP.h
#	Point_set_processing_3/include/CGAL/IO/write_xyz_points.h
2021-05-18 18:13:38 +02:00