songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
113,895 Commits 3 Branches 156 Tags 965 MiB
Commit Graph

2446 Commits

Author SHA1 Message Date
Marc Glisse 232fc7ecf0 Help type deduction for expression template number types. 2016-10-13 11:25:59 +02:00
Sébastien Loriot 733e948e28 move file to archive and remove dont_submit 2016-10-06 09:53:40 +02:00
Laurent Rineau 223c1cf5a4 Merge pull request #1530 from lrineau/Installation-compute_dependencies-GF 
Compute and fix packages dependencies
 2016-10-05 13:11:04 +02:00
Andreas Fabri 40e9c6f735 Move specializations of graph_traits the packages that are concerned 2016-09-30 15:22:29 +02:00
Efi Fogel d7678c44fb Cleaned up 2016-09-30 09:24:24 +02:00
Efi Fogel 52292c825c Enhanced debug messages & Cleaned up 2016-09-30 09:24:24 +02:00
Efi Fogel 72e114fb3f Enhanced debug messages & Cleaned up 2016-09-30 09:24:24 +02:00
Laurent Rineau 44b4199878 Merge pull request #1366 from lrineau/CGAL-remove_support_for_LEDA_5_and_before-GF 
Remove all usage of CGAL_LEDA_VERSION
 2016-08-29 12:32:24 +02:00
Laurent Rineau 3481352110 Merge pull request #1361 from sloriot/AOS_2-fix_for_polycurve_traits from 'cgal/releases/CGAL-4.8-branch' 2016-08-29 12:13:31 +02:00
Laurent Rineau 0c690014b7 Remove all usage of CGAL_LEDA_VERSION 
Now, LEDA version >= 6.0 is required if `CGAL_USE_LEDA` is toggled.
 2016-08-25 14:38:16 +02:00
Sébastien Loriot 6987c417b2 fix Compare_y_at_x_2 of traits based on Arr_polycurve_basic_traits_2 
this fix an issue when an xmonotone curve is vertical and not
oriented from left-to-right, as the xmonotone curve was assumed
to be oriented from left-to-right.
Note that in the case of a vertical curve, oriented from left-to-right
means from down-to-up
 2016-08-24 11:27:20 +02:00
Sébastien Loriot 43bba7d980 add missing this-> when CGAL_ALWAYS_LEFT_TO_RIGHT is defined 2016-08-24 11:26:42 +02:00
Efi Fogel f9d113d735 Enhanced the description of the geodesic traits 2016-07-28 00:52:20 +03:00
Efi Fogel cb21be15bc Fixed reading and writing geodesic arcs and points 2016-07-14 01:09:54 +03:00
Efi Fogel 7d1022e0f9 Fixed skip_comment() 2016-07-14 01:09:31 +03:00
Efi Fogel da8757b082 Cleaned up geodesic arc on sphere traits and started to document it 2016-06-30 01:19:48 +03:00
Efi Fogel 5677c6db62 Renamed Compare_x_at_limit and Compare_x_near_limit to Compare_x_on_boundary and Compare_c_near_boundary, resp. 2016-04-06 18:25:59 +03:00
Efi Fogel 047bc66024 ../../include/CGAL/Arr_polyline_traits_2.h 2016-04-06 18:23:49 +03:00
Efi Fogel c63193c31e Merge branch 'Aos_2-boundary_objects-efic-old' into Aos_2-boundary_objects-efic 
Conflicts:
	Arrangement_on_surface_2/include/CGAL/Curved_kernel_via_analysis_2/Arc_2.h
 2016-04-06 14:33:54 +03:00
Laurent Rineau 00e6e03d5c Merge pull request #785 from afabri/CGAL-missing_includes-GF 
Partial cleanup of issue #595   Part2
 2016-03-24 17:02:27 +01:00
Andreas Fabri eb90e8e3e1 Include consistently <CGAL/property_map.h> 2016-02-24 12:09:36 +01:00
Sébastien Loriot 5be27c2998 Merge remote-tracking branch 'cgal/releases/CGAL-4.7-branch' into HEAD 2016-02-22 08:17:10 +01:00
Efi Fogel 7293d45d98 A fix by Iddo for the case where the curve is closed (first and last points are the same) 2016-02-22 08:13:48 +01:00
Andreas Fabri 600416bfa2 remove a commented include 2016-02-15 15:03:35 +01:00
Sebastien Loriot 48da87c2b5 Merge pull request #732 from afabri/CGAL-replace_bind-GF 
Replace all std::bind with boost::bind
 2016-02-07 18:21:05 +01:00
Sébastien Loriot ba0c304859 remove emacs user commands 2016-02-04 17:36:31 +01:00
Andreas Fabri 52f8129579 replace all std::bind with boost::bind 2016-02-04 08:59:38 +01:00
Sébastien Loriot 96656bbbdd Add missing const qualifiers 2016-02-03 15:42:51 +01:00
Sébastien Loriot 8cee2ef1dd Merge pull request #686 from afabri/Kernel_fix-warnings-GF 
Fix warnings concerning indentation and unused parameter
 2016-02-03 09:49:54 +01:00
Sébastien Loriot b406fb8a83 use special case is only for visual not clang 2016-01-29 14:46:30 +01:00
Sébastien Loriot 40de762742 fix indentation warning 2016-01-29 14:20:20 +01:00
Efi Fogel c26bf713b2 Hid unused variables 2016-01-28 13:40:54 +02:00
Efi Fogel 7484d24f34 Prevented min/max macro expansion to pacify MSVC 2016-01-28 13:40:43 +02:00
Efi Fogel f1161c6e6b Hid unused variables 2016-01-27 01:55:40 +02:00
Efi Fogel bce5aa428e Used operational code instead of deprecated code. Used predefined type (size_t) instead of int 2016-01-21 19:27:01 +02:00
Efi Fogel f8c83d82f9 Added back deprecated member functions begin_subcurves() and end_subcurves() 2016-01-19 15:48:16 +01:00
Efi Fogel be691a3644 Supported CGAL::Segment_2<Kernel> 2016-01-19 15:48:16 +01:00
Efi Fogel 9750733dfb Moved IO operations from Polycurve_2 to Polycirve_2_iostream.h 2016-01-19 15:48:16 +01:00
Efi Fogel 4486cba188 replaced {begin,end}_{points,subcurvs} with {points,subcurvs}_{begin,end} moved IO operations to Polycirve_2_iostream.h 2016-01-19 15:48:16 +01:00
Efi Fogel d405c9aa51 replaced {begin,end}_{points,subcurvs} with {points,subcurvs}_{begin,end} 2016-01-19 15:48:15 +01:00
Efi Fogel cf01ef7a26 replaced {begin,end}_{points,subcurvs} with {points,subcurvs}_{begin,end} and included Polycurve_2_iostream.h 2016-01-19 15:48:15 +01:00
Efi Fogel 101d1bcefc replaced {begin,end}_{points,subcurvs} with {points,subcurvs}_{begin,end} 2016-01-19 15:48:15 +01:00
Efi Fogel 245f11ac68 Initialized res to pacifiy compiler warnings 2016-01-19 15:48:15 +01:00
Efi Fogel 92544a44ab Cleanup 2016-01-19 15:48:14 +01:00
Efi Fogel a013201184 Cleanup 2016-01-19 15:48:12 +01:00
Andreas Fabri c32b00acce partial cleanup of issue #595 2016-01-08 17:55:08 +01:00
Efi Fogel fb09c4ac65 Fixed initializer API 2016-01-03 01:01:26 +02:00
Efi Fogel 87309bafcd Merge branch 'Aos_2-boundary_objects-efic-old' into Aos_2-boundary_objects-efic 
Conflicts:
	Arrangement_on_surface_2/include/CGAL/Basic_sweep_line_2.h
 2016-01-02 23:53:18 +02:00
Sébastien Loriot 4b4723752a Merge remote-tracking branch 'cgal/releases/CGAL-4.7-branch' 2015-12-28 10:09:01 +01:00
Sebastien Loriot a905f55a29 Merge pull request #497 from sloriot/AOS-leak_in_trapezoidal_decomposition 
fix a leak in the trapezoidal decomposition that occurs when a curve is removed
 2015-12-28 10:07:16 +01:00
Sébastien Loriot 287a5078ea Merge remote-tracking branch 'cgal/releases/CGAL-4.7-branch' 2015-12-10 20:56:52 +01:00
Sébastien Loriot c5ff83ce3f fix IO of polycurves 
on the behalf of @efifogel
 2015-12-07 09:21:05 +01:00
Sébastien Loriot 04a8230daa fix a leak in the trapezoidal decomposition that occurs when a curve is removed 
A dag node contains a variant that amongst other can point onto a
Tr_active_trapezoid. This class inherits from Handle in order to
reference count the data (of type Tr_active_trapezoid::Data) that
contains 4 neightbors, each being of type Tr_active_trapezoid.
The problem is that if a dag node is no longer used and if it
holds a instance of a Tr_active_trapezoid which neighbors trapezoid
are not cleared, we might have objects of type Tr_active_trapezoid
pointing onto each others preventing them from being deleted.
 2015-11-23 14:49:52 +01:00
Efi Fogel 29bec5b0e4 Added missing this-> 2015-11-18 11:00:01 +01:00
Efi Fogel ad86fc799f Added missing copy constructor 2015-11-18 11:00:00 +01:00
Efi Fogel cd36eed4f4 Fixed Compare_y_at_x predicate. In Particular, correctly handled the case of vertical curves 2015-11-18 10:59:58 +01:00
Sebastien Loriot bb85ae0179 Merge pull request #474 from afabri/BGL-suppress_warning-GF 
suppress warning in boost as this has to be solved upstream
 2015-11-17 13:21:05 +01:00
Efi Fogel 49ce1f0f05 Added missing this-> 2015-11-16 09:53:08 +02:00
Efi Fogel 2a9c8f1f5b Added missing copy constructor 2015-11-15 12:19:54 +02:00
Efi Fogel 3b96690d37 Fixed Compare_y_at_x predicate. In Particular, correctly handled the case of vertical curves 2015-11-14 11:10:43 +02:00
Andreas Fabri bf6cfaa8d9 include header which pragma pushes a warning 2015-11-14 09:44:04 +01:00
Sebastien Loriot 91dd3e6a1e Merge pull request #369 from sloriot/AOS-removal_optimisation-efifogel_sloriot 
Arr_2: removal optimisation
 2015-10-22 08:49:46 +02:00
Sébastien Loriot cddf8c3ab8 use pointer of simplices to be more consistant 2015-10-06 15:17:06 +02:00
Sébastien Loriot fa3fe631f1 fix a memory leak: curves of edges and point of vertices deleted must be deleted 2015-10-05 17:20:48 +02:00
Sebastien Loriot 2243728001 Merge pull request #373 from efifogel/AOS-ccb_removal_optimization-efif 
Aos ccb removal optimization efif
 2015-10-01 11:02:10 +02:00
Efi Fogel 9bfaa542d8 Introduced _move_all_isolated_vertices() and used it 2015-09-28 16:57:44 +03:00
Efi Fogel 452444e704 Introduced _move_all_inner_ccb() and used it 2015-09-28 15:04:14 +03:00
Efi Fogel 0f72382580 Pure aesthetic changes 2015-09-28 12:20:18 +03:00
Sébastien Loriot b92e34fcfd also do the swap if f1!=f2 2015-09-27 16:08:14 +02:00
Sébastien Loriot d81b0b4545 update face type to give access to the ccb containers 2015-09-27 15:48:14 +02:00
Sébastien Loriot 9968192330 enrich Arr_accessor of some functions to allow dcel manipulations 2015-09-27 15:30:02 +02:00
Efi Fogel ecf346287c Clean up the code of: 
_remove_edge(DHalfedge* e, bool remove_source, bool remove_target).

If (f1 != f2) then retain the face that has a larger number of inner ccbs.
Otherwise, continue as before...
 2015-09-26 14:48:56 +03:00
Efi Fogel e695933cbb Brought up to date with master. Resolved conflicts mainly due to recent changes in master for polylines 2015-09-26 11:49:30 +03:00
Sébastien Loriot cdfc7f1c31 Merge branch 'old/CGAL-split_packages-GF' into CGAL-split_packages-GF 2015-09-23 10:08:41 +02:00
Sébastien Loriot 621a134f3a add an alternative way to remove edges by remove all elements at the same time 
Here is the output of benchmark program polygon_set_2_join.cpp on my machine

current version (polygon_set_2_join):
   Timer for join is 0.316
   Timer for remove_redundant_edges is 0.08799999999999997
   Timer for _reset_faces is 0
Time for 402 grid crossing polygons 0.404

   Timer for join is 1.512
   Timer for remove_redundant_edges is 0.008000000000000007
   Timer for _reset_faces is 0
Time for 1000 random polygons 1.52s

   Timer for join is 3.108
   Timer for remove_redundant_edges is 0
   Timer for _reset_faces is 0
Time for 100000 nested polygons 3.108s

   Timer for join is 6.103999999999999
   Timer for remove_redundant_edges is 0.01200000000000045
   Timer for _reset_faces is 0.003999999999999559
Time for 40000 disjoint polygons 6.119999999999999s

current version (polygon_set_2_join 2):
   Timer for join is 0.636
   Timer for remove_redundant_edges is 0.1719999999999999
   Timer for _reset_faces is 0
Time for 566 grid crossing polygons 0.8079999999999999

   Timer for join is 3.124000000000001
   Timer for remove_redundant_edges is 0.01199999999999868
   Timer for _reset_faces is 0
Time for 2000 random polygons 3.135999999999999s

   Timer for join is 6.892000000000001
   Timer for remove_redundant_edges is 0
   Timer for _reset_faces is 0
Time for 200000 nested polygons 6.892000000000001s

   Timer for join is 32.16799999999999
   Timer for remove_redundant_edges is 0.04800000000000182
   Timer for _reset_faces is 0.008000000000002672
Time for 160000 disjoint polygons 32.224s
 2015-09-18 16:21:20 +02:00
Laurent Rineau 7ddefbdcc8 Merge pull request #297 from afabri/CGAL-assert-GF 
assert() should not be used in CGAL headers!
 2015-09-07 10:58:20 +02:00
Sébastien Loriot f38a3e8cf9 when removing an edge, keep the face having more holes 
the output of the benchmark program polygon_set_2_join.cpp
are similar for all input but the grid crossing:

current version (polygon_set_2_join):
Time for 402 grid crossing polygons 4.68

current version(polygon_set_2_join 2):
Time for 566 grid crossing polygons 18.804

This improves the run time but the version with CGAL_JOIN_CREATE_AN_ARRANGEMENT
defined is still faster for this example
 2015-09-04 17:19:08 +02:00
Andreas Fabri 1e2ff1131e assert -> CGAL_assertion 2015-08-27 16:51:55 +02:00
Laurent Rineau 0fd6f2fa59 Merge pull request #288 from afabri/CGAL-add_hash-GF 
No longer forward declare struct std:hash

Fixes issues #287 and #274.
 2015-08-27 15:41:50 +02:00
Andreas Fabri bf975ead95 No longer forward declare struct std:hash 2015-08-23 14:30:54 +02:00
Andreas Fabri 67d72675fe split packages 2015-08-17 23:46:59 +02:00
Laurent Rineau 08666dce25 Merge pull request #179 from afabri/CGAL-add_hash-GF 
Add boost::hash and std::hash

https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/hash

Conflicts:
	Installation/changes.html
 2015-07-17 15:39:18 +02:00
Sébastien Loriot 2a7696c210 cast to size_t to avoid a warning by clang 2015-07-16 17:50:31 +02:00
Andreas Fabri 2dea6db3bb Merge branch 'CGAL-add_hash-GF-old' into CGAL-add_hash-GF 
Conflicts:
	Surface_mesh/include/CGAL/Surface_mesh/Surface_mesh.h
 2015-07-06 10:51:23 +02:00
Andreas Fabri dadb129147 g++ needs a forward declaration for std::hash 2015-06-02 08:46:20 +02:00
Andreas Fabri b6850d35c0 #include <functional> and suppress struct/class warning for VC10 2015-06-01 10:42:52 +02:00
Efi Fogel 39f1e22dad Type and typename fixes 2015-05-06 00:40:52 +03:00
Efi Fogel 0f7cb5c709 Merge branch 'MS_2-of_holes-efif-old' into MS_2-of_holes-efif 
Conflicts:
	Arrangement_on_surface_2/include/CGAL/Arr_segment_traits_2.h
	Documentation/biblio/cgal_manual.bib
	Minkowski_sum_2/test/Minkowski_sum_2/test_Minkowski_sum.cpp
 2015-05-03 11:41:36 +03:00
Andreas Fabri 157756f3b3 Add std::hash and boost::hash for the arrangement 2015-04-29 14:30:36 +02:00
Sebastien Loriot faee08becd Merge pull request #56 from efifogel/Aos-Polycurve_tests-wkhan 
Aos polycurve tests wkhan
 2015-04-22 18:00:03 +02:00
Efi Fogel a7c602449b Commenting out unnecessary code (which some compilers barf on) 2015-04-15 09:51:22 +03:00
Philipp Möller 76a4f0da85 Replace detail/algorithm.hpp with type_traits/is_same.hpp 
Also remove the superfluous map include
 2015-04-10 13:46:13 +02:00
Philipp Möller ae72a9f616 Replace detail/algorithm.hpp with type_traits/is_same.hpp 
is_same is the only part of boost used in this file
 2015-04-10 13:45:47 +02:00
Efi Fogel 6cab541cdb Removed unused var. in release mode 2015-03-21 12:50:05 +02:00
Efi Fogel b9570fad98 Updated changes.html and minor fixes discovered by the test suite 2015-02-25 09:37:24 +02:00
Efi Fogel 8724140fd2 Added this-> to access base members 2015-02-24 21:05:48 +02:00
Efi Fogel 4b941981c1 Fixed small issues found by different platforms 2015-02-24 19:22:26 +02:00
Efi Fogel c686aed4cb polycurve stuff 2015-02-19 20:25:25 +02:00
Efi Fogel 0e1716a7eb polycurve 2015-02-16 11:26:39 +02:00
Efi Fogel e35966bac3 Pacify MSVC 10 2015-02-16 01:30:10 +02:00
Efi Fogel d190918cb2 Enhanced polycurve 2015-02-16 00:51:21 +02:00
Efi Fogel 1097c469b2 Fixed subcurve traits name 2015-02-15 11:57:42 +02:00
Efi Fogel 0c5e0ec9cf Improved polyline and polycurve 2015-02-03 22:23:23 +02:00
Efi Fogel 93e0711a66 cleaned up (removed unnecessary members) 2015-01-15 14:58:11 +02:00
Laurent Rineau e965b6293e Fix compilation errors with C++11 and Boost-1.56 
Use *explicit* conversions to `bool`, for boost::shared_ptr and
boost::optional.
 2015-01-14 14:47:29 +01:00
Laurent Rineau be079cb5a3 Fix compilation with Boost-1.56 and later 
In Boost-1.56 and later, with C++11, boost::optional::operator bool() is
explicit.
 2015-01-13 16:21:04 +01:00
Efi Fogel 587bcd1230 Fixed Parameter_space_in_x_2 and Parameter_space_in_y_2 2015-01-12 08:52:32 +02:00
Efi Fogel 69eee76b25 Added missing cases to Compare_x_2 and Compare_xy_2 2015-01-12 00:53:12 +02:00
Eric Berberich 13c3c240c3 Merge branch 'Aos_2-boundary_objects-efic' of ssh://scm.cgal.org/var/git/cgal into Aos_2-boundary_objects-efic 2014-12-23 15:51:54 +01:00
Waqar Khan 57c672d3cc A huge bug in the dispatching of push_back and push_front fixed. Tested by running the test suit. 2014-12-16 16:56:24 +01:00
Waqar Khan 2a7e8ae129 Fixed make_x_monotone again. 2014-12-16 15:57:14 +01:00
Waqar Khan 40eea57ebc Code clean up. 2014-12-16 15:24:53 +01:00
Waqar Khan 0dc764ad7b Boundary condition in make_x_monotone fixed. 2014-12-16 15:22:17 +01:00
Efi Fogel 17e261f99c Pacify msvc 10 2014-12-13 23:48:10 +02:00
Efi Fogel f870a0702f Fixed for g++ 2014-11-30 20:31:59 +02:00
Efi Fogel 1186fe16a8 Cleaned up. Fiexed construction from points 2014-11-30 19:17:55 +02:00
Efi Fogel 851cc2fba9 Merge branch 'Aos-Polycurve_tests-wkhan-old' into Aos-Polycurve_tests-wkhan 
Conflicts:
	Arrangement_on_surface_2/include/CGAL/Arr_polyline_traits_2.h
 2014-11-30 10:49:08 +02:00
Waqar Khan a1e6613dab A bug in intersect functor that cause the non-cashing polylines test to fail has been fixed and tested. 2014-11-30 04:00:58 +01:00
Waqar Khan 57f9d9fd4f Merge branch 'Aos-Polycurve_tests-wkhan' of ssh://scm.cgal.org/var/git/cgal into Aos-Polycurve_tests-wkhan 2014-11-27 13:48:46 +01:00
Waqar Khan aa9e2724b2 Added myself in the authors name. 2014-11-27 13:48:43 +01:00
Efi Fogel 9938daf55b cleaned eup 2014-11-27 14:16:27 +02:00
Efi Fogel 5d28dc7e5c Removed Has_construct_x_monotone_curve_from_two_points_category. Removed traces of Parameter_space where not needed. Cleaned up 2014-11-27 14:01:32 +02:00
Efi Fogel 2ebc9965fd Removed Has_construct_x_monotone_curve_from_two_points_category 2014-11-27 13:59:51 +02:00
Waqar Khan 28ac7a8d94 improvement in infinity support made but there are still errors while running the test suit. 2014-11-27 01:58:34 +01:00
Waqar Khan cf3f6ad5ac Infinity support (Linear_traits) for push_back and push_front added 2014-11-24 01:34:35 +01:00
Efi Fogel 43ef819768 Worked around VC10 problem 2014-11-16 09:43:13 +02:00
Eric Berberich 7108a4ee30 added a sentence why CGAL_error is called 2014-11-12 16:49:10 +01:00
Eric Berberich 133685a275 reput some helping comments 2014-11-12 16:43:08 +01:00
Eric Berberich 8b797b8513 update_event_on_boundary is not needed 2014-11-12 16:43:08 +01:00
Efi Fogel a31ee33af9 restored 2014-11-11 20:38:28 +02:00
Efi Fogel 653c926e17 fixed (reverted) _compare_point_curve_end 2014-11-07 00:43:11 +02:00
Efi Fogel caeab5306b replaced the call _update_event_at_boundary() 2014-11-06 21:40:30 +02:00
Efi Fogel db5e3a5ede Fixed _init_curve_end 2014-11-06 20:53:57 +02:00
Efi Fogel ea3916d84e Fixed _init_curve_end 2014-11-06 20:53:38 +02:00
Efi Fogel 51d2ca4c4d cleaned up 2014-11-06 20:47:39 +02:00
Efi Fogel 690dca1282 cleaned up 2014-11-06 20:47:10 +02:00
Efi Fogel 0d21089e72 cleaned up 2014-11-06 20:46:10 +02:00
Efi Fogel f158fdaf78 cleaned up 2014-11-06 20:44:51 +02:00
Efi Fogel c0ae0eb9c1 cleaned up 2014-11-06 20:44:29 +02:00
Efi Fogel db90394fda cleaned up 2014-11-06 20:43:25 +02:00
Efi Fogel d0b874ace1 cleaned up 2014-11-04 10:03:09 +02:00
Efi Fogel 90c16905b1 Made all traits const. Pass traits as const reference 2014-10-25 00:37:54 +03:00
Eric Berberich 51ac437de9 restored previous signatures 2014-10-18 17:39:14 +02:00
Waqar Khan 6688b4c8d7 unnecessary code from intersect functor removed. Intersect Functor fixed and tested 2014-10-15 13:21:47 +02:00
Waqar Khan 8905ee6be3 Trim functors cleaned. 2014-10-15 13:21:46 +02:00
Waqar Khan 5b9abc1473 Default instantiation of Template traits removed. As that is derived from the base class. 2014-10-15 13:21:46 +02:00
Waqar Khan f1d1763006 Intersect functor: Bug fixed and tested. 
*Trim_traits is no longer needed.
 2014-10-15 13:21:46 +02:00
Waqar Khan 64580d17d8 Bug in trim_2 fixed. 2014-10-15 13:21:45 +02:00
Waqar Khan 77258123cb Cleaned the trim functors. 2014-10-15 13:21:45 +02:00
Waqar Khan 6861de4fa7 Trim functionality in bezier curves fixed and tested. 2014-10-15 13:21:44 +02:00
Waqar Khan a632fe0caa Some more bugs with Trim fixed. (typos from the previous commit) 2014-10-15 13:21:44 +02:00
Waqar Khan ba724acfb6 A bug in Trim functor fixed. 2014-10-15 13:21:44 +02:00
Waqar Khan 79ed86f54a Construct_opposite functor added. 2014-10-15 13:21:44 +02:00
Waqar Khan e76962ec96 Trim functor added and tested. 2014-10-15 13:21:43 +02:00
Waqar Khan 761d74f95a Compare_x_near_limits_2 functor added that is required by the linear_traits Arrangment 2014-10-15 13:21:43 +02:00
Waqar Khan a4a34cf828 Old incorrect implementation of infinity supprt removed. Also Compare_x_at_coundary_2 added as this is needed for infinity support. 2014-10-15 13:21:43 +02:00
Waqar Khan cc7eb0b1bc Push_back and Push_front funtors now inherites operators from the base class as well. 2014-10-15 13:21:43 +02:00
Waqar Khan 83d300c5fb incorrect implementation of functors required for infinity support of polycurves REMOVED. (reverted back. nothing new added.) 2014-10-15 13:21:42 +02:00
Eric Berberich 14c4b5f8e7 fixed typos 2014-10-10 16:33:02 +02:00
Eric Berberich b5f7d87c9d comments for Curve_comparer and boundary 2014-10-10 16:30:07 +02:00
Eric Berberich 0ee9e28455 added assertion 2014-10-10 16:29:36 +02:00
Eric Berberich 6778770a26 use boundary touching curve + rename 2014-10-10 16:27:39 +02:00
Eric Berberich ad89312e25 bugfix: compare_y when x-interior and equal x 
as a side effect code got refactored

also fixed another bug: pt2 was not accesible in previous location
 2014-10-10 16:14:10 +02:00
Eric Berberich e2f37437e3 replace e2->curve() + _curve_end(e2) with e2->boundary_touching_curve() 
and bugfix: interior closed event must use the point as curves might not
start/end there (e.g. for an intersection)
 2014-10-10 16:11:24 +02:00
Eric Berberich 9342874b69 curve() is for interior, boundary_touching_curve is for boundary 2014-10-10 16:04:58 +02:00
Eric Berberich b3c6870393 cleanup 2014-10-10 16:03:13 +02:00
Eric Berberich f10528c181 non-boundary events do not neet a special handling by the visitor 2014-10-10 15:35:40 +02:00
Eric Berberich 958a930002 new hierarchy of side tags (better specialization) + bugfix 
bugfix: compare y for boundary events
 2014-10-10 15:32:22 +02:00
Eric Berberich 7606981b55 removed TODO 2014-10-10 15:29:14 +02:00
Eric Berberich 243aa3ad19 split &&-assertions into several ones 2014-10-10 09:17:24 +02:00
Eric Berberich b7d842813e removed warnings about unused variables 2014-10-08 00:40:27 +02:00
Eric Berberich 4957a2cbbb exclude left top corner when dealing with moving halfedge indices 2014-10-07 23:57:47 +02:00
Eric Berberich 07ae9438f5 Handling of events on the boundary of the parameter space 
Comes with a refactoring:
* point-point
* point-curveend
* curveend-curveend
Boundary check is done inside each of the three cases
 2014-10-07 16:14:19 +02:00
Eric Berberich e82b579701 fix compare_x_curve_ends 2014-10-07 15:44:11 +02:00
Eric Berberich 506bb974fa Support curves, curve-ends and points on the boundary of the parameter space 
We basically rewrite ps_x and ps_y to LEFT and BOTTOM in case of
identifications and implemented compare_x_on_boundary correctly

Also fixed documentation typos
 2014-10-07 12:12:59 +02:00
Eric Berberich 7c93922cc8 Support curves, curve-ends and points on the boundary of PS 
* ps_x and ps_y only queried for ps-interior arcs and isolated points
  (ps_x includes to poles! - that is corners have ps_s and ps_y set
   to non-ARR_INTERIOR)
* compare_y_on_boundary needs to deal with poles
* compare_x_on_boundary needs to deal with two isolated points
*
* removed Is_on_x_identification

Misc:
* fixed some const& problems
* fixed documentation
* fixed preconditions
 2014-10-07 12:12:57 +02:00
Eric Berberich 3fddae42bc Curve-end must be pushed into the queue as curve-ends 
If pushed as isolated points, incidence relation to the curve is lost,
which does not allow to correctly sort the respective events in the
parameter space
 2014-10-07 12:12:57 +02:00
Eric Berberich 70afed4463 improved std::cout commands 2014-10-07 12:12:57 +02:00
Eric Berberich 36558578ba fix for number of curves 2014-10-07 12:12:56 +02:00
Eric Berberich ab4dd55bc8 fixed preconditions 2014-10-07 12:12:56 +02:00
Eric Berberich aef0ff954a implemented dealing with isolated vertices on the boundary 
added create_boundary_vertex(const Point_2& pt)
added is_isolated()
 2014-10-07 12:12:56 +02:00
Eric Berberich f33e94fc0e added is_isolated() member function 2014-10-07 12:12:55 +02:00
Eric Berberich 225334fafe implemented operator()(e1, e2) 
which is for debugging only

removed some verbosity
 2014-10-07 12:12:55 +02:00
Eric Berberich d4fd16ac4a replace m_ps_in_x/y with m_ps_x/y and use it for point comparison too 2014-10-07 12:12:55 +02:00
Eric Berberich cd4f66f3d1 implement operator()(point, event) and operator()(curve-end, event) 2014-10-07 12:12:55 +02:00
Eric Berberich 3ddcacbf50 if a curve-end is closed, there is a point that is to be pushed 2014-10-07 12:12:54 +02:00
Eric Berberich 3082a7fd1d better debug output 2014-10-04 12:38:15 +02:00
Eric Berberich 9c612979e0 moved remark 2014-10-04 12:38:15 +02:00
Eric Berberich c599bd091a number_of_left/right_curves is const 2014-10-04 12:38:14 +02:00
Eric Berberich 4bbb8008a9 number of left and right curves printed 2014-10-04 12:38:14 +02:00
Eric Berberich 9f07312535 index is actually ind (a curve end) 2014-10-04 12:38:14 +02:00
Eric Berberich 8d0cde0036 documenation bug fixed (wrong names) 2014-10-04 12:38:14 +02:00
Efi Fogel d128f21fbd cleaned up 2014-10-04 10:36:34 +03:00
Efi Fogel 8901061892 Fixed handling boundary vertex when splitting boundary curve 2014-10-04 09:49:24 +03:00
Efi Fogel 16151c46ff Enhanced operator(). Made the type of the coordinate index iterator a template parameter 
Patch exceptionally accepted in master on a file not used by CGAL.
Approved by the interim release manager.
 2014-09-29 10:53:18 +02:00
Efi Fogel e1febb5eb8 Fixed _is_to_right_impl(p, he, not-oblivious 2014-09-28 22:55:14 +03:00
Efi Fogel 8aa0604792 Fixed Is_in_x_range_2 of the traits adaptor and cleaned up 2014-09-28 22:08:08 +03:00
Efi Fogel cf2b03d819 Added support for zone computation that allow isolated features that lie on the boundary 2014-09-23 03:00:16 +03:00
Efi Fogel 823b938f7d cleaned up 2014-09-23 02:38:03 +03:00
Efi Fogel 95aae645c3 Fixed yet again _locate_around_pole 2014-09-23 00:16:39 +03:00
Efi Fogel 16f418a803 cleaned up 2014-09-22 21:41:30 +03:00
Efi Fogel 97664a159c Fixed compare_x_on_boundary 2014-09-22 20:13:28 +03:00
Efi Fogel 2420650fde Added code to handle the case where a curve-end is on the left or right boundaries 2014-09-22 20:12:29 +03:00
Efi Fogel da77c29b48 Fixed locate_around_boundary_vertex 2014-09-22 20:11:13 +03:00
Efi Fogel 8552458c56 Fixed locate_curve_end() of the spherical top. traits and cleaned up 2014-09-22 15:11:00 +03:00
Efi Fogel 7a203a2537 cleaned up 2014-09-21 17:56:33 +03:00
Efi Fogel 3bf7512863 Reimplemented split_edge() 2014-09-21 15:53:19 +03:00
Efi Fogel f91ad88492 Changed at_limit and near_limit to on_boundary and near_boundary respectively 2014-09-21 03:23:13 +03:00
Efi Fogel 77d63980b9 Support for features that lie on the boundary 2014-09-20 23:52:10 +03:00
Efi Fogel 90ed32c3b4 Towards support of isolated features that lie on the boundary 2014-09-20 23:16:15 +03:00
Efi Fogel 6efc9c09a6 Added missing notify_on_boundary_vertex_creation 2014-09-20 23:14:59 +03:00
Efi Fogel f003ce01d5 Fixed type in is_on_x_identification and is_on_y_identification 2014-09-20 23:14:19 +03:00
Efi Fogel cbb551b42d Support for isolated vertices on the boundary 2014-09-20 12:36:17 +03:00
Waqar Khan 59b8d86465 push_back and front are now derived from the polycurve::push_back and push_front. 2014-08-18 16:00:13 +02:00
Waqar Khan edd45dc2e7 necessary functors added that are used by the polycurves for infinite support. 2014-08-18 15:15:09 +02:00
Waqar Khan 1228ca4cd3 added functors to be compatible with polycurves 2014-08-17 23:52:31 +02:00
Waqar Khan 4215481fc5 functors added to these classes to make is compatible with the infinity support of the polycurve. 2014-08-17 23:44:31 +02:00
Waqar Khan 868060d1d8 option of adding a ray and the end of the polyline via push_back added. 2014-08-17 23:42:56 +02:00
Sébastien Loriot 881a5b49bb remove warnings triggered in release mode 
trivial bugfix for master
 2014-08-10 15:57:29 +02:00
Waqar Khan a528537c18 * Push_back and Push_front added for polyline traits. 
* push_back and push_front operators that took point as input argument disabled in polycurve_traits.
 * Documentation of polycurve traits modified.
 2014-08-05 02:18:09 +02:00
Waqar Khan 4afb96fee8 Arr_polyline_traits_2 renamed to Arr_polycurve_traits_2. Also the new class Arr_polyline_traits_2 is inherited from Arr_polycurve_traits_2 for backword compatibility. 2014-07-31 15:32:09 +02:00
Efi Fogel 207f70b167 minor fix for master. traits() => geometry_traits() 2014-07-13 10:27:30 +03:00
Waqar Khan 3a2dc27eab Some commented conditions to added to intersect functor that might help fix the functor even when the trim functor does not atomatically fix the source and target points. Check with Eric 2014-07-08 01:08:25 +02:00
Waqar Khan b72f433a4b Trim function user friendly source and target swapping enabled again as it was causing problem with intersect functor of Arr_polyline. 2014-07-08 01:06:42 +02:00
Sébastien Loriot 0b353bb85b Merge remote-tracking branch 'origin/CGAL-use_leda-GF' 
Reintroduce the possibility to use CGAL without GMP
  (to use LEDA number types instead for example).
  The cmake option to set to switch off GMP when building
  the lib is CGAL_DISABLE_GMP.

Tested in CGAL-4.5-Ic-86
Approved by the release manager

ge is necessary,
 2014-07-04 12:02:37 +02:00
Waqar Khan a59039c37f * dummy trim functor added to Arr_Bezier_curve_traits so that the tet framework wont fail 2014-06-23 18:46:32 +02:00
Waqar Khan 9e5ee3890e * Has_construct_x_monotone_curve_from_two_points_category added into "Arr_bezier_curve_traits" 
* test_bezier_polycurve is a test file for my own use
 2014-06-23 17:21:22 +02:00
Sébastien Loriot 251a9d8446 fixes for tests to use leda and not gmp 2014-06-19 14:29:20 +02:00
Efi Fogel 65bfcd77a3 minor fix for master: fixed locate_gen(cv), where cv is vertical 2014-06-19 10:03:12 +03:00
Waqar Khan 42c21408f8 * Arr_Polyline_traits_2 now use trim functionality to find overlapping curves in 
Intersect_2 functor.
 2014-06-18 18:54:15 +02:00
Waqar Khan 4084abf21f * Trim functionality added to Arr_segment_traits_2 2014-06-18 18:53:08 +02:00
Waqar Khan b11285741f * Trim functionality added to Arr_conic_traits_2 2014-06-18 18:52:17 +02:00
Waqar Khan 282ebee1db * Trim functionality added for Arr_circle_segment_traits_2. 2014-06-18 18:51:06 +02:00
Laurent Rineau bb492768b1 Merge remote-tracking branch 'origin/Arrangement_on_surface_2-remove_edge-efif' 
Conflicts:
	Installation/changes.html
 2014-05-26 12:21:37 +02:00
Waqar Khan 22dfb578c8 * Trim functor now working with conic polycurves. Tested. 2014-05-25 02:55:53 +02:00
Waqar Khan be658a222f * trim functionality added to polyline_traits and tested with conic polycurves. Works for most cases however 
* some cases result in failure.
 2014-05-25 02:10:27 +02:00
Waqar Khan 52c6d3044d * Permissios of the files changed 
* Trim functionality added to conic and circular_arc traits.
 * Examples for conic_polycurve and circular_arc_polycurve added.
 2014-05-24 21:55:36 +02:00
Laurent Rineau 2242efe153 fix permissions 2014-05-22 14:58:17 +02:00
Efi Fogel a7c7a842f7 Fixed removal of unbounded & added corresponding tests 2014-05-18 17:16:54 +03:00
Laurent Rineau 73f4734525 Fix permissions 2014-05-15 18:33:36 +02:00
Waqar Khan ae79550a0d Examples for polycurve_conics and polycurve_circular_arcs added 2014-05-11 16:56:16 +02:00
Waqar Khan 5a86e06399 Added more tests for polycurve_circular_arc traits 
* Intersect functor still remains to be tested.
 2014-05-04 21:04:38 +02:00
Efi Fogel eb1ac16965 Fixed unbounded removal 2014-05-04 18:55:46 +03:00
Waqar Khan f534f4eb31 More tests for conic polycurves added, Also fixed an issue with number_of_points_2 functor in 'Arr_polyline_traits_2.h' 2014-04-08 20:32:21 +02:00
Laurent Rineau a749963859 Merge branch 'CGAL_VC12_GF' 
Fix a compilation error of VC9, due to the merge of previous revisions
of CGAL_VC12_GF.

Tested in CGAL-4.4-Ic-161.
 2014-03-28 18:16:01 +01:00
Laurent Rineau ff8a7bbe3c Fix a compilation error with VC9 2014-03-26 16:04:57 +01:00
Andreas Fabri 66380cca74 Merge branch 'CGAL_VC12_GF' 
Get the testsuite compiled with VC12 ( = MSVC 2013)

Approved by the release manager
 2014-03-26 12:13:01 +01:00
Efi Fogel 1936810b36 minor fix for master 2014-03-25 01:58:59 +02:00
Andreas Fabri 28ab87eb7a Turn copy constructor into a real default constructor 2014-03-19 12:30:20 +01:00
Laurent Rineau 6330632723 Fix various warnings about unused variables/types 2014-01-10 13:25:23 +01:00
Efi Fogel d6ef591c06 removed unused typedef 2013-12-09 08:49:37 +02:00
Efi Fogel a1bd7bd05d removed unnecessaty typedef 2013-12-08 11:06:35 +02:00
Efi Fogel e6839a652c cleaned up destructors 2013-12-06 01:57:27 +02:00
Efi Fogel c745b67e4b cleaned up 2013-12-06 01:26:54 +02:00
Efi Fogel bb018b8fbe Added is_on_y_identification functor 2013-12-06 01:25:55 +02:00
Efi Fogel 4402598ddc Fixed is_in_face() for the case that the point is on the identification curve. Cleaned up 2013-12-03 17:29:24 +02:00
Efi Fogel e50c32655a Fixed typo in is_on_y_identification(), cleaned up 2013-12-03 17:27:33 +02:00
Eric Berberich 713d9227b9 need also a special handling for the right boundary 
mimics the behavior for the top boundary, but here we only have to deal with "ARR_MAX_END"
 2013-12-03 09:56:41 +01:00
Eric Berberich bf1bcaa523 added missing include 2013-12-03 09:56:16 +01:00
Eric Berberich b903e01224 Compare_y_on_boundary should use compare_y and not compare_x :-) 2013-12-03 09:55:40 +01:00
Eric Berberich e7118a904d Merge branch 'Aos_2-test_spherical_blp_vd-tau' of ssh://scm.cgal.org/var/git/cgal into Aos_2-test_spherical_blp_vd-tau 
Conflicts:
	Arrangement_on_surface_2/test/Arrangement_on_surface_2/Batched_point_location_test.h
 2013-12-01 18:05:50 +01:00
Eric Berberich debf144985 fixed typo 2013-12-01 18:03:53 +01:00
Eric Berberich 28cae3423f bugfix: vertical curve must only be considered of the respective halfedge is LEFT TO RIGHT 2013-12-01 18:02:57 +01:00
Eric Berberich 5b20defb95 implemented after_handle_event for spherical batched point location helper 2013-12-01 18:02:21 +01:00
Efi Fogel c3a869f61b cleaned up 2013-12-01 18:37:51 +02:00
Efi Fogel e429e61762 Fixed basic things 2013-12-01 14:41:32 +02:00
Efi Fogel 4001c28082 Documented triangulation point-location and fixed landmark point-location 2013-11-18 00:16:51 +02:00
Efi Fogel affa4e71ad Fixed triangulation point-location 2013-11-17 12:01:31 +02:00
Efi Fogel 42906f161a fixed triangulation point-location 2013-11-17 08:55:47 +02:00
Dror Atariah a51a9a6556 Surrounded CGAL_assertion with #if defined (CGAL_NO_ASSERTIONS) 2013-11-12 09:36:02 +01:00
Dror Atariah 4a4b00d531 Removed Efi's printouts 2013-11-12 08:36:31 +01:00
Dror Atariah 9df5801e7b Altered a call enclosed in a CGAL::assertion 2013-11-11 13:33:31 +01:00
Efi Fogel 2de1b2ec15 Cleaned up. Added print statement for remote debugging 2013-11-10 13:01:02 +02:00
Dror Atariah a4e1fffc99 FIXes: Applied correction according to tests results 2013-10-26 15:58:46 +02:00
Dror Atariah fd5ad145e9 Removed unused variable and clarified Boolean statements 2013-10-25 09:46:08 +02:00
Dror Atariah 99c30184ab Removed un-used variable 
Caused warnings in the tests
 2013-10-24 08:11:47 +02:00
Dror Atariah 7a8395895f Warned comparison between int and std::size_t 
Corrected
 2013-10-24 08:02:01 +02:00
Dror Atariah 81deebb131 Replaced "unsigned int" with "std::size_t" 
Avoid compilation warnings
 2013-10-23 10:54:22 +02:00
Dror Atariah 082cb3b185 Corrected returning from functor 
Added return statement
 2013-10-23 10:53:31 +02:00
Efi Fogel 564a6c794d Synchronized with a recent version of master 2013-10-22 10:00:18 +03:00
Laurent Rineau fa7588e6e5 Restore correct permissions of files 
File created by the Windows port of Emacs, and then commited using the
Cygwin version of Git, have incorrect permissions: they are all executable!
Andreas works using that combination of software.
 2013-09-24 11:05:57 +02:00
Dror Atariah 081b46ce9b Merge branch 'Aos_2-polyline_upgrade-fub' of ssh://scm.cgal.org/var/git/cgal into Aos_2-polyline_upgrade-fub 2013-09-23 10:21:57 +02:00
Dror Atariah 87763b59a6 Corrected const's issues in Push_back_2 
The x-monotone curve was const and the point was not.
 2013-09-23 09:50:05 +02:00
Andreas Fabri a55e82856f put files in dont_submit, and #ifdef so that compiles does not see this code, and add #includes 2013-09-16 15:07:03 +02:00
Andreas Fabri 6c547e5663 Mainly added includes 2013-09-13 22:24:30 +02:00
Eric Berberich 9a9e915317 added missing functors 2013-09-07 12:39:53 +02:00
Eric Berberich 39e453729f fixed naming problem: some variables were wrongly named m_base (should be m_self) 
minor fix for master
bug-fix for master
 2013-09-07 12:39:53 +02:00
Efi Fogel ce5360638a Moved some assertion statements, Approved by the Release Manager 2013-09-02 18:45:26 +03:00
Efi Fogel b234ccfae2 Pacified MSVC 2013-08-07 23:00:23 +03:00
Eric Berberich 1836ae87a7 unified signatures 2013-08-01 15:33:51 +02:00
Eric Berberich a12ede2a2d whitespace cleanup 2013-08-01 15:22:50 +02:00
Eric Berberich ea0feb5553 removed warnings: unused variables from signatures 2013-08-01 15:21:40 +02:00
Efi Fogel d51398cfdc commented out unused variables 2013-08-01 10:39:01 +03:00
Eric Berberich 6c5ecdc3da fixed warning: here, we indeed want to "adapt" by one 2013-07-31 17:21:35 +02:00
Efi Fogel 4b2386d70c replaced unsigned int with size_t 2013-07-31 12:21:49 +03:00
Efi Fogel 7775a6ddc2 Added some CGAL_USE_TYPE() to suppress warnings about unused locally defined typedefs 2013-07-31 12:21:14 +03:00
Efi Fogel 794f2e9236 continue development of poly-geodesics on the sphere 2013-07-30 14:56:14 +03:00
Efi Fogel 808c5d3cd7 Added a comment regarding the defficiency of _compute_signs()---it doesn't support the cylinder case 2013-07-29 14:45:04 +03:00
Efi Fogel d5ae8887fc Useing a constant index-map to prvent the introduction of new entries to m_he_indices_table 2013-07-29 14:27:48 +03:00
Efi Fogel cc7d2a6379 Dispatched _compute_signs() based on whether there are identified boundaries 2013-07-28 12:58:49 +03:00
Efi Fogel e4e7c6e523 Merge branch 'Aos_2-polyline_upgrade-fub' of ssh://scm.cgal.org/var/git/cgal into polyline 2013-07-24 00:09:49 +03:00
Efi Fogel 36e617dde4 continue implementation for polylines in parameter spaces with boundaries 2013-07-24 00:09:14 +03:00
Efi Fogel ee8e68fd1e continue implementation for polylines in parameter spaces with boundaries 2013-07-23 23:03:03 +03:00
Dror Atariah 41bd29724a Removed a todo note 2013-07-23 14:50:46 +02:00
Efi Fogel 88fcfbf9c5 Continue the implementation for poly-geodesics 2013-07-22 18:09:42 +03:00
Efi Fogel 3bd5215150 Made the polyline traits a practical model of the ArrangementLandmarkTraits concept only if the segment traits is a model of this concept 2013-07-22 15:01:36 +03:00
Efi Fogel d6a7413cdb Made the polyline traits a practical model of the ArrangementLandmarkTraits concept only if the segment traits is a model of this concept 2013-07-22 14:58:11 +03:00
Eric Berberich aa414b9ed5 fixed years 2013-07-22 09:33:21 +02:00
Eric Berberich 64f98fa6c7 removed old code 2013-07-22 09:33:21 +02:00
Dror Atariah 2787def18a Changed grouping of Landmark's approximate functor 2013-07-22 09:13:03 +02:00
Dror Atariah 384966d99d Improved the construction of x-polylines when CGAL_ALWAYS_LEFT_TO_RIGHT is on 
In particular, when CGAL_ALWAYS_LEFT_TO_RIGHT is on, then the
construction functor returns an x-polyline which is oriented from left-to-right.
 2013-07-21 18:25:24 +02:00
Efi Fogel aee694b391 Fixed _hole_creation_on_edge_removal() 2013-07-21 18:09:39 +03:00
Efi Fogel c935bfb236 Added support for boundary conditions 2013-07-21 15:49:56 +03:00
Eric Berberich cdc17064f5 replaced top_traits.hole_creation... with general _hole_creation... 2013-07-18 14:54:37 +02:00
Efi Fogel 57101ce35d Integrated with a recent version master 2013-07-14 14:40:09 +03:00
Dror Atariah d30f8d93e7 Updated the documentation - reflect the generality of general polyline 
This update documents the generalization of the possible segments that
can be used as the segments of a polyline. In particular, the
possibility to have non x-monotone segments.
 2013-07-11 08:08:59 +02:00
Dror Atariah cf68065108 Added precondition tests from Make_x_monotone_2 and improved doc's 2013-07-10 18:09:14 +02:00
Dror Atariah 546f07550b Fixed the namespace of Polyline_2 2013-07-10 18:07:16 +02:00
Efi Fogel 7d5a0a0c12 Added Push_front and used it in make_x_monotone (needed for backward compatibility) 2013-07-09 13:27:17 +03:00
Efi Fogel e3170f84b0 Fixed push_back and make_x_monotone while distinguishing between segments and x-monotone segments 2013-07-08 17:14:35 +03:00
Efi Fogel 4039b1d6a0 Replaced SegmentTraits with Segment_type and Point_type as template parameters of Polyline and X_monotone_polyline 2013-07-08 14:20:32 +03:00
Dror Atariah b14a20ab0e Corrected the operator>> in Polyline_2 2013-07-03 15:59:35 +02:00
Sébastien Loriot 225f4ec425 remove warning on msvc 2013-06-26 07:32:34 +02:00
Sébastien Loriot 496d75c256 update licenses that were incorrect after merging replace object feature branch 2013-06-21 15:06:17 +02:00
Dror Atariah b9c7c5f2a8 Documented the construction functors and the macro 
macro = CGAL_ALWAYS_LEFT_TO_RIGHT
 2013-06-21 11:13:22 +02:00
Dror Atariah fab148f88d Corrected and completed the documentation of the functor Push_back_2 2013-06-19 16:40:28 +02:00
Dror Atariah a97d636819 Corrected indentations 2013-06-19 15:40:16 +02:00
Dror Atariah f4ddbee4a4 Changed the namespace POLYLINE to polyline 2013-06-19 13:26:05 +02:00
Dror Atariah 732ae7f619 Updated the documentation of X_monotone_curve_2 2013-06-19 12:13:56 +02:00
Dror Atariah 063b8c5260 Updated the documentation - deprecated and new replacing functions 2013-06-19 11:50:30 +02:00
Dror Atariah 4fa1781731 Corrected the default template parameter 
Not providing a kernel by default. If default SegmentTraits is used,
then the kernel is the default of the SegmentTraits.
 2013-06-19 11:06:49 +02:00
Dror Atariah 3e8ccdad0c Defined Exact_predicates_exact_constructions_kernel as default 
Defined the Exact_predicates_exact_constructions_kernel as the default
template parameter for the Arr_segment_traits_2
 2013-06-19 10:59:20 +02:00
Dror Atariah e43ee37b39 Defined the Arr_segment_traits_2 as the default SegmentTraits 
In this case the default kernel is Exact_predicates_exact_constructions_kernel
 2013-06-19 09:58:04 +02:00
Dror Atariah 2435d1e3e4 Changed the macro for left-to-right invariant of the x-polylines 2013-06-18 15:24:51 +02:00
Dror Atariah 06caf04210 Merge branch 'Aos_2-polyline_upgrade-fub-old' into Aos_2-polyline_upgrade-fub 
Conflicts:
	.gitignore
	Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/Arr_polyline_traits_2.h
	Arrangement_on_surface_2/include/CGAL/Arr_geometry_traits/Polyline_2.h
	Arrangement_on_surface_2/include/CGAL/Arr_polyline_traits_2.h

Resolved the conflicts manually
 2013-06-18 11:55:22 +02:00
Efi Fogel e822dc56d4 Fixed typo 2013-06-17 18:50:33 +03:00
Efi Fogel e9748e047a Merge branch 'master' of ssh://scm.cgal.org/var/git/cgal 2013-06-16 11:46:27 +03:00
Efi Fogel 7aedf66f1a pacify MSVC: fixed a friend statement in a nexted class 2013-06-16 11:45:41 +03:00
Sébastien Loriot c09ec2beaa Merge branch 'Kernel-replace_object-pmoeller' 
Successfully tested in CGAL-4.3-Ic-59
Approved by the release manager

Conflicts:
	Kernel_23/doc/Kernel_23/CGAL/intersections.h
	Kernel_23/doc_tex/Kernel_23_ref/intersection.tex
	Kernel_d/doc/Kernel_d/Kernel_d.txt
	STL_Extension/doc/STL_Extension/CGAL/iterator.h
 2013-06-14 14:26:05 +02:00
Dror Atariah 42df3f2d15 Added the macro CGAL_POLYLINE_FIXED_LEFT_TO_RIGHT 
If defined then Make_x_monotone asserts that the resulting x-polylines are
directed from left-to-right.
 2013-06-14 08:22:57 +02:00
Dror Atariah 496c715256 Implemented Efi's suggestion from 10.06.2013 2013-06-12 12:59:12 +02:00
Efi Fogel fe6e9b860d Apply fixes to compile the arrangement demo with VC 10 2013-06-11 18:27:33 +03:00
Dror Atariah 318d3118a7 Added a roadmap entry - Merge_2 
In the furture we might want to have that merging of overlapping polylines
should be allowed and possible.
 2013-06-08 12:00:51 +02:00
Dror Atariah b4be631802 Removed a todo note 2013-06-08 11:54:33 +02:00
Dror Atariah 0ae61147c0 Removed a todo from Merge_2 2013-06-08 09:57:17 +02:00
Dror Atariah 6890ade8f6 Corrected Merge_2 and Are_mergeable_2 
Update the functors to handle the case when the x-monotone polylines
are oriented either left-to-right _or_ right-to-left.
 2013-06-07 16:18:34 +02:00
Dror Atariah c12fe92bc8 Added a TODO for the Merge_2 functor 2013-06-07 13:13:51 +02:00
Dror Atariah 03cfd952d6 Polsihed the functor Split_2 2013-06-07 13:08:22 +02:00
Dror Atariah 984a7de010 Implemented preconditions of Push_back_2 
In particular for augmenting x-monotone polylines.
 2013-06-07 11:18:33 +02:00
Dror Atariah 63b8b4507d Improved the implementation of Push_back_2 of a segment 
Added a precondition that the orientation fo the given segment should
coincide with the one of the polyline.
 2013-06-07 10:43:04 +02:00
Dror Atariah 46793fe570 Added documentation to the functor Construct_opposite_2 2013-06-07 10:12:08 +02:00
Dror Atariah 8d54b31dcb Removed TODO and corrected comment of Compare_endpoints_xy_2 2013-06-07 09:45:41 +02:00
Dror Atariah 429d247b79 Corrected behavior of Intersect_2 
There was a problem with the indices when the x-poly was oriented
right-to-left. In this case, when getting special care had to be paid
to the value of the "pointing" indices.
 2013-06-05 11:03:58 +02:00
Efi Fogel d7ca4432c4 added the option to pass a flat container of indices (without the -1 at the end of each facet) 2013-06-04 18:17:14 +03:00
Sébastien Loriot f0a5e23c97 bug-fix: take the variant by reference to avoid refering to a temporary 
variant are not ref-counted
 2013-06-04 14:05:18 +02:00
Dror Atariah fec7c17920 Improved locate() to assure that the returned segment 
Make sure that the returned segment contains the query point on its
right end (if possible)
 2013-06-04 11:05:17 +02:00
Sébastien Loriot 404bba0aeb add a workaround for a bug in boost variant and its swap function 
the bug appears on MSVC
The ticket is here:
https://svn.boost.org/trac/boost/ticket/2839
 2013-06-03 19:04:08 +02:00
Efi Fogel ab37ee592e Cleanup, removed unused variables 2013-06-03 15:56:09 +03:00
Dror Atariah 5d3d22ce24 Corrected a test with Intersect_2 2013-06-03 13:21:09 +02:00
Efi Fogel c888eeadff removed 2013-06-03 12:13:26 +03:00
Efi Fogel e4bc02ae57 convert _compute_signs_and_local_minima() used when an edge is removed to _compute_signs_and_min() 2013-05-31 23:03:58 +03:00
Dror Atariah a4ae33e50b Corrected porblem with Intersect_2 2013-05-31 15:51:22 +02:00
Efi Fogel 16532d0eab improved _remove_edge() and introduced (and used) _compute_signs 2013-05-31 16:38:25 +03:00
Dror Atariah 8fdea5a11b Corrected and improved Intersect_2 2013-05-30 19:02:21 +02:00
Dror Atariah 5765f10275 Intersect_2 returns left-to-right when overlapping (comment) 
Corrected the comment
 2013-05-30 14:12:13 +02:00
Dror Atariah c90571d516 Added Construct_opposite_2 functor (not tested!) 2013-05-30 12:03:09 +02:00
Dror Atariah 8dc681ce2d Started to fix bug with Intersect_2 
Fixed some style issues as well
 2013-05-30 11:58:40 +02:00
Dror Atariah 2a8e5b5388 Implemented Compare_endpoints_xy_2 functor 2013-05-30 10:00:50 +02:00
Efi Fogel a895f3bc19 fixed inertion into non-empty arrangement. More precisely, fixed computation of the current top face 2013-05-30 10:57:43 +03:00
Dror Atariah 4d8165ad7f Updated todo's and roadmaps 2013-05-30 09:39:38 +02:00
Dror Atariah 1f2bd84cb3 Removed TODO's and corrected indentations 2013-05-29 13:49:06 +02:00
Dror Atariah a1ccc0a138 Corrected a problem with Intersect_2 
It seems like this problem was already there in the original code.
 2013-05-29 12:11:20 +02:00
Dror Atariah d6b3d101ef Corrected the functors Intersect_2 and Split_2 (result of polylines.cpp) 
polylines.cpp returns correct answer which coincides with the result of
master (4441f27)
 2013-05-28 20:04:48 +02:00
Sébastien Loriot 541eb8d656 add missing template keyword detected by clang 2013-05-28 18:51:00 +02:00
Clement Jamin c78bae3299 Removed a warning 2013-05-28 17:34:38 +02:00
Efi Fogel 220add1ae3 cleanup 2013-05-28 18:17:50 +03:00
Dror Atariah 71856f9efe Removed unneeded code snippet "#if 0 etc. 2013-05-28 13:41:51 +02:00
Dror Atariah bb977708fe Corrected a small bug 2013-05-28 12:40:07 +02:00
Dror Atariah 95d1da0e9d Revert the implementation of Intersect_2 
After realizing that the hack was not consistent we reverted to the
"original" code and start correcting the Intersect_2 from scratch.
 2013-05-28 12:38:56 +02:00
Dror Atariah 361d09ef06 WIP on the Intersect_2 - still not working 2013-05-28 10:39:32 +02:00
Dror Atariah 4441f2743d Added missing const - minor bugfix 2013-05-27 16:58:39 +02:00
Dror Atariah 93294534cd Changed an if-else according to Efi's suggestion 2013-05-27 12:02:44 +02:00
Dror Atariah 64c36ccdc5 Corrected locate_side() after lifting direction invariant 2013-05-26 15:41:32 +02:00
Dror Atariah 4ea51ee35a Corrected locate(cv,p) 
Mainly the testing of a non-vertical polyline.
 2013-05-24 16:56:33 +02:00
Sébastien Loriot a4089fcad8 remove warnings spotted by examples 2013-05-24 11:20:50 +02:00
Sébastien Loriot 5d613db62b rename result_return to make_result 2013-05-24 10:55:09 +02:00
Sébastien Loriot af1dd0d01b rename make_default_result to default_result 2013-05-24 10:52:12 +02:00
Sébastien Loriot dcb0fbfba6 bugfix: a default constructed variant was returned instead of an empty optional 
This fix includes also a renaming to make things more clear.
The bug fix is where make_optional_result is now called
 2013-05-24 10:48:50 +02:00
Sébastien Loriot 690720c14b fix compatibility with version 1 2013-05-24 08:52:22 +02:00
Dror Atariah e62e15b1d0 Corrected locate() for the case of vertical x-poly 2013-05-23 14:03:04 +02:00
Sébastien Loriot c67ba90514 Merge branch 'Kernel-replace_object-pmoeller-old' into Kernel-replace_object-pmoeller 
Conflicts:
	Circular_kernel_2/include/CGAL/Circular_kernel_2/Circular_arc_2.h
	Circular_kernel_2/include/CGAL/Circular_kernel_2/internal_functions_on_circle_2.h
	Installation/changes.html
	Kernel_d/doc/Kernel_d/CGAL/intersections_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Center_of_sphere_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Compare_lexicographically_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Component_accessor_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Compute_coordinate_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_affine_hull_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_linear_hull_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_simplex_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Equal_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Has_on_positive_side_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Intersect_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Less_coordinate_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Less_lexicographically_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Less_or_equal_lexicographically_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Lift_to_paraboloid_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Linear_base_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Linear_rank_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Linearly_independent_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Midpoint_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Orientation_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Oriented_side_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Orthogonal_vector_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Point_dimension_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Point_of_sphere_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Point_to_vector_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Project_along_d_axis_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Side_of_bounded_sphere_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Side_of_oriented_sphere_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Squared_distance_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Value_at_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Vector_to_point_d.h
 2013-05-23 13:13:08 +02:00
Dror Atariah d925209b79 Corrected Equal_2 and X-poly construction from range of pts 2013-05-23 09:20:44 +02:00
Dror Atariah d9fe68202b Corrected Construct_min/max_vertex_2 functors 
The functors were implicitly assuming the existence of the direction
invariant of the x-polylines.
 2013-05-23 09:20:44 +02:00
Dror Atariah 8063daacc5 Lifted dir-invariant from construction of x-poly from range of segs 2013-05-23 09:20:44 +02:00
Dror Atariah f4976807fc Lifted dir.-invariant from functor of x-poly from range of pts. 2013-05-23 09:20:43 +02:00
Dror Atariah 1e2c37615f Lifted direction-invariant from functors constructions of x-polylines 2013-05-23 09:20:43 +02:00
Dror Atariah 6579cc948f Cosmetic correction to the construction functors of general polylines 2013-05-23 09:20:43 +02:00
Dror Atariah a80545845a Updated comments of constructions of general polylines. 2013-05-17 11:54:27 +02:00
Dror Atariah ae7bdf97c7 Cosmetic change (empty lines adding/removing) 2013-05-16 11:11:06 +02:00
Dror Atariah 115429e274 Precondition tests that construction from range of segs is well-oriented 
Implemented the tests that the input range of polylines is well-oriented.
 2013-05-16 10:54:04 +02:00
Dror Atariah b242276a9b Updated precondition of construction from range of segs. Update todo's 
Updated the precondition that the segments given as an input for
construction of a (general) polyline should be well-oriented.
 2013-05-16 09:35:51 +02:00
Dror Atariah 5945972206 Corrected comment, changes local variable name, added TODO 2013-05-15 13:38:59 +02:00
Dror Atariah 8cb8085623 Corrected signature of operator() Push_back_2 of a seg to a polyline 2013-05-15 08:29:39 +02:00
Dror Atariah 0bffffb27a Corrected a todo and a roadmap 2013-05-15 08:27:14 +02:00
Dror Atariah 874b5a8dc9 Corrected Push_back_2 of a single segment to a general polyline 
Implemented the post-condition that the resulting polyline is well oriented.
 2013-05-14 17:23:25 +02:00
Dror Atariah 6021823ac8 Corrected Push_back_2 of a single point to a polyline 
Applied the assumption that SegmentTraits models ArrangementDirectionalXMonotoneTraits_2.
 2013-05-14 16:48:19 +02:00
Dror Atariah f73de5f722 Removed todo about Has_source_target tag 
Once we decided to assume (for the time being) that the SegmentTraits
should model ArrangementDirectionalXMonotoneTraits_2 then there's no
need for this tag.
 2013-05-14 15:55:57 +02:00
Dror Atariah 154df43c2e Utilized ArrangementDirectionalXMonotoneTraits_2 in Make_x_monotone_2 
Made use of the functor Compare_endpoints_xy_2 which is provided by
ArrangementDirectionalXMonotoneTraits_2 in the implementation of Make_x_monotone_2.
 2013-05-14 14:47:39 +02:00
Dror Atariah 774e04d0b3 Removed TODO in Make_x_monotone_2, case where polyline has only one seg 
This case was simplified once assuming that the polylines cannot be
degenerated. So, if the polyline has only one seg then it means that it
is already x-monotone.
 2013-05-13 15:35:45 +02:00
Efi Fogel 3f4db83af2 cleanup 2013-05-12 01:11:28 +03:00
Efi Fogel 26eabd2161 cleanup 2013-05-12 00:10:35 +03:00
Efi Fogel d6a062dff4 cleanup 2013-05-10 14:25:54 +03:00
Efi Fogel 31c1a5de59 cleanup 2013-05-10 14:06:41 +03:00
Efi Fogel 8dca4b39c5 added a comment 2013-05-09 16:11:28 +03:00
Efi Fogel e26354c71c when splicing, need to use the next halfedge that starts at the northpole (and not the previous one) cause the next one around the north pole is actually the previous one encountered 2013-05-09 16:04:57 +03:00
Efi Fogel 5510218dc9 cleanup 2013-05-05 18:16:47 +03:00
Efi Fogel c21c2c9fed cleanup 2013-04-29 15:30:42 +03:00
Dror Atariah 6f380d0f68 Changed a todo to a roadmap 2013-04-25 13:25:37 +02:00
Dror Atariah 3543b91c72 Updated roadmap item 2013-04-25 11:37:07 +02:00
Dror Atariah ad8986c926 Obtain the seg-traits using the segment_traits_2() function 
Instead of referring directly to the member m_seg_traits
 2013-04-25 11:35:36 +02:00
Dror Atariah fe88ab9087 Replaced InputIterator with ForwardIterator 
In the construction functors a ForwardIterator has to be used as the
container is iterated by at least two iterators at the same time. This
behavior is not supported by the concept of an InputIterator.
 2013-04-25 11:22:04 +02:00
Dror Atariah 77f45a3be7 Merge branch 'WIP-shorten-calls-to-seg-traits' into Aos_2_polyline_cleaning 2013-04-25 11:09:17 +02:00
Dror Atariah c3c6dc290b Update signature of locate() and the calls to this function 2013-04-25 11:05:15 +02:00
Dror Atariah 0d81073c22 Changed the function's name and updated the calls 2013-04-25 10:51:15 +02:00
Dror Atariah 5adf42f96a Shortened the calls to object from the segment traits 
Instead of having lots of calls like:
m_poly_traits->m_seg_traits->equal_2_object();

I added, where needed,
const Segment_traits_2* seg_traits = m_poly_traits->segment_traits_2();
and then replaced the above line with:
seg_traits->equal_2_object();
 2013-04-25 09:58:02 +02:00
Dror Atariah 88550ef207 Added a documentation of the X_monotone_curve_2 type 2013-04-22 15:50:20 +02:00
Dror Atariah 9194016930 Corrected indentation in Polyline_2 2013-04-22 14:44:01 +02:00
Dror Atariah e3af05fea6 Used the polyline traits in each functor 
Then, when the segment traits was needed, extracted it from the polyline-traits.
 2013-04-22 12:56:59 +02:00
Dror Atariah 7b5a54c311 Improved a roadmap statement. 2013-04-22 09:13:29 +02:00
Efi Fogel 1238057b23 Added assertion when trying to push a point into an empty polyline 2013-04-20 21:22:16 +03:00
Dror Atariah 453dbb8e9a Code cosmetics optimization 
Avoided duplicated code in Merge_2
 2013-04-19 17:39:45 +02:00
Dror Atariah 972baf6071 Added two Roadmap items 
- Correct the _locate()
- Correct the way functors access the segment traits.
 2013-04-19 17:21:29 +02:00
Dror Atariah f03fba9ded Corrected declaration of index in a for loop. Style improve. 2013-04-19 16:56:05 +02:00
Dror Atariah 32b2a46219 Added a roadmap item - overkill in the Push_back_2 2013-04-19 16:23:43 +02:00
Dror Atariah 59ebc5d5f2 BUGFIX: in Make_x_monotone_2 corrected a problem 
Previously if the polyline went vertically up->down->up (again) then
it wouldn't be split. This was now corrected.
 2013-04-19 16:17:52 +02:00
Dror Atariah 799df6c8b7 Styling: replaces min/max_v occurrences with get_min/max_v 
To stress that it is a function which returns something (Point_2)
 2013-04-19 15:58:32 +02:00
Dror Atariah 2c403d9aca Becoming unfriendly! Remove all un-needed friendships. 2013-04-19 15:44:46 +02:00
Dror Atariah 57bc6defce Returning const ref Point_2 from the construct_min/max_vertex_2 2013-04-19 15:41:50 +02:00
Dror Atariah 66846e3a7e Moved Polyline_2 and X_monotone_polyline_2 into a new sub-namespace POLYLINE 2013-04-19 15:25:46 +02:00
Dror Atariah e2c9e4cf63 Updating comments together with M. Hemmer 2013-04-19 15:18:49 +02:00
Dror Atariah f46274c4b0 Merge branch 'Aos_2_polyline_cleaning-old' into Aos_2_polyline_cleaning 2013-04-12 11:55:19 +02:00
Dror Atariah 8eeec64cd0 Disabled non-const iterators over the segments 2013-04-12 11:52:23 +02:00
Dror Atariah e63dedfcba Cleared the last TODO 2013-04-12 11:37:07 +02:00
Dror Atariah fc340e85e0 Added a TODO 
Handle Construct_min_vertex_2 and Construct_max_vertex_2 functors
 2013-04-12 11:29:08 +02:00
Dror Atariah 191d4bf3de Polished comments and layout, removed TODO 2013-04-12 09:52:38 +02:00
Dror Atariah 2a69db75e9 Added tests that input doesn't contain degenerated segments 
After deciding that a polyline cannot contain degenerated segments, this commit
implemented the preconditions to verify the validity of the input.
 2013-04-09 17:12:02 +02:00
Dror Atariah d1e5b422fc Polished the output operator for a polyline 2013-04-09 16:57:18 +02:00
Laurent Rineau dbdcdffaeb The default value of a parameter is used even if its name is not. 
Fixes:
  | commit 0cbc8b0e40
  | Author: Andreas Fabri <andreas.fabri@geometryfactory.com>
  | Date:   Sat Mar 23 08:45:06 2013 +0100
  |
  |     remove unused parameters
 2013-03-25 14:26:50 +01:00
Andreas Fabri 0cbc8b0e40 remove unused parameters 2013-03-23 08:45:06 +01:00
Sébastien Loriot 14429d2b8e fix compilation errors 2013-03-14 18:32:14 +01:00
Sébastien Loriot f97d6b8bd9 s/boost::result_of/cpp11::result_of/g 2013-03-14 10:38:13 +01:00
Sébastien Loriot d6905c61be Merge branch 'Kernel-replace_object-pmoeller-old' into Kernel-replace_object-pmoeller 
Conflicts:
	AABB_tree/include/CGAL/AABB_tree.h
	Circular_kernel_2/include/CGAL/Circular_kernel_2/internal_functions_on_line_arc_2.h
	Intersections_3/include/CGAL/Intersections_3/intersection_3_1_impl.h
	Kernel_23/doc/Kernel_23/CGAL/intersections.h
	Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h
	STL_Extension/doc/STL_Extension/CGAL/iterator.h
 2013-03-14 10:29:31 +01:00
Dror Atariah 008c3b6169 Documented the possible cause of a problem. No solution yet. 2013-03-13 12:46:08 +01:00
Dror Atariah a392530218 Updated TODO's and worked on the included example 
Altered the example to relay on the constructions provided by the traits class.
 2013-03-13 12:19:05 +01:00
Dror Atariah ad266ca336 Corrected dispatching in the constructors 
In the polyline's class I switched to a dispatching based on boost.
 2013-03-13 12:07:52 +01:00
Dror Atariah 0fd06a8a25 Updated a comment on the construction of x-mono from points 2013-03-13 11:06:36 +01:00
Dror Atariah 7906b4e43b Removed a TODO 2013-03-13 11:03:58 +01:00
Dror Atariah dce8527b11 Construction from single segment of polyline and x-mono polyline 2013-03-13 11:00:55 +01:00
Dror Atariah ff0511a29b Construction of polyline and x-mono polyline from two points 2013-03-13 10:50:57 +01:00
Dror Atariah 45fc3336ba Cleaned and tested construction of polyline from points 
In the traits class I cleaned and tested the construction functor of a
polyline from a range of points.
 2013-03-13 10:14:35 +01:00
Dror Atariah af8c796438 Corrected typo in an error message 2013-03-13 10:11:47 +01:00
Efi Fogel 5f277db38b included boost/optional/optional.hpp 2013-03-13 10:59:31 +02:00
Dror Atariah 859b98772e Manually merged changes from local branch WIP-dror 2013-03-13 09:48:39 +01:00
Efi Fogel a05c10260d cleanup 2013-03-12 12:22:40 +02:00
Andreas Fabri 5ff303803a remove unused parameters 2013-03-12 09:55:38 +01:00
Dror Atariah 76c23d4ed9 Cleaning the class and the traits 2013-03-11 18:00:12 +01:00
Dror Atariah 0716e3dca1 Updated my branches with changes on master 
Merge branch 'AOS_2_bounded_clean_old' into AOS_2_bounded_clean

Conflicts:
	.gitignore
 2013-03-11 15:51:43 +01:00
Dror Atariah 5e5288ab07 Traits vs. Class construction changes 
Simplified constructions in Polyline_2 and expanded construction
functors in the traits.

In the class I left only the possibility to  construct from a range of
segments.

In exchange, in the traits class I worked on the construction of
x-monotone polylines from ranges of points
 2013-03-11 15:36:52 +01:00
Efi Fogel 1521abd24b replaced red and blue Object with boost::optional<boost::variant<>>, introduced boundary vertices map, and cleaned up 2013-03-10 17:38:54 +02:00
Efi Fogel 9b67042d7e cleanup 2013-03-10 17:37:02 +02:00
Efi Fogel 6d5bd33329 cleanup 2013-03-10 17:35:38 +02:00
Efi Fogel 7ea05d278e cleanup 2013-03-10 17:33:40 +02:00
Efi Fogel 1007862815 cleanup 2013-03-10 17:27:48 +02:00
Laurent Rineau 01e83dfb0a Follow-up to the following commit: 
| commit f202656ca4
  | Author: Laurent Rineau <laurent.rineau@cgal.org>
  | Date:   Fri Mar 1 10:45:02 2013 +0100
  |
  |     Fix warnings in Aos_2
  |
  |     LLVM/clang can display warnings even for functions that are not used,
  |     during the parsing of the code, before the compilation, when it can.

Aos_2 has two constructors and I had modified the code in only one of them.
 2013-03-04 12:09:22 +01:00
Laurent Rineau f202656ca4 Fix warnings in Aos_2 
LLVM/clang can display warnings even for functions that are not used,
during the parsing of the code, before the compilation, when it can.

For example:

[...]/include/CGAL/Arr_tags.h:93:7: warning: unused variable 'missing__Left_side_category__assuming__Arr_oblivious_side_tag__instead' [-Wunused-variable]
      missing__Left_side_category__assuming__Arr_oblivious_side_tag__instead;
      ^
[...]/include/CGAL/Arr_tags.h:138:7: warning: unused variable 'missing__Bottom_side_category__assuming__Arr_oblivious_side_tag__instead' [-Wunused-variable]
      missing__Bottom_side_category__assuming__Arr_oblivious_side_tag__instead;
      ^
[...]/include/CGAL/Arr_tags.h:181:10: warning: unused variable 'missing__Top_side_category__assuming__Arr_oblivious_side_tag__instead' [-Wunused-variable]
    bool missing__Top_side_category__assuming__Arr_oblivious_side_tag__instead;
         ^
[...]/include/CGAL/Arr_tags.h:226:7: warning: unused variable 'missing__Right_side_category__assuming__Arr_oblivious_side_tag__instead' [-Wunused-variable]
      missing__Right_side_category__assuming__Arr_oblivious_side_tag__instead;
      ^
4 warnings generated.

With this commit, the functions 'missing__*_side_category()' are now
function *templates*. The compiler can not longer warn about the unused
variable. However, I have verified that it does warn if the function is
actually instanciated and used.
 2013-03-01 10:45:22 +01:00
Andreas Fabri 34b112ca5d remove unused parameters 2013-02-27 17:16:39 +01:00
Andreas Fabri e5a1756076 undo of a static_cast 2013-02-26 18:35:51 +01:00
Laurent Rineau 2d8da664a3 Merge branch 'CGAL-fix_warnings-gdamiand' 
Conflicts:
	.gitignore
	Skin_surface_3/examples/Skin_surface_3/CMakeLists.txt
 2013-02-22 13:02:37 +01:00
Laurent Rineau e0a66ceb1b QPL->GPLv3+ for files created by the merge of the following branch: 
Arrangement_on_surface_2-RIC_pl_for_unbounded-balasmic
 2013-02-19 16:45:00 +01:00
Laurent Rineau e06a6f535b Add or fix license/copyright headers in CGAL headers 2013-02-19 16:45:00 +01:00
Andreas Fabri 4bbc6ddd39 static_casts, switching to size_t, comparing a pointer with NULL to avoid warnings 2013-02-15 09:27:15 +01:00
Andreas Fabri be1e1738c2 static_casts and int -> size_t in Arrangement and Boolean Set Operations 2013-02-14 13:01:58 +01:00
Sébastien Loriot c397161748 Revert "pacify msvc" 
This reverts commit 395d0c1758.
There were some conflicts with the fixes in the branch
CGAL-fix_warnings-gdamiand, so we cherry-picked this commit
into the branch and resolved the conflicts.
 2013-02-14 10:27:45 +01:00
Efi Fogel 3bc7609717 Avoid if(boolean_variable == false) 2013-02-14 10:02:01 +01:00
Efi Fogel 395d0c1758 pacify msvc 2013-02-13 11:27:16 +02:00
Andreas Fabri e3405423ff replace int with bool 2013-02-12 22:12:28 +01:00
Efi Fogel 09ca243173 cleanup - mainly by a patch provided by Shriramana Sharma 2013-02-11 15:33:02 +02:00
Andreas Fabri 0fccc8a246 compare with NULL, int -> size_t 2013-02-08 17:53:13 +01:00
Andreas Fabri 5afa7b080a Put () around min and max 2013-02-08 16:13:23 +01:00
Laurent Rineau d19578725b Fix warnings 2013-02-07 18:15:23 +01:00
Laurent Rineau e87dad0f95 Fix all warnings in demo/Polyhedron/ 
The compilation was fix g++-4.8, and the flags:
  --std=c++11 -frounding-math Wall -Wno-array-bounds -Wno-uninitialized
 2013-02-06 17:03:20 +01:00
Dror Atariah 5cc3b6f769 Construction implementations and updates. Examples and test 
1. Added a sub directory with an illustration of the examples that can
be found in polylines.cpp
2. Simple implementation of a construction of a polyline from a single
segment
3. In order not to use the construction of polylines from points, in the
construction functor from a range of points, a range of segments is
first constructed. This new range is given as an input to the actual
constructor.
4. Added a simple construction functor of an x-mono polyline from a
single segment.
 2013-01-25 11:42:04 +01:00
Dror Atariah 940b12eefc Posed the problem with construction from two points and why it fails 2013-01-25 09:21:54 +01:00
Dror Atariah 870c1d45b6 Added a constructor from one segment to Polyline_2 2013-01-24 21:42:40 +01:00
Dror Atariah 760ba40ce8 Revert changes in Split_2 
After trying to improve the implementation of the Split_2 functor in the
traits class failed, this is a reverting to a working version.
 2013-01-24 11:21:07 +01:00
Dror Atariah 1077100e0a Merge branch 'AOS_2_bounded_clean-old' into AOS_2_bounded_clean 
In order to get latest status of doxygen in the branch a merge was applied
according to the instructions in:
https://cgal.geometryfactory.com/CGAL/Members/wiki/Guidelines/Source_Code_Management_QuickStart_GIT/FAQ#My_branch_is_really_old._I_would_like_to_update_it_to_get_latest_update_from_master.
 2013-01-18 12:14:03 +01:00
Dror Atariah 94a47bf632 Updated comments according to Efi's suggestions 2013-01-15 11:16:48 +01:00
Dror Atariah bbdde5c28b Cleaning TODO's and trying to solve a range copying problem 2013-01-10 21:38:04 +01:00
Sébastien Loriot b0bd160355 add missing back-ticks in see also 2013-01-09 19:48:41 +01:00
Dror Atariah 8521437f08 Tried to resolve and fix some TODO's 
Together with Panos, we tried to resolve. This is an intermediate commit.
 2013-01-09 17:08:00 +01:00
Efi Fogel d0af3ca089 cleanup 2013-01-03 19:26:58 +02:00
Efi Fogel 49d4e17787 cleanup 2013-01-03 19:19:05 +02:00
Efi Fogel 2f47161666 ops 2013-01-03 19:14:46 +02:00
Efi Fogel 6b88d0a0ee cleanup 2013-01-03 18:05:08 +02:00
Efi Fogel e180993e7b supported geodesic on sphere that are meridians 2013-01-03 17:11:18 +02:00
Efi Fogel e45fa0e513 enhanced overlay test, fixed a bug in the construction visitor, and cleaned up 2012-12-31 12:29:48 +02:00
Eric Berberich 32b0a10059 Merge remote-tracking branch 'origin/hot-fixes-for-Git' into Aos_2-remove_opt-efif 
Conflicts:
	.gitattributes
 2012-12-30 14:19:43 +01:00
Dror Atariah e669ca6afb Updates and TODO's after session with Efi, Michael and Panos 2012-12-21 08:08:52 +01:00
Efi Fogel dda664ecf9 Fixed calling of the various insert_ members 2012-12-21 00:20:41 +02:00
Efi Fogel 3206160b97 Fixed duplicate calls to overlay traits callbacks 2012-12-19 20:29:22 +02:00
Dror Atariah 8c6fdf5d4d Cleaned the Polyline_2.h ready for review by Efi and Panos 
This is a rather big commit, where all the issues and problems were
solved. The package's tests ran successfully.
 2012-12-19 12:18:25 +01:00
Dror Atariah 0e34784038 Backup 2012-12-18 09:26:13 +01:00
Dror Atariah d578a5a29b Backup 2012-12-18 09:25:38 +01:00
Dror Atariah d6b5c66899 Corrected deprecation issues after discussion with Efi Fogel 2012-12-17 17:22:48 +01:00
Dror Atariah fde97f3f6f Deprecated the push_backs in the Polyline_2.h class 2012-12-17 11:46:01 +01:00
Philipp Möller 6497d48f2f Convert all CRLF files to LF 
Conflicts:

	Documentation/stylesheet.css
	Installation/cmake/modules/CGAL_SCM.cmake
 2012-12-13 12:30:37 +01:00
Dror Atariah 1163d9985a Updating some chats with Efi. Finished the importer 2012-12-06 21:50:37 +01:00
Dror Atariah 4662e57d51 Corrected indentation 2012-12-05 15:39:55 +01:00
Dror Atariah c0edfa15e4 Un-deprecated mistakely deprectaed types 2012-12-05 15:30:24 +01:00
Philipp Möller d198458ca7 Merge branch 'origin-gsoc2011-boost_object-pmoeller' into Kernel-replace_object-pmoeller 
Conflicts:
	.gitattributes
	AABB_tree/doc_tex/AABB_tree_ref/AABBGeomTraits.tex
	AABB_tree/doc_tex/AABB_tree_ref/AABBTraits.tex
	AABB_tree/doc_tex/AABB_tree_ref/AABB_traits.tex
	AABB_tree/include/CGAL/AABB_traits.h
	AABB_tree/include/CGAL/AABB_tree.h
	AABB_tree/test/AABB_tree/AABB_test_util.h
	Arrangement_on_surface_2/doc_tex/Arrangement_on_surface_2/arr_queries.tex
	Arrangement_on_surface_2/doc_tex/Arrangement_on_surface_2_ref/Arr_trapezoid_ric_point_location.tex
	Arrangement_on_surface_2/doc_tex/Arrangement_on_surface_2_ref/intro.tex
	Arrangement_on_surface_2/include/CGAL/Arr_batched_point_location.h
	Arrangement_on_surface_2/include/CGAL/Arr_point_location/Arr_lm_generator_base.h
	Arrangement_on_surface_2/include/CGAL/Arr_point_location/Arr_lm_random_generator.h
	Arrangement_on_surface_2/include/CGAL/Arr_point_location/Arr_trapezoid_ric_pl_impl.h
	Arrangement_on_surface_2/include/CGAL/Arr_point_location/Arr_walk_along_line_pl_impl.h
	Arrangement_on_surface_2/include/CGAL/Arr_trapezoid_ric_point_location.h
	Arrangement_on_surface_2/test/Arrangement_on_surface_2/point_location.cpp
	Circular_kernel_2/include/CGAL/Circular_kernel_2/internal_functions_on_line_arc_2.h
	Circular_kernel_3/include/CGAL/Circular_kernel_3/internal_functions_on_circular_arc_3.h
	Circular_kernel_3/include/CGAL/Circular_kernel_3/internal_functions_on_line_arc_3.h
	Circular_kernel_3/include/CGAL/Circular_kernel_3/internal_functions_on_sphere_3.h
	Filtered_kernel/include/CGAL/Lazy.h
	Filtered_kernel/include/CGAL/Lazy_kernel.h
	Intersections_2/include/CGAL/Triangle_2_Iso_rectangle_2_intersection.h
	Intersections_2/test/Intersections_2/test_intersections_2.cpp
	Intersections_3/test/Intersections_3/test_intersections_3.cpp
	Kernel_23/doc_tex/Kernel_23_ref/intersection.tex
	Kernel_23/include/CGAL/Kernel/Type_mapper.h
	Kernel_d/doc_tex/Kernel_d_ref/Kernel.tex
 2012-12-04 17:57:53 +01:00
Dror Atariah a01bb2d93c Corrected problems Efi mentioned. Continue the discussion with Efi. 2012-12-04 16:53:49 +01:00
Philipp Möller 1adf441b18 Convert all CRLF files to LF 2012-12-03 18:44:24 +01:00
Efi Fogel fa065d6a80 included <algorithm> 2012-12-02 11:09:47 +02:00
Sébastien Loriot 99431d84f0 Merge branch 'hot-fixes-for-Git' 
Conflicts:
	Arrangement_on_surface_2/include/CGAL/Arr_point_location/Trapezoidal_decomposition_2_impl.h
 2012-11-29 19:38:34 +01:00
Sébastien Loriot d3e29b0441 Normalize line endings 2012-11-29 19:23:40 +01:00
Efi Fogel 596927b48f answered some questions 2012-11-29 10:45:13 +02:00
Dror Atariah 680212344c Answered comments of Efi 
Continued the final cleaning of the code.
 2012-11-27 15:47:27 +01:00
Dror Atariah eeeb310763 Add a constructor of a polyline in the traits class. 
Applied few of Efi's comments.
 2012-11-27 11:14:35 +01:00
Efi Fogel 0731663905 answered some questions raised by Dror 2012-11-27 10:11:24 +02:00
Dror Atariah 245ef61ece Added few inline questions to Efi. 2012-11-26 16:10:07 +01:00
Dror Atariah d8584143ea Added some TODOS 2012-11-26 10:53:43 +02:00
Dror Atariah a94061f832 Removed the source/target calls in the push_back of segment 
In the x-monotone part of the Polyline_2.h I removed the usage of
source/target of segments. Instead, there's a use of
Construct_min/max_vertex_2.
 2012-11-21 17:14:23 +02:00
Dror Atariah eaeaee535f Corrected problems with the computations 
Corrected problems in the Make_x_monotone and the constructions of
x-monotone curves. This seems to enable correct computations of the
arrangements - but there is more to test.

Furthermore, the usage of source/target of segments still has to
be avoided.
 2012-11-21 14:31:21 +02:00
Dror Atariah b8cbc60bfc Working code, wrong results 
This seems to be related to problems with the const_iterator
over points.
 2012-11-20 18:38:45 +02:00
Dror Atariah 8e92d8a762 backup before updating make-x-monotone 2012-11-20 15:07:00 +02:00
Efi Fogel 928058bbd0 improved make-x-monotone 2012-11-20 13:44:06 +02:00
Dror Atariah aa991c8b19 Corrected problems with Make_x_monotone_2 
Code compiles and runs properly but doesn't compute correct
arrangement.
 2012-11-20 13:15:00 +02:00
Dror Atariah e0d185d9a0 Plugged in Make_x_monotone code from old version 
I took the code from the unbounded branch, and used it in the current
implementation.
 2012-11-19 19:41:27 +02:00
Dror Atariah 6321c1de4e Trying to find the problem with the Make_x_monotone 2012-11-19 19:27:05 +02:00
Dror Atariah c3740c2868 Added a const iterator over the segments of a polyline 
In the Polyline_2.h a const iterator over the segments was added,
and the Make_x_monotone_2 in the traits class was modified to use
the segmenets iterator.
 2012-11-19 16:32:21 +02:00
Efi Fogel 00f6a17627 cleanup 2012-11-19 14:02:58 +02:00
Dror Atariah dc9314c06b Changes to the constructor 
Added support to construction from points to the constructor in the
traits class.
 2012-11-19 12:24:40 +02:00
Dror Atariah bba1778558 Added a test of the new construction in the traits class 
In the Make_x_monotone_2 functor I replaced the call to the
constructor of the polyline with the call to the
constructor-traits.
 2012-11-19 11:23:45 +02:00
Efi Fogel 5fa2818cde Merge branch 'Arrangement_on_surface_2-bounded_polylines-cleaning-code-fub' of ssh://scm.cgal.org/var/git/cgal into bp 2012-11-18 16:32:35 +02:00
Efi Fogel 09d8e3e7dc added constructor functors to polyline traits 2012-11-18 16:29:27 +02:00
Dror Atariah 7dde3536d5 Stated a problem when iterating over a polyline 2012-11-18 13:03:29 +01:00
Dror Atariah f2a5b9cfcd Changed the internal constructor of Polyline_2 2012-11-15 14:29:19 +01:00
Efi Fogel 712ebe392e cleanup 2012-11-14 15:41:32 +02:00
Eric Berberich 134e26e48e bugfix: in spherical arr there can be more than one curve starting on an event on the boundary 
In particular a red and a blue one. In the previous code only one of those got detected, and
thus, only the red or the blue top face got updated. The improved version searches for the first
non-blue and non-red subcurve (as overlap is blue and red!)
 2012-11-05 13:04:15 +00:00
Efi Fogel 38252f06a6 fixed typo 2012-11-04 10:31:31 +00:00
Efi Fogel 411cd2c74f cleanup 2012-11-01 14:59:03 +00:00
Efi Fogel abded7f8d5 cleanup 2012-11-01 13:20:16 +00:00
Efi Fogel 1e3833930c merged with next 2012-10-25 10:07:41 +00:00
Eric Berberich 1102c1994e Internal _insert_xyz function get a more intuitive signature 
This change is motivated by other internal function that have a
similar signature already. Example: prev1->cv<-prev2+cmp is now 
he_to->cv,cv_dir->he_away
 2012-10-23 12:55:25 +00:00
Eric Berberich e3baab4b54 fixed typos 2012-10-21 14:47:07 +00:00
Eric Berberich ce8f47a230 precised a comment 2012-10-21 14:33:45 +00:00
Eric Berberich 74e5084bbd removed some TODOs, improved verbosity, added comments to better understand the code 2012-10-21 12:42:36 +00:00
Eric Berberich 01434e194e added is_on_outer_ccb 2012-10-21 12:41:35 +00:00
Efi Fogel 679f2ca65b fixed for closed boundary 2012-10-21 12:04:17 +00:00
Efi Fogel 83adc68f4c fixed typo 2012-10-21 12:03:53 +00:00
Eric Berberich 6af10df2a1 added comment 2012-10-17 22:21:39 +00:00
Eric Berberich 8fd8504e39 added some documentation 2012-10-17 22:17:34 +00:00
Eric Berberich 3c03709874 compile _compute_indices only when there is an identifiaction 2012-10-17 15:28:45 +00:00
Eric Berberich 4c68e6e224 removed a test that was too restrictive 
we can have outer-outer insertation that require a relocation
 2012-10-17 13:32:34 +00:00
Efi Fogel 6523159b41 fixed typo 2012-10-17 10:32:46 +00:00
Eric Berberich b2493ce362 need to assign it to correct curve starting on left boundary 2012-10-16 15:01:35 +00:00
Eric Berberich b968c92ab5 increase verbosity and cosmetics 2012-10-16 12:38:36 +00:00
Eric Berberich 5a52acbe20 some more verbosity 2012-10-16 12:23:43 +00:00
Efi Fogel 2db235b36f cleanup 2012-10-15 16:17:28 +00:00
Efi Fogel 173049c72e cleanup 2012-10-15 16:14:33 +00:00
Efi Fogel 877ce54fc9 changed back some code 2012-10-15 16:14:14 +00:00
Efi Fogel 3c6411f41c cleanup and added assertion 2012-10-15 16:13:36 +00:00
Efi Fogel c1253cb8b5 fixed a bug that shows up when a curve that reaches the boundary is also an an antena 2012-10-15 08:08:55 +00:00
Efi Fogel 60baa4222d Replaced Arrangement with Arrangement_on_surface 2012-10-10 16:38:26 +00:00
Eric Berberich 1b1e5ea39f various cleanup tasks 
- typos
- reduce verbosity
 2012-10-08 12:41:00 +00:00
Eric Berberich ae53d74af4 fix of subcurves assigned to top face 
The correct thing is to re-assign subcurves starting on the left boundary
from the top face to another subcurve 'larger' in the status line when we
insert this larger curve. Only the topmost subcurve of the status line
after processing the left boundary should be assigned to the top face
We also added a new members (halfedge_indices_list) to helper classes and 
subcurve. It is open whether insertion/overlay visitor need the same fix
 2012-10-08 12:27:19 +00:00
Ophir Setter ccb742fba0 * Removing Arr_vertex_property_map and Arr_face_property_map. 
* Adding documentation for Arr_face_index_map and Arr_vertex_index_map.
* Improving examples of BGL.
 2012-10-05 17:29:41 +00:00
Eric Berberich 51599d5bb3 added remark 2012-10-01 21:37:46 +00:00
Eric Berberich 181de78122 some cleanup 2012-10-01 21:33:28 +00:00
Eric Berberich 5112dbdaab improved remark 2012-09-28 11:52:17 +00:00
Eric Berberich 838f495582 phrasing improvement 2012-09-24 07:40:17 +00:00
Eric Berberich 5b3f9330ec the x-index needs a correction in some cases, when stored with a local minimum 2012-09-23 15:05:42 +00:00
Eric Berberich a6da5944fd relying on local minima does not require to check direction of curves anymore 2012-09-20 12:20:44 +00:00
Efi Fogel 20afae72e6 fixed typo 2012-09-18 22:40:28 +00:00
Efi Fogel 5b2f07e536 removed erroneous assertion 2012-09-18 22:31:48 +00:00
Eric Berberich 1de4431159 fixed typo 2012-09-04 07:10:44 +00:00
Eric Berberich 18b9097287 removed old code 2012-08-22 21:24:42 +00:00
Eric Berberich 9bcfe3f543 removed a compiler warning && || 2012-08-22 21:24:08 +00:00
Eric Berberich c06575dc75 two fixes: indices + codefactoring 
1) when deleting he1/he2 the start of the two loops might
lie on different sides of the identification, we added
a fix
2) the _compute_sign_and_local_minima for a closed loop
now also uses the _compute_indices function
 2012-08-21 22:11:39 +00:00
Efi Fogel c8cabda314 inserting minima at the back so that if NULL is inserted it is always at the front 2012-08-17 01:10:29 +00:00
Efi Fogel 61bc918ef3 unfolded the loop in _compute_signs_and_local_minima 2012-08-17 00:53:08 +00:00
Efi Fogel 38034d615d unfolded the loop in _compute_signs_and_local_minima 2012-08-17 00:52:30 +00:00
Efi Fogel 6085ea8d58 cleanup 2012-08-16 22:35:04 +00:00
Eric Berberich fe61fd5f72 added TODO 2012-08-08 15:18:31 +00:00
Eric Berberich a379550e7b correct sign 2012-08-08 15:12:58 +00:00
Eric Berberich 093a15f156 more putput 2012-08-08 14:47:37 +00:00
Eric Berberich 4f68658679 fixed loop in _compute_signs_and_local_minima for closed cycles 
There are two variants: f1 == f2 and f1 != f2
In the second case he1 and he2 form closed outer ccbs that will be 
merged into one, in the first case, the removal of he1/he2 splits 
a single ccb into two (and we simulate to walk these two already)
Comment: test03 in spherical_removal does not yet work, everything 
else is ok
 2012-08-08 12:42:05 +00:00
Eric Berberich e3c59a5a08 added TODO 2012-08-07 16:04:45 +00:00
Eric Berberich ae11cc5e90 removed subsumed code 2012-08-07 15:51:44 +00:00
Eric Berberich d9014e1962 implement boundaries of same face in terms of comparing signs of ccbs 
the case for torus is not yet covered
 2012-08-07 15:50:59 +00:00
Eric Berberich 1716d3434a removed old Sign_of_path 2012-08-07 15:26:18 +00:00
Eric Berberich f486fffb8e prepare to compare signs to be used for 'boundaries of same face' 
also clean up: remove sign_of_path
 2012-08-07 15:25:16 +00:00
Eric Berberich aa8066d7db some documentation 2012-08-07 14:37:04 +00:00
Eric Berberich 77b79f3dda merge from next 2012-08-07 13:52:31 +00:00
Eric Berberich 0ecdae3143 removed old cold 2012-08-07 13:30:44 +00:00
Eric Berberich 5404590424 moved swapping for he with he->opposite on edge removal into _remove_edge 
Rationale: swapping requires to compute signs of ccbs, which will be
used in _remove_edge again (for hole_creation)
 2012-08-07 13:24:09 +00:00
Efi Fogel 6d9973d15d updated 2012-08-07 09:46:18 +00:00
Eric Berberich 16404bbc57 topology traits function face_split_after_edge_insertion now works with signs of implied ccbs 2012-08-06 09:49:28 +00:00
Eric Berberich cd16c29d63 first step to replace cmp with cv_dir 2012-08-06 09:29:39 +00:00
Eric Berberich 76f897b6ed cleanup and rename of prev1_on_outer_ccb_and_not_prev2 to swapped_predecessors 
The variable got a passive interpretation now, as it is the output of
_insert_at_vertices
 2012-08-06 09:22:36 +00:00
Eric Berberich 1ef730fd7b moved swapping of predecessor halfedges into _insert_vertices 
needed two adaptions in its signature:
1) add new bool-by-reference which returns whether swapping took place
2) add new bool which determines whether swapping is allowed (true by default)
Changes in Env_3 and Bsop_2 are still needed
 2012-08-05 22:29:45 +00:00
Eric Berberich 1bd5a4b24b typo 2012-08-05 14:18:27 +00:00
Laurent Rineau 4c3e1c3138 Fix mixed eol styles 2012-08-02 13:35:03 +00:00
Laurent Rineau b6acb44b19 Fix mixed eol styles introduced by the licenses change scripts 2012-08-02 12:48:04 +00:00
Laurent Rineau db194534c7 First big patch to fix -Wunused-local-typedefs 
-Wunused-local-typedefs is a new warning flag of gcc-4.7, and it will enabled
 by -Wall since gcc-4.8 (not yet released).

The fix is a big set of removals of unused typedefs (or comments, or moves,
depending on the context).
 2012-08-01 13:29:16 +00:00
Eric Berberich 055c05fea6 added TODOs 2012-07-30 13:07:19 +00:00
Eric Berberich 33395deadb cleanup 2012-07-30 10:03:16 +00:00
Eric Berberich 29686283f1 in analogy to open loop, implemented closed loop with local-minima 2012-07-30 00:38:50 +00:00
Eric Berberich cc5ccff503 the loop now considers all edges (fixes a bug) 2012-07-28 14:02:10 +00:00
Eric Berberich 49d70d691a made loop to compute signs and local minimal more readable 
removed special first and last iteration, unified in one loop 
with two initial iterations for to,cv and cv,away, only then 
next pointer is used

test_construction still fails
 2012-07-27 17:24:12 +00:00
Eric Berberich 3283cec4fe make signature he_to=>cv,cv_dir=>he_away 2012-07-27 12:05:49 +00:00
Eric Berberich 7b89d3a4f2 sorted code 2012-07-27 01:36:41 +00:00
Eric Berberich a7d3ff0f22 started refactorization of sign of ccb computations 
- introduced _compute_signs_and_local_minima
- enhanced _defines_outer_ccb_of_new_face with local-minima-range
-- it also computes the global leftmost vertex of a ccb
cd >> both are based on now deprecated _find_leftmost_vertex_on_open_loop function
- introduced m_topol_traits.let_me_decide_the_outer_ccb
- rename prev1_before_prev2 -> prev1_on_outer_ccb_and_not_prev2
- added TODOs for _insert_at_vertices and (_)remove_edge
- missing: to-cv-away semantics in some functions
- TODO remove std::couts
- TODO some documentation
* all tests work
 2012-07-27 01:26:41 +00:00
Eric Berberich 8bce1e9edb new name of internal function 2012-07-26 23:23:06 +00:00
Eric Berberich 11cf8461a7 added new impl 2012-07-26 14:15:22 +00:00
Efi Fogel 68e7cd9cd7 cleanup 2012-07-25 15:23:29 +00:00
Eric Berberich c88bb26f3a fix bug: order of arguments wrong 2012-07-25 15:22:19 +00:00
Efi Fogel 46f3c87630 integrated next 2012-07-25 13:27:34 +00:00
Eric Berberich 92e6e55416 access to infinite endpoint is not granted, added guards 2012-07-19 11:59:12 +00:00
Michael Hemmer 254aa83353 fix conversion problems 2012-07-19 10:18:12 +00:00
Efi Fogel 9cfc2e8634 updated 2012-07-18 16:43:03 +00:00
Efi Fogel 2f079bbf85 updated 2012-07-18 14:36:41 +00:00
Eric Berberich ee7da1d7fc fixed an error that showed up after correctly adding a precond to Split_2 functor in r70397 2012-07-18 09:20:29 +00:00
Efi Fogel 7de493a026 updated 2012-07-16 19:20:53 +00:00
Efi Fogel 0137778ac8 updated 2012-07-16 16:40:52 +00:00
Efi Fogel 800d182fc3 updated 2012-07-16 15:00:23 +00:00
Efi Fogel 4d778fdf93 updated 2012-07-12 12:30:29 +00:00
Efi Fogel 0bf53287f5 updated 2012-07-11 20:15:00 +00:00
Efi Fogel f687a9d8a0 updated 2012-07-09 08:09:48 +00:00
Michael Hemmer 2ebc7d78c5 fix problems with leda real 2012-07-08 12:05:05 +00:00
Eric Berberich f87bbe2479 cleanup code as indicated by compiler warnings 2012-07-08 10:47:58 +00:00
Eric Berberich bc4ca5b218 silent some compiler warnings 2012-07-08 10:30:22 +00:00
Eric Berberich 42d9d930ac it's a precondition not precondition_code 2012-07-08 10:24:27 +00:00
Eric Berberich 4ef408a60c removed some unneded friends 2012-07-07 14:57:44 +00:00
Eric Berberich d9eb0e8ece Intel compiler does not like typename friends 
error: friend class name may not be introduced with "typename"
So reverted change
 2012-07-07 08:17:07 +00:00
Efi Fogel 2184d52c1c cleanup 2012-07-06 12:08:40 +00:00
Efi Fogel 2233dc9dd8 fixed a bug found by Victor Lopez 2012-07-06 11:56:14 +00:00
Eric Berberich 5443e86fd4 class seems to only work for g++ in a friend 
This is not the correct fix; a correct one changes the friend 
design of the classes
 2012-07-06 06:53:30 +00:00
Efi Fogel 0dc8526f64 added missing include statement 2012-07-05 11:06:58 +00:00
Efi Fogel 952f89e7d5 cleanup 2012-07-04 15:29:02 +00:00
Efi Fogel 15e2cad2f7 merged from next 2012-07-04 12:54:27 +00:00
Efi Fogel 9561bdc1b0 cleanup 2012-07-01 15:11:31 +00:00
Efi Fogel e3727e9c20 merged next 2012-07-01 05:53:44 +00:00
Efi Fogel 29491b5f56 cleanup 2012-06-30 23:35:30 +00:00
Efi Fogel 95a9372721 merged next 2012-06-30 23:11:26 +00:00
Efi Fogel 349cb198d9 cleanup 2012-06-30 22:52:28 +00:00
Efi Fogel 6058295b42 cleanup 2012-06-28 21:35:44 +00:00
Efi Fogel d698e7dd79 cleanup 2012-06-28 06:05:38 +00:00
Efi Fogel 7c31216491 cleanup 2012-06-27 12:36:34 +00:00
Philipp Möller e3d53ae16c Also use typename on clang. This is the same fix as the previous one. 
That code will still not work should someone use -std=c++03 on clang
and a more substantial fix should be done.
 2012-06-26 15:49:41 +00:00
Philipp Möller ff418f7695 Also use typename with clang. 2012-06-26 15:07:10 +00:00
Efi Fogel 7504ef7697 remove 2012-06-26 12:09:55 +00:00
Michal Kleinbort 6af7e30a62 commented debug print and changed -1 to false in several test methods 2012-06-26 11:59:10 +00:00
Michal Kleinbort b90a77694d deleted commented lines 2012-06-25 15:17:54 +00:00
Michal Kleinbort 9adc16b8d6 remove curve_end() method from AOS2 - step3 2012-06-25 15:05:41 +00:00
Michal Kleinbort 1183de2fb6 remove curve_end() method from AOS2 - step2 2012-06-25 14:36:20 +00:00
Michal Kleinbort 6e16b39c0b remove curve_end() method from AOS2 - step1 2012-06-25 14:15:07 +00:00
Michal Kleinbort f3246439fa remove min_vertex and max_vertex from Arrangement_on_surface_2.h 2012-06-25 13:35:48 +00:00
Michal Kleinbort 89c0946cda put debug method in remark 2012-06-25 13:34:58 +00:00
Michal Kleinbort 1dbfd98e6c comment unused 2012-06-25 10:33:59 +00:00
Michal Kleinbort bba0609a3f use templates again 2012-06-25 08:35:44 +00:00
Michal Kleinbort 5a02948f00 add typename 2012-06-25 08:28:49 +00:00
Michal Kleinbort e3a1aa0ce4 replace te,plate with two variants 2012-06-25 08:17:41 +00:00
Michal Kleinbort 45aab950ec template updates and vertical ray shooting fixes 2012-06-25 07:38:23 +00:00
Michal Kleinbort a29d327702 minor include/CGAL/Arr_point_location/Trapezoidal_decomposition_2.h include/CGAL/Arr_point_location/Arr_trapezoid_ric_pl_impl.hupdates 2012-06-24 10:46:39 +00:00
Alex Tsui d6670b2c70 Fixed bugged usage of ArrangementPainterOstream. 2012-06-24 05:12:22 +00:00
Michal Kleinbort ff72eab987 vertical ray shoot fix7 2012-06-21 14:41:07 +00:00
Michal Kleinbort 3afc8fa1c1 vertical ray shoot fix6 2012-06-21 12:54:34 +00:00
Michal Kleinbort 958573cab1 vertical ray shoot fix5 2012-06-21 12:40:20 +00:00
Michal Kleinbort 3cd19f15c3 vertical ray shoot fix4 2012-06-21 12:35:54 +00:00
Michal Kleinbort e37eec7d87 vertical ray shoot fix3 2012-06-21 12:25:14 +00:00
Michal Kleinbort aedb2cefb4 vertical ray shoot fix2 2012-06-21 12:16:32 +00:00
Michal Kleinbort 0080da0219 vertical ray shoot 2012-06-21 11:39:29 +00:00
Efi Fogel b6cace64a9 fixed the case where the x (resp. y) ranges is discrete 2012-06-20 13:30:45 +00:00
Michal Kleinbort 009824d641 merge next into RIC-PL feature branch 2012-06-19 21:01:44 +00:00
Michal Kleinbort 9b4a221a66 updates before merging next 2012-06-19 09:17:00 +00:00
Michal Kleinbort e75edb8582 fix for debug 2012-06-19 06:25:01 +00:00
Michal Kleinbort 5ecff5efe9 minor update 2012-06-18 21:05:44 +00:00
Michal Kleinbort 5213b43301 new updates before integration (1) 2012-06-18 12:17:52 +00:00
Michal Kleinbort 2026405784 remove (again) around point circulator 2012-06-18 12:16:27 +00:00
Alex Tsui 7ba8b08c4d Implemented insertion and removal of segments to arrangements. 2012-06-15 05:28:38 +00:00
Efi Fogel 9be779e881 updated 2012-06-14 14:16:53 +00:00
Efi Fogel 898db0b123 updated 2012-06-14 13:20:29 +00:00
Efi Fogel 43e7659492 updated 2012-06-13 15:04:05 +00:00
Alex Tsui 5383a462f3 Implemented skeleton ArrangementGraphicsItem and basic mouse event callback 2012-05-27 06:08:22 +00:00
Philipp Möller d3ee04897c merged next 2012-05-09 13:50:00 +00:00
Efi Fogel 6d6d7e607d updated 2012-05-03 08:51:54 +00:00
Efi Fogel 29da4018dc updated 2012-05-02 16:03:30 +00:00
Efi Fogel e32227ad45 updated 2012-05-02 16:00:46 +00:00
Efi Fogel 0674993246 updated 2012-05-01 18:53:37 +00:00
Efi Fogel 8a98624f92 updated 2012-04-30 13:46:58 +00:00
Philipp Möller 17797b7271 Merge next into this branch. There have been conflicts in the 
AABB_tree documentation, Intersections_3 and Arrangement_on_surface_2.

The merge also introduced a regression for a bug fixed in R68387 which
fixed a bug in Triangle_3 Segment_3 intersections. The relevant
testcase is in triangle_other_intersection_test.cpp.
 2012-04-24 15:06:19 +00:00
Philipp Möller 3889dc2d7f BUGFIX Fixed the leak of an empty memory block. 2012-04-17 12:03:00 +00:00
Efi Fogel 1f174c0d26 updated 2012-04-14 22:24:55 +00:00
Philipp Möller 8f1ce2412c Removed all places where the CGAL_CFG_NO_TMPL_IN_TMPL work-around was 
used. Those were mostly in Polyhedron and HalfedgeDS but some places
in Arrangement_2 used it, too. Neither of the parts of Arrangement_2
have been documented.
 2012-04-13 13:13:30 +00:00
Efi Fogel 22f962662b updated 2012-03-28 16:00:43 +00:00
Michal Kleinbort 270b75ff2a updated the longest query path length menthod 2012-03-28 10:25:50 +00:00
Efi Fogel 9a11c7b9a9 updated 2012-03-28 08:37:09 +00:00
Efi Fogel daa9b5d6c9 updated 2012-03-26 16:02:14 +00:00
Efi Fogel e6008e4731 added missing inline 2012-03-21 22:14:40 +00:00
Efi Fogel b845684397 updated 2012-03-21 16:13:09 +00:00
Efi Fogel 11cddc2172 updated 2012-03-08 14:23:13 +00:00
Efi Fogel 17450c247d updated 2012-03-08 14:11:46 +00:00
Efi Fogel b7a76a8c3a updated 2012-03-08 14:02:54 +00:00
Efi Fogel db67bab07e updated 2012-03-04 17:01:26 +00:00
Efi Fogel c031c9e2c4 updated 2012-02-29 22:39:32 +00:00
Efi Fogel 74f1dee4a6 updated 2012-02-27 15:27:27 +00:00
Efi Fogel 3a00f570ea Added io ops 2012-02-21 22:06:51 +00:00
Efi Fogel c9e721511d Replace Object 2012-02-12 22:52:34 +00:00
Efi Fogel e25e73a5f5 Replace Object 2012-02-09 23:46:31 +00:00
Efi Fogel 5a7309f692 Replaced Object 2012-02-09 16:21:01 +00:00
Michal Kleinbort 3fbd7108dc fix empty_handle bug 2012-02-08 08:47:52 +00:00
Michal Kleinbort 62247209a1 clear trapezoid neighbors before deleting the dag_node. removing irrelevant files 2012-02-08 08:39:29 +00:00
Michal Kleinbort c78295944f remove extra he handle for td_vertices 2012-02-07 22:12:45 +00:00
Michal Kleinbort f49f77552c remove around_point_circulator and update edge & vertex neighbors 2012-02-07 21:16:20 +00:00
Efi Fogel 4a20a898d7 replaced Object 2012-02-07 13:57:36 +00:00
Efi Fogel 178e7a89a5 replaced Object 2012-02-07 13:45:10 +00:00
Efi Fogel 3f021c72df replaced Object 2012-02-07 09:43:54 +00:00
Efi Fogel 15e766a59d replaced CGAL::Object 2012-02-06 17:14:16 +00:00
Efi Fogel 40fac7ad31 replace Object 2012-02-06 10:15:38 +00:00
Efi Fogel 033a9ee31f Added missing signature required to build in debug mode 2012-01-31 14:27:24 +00:00
Sébastien Loriot fd735eb438 fix typo in class name 2012-01-31 07:09:24 +00:00
Efi Fogel 1e9ca50134 fixed 2 bugs related to events on an identified boundary 2012-01-26 15:40:29 +00:00
Michael Hemmer 8042e3bc29 nil -> Td_nothing 2012-01-26 09:13:46 +00:00
Michal Kleinbort f14ad798fc A Linux compiling version 2012-01-25 19:31:44 +00:00
Efi Fogel 19384995de pacify some compiler & cleanup 2012-01-25 10:33:50 +00:00
Michael Hemmer 8d762bb03e removed a cout 2012-01-24 13:50:23 +00:00
Michal Kleinbort 61367c0b1a some changes in td types 2012-01-24 12:06:39 +00:00
Efi Fogel 0d9f5aa107 replace Object 2012-01-23 15:08:58 +00:00
Efi Fogel f669df07bf replace Object 2012-01-23 13:55:36 +00:00
Michal Kleinbort 021ee51ac8 working version 2012-01-19 08:31:35 +00:00
Michal Kleinbort 4b89d0750f Running version , with empty item in variant 2012-01-18 11:50:34 +00:00
Efi Fogel 1c0590aff9 pacify some compiler 2012-01-16 14:53:30 +00:00
Efi Fogel 9ff1458ad4 pacify some compiler 2012-01-16 14:53:13 +00:00
Efi Fogel 21fafef0b6 pacify some compiler 2012-01-16 14:52:48 +00:00
Laurent Rineau 8f59fd9592 Turn QPL into LGPLv3+ 2012-01-13 16:33:35 +00:00
Laurent Rineau 506f2f0127 Fix typos in "This file is part of CGAL..." 2012-01-13 16:14:28 +00:00
Laurent Rineau 4ea497c28c merge changes from next 2012-01-09 17:24:49 +00:00
Efi Fogel 020e29421a cleanup 2012-01-09 15:33:46 +00:00
Efi Fogel 38448d4a07 fixed x-comparison of a point and and a curve-end with an interior y parameter space 2012-01-09 15:20:47 +00:00
Laurent Rineau 5b5dd33848 merge changes from next 2012-01-09 12:33:39 +00:00
Michal Kleinbort 751f44787b Added nil to variant, before removing the boost::optional 2012-01-08 11:09:52 +00:00
Michal Kleinbort 7ece7b3c83 rep is now an inner class of each handle, compiling, not running 2012-01-08 10:04:28 +00:00
Efi Fogel d2fc6f7fe3 cleanup 2012-01-05 14:24:13 +00:00
Michal Kleinbort b1a5bda2da First compiling version with seperate classes 2012-01-04 16:22:17 +00:00
Michal Kleinbort fe331f99ba Add and update print methods 2011-11-30 09:24:01 +00:00
Michal Kleinbort af99b0d117 added longest query path length method and change operator! of td_dag_node to is_null() 2011-11-16 12:00:05 +00:00
Michal Kleinbort bd8579bd2a added debug data 2011-11-16 11:54:55 +00:00
Michal Kleinbort b5675d5afa Few updates to some td_traits methods 2011-11-16 11:52:47 +00:00
Efi Fogel 0ed3305f2a fixed a typo 2011-11-09 16:32:02 +00:00
Efi Fogel 22be584197 fixed a typo 2011-11-09 16:12:44 +00:00
Michal Kleinbort 65170e87ec range-insert method for Trapezoidal_decomposition_2 , thrs constant update 2011-11-07 10:54:44 +00:00
Michal Kleinbort 0f54ff686e Allowing Arr_trapezoid_ric_point_location to set the threshold constnts of Trapezoidal_decomposition_2, and also some couts for debug 2011-11-02 11:57:29 +00:00
Michael Hemmer bac7c64579 update from next 2011-10-31 13:02:16 +00:00
Michal Kleinbort fe3925b0c8 Maintain largest-leaf-depth and number-of-dag-nodes 2011-10-30 19:25:41 +00:00
Michal Kleinbort ec9fc196dc Maintain largest-leaf-depth and number-of-dag-nodes 2011-10-30 19:20:14 +00:00
Michal Kleinbort 2213e7ee75 Maintain largest-leaf-depth and number-of-dag-nodes 2011-10-30 19:10:21 +00:00
Michal Kleinbort 6789da244f Maintain largest-leaf-depth and number-of-dag-nodes 2011-10-30 13:10:33 +00:00
Laurent Rineau 6ced1782d0 merge from next 2011-10-28 12:36:01 +00:00
Eric Berberich c1119ac9fb Bugfix: skip common left point only on boundary 2011-10-27 11:41:18 +00:00
Eric Berberich a8f40bf65c Bugfix: Returned mix/max vertex had no assigned red or blue objects in some cases 2011-10-27 08:49:55 +00:00
Eric Berberich a3b0734abd Bugfix: not all cases of overlaps were found when adding a curve to the left of an event (wrong overlap-hierarchy-traversal) 2011-10-27 08:36:38 +00:00
Eric Berberich 6aebc5da93 improved output for debugging 2011-10-27 08:30:53 +00:00
Laurent Rineau 6ed56d75b5 merge from next 2011-10-25 15:48:02 +00:00
Andreas Fabri f1403b52e8 size_t -> unsigned int 2011-10-24 10:50:14 +00:00
Andreas Fabri acb6283b97 Undo int>size_t changes and do static_cast<int> instead 2011-10-24 10:13:48 +00:00
Laurent Rineau cfd37935cf merge from next 2011-10-20 16:04:32 +00:00
Andreas Fabri eea6d0df2b int -> std::size_t 2011-10-20 10:27:56 +00:00
Michal Kleinbort 4ce6da87e2 add dag debug method 2011-10-17 11:34:19 +00:00
Michal Kleinbort e0a0eb08a3 unbounded RIC feature 2011-10-10 17:39:43 +00:00
Michal Kleinbort 6280120cbc unbounded RIC feature 2011-10-10 17:39:22 +00:00
Michal Kleinbort 6b126ba221 unbounded RIC feature 2011-10-10 17:39:11 +00:00
Michal Kleinbort 25fc3ecbf1 unbounded RIC feature 2011-10-10 17:38:50 +00:00
Michal Kleinbort 6cb72503ba unbounded RIC feature 2011-10-10 17:38:30 +00:00
Michal Kleinbort f4c841f61d unbounded RIC feature 2011-10-10 17:38:13 +00:00
Michal Kleinbort ceb5341686 unbounded RIC feature 2011-10-10 17:37:50 +00:00
Michal Kleinbort 85afe718a2 unbounded RIC feature 2011-10-10 17:17:27 +00:00
Michal Kleinbort 9df4f33b0c unbounded RIC feature 2011-10-10 17:12:13 +00:00
Michal Kleinbort 5982247ded unbounded RIC feature 2011-10-10 17:10:38 +00:00
Michal Kleinbort 70e02a623a unbounded RIC feature 2011-10-10 17:10:19 +00:00
Michal Kleinbort 135d94adb6 unbounded RIC feature 2011-10-10 17:09:47 +00:00
Michal Kleinbort c43364ce49 unbounded RIC feature 2011-10-10 17:09:09 +00:00
Michal Kleinbort 51b20e7ff4 unbounded RIC feature 2011-10-10 17:06:59 +00:00
Michal Kleinbort 4276e8a08a unbounded RIC feature 2011-10-10 17:05:29 +00:00
Michal Kleinbort d408aec32a unbounded RIC feature 2011-10-10 17:04:38 +00:00
Michal Kleinbort 3154d21bf5 unbounded RIC feature 2011-10-10 17:03:00 +00:00
Sébastien Loriot 91a5327fa8 change LGPLv2 -> LGPLv3 2011-10-10 13:48:25 +00:00
Michal Kleinbort 48f80b6bfc new protected method: _compare_induced_path_length 2011-10-09 20:07:02 +00:00
Michal Kleinbort 7ea1a448bc new protected method: _compare_induced_path_length 2011-10-09 20:06:38 +00:00
Guillaume Damiand a29c905ee0 Replace BOOST_STATIC_ASSERT by CGAL_static_assertion. 2011-08-31 14:30:07 +00:00
Sébastien Loriot 30e61afa0a add debug macro to indicated when an event is updated 
remove extra;
add a comment
 2011-08-30 16:00:03 +00:00
Efi Fogel 5a9e13452f fixed a bug where a deleted event was accessed 2011-08-30 13:15:42 +00:00
Efi Fogel 9e2a08d5b1 typo 2011-08-30 12:57:14 +00:00
Efi Fogel 4b3e103686 Fixed ArrangementXMonotoneTraits_2 and ArrangementDirectionalXMonotoneTraits_2 concepts 2011-08-28 09:59:40 +00:00
Michael Hemmer a5b09f4197 enable output operators independent from SL_VERBOSE 2011-08-25 13:37:54 +00:00
Michael Hemmer 5b2086938d bug fix 
during relocation of inner ccbs it may happen that the the outer ccb 
still contains vertices at TOP/BOTTOM that do not have a curve assigned yet
we simply jump over them as if there where not created yet
remark: easy fix, hard to find !
 2011-08-25 12:07:42 +00:00
Efi Fogel 26fdabe05e Fixed friend statements to pacify MSVC 9 2011-08-18 20:24:05 +00:00
Michael Hemmer dc6335559d revert unintended commit 2011-08-18 13:12:10 +00:00
Michael Hemmer d93ed35b8b added missing Multiplicity 2011-08-18 09:08:58 +00:00
Michael Hemmer 957c8d7c86 fix Multiplicity issues not covered by test in Arrangement/test 2011-08-15 11:23:04 +00:00
Michael Hemmer 5b1d63333b remove traces of vertical segment support, which was incomplete 2011-08-15 11:15:32 +00:00
Michael Hemmer 0ad1081f53 consistent use of Multiplicity 2011-08-14 14:34:22 +00:00
Efi Fogel 3eaef74439 leftover from the Rational-arc traits 2011-08-14 14:02:19 +00:00
Efi Fogel f97f426d65 removed redundant mutable qualifier and cleanup 2011-07-11 10:15:31 +00:00
Laurent Rineau 6896dc38d7 Better use of deprecation_warning.h 2011-07-06 15:57:54 +00:00
Michael Hemmer bce1a1fffa use CGAL/internal/deprecation_warning.h 2011-07-06 15:35:19 +00:00
Michael Hemmer dc1b486cca fix const issues 
fix clean up order in cache
 2011-06-29 14:18:09 +00:00
Efi Fogel 95b31f9fd6 removed non const traits retrieval function 2011-06-29 07:41:40 +00:00
Efi Fogel 792757673b Added missing const 2011-06-28 21:09:54 +00:00
Efi Fogel c5e8783557 Pacify MSVC 2011-06-28 15:12:42 +00:00
Efi Fogel 5542b199bc added missing const 2011-06-25 12:59:54 +00:00
Efi Fogel 539162977f cleanup 2011-06-24 09:43:57 +00:00
Efi Fogel 373193ee5d Added result_type 2011-06-23 23:02:56 +00:00
Efi Fogel 309cf4113a renamed *_boundary_* => *_parameter_space_* 2011-06-23 23:01:03 +00:00
Efi Fogel 4c8d099393 Added qualifiers to pacify some g++ versions 2011-06-23 11:49:10 +00:00
Efi Fogel 732442db65 cleanup 2011-06-23 08:03:02 +00:00
Efi Fogel 3746eccf1d cleanup 2011-06-22 14:01:35 +00:00
Efi Fogel 1f44224491 small fixes and cleanup 2011-06-22 12:51:20 +00:00
Efi Fogel 115b376672 small fixes and cleanup 2011-06-22 12:28:01 +00:00
Oren Salzman 4935c54c01 bug fixes 2011-06-21 21:36:48 +00:00
Michael Hemmer 530955245e fixed for manual 2011-06-21 08:28:10 +00:00
Efi Fogel 3121279ea7 pacify g++ 2011-06-21 08:21:43 +00:00
Efi Fogel efe448faaf added missing typedefs 2011-06-21 07:57:37 +00:00
Efi Fogel 79b73f0084 fixed typo 2011-06-20 13:20:55 +00:00
Efi Fogel e9eda73bcc cleanup & passed kernel as argument 2011-06-20 09:58:35 +00:00
Efi Fogel 3b19f90449 Pacify g++ 2011-06-19 12:14:52 +00:00
Oren Salzman 417c76d604 bug fix for cache copy 2011-06-15 14:30:26 +00:00
Oren Salzman d624e52bd8 updated constructors 2011-06-15 11:52:32 +00:00
Oren Salzman 8e89cb5b7d updated constructors 2011-06-15 11:52:02 +00:00
Efi Fogel 9f9e8046c3 Used the new rational function traits as the default traits for the corresponding curve 2011-06-12 15:18:03 +00:00
Oren Salzman aa170306a8 fixed cache bug 2011-06-12 08:34:53 +00:00
Oren Salzman e936a086b7 update print 2011-06-08 18:30:45 +00:00
Eric Berberich 5e8364fbd4 compile fixes + cosmetics 2011-06-07 23:48:32 +00:00
Eric Berberich 26d22ce024 wrong signatures chosen 2011-06-07 14:37:51 +00:00
Efi Fogel 3b49f02cdc fixed category names 2011-06-07 13:31:25 +00:00
Eric Berberich 58e61229c4 Tag -> Category 2011-06-07 02:13:03 +00:00
Eric Berberich 1c08f70313 roll back traits adaptor changes (due to problem with Arr_with_history_2, derivation problem) 2011-06-03 10:47:27 +00:00
Eric Berberich 4abb2c62fe make deprecated 2011-06-03 09:53:39 +00:00
Eric Berberich 749b8fed3f fix years in header from svn 2011-06-03 09:51:23 +00:00
Eric Berberich 76e844898f merge from next 2011-06-01 09:41:17 +00:00
Eric Berberich 98a9bef08f open is not contracted 2011-06-01 09:26:48 +00:00
Eric Berberich 4749bfb7fe removed traits_adaptor redefinition 2011-06-01 09:08:15 +00:00
Oren Salzman 9d21e9cedd updated member variable handling and constructors 2011-06-01 08:33:31 +00:00
Eric Berberich 53c72e785a tag -> category 2011-06-01 08:24:38 +00:00
Eric Berberich 53d9a9c05a removed deprecated function 2011-05-31 18:12:15 +00:00
Eric Berberich a7a06c4e2b replaced Arr_..._side_category with :.._side_category 2011-05-31 18:08:54 +00:00
Efi Fogel dd6194ec15 removed some garbage 2011-05-31 16:43:46 +00:00
Efi Fogel 83a56e9721 Fixes for g++ and cleanup 2011-05-31 16:41:56 +00:00
Eric Berberich 96d4948849 fixed remark 2011-05-31 16:12:20 +00:00
Eric Berberich cea8dc60c6 fix compile error 2011-05-31 12:33:15 +00:00
Eric Berberich 1711568da0 handling of contraction in compare_x_curve_ends 2011-05-31 09:31:49 +00:00
Eric Berberich 07db04d3cf added missing signatures 2011-05-30 14:50:10 +00:00
Eric Berberich 3d36ca2423 use of correct functor 2011-05-30 13:55:21 +00:00
Eric Berberich fc13a07b26 added missing signatures for compare_x_on_boundary 2011-05-30 13:54:58 +00:00
Michael Hemmer 09c2c927e4 run examples in linux + cosmetics 2011-05-30 13:20:08 +00:00
Oren Salzman 3b255863af re-updated manual changes 2011-05-30 08:45:28 +00:00
Oren Salzman a0a6a11438 with .h extension this time 2011-05-30 07:23:43 +00:00
Oren Salzman 7c228e46bf update to manual 2011-05-30 07:19:09 +00:00
Oren Salzman 0e0f13d7c9 updating to manual 2011-05-30 07:17:20 +00:00
Michael Hemmer 4379719cda bug fix for inserted curve with two vertical asymptotes at the top 2011-05-29 06:13:22 +00:00
Efi Fogel 3df239caae fixes for g++ and rational traits 2011-05-25 10:03:57 +00:00
Oren Salzman dd1ffd5fe4 cleaned code 2011-05-22 14:06:50 +00:00
Oren Salzman c42ee37a48 updated bug in algebraic point 2011-05-22 14:01:40 +00:00
Oren Salzman 6efcbaaee4 Support for rational arc traits with vertical segments (not documented) 2011-05-22 07:15:00 +00:00
Oren Salzman 1cec38216b updated cache 2011-05-22 07:07:39 +00:00
Oren Salzman a32102cd7c updated constructors 2011-05-22 07:06:53 +00:00
Sébastien Loriot ba1c543c27 *add non documented conjugate() to Sqrt_extension (root_of_2 testsuite) 
*fix template specialization of Standardise (detected thanks to a bug of gcc-4.1.2)
*add missing template ACDE_TAG and FP_TAG at few places
 2011-05-19 12:15:44 +00:00
Michael Hemmer 76c3c06de9 minor bug fix 
added precondition 
(did not add tmp fix for insertion of curves with both ends at top(or bottom))
 2011-05-18 11:25:16 +00:00
Michael Hemmer 69ef095543 typo - use wrong arc no. 2011-05-12 16:39:43 +00:00
Michael Hemmer 2e80c12b5b Check the right parameter space, namely y 2011-05-12 16:39:11 +00:00
Oren Salzman fd3bfdcd5b updates for submission 2011-05-11 08:10:16 +00:00
Oren Salzman caae7c413f updates for submission 2011-05-11 08:09:50 +00:00
Eric Berberich ccee2bb2e3 merge from test branch 2011-05-04 12:43:11 +00:00
Sébastien Loriot d5c2355419 merge the modification from experimental packages to 
the candidate branch of the feature + few name bug fixes
 2011-04-12 11:34:37 +00:00
Sébastien Loriot e174d79248 Bug fix in merge function of Bezier_x_monotone 2011-04-05 10:47:36 +00:00
Sébastien Loriot 0399f8da12 Bezier traits bug fix 
*identity test of span must be done using directions
 *add a test for identical but opposite spans 
 *add missing make_exact calls
 *special case of has_same_support for vertical bezier
 *special case of _is_in_range for vertical bezier
 *add a do-while loop to increase precision in _exact_vertical_position
 2011-04-05 09:45:14 +00:00
Sébastien Loriot 7927234379 Bezier traits: 
*fix a bug in resultant computation
*a missing originator when using split with an endpoint of a bezier.
 this happen for example when computing the arrangement of a vertical bezier
and another one having its start point on the vertical one
*fix bug in skewbbox intersection in the case of a vertical bezier
 2011-03-18 18:55:54 +00:00
Efi Fogel 8b296bf01c introduced has_outer_ccb(0 in the arr. face 2011-03-09 12:41:47 +00:00
Sébastien Loriot 0ebdccfa4e update URL and Id tag 2011-03-02 14:59:51 +00:00
Sébastien Loriot 0260f405a5 overlap of spans was not detected when equal. 
As a consequence, identical bezier curves was intersected only at one of
extremity (overlap was not detected).
 2011-03-01 14:04:47 +00:00
Sébastien Loriot 1c4d5c4bb9 set the multiplicity of intersection points of bezier curve to unknown 
when it was determined using a control point during de Casteljau subdivision
(when we try to compute approximated intersection points).

update test-suite to set to 0 the multiplicity of bezier segments sharing an endpoint,
add an example of 2 bezier bezier tangent at a control point found during de Casteljau
subdivision. Also add an example of an intersection point of two bezier segments
which multiplicity is 1.
 2011-02-22 15:14:40 +00:00
Michael Hemmer 73c28d947c add is_empty function to indicated that no landmarks where generated 2011-02-21 09:22:44 +00:00
Efi Fogel ced88fe743 cleanup 2011-02-19 19:59:29 +00:00
Sébastien Loriot a7b078cdcf The change I did in r61259 restricted the look-up of intersection 
of bezier curves with parameters in range  [0,1]. I need to change also the pairing
of parameters as a parameter s  in the range [0,1] for one curve may correspond to
a parameter t outside the range (so the number of s and t values may be different).
To handle this problem, we choose the list with less parameter values and make the
pairing with the other values.
Note that on the test-suite, this divided by 3 the time needed to compute
the intersection of the two polygons.
 2011-02-18 10:41:22 +00:00
Sébastien Loriot 93238731cd *allow duplicate control points for Bezier curves. 
After checking, it appears that everything is done at the polynomial
level in the code and should be fine (after having fixed the solver
to find roots in [0,1]). Modify a test file to use duplicated control points.

*forgot to generate exact representation of input in case they
were just approximations.
 2011-02-16 15:10:34 +00:00
Eric Berberich 9df4a09926 fixed friend (AF remark) 2011-02-10 01:28:44 +00:00
Eric Berberich 3f767e6309 fixed CERR -> CKvA_ERROR 2011-02-10 01:25:36 +00:00
Sébastien Loriot fe14f0c121 correct but in Bezier_x_monotone::point_poisition in the case 
the bezier is a vertical or horizontal segment.
This fix showed a probable bug in expected result of the testsuite:
 In the case the bezier is a vertical segment,
 compare_y_at_x now returns EQUAL when the query point
 is inside the segment.
 2011-02-09 17:38:10 +00:00
Sébastien Loriot 263ff08e7d correct buggy comment 2011-02-07 15:43:37 +00:00
Sébastien Loriot eff6c7b647 bug fix in the case the query point is a rational "user made" 
the case of a algebraic "user made" is not solved.
 2011-02-04 11:22:23 +00:00