Commit Graph

2419 Commits

Author SHA1 Message Date
Efi Fogel 2ee127aea8 Merge branch 'Aos_2-polyline_upgrade-fub' of ssh://scm.cgal.org/var/git/cgal into polyline 2013-07-22 18:10:04 +03:00
Efi Fogel 88fcfbf9c5 Continue the implementation for poly-geodesics 2013-07-22 18:09:42 +03:00
Dror Atariah 1de7e99f11 Update documentation.
Mainly:
- Modeling ArrangementLandmarkTraits
- Polishing the case of discontinuous or not well-oriented polyline
2013-07-22 16:06:52 +02:00
Efi Fogel 3bd5215150 Made the polyline traits a practical model of the ArrangementLandmarkTraits concept only if the segment traits is a model of this concept 2013-07-22 15:01:36 +03:00
Efi Fogel d6a7413cdb Made the polyline traits a practical model of the ArrangementLandmarkTraits concept only if the segment traits is a model of this concept 2013-07-22 14:58:11 +03:00
Eric Berberich aa414b9ed5 fixed years 2013-07-22 09:33:21 +02:00
Eric Berberich 64f98fa6c7 removed old code 2013-07-22 09:33:21 +02:00
Dror Atariah 2787def18a Changed grouping of Landmark's approximate functor 2013-07-22 09:13:03 +02:00
Dror Atariah 7dd3f395e2 Improved the documentation.
In particular:
- Reflected the more general segment traits that can be used
- That the construction functor of an x-polyline return a left-to-right
oriented polyline.
2013-07-21 18:27:02 +02:00
Dror Atariah 384966d99d Improved the construction of x-polylines when CGAL_ALWAYS_LEFT_TO_RIGHT is on
In particular, when CGAL_ALWAYS_LEFT_TO_RIGHT is on, then the
construction functor returns an x-polyline which is oriented from left-to-right.
2013-07-21 18:25:24 +02:00
Dror Atariah 4e71ed41be Cleaned the example polylines.cpp 2013-07-21 18:18:12 +02:00
Efi Fogel aee694b391 Fixed _hole_creation_on_edge_removal() 2013-07-21 18:09:39 +03:00
Dror Atariah 1ba60a7607 Improved the example polylines to demonstrate construction from segments 2013-07-21 15:36:23 +02:00
Efi Fogel c935bfb236 Added support for boundary conditions 2013-07-21 15:49:56 +03:00
Eric Berberich cdc17064f5 replaced top_traits.hole_creation... with general _hole_creation... 2013-07-18 14:54:37 +02:00
Efi Fogel 58b8ecd090 Kept only one reference to the traits 2013-07-14 16:38:15 +03:00
Efi Fogel 57101ce35d Integrated with a recent version master 2013-07-14 14:40:09 +03:00
Efi Fogel 9e610d76d9 Passed the traits all the way to IO_base_test, so that it can be used to construct points, curves, and x-curves 2013-07-13 09:36:36 +03:00
Efi Fogel bfeb3de255 Passed the traits all the way to IO_base_test, so that it can be used to construct points, curves, and x-curves 2013-07-12 01:39:56 +03:00
Dror Atariah d30f8d93e7 Updated the documentation - reflect the generality of general polyline
This update documents the generalization of the possible segments that
can be used as the segments of a polyline. In particular, the
possibility to have non x-monotone segments.
2013-07-11 08:08:59 +02:00
Dror Atariah cf68065108 Added precondition tests from Make_x_monotone_2 and improved doc's 2013-07-10 18:09:14 +02:00
Dror Atariah 546f07550b Fixed the namespace of Polyline_2 2013-07-10 18:07:16 +02:00
Sébastien Loriot d4d9bc212b replace in the doc \R by \mathbb{R}
\R is not a valid latex command
I used: sed -i 's/\\f$\s*\\R/\\f$ \\mathbb{R}/g'
2013-07-10 17:07:43 +02:00
Dror Atariah a86708e7d6 Merge branch 'Aos_2-polyline_upgrade-fub' of ssh://scm.cgal.org/var/git/cgal into Aos_2-polyline_upgrade-fub 2013-07-09 13:22:47 +02:00
Dror Atariah 1fc4b25cf8 Corrected formula representation in the doc 2013-07-09 13:21:29 +02:00
Efi Fogel 7d5a0a0c12 Added Push_front and used it in make_x_monotone (needed for backward compatibility) 2013-07-09 13:27:17 +03:00
Efi Fogel 02462fdfd4 cleanup (spaces) 2013-07-09 13:26:29 +03:00
Efi Fogel 4d869698ce uncommented tests 2013-07-09 13:25:55 +03:00
Efi Fogel e3170f84b0 Fixed push_back and make_x_monotone while distinguishing between segments and x-monotone segments 2013-07-08 17:14:35 +03:00
Efi Fogel 4039b1d6a0 Replaced SegmentTraits with Segment_type and Point_type as template parameters of Polyline and X_monotone_polyline 2013-07-08 14:20:32 +03:00
Efi Fogel 17d5c57c1e cleanup 2013-07-08 14:19:16 +03:00
Dror Atariah b14a20ab0e Corrected the operator>> in Polyline_2 2013-07-03 15:59:35 +02:00
Dror Atariah 99eff890c5 Merge branch 'Aos_2-polyline_upgrade-fub' of ssh://scm.cgal.org/var/git/cgal into Aos_2-polyline_upgrade-fub 2013-07-02 16:39:18 +02:00
Efi Fogel cf58ffabdb Merge branch 'Aos_2-polyline_upgrade-fub' of ssh://scm.cgal.org/var/git/cgal into polyline 2013-07-02 17:35:08 +03:00
Efi Fogel 17a66268ee Specified the default kernel for Arr_segment_traits_2 2013-07-02 17:34:14 +03:00
Dror Atariah f008466061 Removed white spaces at EOL 2013-07-02 16:29:49 +02:00
Dror Atariah 4f48ac1c34 Merge branch 'Aos_2-polyline_upgrade-fub' of ssh://scm.cgal.org/var/git/cgal into Aos_2-polyline_upgrade-fub 2013-07-02 15:05:06 +02:00
Dror Atariah 39ea5fdbee Removed private tests related to the polyline upgrading 2013-07-02 15:03:42 +02:00
Efi Fogel 9e28e66402 updated polyline traits description 2013-07-02 14:55:03 +03:00
Dror Atariah a5b27d85ea Noted that the default template parameter is Arr_segment_traits_2 2013-07-01 18:45:20 +02:00
Dror Atariah 3fed47e6a7 Updated the user-manual in section on polylines 2013-07-01 18:28:12 +02:00
Dror Atariah dc3f8bc0be Images for well-oriented polyline were added 2013-07-01 18:19:46 +02:00
Dror Atariah 5f7005572c Re-flowed a paragraph in the polylines subsection 2013-07-01 16:02:56 +02:00
Dror Atariah ab0dd90096 Removed white spaces at EOLs 2013-07-01 15:58:49 +02:00
Sébastien Loriot 634fbb0617 remove unused variable warning 2013-06-26 07:35:13 +02:00
Sébastien Loriot 225f4ec425 remove warning on msvc 2013-06-26 07:32:34 +02:00
Dror Atariah 88dfe495af Documented the macro CGAL_ALWAYS_LEFT_TO_RIGHT 2013-06-24 09:21:46 +02:00
Sébastien Loriot 496d75c256 update licenses that were incorrect after merging replace object feature branch 2013-06-21 15:06:17 +02:00
Dror Atariah c45912cf4a Removed empty line at EOF 2013-06-21 11:14:05 +02:00
Dror Atariah b9c7c5f2a8 Documented the construction functors and the macro
macro = CGAL_ALWAYS_LEFT_TO_RIGHT
2013-06-21 11:13:22 +02:00
Dror Atariah fab148f88d Corrected and completed the documentation of the functor Push_back_2 2013-06-19 16:40:28 +02:00
Dror Atariah a97d636819 Corrected indentations 2013-06-19 15:40:16 +02:00
Dror Atariah 36ff7c31d9 Documented Push_back_2 and Number_of_points_2 2013-06-19 15:24:04 +02:00
Dror Atariah f4ddbee4a4 Changed the namespace POLYLINE to polyline 2013-06-19 13:26:05 +02:00
Dror Atariah 01d588c33c Documented the point type of Arr_polyline_traits_2 2013-06-19 13:23:21 +02:00
Dror Atariah 732ae7f619 Updated the documentation of X_monotone_curve_2 2013-06-19 12:13:56 +02:00
Dror Atariah 063b8c5260 Updated the documentation - deprecated and new replacing functions 2013-06-19 11:50:30 +02:00
Dror Atariah 4fa1781731 Corrected the default template parameter
Not providing a kernel by default. If default SegmentTraits is used,
then the kernel is the default of the SegmentTraits.
2013-06-19 11:06:49 +02:00
Dror Atariah 33328b3765 Documented the deprecation of points() 2013-06-19 11:00:05 +02:00
Dror Atariah 3e8ccdad0c Defined Exact_predicates_exact_constructions_kernel as default
Defined the Exact_predicates_exact_constructions_kernel as the default
template parameter for the Arr_segment_traits_2
2013-06-19 10:59:20 +02:00
Dror Atariah d14eb32548 Removed white spaces at the end of lines 2013-06-19 10:52:04 +02:00
Dror Atariah 684b169aa0 Started to update the documentation
- Corrected the default type used for SegmentTraits.
- Documented the deprecation of the const_iterator's
2013-06-19 10:20:32 +02:00
Dror Atariah a81fa86acd Updated the example polylines.cpp
- Changed the construction of the polylines to use the construction
  functors.
- Provided two possible definitions of the Arrangement traits class. One
  using the defaults and the other using a user-defined kernel and
  SegmentTraits.
2013-06-19 10:01:08 +02:00
Dror Atariah e43ee37b39 Defined the Arr_segment_traits_2 as the default SegmentTraits
In this case the default kernel is Exact_predicates_exact_constructions_kernel
2013-06-19 09:58:04 +02:00
Dror Atariah 2435d1e3e4 Changed the macro for left-to-right invariant of the x-polylines 2013-06-18 15:24:51 +02:00
Dror Atariah 06caf04210 Merge branch 'Aos_2-polyline_upgrade-fub-old' into Aos_2-polyline_upgrade-fub
Conflicts:
	.gitignore
	Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/Arr_polyline_traits_2.h
	Arrangement_on_surface_2/include/CGAL/Arr_geometry_traits/Polyline_2.h
	Arrangement_on_surface_2/include/CGAL/Arr_polyline_traits_2.h

Resolved the conflicts manually
2013-06-18 11:55:22 +02:00
Dror Atariah 7e72eb9f3f Removed whitespaces at the end of lines Arr_polyline_traits_2.h(dummy) 2013-06-18 09:45:03 +02:00
Dror Atariah 39c22bec11 Improved the submission pdf - 1st uploaded version 2013-06-18 09:42:19 +02:00
Efi Fogel e822dc56d4 Fixed typo 2013-06-17 18:50:33 +03:00
Dror Atariah a486d63c0b Improved and updated the style file 2013-06-17 17:10:38 +02:00
Dror Atariah c501e3c014 Added details about testing of Intersect_2 2013-06-17 17:10:16 +02:00
Dror Atariah 520d4294c6 Moved image of tests of Intersect_2 to the submission directory 2013-06-17 16:56:54 +02:00
Dror Atariah b3c2e3d943 Added tests for Intersect_2 and updated the corresponding image 2013-06-17 16:55:14 +02:00
Dror Atariah 36cfbc820e Changed directory name of submission docs 2013-06-17 09:03:23 +02:00
Efi Fogel e9748e047a Merge branch 'master' of ssh://scm.cgal.org/var/git/cgal 2013-06-16 11:46:27 +03:00
Efi Fogel 7aedf66f1a pacify MSVC: fixed a friend statement in a nexted class 2013-06-16 11:45:41 +03:00
Sébastien Loriot c09ec2beaa Merge branch 'Kernel-replace_object-pmoeller'
Successfully tested in CGAL-4.3-Ic-59
Approved by the release manager

Conflicts:
	Kernel_23/doc/Kernel_23/CGAL/intersections.h
	Kernel_23/doc_tex/Kernel_23_ref/intersection.tex
	Kernel_d/doc/Kernel_d/Kernel_d.txt
	STL_Extension/doc/STL_Extension/CGAL/iterator.h
2013-06-14 14:26:05 +02:00
Dror Atariah 42df3f2d15 Added the macro CGAL_POLYLINE_FIXED_LEFT_TO_RIGHT
If defined then Make_x_monotone asserts that the resulting x-polylines are
directed from left-to-right.
2013-06-14 08:22:57 +02:00
Sébastien Loriot 716f87d2d7 rename Hidden_type to unspecified_type and update its description 2013-06-13 18:48:58 +02:00
Dror Atariah 496c715256 Implemented Efi's suggestion from 10.06.2013 2013-06-12 12:59:12 +02:00
Efi Fogel fe6e9b860d Apply fixes to compile the arrangement demo with VC 10 2013-06-11 18:27:33 +03:00
Dror Atariah ff21d69f04 Added "tracing" to test arrangement computation during WIP 2013-06-08 12:08:06 +02:00
Dror Atariah bd78c16774 Added a TikZ plot of the test cases for Make_x_monotone_2 2013-06-08 12:04:15 +02:00
Dror Atariah 318d3118a7 Added a roadmap entry - Merge_2
In the furture we might want to have that merging of overlapping polylines
should be allowed and possible.
2013-06-08 12:00:51 +02:00
Dror Atariah b4be631802 Removed a todo note 2013-06-08 11:54:33 +02:00
Dror Atariah 0ae61147c0 Removed a todo from Merge_2 2013-06-08 09:57:17 +02:00
Dror Atariah 1476aea041 Expanded and extended the tests of Merge_2 and Are_mergeable_2
Included tests of right-to-left x-monotone polylines
2013-06-08 09:47:44 +02:00
Dror Atariah 6890ade8f6 Corrected Merge_2 and Are_mergeable_2
Update the functors to handle the case when the x-monotone polylines
are oriented either left-to-right _or_ right-to-left.
2013-06-07 16:18:34 +02:00
Dror Atariah c12fe92bc8 Added a TODO for the Merge_2 functor 2013-06-07 13:13:51 +02:00
Dror Atariah 4283cd2d05 Improved the tests of the functor Split_2 2013-06-07 13:08:53 +02:00
Dror Atariah 03cfd952d6 Polsihed the functor Split_2 2013-06-07 13:08:22 +02:00
Dror Atariah 984a7de010 Implemented preconditions of Push_back_2
In particular for augmenting x-monotone polylines.
2013-06-07 11:18:33 +02:00
Dror Atariah 63b8b4507d Improved the implementation of Push_back_2 of a segment
Added a precondition that the orientation fo the given segment should
coincide with the one of the polyline.
2013-06-07 10:43:04 +02:00
Dror Atariah 46793fe570 Added documentation to the functor Construct_opposite_2 2013-06-07 10:12:08 +02:00
Dror Atariah 3dc9edb202 Added a manual test of the functor Construct_opposite_2 2013-06-07 10:06:41 +02:00
Dror Atariah 8d54b31dcb Removed TODO and corrected comment of Compare_endpoints_xy_2 2013-06-07 09:45:41 +02:00
Dror Atariah bb332884fe Added manual test of Compare_endpoints_xy_2 2013-06-07 09:44:25 +02:00
Dror Atariah ca2f0d0db9 Merge branch 'Aos_2-polyline_upgrade-fub' of ssh://scm.cgal.org/var/git/cgal into Aos_2-polyline_upgrade-fub 2013-06-07 09:18:41 +02:00
Dror Atariah 4d08e288fb Corrected tests for Make_x_monotone_2
Added tests from x-monotone polylines oriented from right-to-left
2013-06-07 08:36:52 +02:00
Dror Atariah 868978bf4f Added a TikZ plot of the cases for the tests of Intersect_2 2013-06-06 14:00:42 +02:00
Dror Atariah 6d3b573fba Testing Intersect_2 final test after lifting direction invariant
After removing the invariant that x-monotone polylines should be
directed from left to right, these are the related tests.
2013-06-06 11:54:38 +02:00
Efi Fogel 493466ac6d enhanced linear tests 2013-06-06 12:22:06 +03:00
Efi Fogel c8968ebafc enhanced linear traits test 2013-06-06 11:33:45 +03:00
Efi Fogel f08f9d30a1 Added tests that test the lienar traits 2013-06-06 11:16:55 +03:00
Dror Atariah 82e479be6f Improving tests of Intersect_2 (wip) 2013-06-06 09:28:13 +02:00
Efi Fogel 6fe422305b Added missing input flag that indicates whether a normal succeeds the source and target points 2013-06-06 00:28:18 +03:00
Efi Fogel 8b8b6ad909 Added missing input flag that indicates that there a normal does not succeed the source and target points 2013-06-06 00:13:37 +03:00
Dror Atariah a0823dcdfd Added more tests of the Intersect_2 functor 2013-06-05 11:19:50 +02:00
Dror Atariah 429d247b79 Corrected behavior of Intersect_2
There was a problem with the indices when the x-poly was oriented
right-to-left. In this case, when getting special care had to be paid
to the value of the "pointing" indices.
2013-06-05 11:03:58 +02:00
Dror Atariah 01dee2433a Added more tests of Intersect_2 2013-06-05 10:13:53 +02:00
Efi Fogel d7ca4432c4 added the option to pass a flat container of indices (without the -1 at the end of each facet) 2013-06-04 18:17:14 +03:00
Sébastien Loriot f0a5e23c97 bug-fix: take the variant by reference to avoid refering to a temporary
variant are not ref-counted
2013-06-04 14:05:18 +02:00
Dror Atariah fec7c17920 Improved locate() to assure that the returned segment
Make sure that the returned segment contains the query point on its
right end (if possible)
2013-06-04 11:05:17 +02:00
Sébastien Loriot 404bba0aeb add a workaround for a bug in boost variant and its swap function
the bug appears on MSVC
The ticket is here:
https://svn.boost.org/trac/boost/ticket/2839
2013-06-03 19:04:08 +02:00
Efi Fogel ab37ee592e Cleanup, removed unused variables 2013-06-03 15:56:09 +03:00
Dror Atariah 5d3d22ce24 Corrected a test with Intersect_2 2013-06-03 13:21:09 +02:00
Efi Fogel c888eeadff removed 2013-06-03 12:13:26 +03:00
Efi Fogel e4bc02ae57 convert _compute_signs_and_local_minima() used when an edge is removed to _compute_signs_and_min() 2013-05-31 23:03:58 +03:00
Dror Atariah 7fae34c0fc Improving the tests of Intersect_2
Added the reversed x-polylines of length 2
2013-05-31 18:35:20 +02:00
Dror Atariah a4ae33e50b Corrected porblem with Intersect_2 2013-05-31 15:51:22 +02:00
Dror Atariah c5aec87e8a wip - improve tests of Intersect_2 2013-05-31 15:50:05 +02:00
Efi Fogel 16532d0eab improved _remove_edge() and introduced (and used) _compute_signs 2013-05-31 16:38:25 +03:00
Dror Atariah 83637950ee Testing Intersect_2 - wip 2013-05-30 20:09:00 +02:00
Dror Atariah 8fdea5a11b Corrected and improved Intersect_2 2013-05-30 19:02:21 +02:00
Dror Atariah dfa069e3d6 Improved the tests for Intersect_2 for polylines 2013-05-30 18:29:58 +02:00
Philipp Möller 895245426a Fix some errors introduced by adding the titles 2013-05-30 18:09:42 +02:00
Ross Hemsley 4d9caf3763 Added names that were missing into the Doxyfile.in entries.
Also modified Installation/CMakeLists.txt to push the version number variable to the parent level
so that it can be accessed by the documentation
2013-05-30 17:55:43 +02:00
Ross Hemsley c0690f87f4 Manually inserted tags that could not be generated automatically
added in options that were in XML but were not moved across to new Doxyfile.in files.
2013-05-30 14:45:18 +02:00
Philipp Möller 4d469821f7 Generated Doxyfile.in and dependencies 2013-05-30 14:13:47 +02:00
Dror Atariah ab1f21c782 Added a test to the polyline test suite 2013-05-30 14:12:47 +02:00
Dror Atariah 5765f10275 Intersect_2 returns left-to-right when overlapping (comment)
Corrected the comment
2013-05-30 14:12:13 +02:00
Dror Atariah c90571d516 Added Construct_opposite_2 functor (not tested!) 2013-05-30 12:03:09 +02:00
Dror Atariah 951173b6f9 Removed trailing white-spaces 2013-05-30 11:59:24 +02:00
Dror Atariah 8dc681ce2d Started to fix bug with Intersect_2
Fixed some style issues as well
2013-05-30 11:58:40 +02:00
Efi Fogel d644a1a73e fixed typo 2013-05-30 11:17:55 +03:00
Dror Atariah 2a8e5b5388 Implemented Compare_endpoints_xy_2 functor 2013-05-30 10:00:50 +02:00
Efi Fogel a895f3bc19 fixed inertion into non-empty arrangement. More precisely, fixed computation of the current top face 2013-05-30 10:57:43 +03:00
Dror Atariah 4d8165ad7f Updated todo's and roadmaps 2013-05-30 09:39:38 +02:00
Dror Atariah 3dd76cbbdd Added an example to compute random polyline's arrangement
First sample N points and then compute the arrangement of the polyline
which is defined by the points.
2013-05-29 13:50:41 +02:00
Dror Atariah 1f2bd84cb3 Removed TODO's and corrected indentations 2013-05-29 13:49:06 +02:00
Dror Atariah dd5af7dced Updated the output of the bench of polygon from random points 2013-05-29 12:42:31 +02:00
Dror Atariah a1ccc0a138 Corrected a problem with Intersect_2
It seems like this problem was already there in the original code.
2013-05-29 12:11:20 +02:00
Dror Atariah 18c1bc5357 Added the random bench of arr of polylines 2013-05-29 09:27:53 +02:00
Dror Atariah d6b3d101ef Corrected the functors Intersect_2 and Split_2 (result of polylines.cpp)
polylines.cpp returns correct answer which coincides with the result of
master (4441f27)
2013-05-28 20:04:48 +02:00
Sébastien Loriot 541eb8d656 add missing template keyword detected by clang 2013-05-28 18:51:00 +02:00
Clement Jamin c78bae3299 Removed a warning 2013-05-28 17:34:38 +02:00
Efi Fogel 220add1ae3 cleanup 2013-05-28 18:17:50 +03:00
Sébastien Loriot f45c8ccb18 remove todos 2013-05-28 15:26:42 +02:00
Dror Atariah 71856f9efe Removed unneeded code snippet "#if 0 etc. 2013-05-28 13:41:51 +02:00
Dror Atariah bb977708fe Corrected a small bug 2013-05-28 12:40:07 +02:00
Dror Atariah 95d1da0e9d Revert the implementation of Intersect_2
After realizing that the hack was not consistent we reverted to the
"original" code and start correcting the Intersect_2 from scratch.
2013-05-28 12:38:56 +02:00
Dror Atariah 69604fcf21 Merge branch 'Aos_2_polyline_test_updates' into Aos_2_polyline_cleaning 2013-05-28 11:03:38 +02:00
Dror Atariah 3df38f731f Updating the tests to use the construction functors from the traits 2013-05-28 10:43:47 +02:00
Dror Atariah 361d09ef06 WIP on the Intersect_2 - still not working 2013-05-28 10:39:32 +02:00
Sébastien Loriot 170c619a2d fix places where the <div> added by cgalAdvanced conflicts with other html tags 2013-05-28 09:51:49 +02:00
Sébastien Loriot 7e15467c72 new cgal doxygen advanced macro to put the text inside a div 2013-05-27 19:36:33 +02:00
Dror Atariah 18c3fa1a79 Added a push_back_test file 2013-05-27 18:19:56 +02:00
Dror Atariah 6849647bae Added a comment to the personal documentation 2013-05-27 18:18:48 +02:00
Dror Atariah 4441f2743d Added missing const - minor bugfix 2013-05-27 16:58:39 +02:00
Dror Atariah 93294534cd Changed an if-else according to Efi's suggestion 2013-05-27 12:02:44 +02:00
Dror Atariah 7c5224d345 Corrected locate-test to test both locate and locate_side 2013-05-26 15:42:14 +02:00
Dror Atariah 64c36ccdc5 Corrected locate_side() after lifting direction invariant 2013-05-26 15:41:32 +02:00
Dror Atariah 148fee7254 Updated the tests of locate(cv,p) 2013-05-24 16:57:02 +02:00
Dror Atariah 4ea51ee35a Corrected locate(cv,p)
Mainly the testing of a non-vertical polyline.
2013-05-24 16:56:33 +02:00
Sébastien Loriot a4089fcad8 remove warnings spotted by examples 2013-05-24 11:20:50 +02:00
Sébastien Loriot 5d613db62b rename result_return to make_result 2013-05-24 10:55:09 +02:00
Sébastien Loriot af1dd0d01b rename make_default_result to default_result 2013-05-24 10:52:12 +02:00
Sébastien Loriot dcb0fbfba6 bugfix: a default constructed variant was returned instead of an empty optional
This fix includes also a renaming to make things more clear.
The bug fix is where make_optional_result is now called
2013-05-24 10:48:50 +02:00
Sébastien Loriot 690720c14b fix compatibility with version 1 2013-05-24 08:52:22 +02:00
Dror Atariah e62e15b1d0 Corrected locate() for the case of vertical x-poly 2013-05-23 14:03:04 +02:00
Dror Atariah de85da7c42 Added testing of locate() from the traits class 2013-05-23 14:02:08 +02:00
Sébastien Loriot c67ba90514 Merge branch 'Kernel-replace_object-pmoeller-old' into Kernel-replace_object-pmoeller
Conflicts:
	Circular_kernel_2/include/CGAL/Circular_kernel_2/Circular_arc_2.h
	Circular_kernel_2/include/CGAL/Circular_kernel_2/internal_functions_on_circle_2.h
	Installation/changes.html
	Kernel_d/doc/Kernel_d/CGAL/intersections_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Center_of_sphere_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Compare_lexicographically_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Component_accessor_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Compute_coordinate_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_affine_hull_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_linear_hull_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_simplex_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Equal_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Has_on_positive_side_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Intersect_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Less_coordinate_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Less_lexicographically_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Less_or_equal_lexicographically_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Lift_to_paraboloid_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Linear_base_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Linear_rank_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Linearly_independent_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Midpoint_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Orientation_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Oriented_side_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Orthogonal_vector_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Point_dimension_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Point_of_sphere_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Point_to_vector_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Project_along_d_axis_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Side_of_bounded_sphere_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Side_of_oriented_sphere_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Squared_distance_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Value_at_d.h
	Kernel_d/doc/Kernel_d/Concepts/Kernel--Vector_to_point_d.h
2013-05-23 13:13:08 +02:00
Sébastien Loriot e907f9f444 improve Kernel_23, Kernel_d, STL_extension and Arrangemnt doxygen doc 2013-05-23 10:57:36 +02:00
Dror Atariah e1860620fb Added testing of the Is_vertical_2 functor 2013-05-23 10:47:13 +02:00
Dror Atariah 53f56c9210 Added testing of the Construct_min/max_vertex_2 functors 2013-05-23 10:38:20 +02:00
Dror Atariah d925209b79 Corrected Equal_2 and X-poly construction from range of pts 2013-05-23 09:20:44 +02:00
Dror Atariah d9fe68202b Corrected Construct_min/max_vertex_2 functors
The functors were implicitly assuming the existence of the direction
invariant of the x-polylines.
2013-05-23 09:20:44 +02:00
Dror Atariah 8063daacc5 Lifted dir-invariant from construction of x-poly from range of segs 2013-05-23 09:20:44 +02:00
Dror Atariah f4976807fc Lifted dir.-invariant from functor of x-poly from range of pts. 2013-05-23 09:20:43 +02:00
Dror Atariah 1e2c37615f Lifted direction-invariant from functors constructions of x-polylines 2013-05-23 09:20:43 +02:00
Dror Atariah 6579cc948f Cosmetic correction to the construction functors of general polylines 2013-05-23 09:20:43 +02:00
Dror Atariah 05885d22e7 Corrected includes in wip-test 2013-05-23 09:19:42 +02:00
Dror Atariah a78ce07b44 Moved files related to the polyline cleaning WIP to the subdir 2013-05-23 08:57:24 +02:00
Dror Atariah 886f5d97c1 Added TeX documentation of the polyline cleaning project 2013-05-23 08:49:09 +02:00
Dror Atariah 8c65ad97db Added tests to the WIP on the polylines cleaning project 2013-05-23 08:42:58 +02:00
Dror Atariah 59779246e5 Moved WIP tests to a separate sub-directory 2013-05-23 08:40:52 +02:00
Sébastien Loriot 18b9ec1c4f update the doxygen doc of the Arrangement package from the doc_tex
using the following commits:
f669df07
a1fb4c48
0d9f5aa1
40fac7ad
15e766a5
3f021c72
178e7a89
4a20a898
b8817aa6
5a7309f6
b05d1870
03fbdf61
e25e73a5
26cb83f9
9a491625
c9e72151
5651842b
97ed2499
dc2f174b
fea29a85
2013-05-22 17:31:23 +02:00
Laurent Rineau 657675eed3 Missing #include <cassert> for assert() 2013-05-22 13:29:57 +02:00
Sébastien Loriot ee776291e7 compact the example 2013-05-22 09:22:01 +02:00
Efi Fogel a434eb1d7d enhanced overlay test 2013-05-20 13:28:26 +03:00
Dror Atariah a80545845a Updated comments of constructions of general polylines. 2013-05-17 11:54:27 +02:00
Dror Atariah ae7bdf97c7 Cosmetic change (empty lines adding/removing) 2013-05-16 11:11:06 +02:00
Dror Atariah 115429e274 Precondition tests that construction from range of segs is well-oriented
Implemented the tests that the input range of polylines is well-oriented.
2013-05-16 10:54:04 +02:00
Dror Atariah b242276a9b Updated precondition of construction from range of segs. Update todo's
Updated the precondition that the segments given as an input for
construction of a (general) polyline should be well-oriented.
2013-05-16 09:35:51 +02:00
Dror Atariah 5945972206 Corrected comment, changes local variable name, added TODO 2013-05-15 13:38:59 +02:00
Dror Atariah 8cb8085623 Corrected signature of operator() Push_back_2 of a seg to a polyline 2013-05-15 08:29:39 +02:00
Dror Atariah 0bffffb27a Corrected a todo and a roadmap 2013-05-15 08:27:14 +02:00
Dror Atariah 874b5a8dc9 Corrected Push_back_2 of a single segment to a general polyline
Implemented the post-condition that the resulting polyline is well oriented.
2013-05-14 17:23:25 +02:00
Dror Atariah 6021823ac8 Corrected Push_back_2 of a single point to a polyline
Applied the assumption that SegmentTraits models ArrangementDirectionalXMonotoneTraits_2.
2013-05-14 16:48:19 +02:00
Dror Atariah f73de5f722 Removed todo about Has_source_target tag
Once we decided to assume (for the time being) that the SegmentTraits
should model ArrangementDirectionalXMonotoneTraits_2 then there's no
need for this tag.
2013-05-14 15:55:57 +02:00
Dror Atariah 154df43c2e Utilized ArrangementDirectionalXMonotoneTraits_2 in Make_x_monotone_2
Made use of the functor Compare_endpoints_xy_2 which is provided by
ArrangementDirectionalXMonotoneTraits_2 in the implementation of Make_x_monotone_2.
2013-05-14 14:47:39 +02:00
Dror Atariah 204eb8ea47 Test construction from a single seg 2013-05-13 15:37:31 +02:00
Dror Atariah 598c36b778 Added todo to the example of polylines
Make sure to test all constructing cases.
2013-05-13 15:36:28 +02:00
Dror Atariah 774e04d0b3 Removed TODO in Make_x_monotone_2, case where polyline has only one seg
This case was simplified once assuming that the polylines cannot be
degenerated. So, if the polyline has only one seg then it means that it
is already x-monotone.
2013-05-13 15:35:45 +02:00
Efi Fogel 197fa9755c enhanced the paragraph that talks about exact predicates and exact constructions 2013-05-13 12:26:32 +03:00
Efi Fogel 50abc7acb7 enhanced the paragraph that talks about exact predicates and exact constructions 2013-05-12 14:29:40 +03:00
Efi Fogel 3f4db83af2 cleanup 2013-05-12 01:11:28 +03:00
Efi Fogel 26eabd2161 cleanup 2013-05-12 00:10:35 +03:00
Efi Fogel d6a062dff4 cleanup 2013-05-10 14:25:54 +03:00
Efi Fogel 8fee956a0f enhanced 2013-05-10 14:07:55 +03:00
Efi Fogel 31c1a5de59 cleanup 2013-05-10 14:06:41 +03:00
Efi Fogel 145e7b34f8 enhanced the tests 2013-05-09 17:58:50 +03:00
Efi Fogel 8dca4b39c5 added a comment 2013-05-09 16:11:28 +03:00
Efi Fogel e26354c71c when splicing, need to use the next halfedge that starts at the northpole (and not the previous one) cause the next one around the north pole is actually the previous one encountered 2013-05-09 16:04:57 +03:00
Efi Fogel 3b351bf48e added tests 2013-05-08 23:31:50 +03:00
Efi Fogel 753ba63d7f added tests 2013-05-08 21:04:45 +03:00
Efi Fogel ecbec2fb65 added test03 2013-05-07 16:22:24 +03:00
Efi Fogel 5510218dc9 cleanup 2013-05-05 18:16:47 +03:00
Efi Fogel b8a2648437 Merge branch 'Aos_2-remove_opt-efif' of ssh://scm.cgal.org/var/git/cgal into ro 2013-05-01 14:06:51 +03:00
Efi Fogel ec0b18a480 updated 2013-04-30 00:07:56 +03:00
Efi Fogel 71f7a0bcdb updated 2013-04-30 00:01:54 +03:00
Efi Fogel b6a8fd106e reduced test case 2013-04-29 22:00:59 +03:00
Efi Fogel c21c2c9fed cleanup 2013-04-29 15:30:42 +03:00
Efi Fogel 4efb52f658 reduced test 2013-04-29 13:31:44 +03:00
Dror Atariah 6f380d0f68 Changed a todo to a roadmap 2013-04-25 13:25:37 +02:00
Dror Atariah 3543b91c72 Updated roadmap item 2013-04-25 11:37:07 +02:00
Dror Atariah ad8986c926 Obtain the seg-traits using the segment_traits_2() function
Instead of referring directly to the member m_seg_traits
2013-04-25 11:35:36 +02:00
Dror Atariah fe88ab9087 Replaced InputIterator with ForwardIterator
In the construction functors a ForwardIterator has to be used as the
container is iterated by at least two iterators at the same time. This
behavior is not supported by the concept of an InputIterator.
2013-04-25 11:22:04 +02:00
Dror Atariah 77f45a3be7 Merge branch 'WIP-shorten-calls-to-seg-traits' into Aos_2_polyline_cleaning 2013-04-25 11:09:17 +02:00
Dror Atariah c3c6dc290b Update signature of locate() and the calls to this function 2013-04-25 11:05:15 +02:00
Dror Atariah 0d81073c22 Changed the function's name and updated the calls 2013-04-25 10:51:15 +02:00
Dror Atariah 5adf42f96a Shortened the calls to object from the segment traits
Instead of having lots of calls like:
m_poly_traits->m_seg_traits->equal_2_object();

I added, where needed,
const Segment_traits_2* seg_traits = m_poly_traits->segment_traits_2();
and then replaced the above line with:
seg_traits->equal_2_object();
2013-04-25 09:58:02 +02:00
Dror Atariah 88550ef207 Added a documentation of the X_monotone_curve_2 type 2013-04-22 15:50:20 +02:00
Dror Atariah 9194016930 Corrected indentation in Polyline_2 2013-04-22 14:44:01 +02:00
Dror Atariah e3af05fea6 Used the polyline traits in each functor
Then, when the segment traits was needed, extracted it from the polyline-traits.
2013-04-22 12:56:59 +02:00
Dror Atariah 7b5a54c311 Improved a roadmap statement. 2013-04-22 09:13:29 +02:00
Efi Fogel 1238057b23 Added assertion when trying to push a point into an empty polyline 2013-04-20 21:22:16 +03:00
Dror Atariah 453dbb8e9a Code cosmetics optimization
Avoided duplicated code in Merge_2
2013-04-19 17:39:45 +02:00
Dror Atariah 972baf6071 Added two Roadmap items
- Correct the _locate()
- Correct the way functors access the segment traits.
2013-04-19 17:21:29 +02:00
Dror Atariah f03fba9ded Corrected declaration of index in a for loop. Style improve. 2013-04-19 16:56:05 +02:00
Dror Atariah 32b2a46219 Added a roadmap item - overkill in the Push_back_2 2013-04-19 16:23:43 +02:00
Dror Atariah 59ebc5d5f2 BUGFIX: in Make_x_monotone_2 corrected a problem
Previously if the polyline went vertically up->down->up (again) then
it wouldn't be split. This was now corrected.
2013-04-19 16:17:52 +02:00
Dror Atariah 799df6c8b7 Styling: replaces min/max_v occurrences with get_min/max_v
To stress that it is a function which returns something (Point_2)
2013-04-19 15:58:32 +02:00
Dror Atariah 2c403d9aca Becoming unfriendly! Remove all un-needed friendships. 2013-04-19 15:44:46 +02:00
Dror Atariah 57bc6defce Returning const ref Point_2 from the construct_min/max_vertex_2 2013-04-19 15:41:50 +02:00
Dror Atariah 66846e3a7e Moved Polyline_2 and X_monotone_polyline_2 into a new sub-namespace POLYLINE 2013-04-19 15:25:46 +02:00
Dror Atariah e2c9e4cf63 Updating comments together with M. Hemmer 2013-04-19 15:18:49 +02:00
Dror Atariah f46274c4b0 Merge branch 'Aos_2_polyline_cleaning-old' into Aos_2_polyline_cleaning 2013-04-12 11:55:19 +02:00
Dror Atariah 8eeec64cd0 Disabled non-const iterators over the segments 2013-04-12 11:52:23 +02:00
Dror Atariah e63dedfcba Cleared the last TODO 2013-04-12 11:37:07 +02:00