Commit Graph

272 Commits

Author SHA1 Message Date
Sébastien Loriot 1fb47e3fd1 accomodate updates of named parameters 2022-01-21 15:25:18 +01:00
Andreas Fabri 40e800f1af Fix VC problem with max 2021-12-28 09:54:21 +00:00
Dmitry Anisimov 930278ec50 Merge remote-tracking branch 'origin/master' into Region_growing-revision-danston 2021-11-16 14:57:16 +01:00
Dmitry Anisimov 86b26e44d3 added access to circle/sphere/cylinder shapes 2021-11-16 14:51:00 +01:00
Dmitry Anisimov 43d4d27c5b added two utility operators to neighbor queries 2021-10-14 15:18:44 +02:00
Dmitry Anisimov 61a6dff624 added functions to update parameters 2021-10-14 12:03:42 +02:00
Mael Rouxel-Labbé 8166579e55 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_master-GF 2021-10-11 19:58:07 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé df560987a6 Whitespace & cleaning changes 2021-10-08 12:13:43 +02:00
Dmitry Anisimov 9246c1389e remove unnecessary conversions in utils for circles and spheres 2021-09-27 17:03:44 +02:00
Dmitry Anisimov c63d41d0e3 more precision for cylinder fitting and sorting 2021-09-27 16:39:11 +02:00
Dmitry Anisimov 02edd6d2cb more precise sphere fitting and sorting 2021-09-27 15:10:54 +02:00
Dmitry Anisimov c093f84ac9 cleanup 2021-09-27 14:45:31 +02:00
Dmitry Anisimov 1222be73b0 more precise circle fitting and sorting 2021-09-27 13:53:57 +02:00
Dmitry Anisimov 7465e7caac added constructors with np set to all_default 2021-09-27 12:40:08 +02:00
Dmitry Anisimov d6004297f1 added cgal no deprecated code 2021-09-27 12:03:25 +02:00
Dmitry Anisimov 8c0b6f14d6 fixed wrong np 2021-09-23 14:26:30 +02:00
Dmitry Anisimov ae50a0beae fixed examples + some other small stuff 2021-09-22 17:36:32 +02:00
Dmitry Anisimov 7a068f227a adding np to cylinder classes 2021-09-22 16:10:31 +02:00
Dmitry Anisimov 2c16e6f9bf adding np to sphere classes 2021-09-22 15:27:01 +02:00
Dmitry Anisimov 0fbc3ea1bb removed fitting.h and using np in circle classes 2021-09-22 14:59:01 +02:00
Dmitry Anisimov b28f32269b make everything compile 2021-09-22 13:04:59 +02:00
Dmitry Anisimov 0d86275191 Merge remote-tracking branch 'origin/master' into Region_growing-revision-danston 2021-09-22 12:20:28 +02:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Dmitry Anisimov d82ca437c4 correctly handling wrong values in new classes 2021-08-20 11:19:22 +02:00
Dmitry Anisimov f2d9066aaf added more debug output for failure cases 2021-08-19 12:05:30 +02:00
Dmitry Anisimov 460c50b142 Merge remote-tracking branch 'origin/master' into Region_growing-revision-danston 2021-08-16 12:28:34 +02:00
Dmitry Anisimov c2a1f047eb fixed test suite errors in examples 2021-08-16 11:56:36 +02:00
Dmitry Anisimov 6d2a3894f6 fixed test suite warnings in fitting 2021-08-16 10:50:58 +02:00
Dmitry Anisimov 2246c4dcef Merge remote-tracking branch 'origin/master' into Shape_detection-Region_growing_on_spheres-GF 2021-08-16 10:27:39 +02:00
Sébastien Loriot de6d8c6cbd Merge pull request #5742 from danston/Shape_regularization-new_package-danston
[Feature] Shape Regularization New Package
2021-08-13 18:19:35 +02:00
Dmitry Anisimov 5f0ed6ba7b fixed missing param 2021-07-29 15:26:22 +02:00
Dmitry Anisimov 37dcf522de refactoring the clear function 2021-07-29 13:57:44 +02:00
Dmitry Anisimov ae0a1fd6d0 Merge remote-tracking branch 'origin/Shape_detection-fix_leaks_in_ransac-danston' into Shape_detection-Region_growing_on_spheres-GF 2021-07-08 17:31:45 +02:00
Dmitry Anisimov 5e616f74e6 fixed leaks in ransac related to callback 2021-07-08 17:30:26 +02:00
Dmitry Anisimov 73df51622f fixed errors and warnings from the test suite 2021-07-08 16:38:53 +02:00
Dmitry Anisimov c1aa66f0fa renamed max to maximum and min to minimum and cos to cosine to be consistent with other NP in CGAL 2021-06-30 13:15:06 +02:00
Dmitry Anisimov 1c7ba09863 undocumented useless headers from convenience headers 2021-06-30 12:46:41 +02:00
Dmitry Anisimov 478178a923 added docs for convenience headers 2021-06-28 18:59:16 +02:00
Dmitry Anisimov 3263e54a3a added missing deprecated constructors for old classes 2021-06-28 18:42:32 +02:00
Dmitry Anisimov d33559c3fc fixed unspecified doxygen types 2021-06-25 17:16:38 +02:00
Dmitry Anisimov afb138478d all plane regularization stuff in shape detection is now moved to shape regularization 2021-06-25 16:55:15 +02:00
Dmitry Anisimov 68b86a47b0 better naming for parameters 2021-06-14 12:43:04 +02:00
Dmitry Anisimov 6453d49c23 fixed errors in the docs 2021-06-01 16:42:44 +02:00
Dmitry Anisimov 4f1fc20e22 Merge remote-tracking branch 'origin/master' into Region_growing-revision-danston 2021-06-01 16:06:16 +02:00
Simon Giraudot 6fbc190c0d Fix includes 2021-05-04 11:06:48 +02:00
Simon Giraudot 4b313a50d7 Add missing include 2021-05-04 10:20:09 +02:00
Simon Giraudot ad17c0b562 Cylinder/circle sorting + documentation update 2021-05-04 08:47:08 +02:00
Simon Giraudot a85583387d Doc of sorting 2021-04-28 15:52:56 +02:00
Simon Giraudot ab18b6bb39 Region growing sphere sorting + test 2021-04-28 14:38:08 +02:00