Commit Graph

272 Commits

Author SHA1 Message Date
Simon Giraudot dc4b2c94c5 Move sphere fit out of fitting class 2021-04-28 12:15:18 +02:00
Simon Giraudot 4080a8c32f Rebase 2021-04-28 08:20:24 +02:00
Dmitry Anisimov 04f385687d fixed several tests and memory management 2021-04-16 15:37:00 +02:00
Dmitry Anisimov 17bcbfc38d fixed another missing include 2021-04-14 14:12:43 +02:00
Dmitry Anisimov 55cc13bc5a fixed bug with missing includes for undocumented free functions 2021-04-14 13:11:05 +02:00
Simon Giraudot 8e7ea14f58 Fix conversion warning 2021-04-14 10:57:53 +02:00
Dmitry Anisimov d10c72f7d3 Merge remote-tracking branch 'upstream/master' into Region_growing-revision-danston 2021-04-14 10:57:01 +02:00
Simon Giraudot e87747d082 Fix candidate counting 2021-04-14 09:20:17 +02:00
Dmitry Anisimov 1a542135d1 now works with default maps 2021-04-13 13:47:18 +02:00
Dmitry Anisimov fe5e3415e8 changed API of Polyline_graph 2021-04-13 11:59:34 +02:00
Dmitry Anisimov fa5d4b251a remved some useless internal code 2021-04-13 09:24:45 +02:00
Dmitry Anisimov f9bdb150a6 removed deprecated code 2021-04-13 09:20:19 +02:00
Dmitry Anisimov b6e2ea61ea named parameters now include point/normal/segment maps 2021-04-12 18:02:57 +02:00
Dmitry Anisimov c1f27fb0c5 relaxed constraints on property maps 2021-04-12 15:27:55 +02:00
Dmitry Anisimov 3c48e35138 review Sebastien 2021-04-12 14:02:14 +02:00
Simon Giraudot 10f6992b2a Rebase on master 2021-04-07 14:32:31 +02:00
Simon Giraudot 4ec9bd6c9a Optimize location of node 2021-04-07 14:26:19 +02:00
Simon Giraudot 4c0018791c Fix bbox, width and depth computations in Octree wrapper 2021-04-07 14:13:29 +02:00
Simon Giraudot 1794620ab9 Move index access property map to property map package 2021-04-01 09:43:14 +02:00
Simon Giraudot 616cd5a549 Apply corrections from review 2021-04-01 08:55:51 +02:00
Dmitry Anisimov f0a667d7be docs cleanup 2021-03-29 17:14:06 +02:00
Dmitry Anisimov 0072ad7a77 updated ref docs + added sections in the user manual 2021-03-29 16:55:53 +02:00
Dmitry Anisimov c7d9f007ce updated docs, region growing now properly handles the first time call for all regions 2021-03-29 15:01:40 +02:00
Dmitry Anisimov 424405bcfd added polyline ref docs 2021-03-26 17:18:21 +01:00
Dmitry Anisimov a1af0e9bb3 added segment set region type + better polyline graph 2021-03-26 16:53:15 +01:00
Dmitry Anisimov d881117b41 fitting now works both on points and segments, added segment set sorting 2021-03-26 15:51:23 +01:00
Dmitry Anisimov 8cc513e935 added internal region growing traits and polyline graph based on segments 2021-03-26 14:48:53 +01:00
Dmitry Anisimov 35648ab3d6 cleanup, move some stuff to internal, updated docs 2021-03-26 11:12:46 +01:00
Dmitry Anisimov c502a39ea9 added empty segment set classes + updated several docs 2021-03-25 17:16:27 +01:00
Dmitry Anisimov 462817c48e added polyline graph test 2021-03-25 14:55:01 +01:00
Dmitry Anisimov 8a0996b671 added polyline graph query 2021-03-25 11:33:35 +01:00
Dmitry Anisimov 3ca82f638c added empty polyline graph 2021-03-24 17:36:52 +01:00
Dmitry Anisimov 793037c3d7 more precise tests, point set free function, better plane detection on points 2021-03-24 17:28:22 +01:00
Dmitry Anisimov da8e1a66a3 cleanup (new assertions, removed useless code, etc.) + better examples 2021-03-24 12:25:22 +01:00
Dmitry Anisimov ca8c7f0470 added polyline classes, both 2D and 3D, fixed a few small things in other classes 2021-03-23 18:51:40 +01:00
Dmitry Anisimov b31c9016f9 internal code is unified, added utility functions, added normal orientation 2021-03-23 15:29:42 +01:00
Dmitry Anisimov 1ff8c00af4 several repeating functions are moved to internal 2021-03-23 12:29:22 +01:00
Simon Giraudot 91de37ec3a Fix warning: std::pow(float, int) returns double instead of float in recent C++ 2021-03-23 11:25:53 +01:00
Dmitry Anisimov 25cd87cce3 better precision in all shapes, no approximations now, added iota to sorting 2021-03-22 17:37:25 +01:00
Dmitry Anisimov b971f6a0e2 added free functions and new examples 2021-03-22 13:22:32 +01:00
Dmitry Anisimov 2d0b31b7f7 added named parameters 2021-03-19 14:32:14 +01:00
Dmitry Anisimov 4a9b7c7c9a better incapsulation, naming, and added access to internal property maps 2021-03-19 12:20:03 +01:00
Dmitry Anisimov 05a8105ff8 added polyline headers and updated CGAL-style docs + fixed warnings in the Generic_facegraph_printer 2021-03-19 11:29:03 +01:00
Simon Giraudot 987b177833 Fix conversion warning 2021-03-18 08:36:34 +01:00
Simon Giraudot 9fe8708fc2 Fix bug that created empty octrees 2021-03-15 10:18:55 +01:00
Simon Giraudot a5f139f9df Remove unused variables 2021-03-11 09:34:33 +01:00
Simon Giraudot 46b9452ef4 Rebase on master 2021-03-04 13:48:11 +01:00
Simon Giraudot bbcab8e56f Merge remote-tracking branch 'mine/Shape_detection-Region_growing_on_spheres-GF' into Shape_detection-Region_growing_on_spheres-GF 2021-03-03 11:52:14 +01:00
Simon Giraudot 244ca61261 Text corrections from review 2021-02-23 08:26:41 +01:00
Simon Giraudot 0cf9990bf0 Fix conversion warning in RANSAC 2021-02-04 08:33:54 +01:00
Simon Giraudot a19836bfb6 Fix RANSAC's use of outdated Octree API 2021-01-20 11:20:01 +01:00
Simon Giraudot 1dcf876679 Remove TODOs 2021-01-19 14:07:13 +01:00
Simon Giraudot ae8ec55eac Merge remote-tracking branch 'jackson/gsoc2020-Octree-campolattaro' into gsoc2020-Octree-campolattaro 2021-01-19 09:54:58 +01:00
Simon Giraudot 661fe3505e User + ref manual for new region growing classes 2021-01-05 10:35:05 +01:00
Simon Giraudot 74d01916e3 Document missing parts 2021-01-04 15:23:41 +01:00
Simon Giraudot 8a2029e233 Add possibility to restrict radius of sphere/circle/cylinder 2021-01-04 15:20:10 +01:00
Simon Giraudot 5e0487e455 Add region growing on cylinders for point_set_3 2020-12-31 13:26:57 +01:00
Simon Giraudot 31c577fc47 Add region growing on circles for point_set_2 2020-12-30 14:51:15 +01:00
Simon Giraudot da90b6ee4f Add region growing on spheres for point_set_3 2020-12-30 08:48:28 +01:00
Laurent Rineau 47c4fc8aa2 Merge pull request #5279 from sgiraudot/RANSAC-Fix_ptrdiff_overflow-GF
[RANSAC] Fix ptrdiff overflow
2020-12-16 17:49:07 +01:00
Laurent Rineau fe34a5aa04 Merge pull request #5279 from sgiraudot/RANSAC-Fix_ptrdiff_overflow-GF
[RANSAC] Fix ptrdiff overflow
2020-12-16 17:47:45 +01:00
Simon Giraudot a7b2ed13f4 Fix conversion warning 2020-12-15 15:44:11 +01:00
Laurent Rineau 3301a47c44 Merge pull request #5255 from sgiraudot/Shape_detection-Fix_auto_param_detection-GF
[RANSAC] Fix detection of automatic parameter selection
2020-12-15 09:07:44 +01:00
Laurent Rineau a0e1b15da3 Merge branch '5.1.x-branch' into 5.2.x-branch 2020-12-15 09:07:21 +01:00
Laurent Rineau 91b1ab221f Merge pull request #5255 from sgiraudot/Shape_detection-Fix_auto_param_detection-GF
[RANSAC] Fix detection of automatic parameter selection
2020-12-15 09:04:55 +01:00
Simon Giraudot 360040dfd6 Fix ptrdiff_t overflow 2020-12-14 15:18:56 +01:00
Simon Giraudot 8c7d012297 Fix detection of automatic parameter selection + early exit if no shape can be detected 2020-12-08 15:35:22 +01:00
Laurent Rineau 89eea037da
Merge pull request #5234 from sgiraudot/Shape_detection-Add_validity_tests-GF 2020-12-07 16:32:07 +01:00
Simon Giraudot b2573a7b38 Fix Windows min/max garbage 2020-12-03 09:34:31 +01:00
Simon Giraudot 4a3ad83f21 Small optimization: pick several candidates at each loop 2020-12-01 14:28:00 +01:00
Simon Giraudot d2d766a38e Fix stop probability to take into account different shapes 2020-12-01 14:28:00 +01:00
Maxime Gimeno 393f547abf Fix size_t always >=0 warnings. 2020-11-27 09:10:24 +01:00
Simon Giraudot f30b1e5c06 Update RANSAC with octree changes 2020-10-27 14:06:12 +01:00
Jackson Campolattaro 943183490d Replace hardcoded bounding box with a method for determining the actual bounds of the tree 2020-10-19 16:20:45 -04:00
Laurent Rineau 0b2528c8b0 Merge branch 'releases/CGAL-5.0-branch' into 5.1.x-branch 2020-09-24 16:41:45 +02:00
Simon Giraudot c717fdaab6 Fix index access in RANSAC octrees 2020-09-17 14:51:04 +02:00
Simon Giraudot fb86a45d47 Adapt max level to old version 2020-09-17 14:19:04 +02:00
Simon Giraudot 64693edffa Fix RANSAC Octree wrapper: now Octrees are exactly the same as with old version 2020-09-17 11:45:34 +02:00
Simon Giraudot 604c793ba7 Fix nonnull warning 2020-09-01 09:14:10 +02:00
Jackson Campolattaro f1144724dd Rename Direct_octree to RANSAC_octree 2020-08-17 15:01:55 -04:00
Jackson Campolattaro 9e1505ad8a Eliminate Indexed_octree 2020-08-17 14:59:56 -04:00
Jackson Campolattaro 3252f82498 Update function invocations 2020-08-14 14:06:02 -04:00
Jackson Campolattaro ee2a93e8e1 Update refine method of Direct octree to match indexed 2020-08-10 12:39:19 -04:00
Jackson Campolattaro 939ba23f39 Add brackets to do-while loop for clarity 2020-08-08 14:14:06 -04:00
Jackson Campolattaro 87af9e7951 Add brackets to keep_searching check for clarity 2020-08-08 13:20:42 -04:00
Jackson Campolattaro 4c3c6c5140 Force bbox value to make sure it's not causing issues 2020-08-08 13:01:27 -04:00
Jackson Campolattaro e8b4d56aad Remove printouts from Efficient_RANSAC.h 2020-08-07 18:56:21 -04:00
Jackson Campolattaro fa61c44d73 Return to independently defined Direct octree 2020-08-07 18:52:48 -04:00
Jackson Campolattaro dd9878a20d Add reminder to replace fixed side length map size 2020-08-07 18:41:41 -04:00
Jackson Campolattaro c53790776c Give indexed octree consistent api with direct 2020-08-07 18:26:15 -04:00
Jackson Campolattaro 49baf4ce36 Mark location of issue 2020-08-07 17:17:22 -04:00
Jackson Campolattaro 7b7a4e2b6a Print out first input iterator value at multiple points in the code 2020-08-07 16:37:19 -04:00
Jackson Campolattaro 275feb0d3f Refactor check for enough samples 2020-08-07 11:03:23 -04:00
Jackson Campolattaro 6084084f3a Add more printouts to sample drawing 2020-08-07 10:47:25 -04:00
Jackson Campolattaro 1d19bca766 Remove printouts from refine() 2020-08-06 17:00:54 -04:00
Jackson Campolattaro 6905a65127 Add logic changing max level based on cluster epsilon 2020-08-06 16:05:10 -04:00
Jackson Campolattaro aa7b8114cf Implement node_containing_point using older version's logic 2020-08-06 15:07:03 -04:00
Jackson Campolattaro ba79b9ecc6 Refactor logic confirming the node was found 2020-08-06 14:56:17 -04:00
Jackson Campolattaro 8747114f72 Add printout whether the relevant node was found 2020-08-06 14:37:18 -04:00
Jackson Campolattaro 7337443b6f Include IO.h for printing octree nodes 2020-08-06 14:31:29 -04:00