Commit Graph

99513 Commits

Author SHA1 Message Date
Andreas Fabri 2c8d317960 Spatial_searching: Fix doc 2022-11-29 10:45:00 +00:00
Laurent Rineau 35fa93f9c0 Merge pull request #6935 from lrineau/CGAL-fix_autotest_with_ctest-GF
Fix autotest_cgal_with_ctest
2022-11-25 10:13:38 +01:00
Laurent Rineau a7326910e1 Merge pull request #7056 from MaelRL/BGL-Clarify_pmap_value_type-GF
Fix implicit conversion from `std::size_t` to `bool` creating ambiguous calls
2022-11-25 10:13:36 +01:00
Sébastien Loriot 6fd4c16942 TWS 2022-11-22 17:47:19 +01:00
Sébastien Loriot c0ba9b479e fix compilation issues 2022-11-22 17:42:02 +01:00
Sébastien Loriot 7322c7908d try to workaround warnings 2022-11-21 14:09:08 +01:00
Sébastien Loriot b8aa2558fd add missing using 2022-11-17 19:40:38 +01:00
Sébastien Loriot 285dbb96bf value must be removed
Was reported as a warning by MSVC 2022
2022-11-17 19:17:32 +01:00
Sébastien Loriot 8bbbf8d494 try workaround warnings 2022-11-17 19:11:00 +01:00
Sébastien Loriot 4d797b55c4 try working around a warning 2022-11-17 19:03:30 +01:00
Sébastien Loriot 33cfc700b2 fix unused warning 2022-11-17 12:12:01 +01:00
Mael Rouxel-Labbé 8437eec29d Fix implicit conversion from std::size_t to bool creating ambiguous calls 2022-11-17 11:17:54 +01:00
Laurent Rineau ba40f768b5 Merge pull request #7028 from afabri/Orthtree-CC-GF
Orthtree:  Fix memory leak
2022-11-15 16:59:29 +01:00
Laurent Rineau 48811a4622 Merge pull request #7034 from sloriot/PMP-coref_open_mesh_case_fix
Fix inconsistency check
2022-11-15 16:59:27 +01:00
Sébastien Loriot cd4de51a40 fix inconsistency check 2022-11-09 18:17:31 +01:00
Andreas Fabri 331ea2898a Orthtree: Fix memory leak 2022-11-09 08:47:54 +00:00
Andreas Fabri d1eca8310f typo 2022-11-09 08:47:37 +00:00
Laurent Rineau 8d3b7c72a0 Merge pull request #6978 from janetournois/Mesh_3-detect_cc_in_labeled_images-GF
Mesh 3 for labeled images - avoid vertex clusters on surfaces
2022-11-07 10:06:17 +01:00
Laurent Rineau 0b26507579 Merge pull request #7003 from sloriot/BGL-OpenMesh_const_point_operator
Add a const version of the operator
2022-11-07 10:06:13 +01:00
Sébastien Loriot 54629efea2 make the operator const 2022-11-03 15:51:11 +01:00
Jane Tournois 3816d8c2af boost::optional has_value() is available only since boost 1.68
and CGAL supports boost >= 1.66
2022-11-03 14:27:54 +01:00
Jane Tournois 7f70d48ab9 seed_cell cannot be infinite 2022-11-03 14:27:53 +01:00
Sebastien Loriot 168825a7f1 fix warning 2022-11-03 14:27:53 +01:00
Jane Tournois a8877c5a44 add struct Seed for better readability
and avoid using boost::none to be ready for std::optional (C++17)
2022-11-03 14:27:53 +01:00
Jane Tournois 7faa73bb27 locate of seed that is outside affine hull returns Cell_handle()
accessing the circumcenter was then failing
2022-11-03 14:27:52 +01:00
Jane Tournois 8b76b55b82 remove useless include 2022-11-03 14:27:52 +01:00
Jane Tournois 28a6946070 do not run random shooting in connected components that already are represented
during feature protection, most of the connected components, in particular on
the bbox boundary, are already represented and ready to start/hint Delaunay
refinement

if the chosen seed lies in a cell that already belongs (wrt Is_in_domain(cc))
to the right connected component, random shooting is canceled and
the loop continues to next seed
2022-11-03 14:27:52 +01:00
Jane Tournois db6b051973 on image boundaries, construct point away from the surface
this avoids creating point clusters on surfaces
2022-11-03 14:27:51 +01:00
Laurent Rineau 27cece3914 Merge pull request #6970 from MaelRL/SMP-Fix_ARAP_post_process-GF
Fix weights in ARAP parameterization's post processing
2022-11-02 16:18:58 +01:00
Laurent Rineau 1501d9943a Fix the bug!
See the empty columns in https://cgal.geometryfactory.com/CGAL/testsuite/results-5.6-Ic-100.shtml
and the CMake output at
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.6-Ic-100/Installation/TestReport_Christo_MSVC-2022-Community-Release.gz

With `Scripts/developer_scripts/run_testsuite_with_ctest`, CMake is
called with `-DWITH_tests=ON -DCGAL_TEST_SUITE=ON`.

We do not want to disable that option `-DWITH_tests=ON` because it
is crucial for the correct behavior of `run_testsuite_with_ctest`.
2022-10-28 15:19:09 +02:00
Mael Rouxel-Labbé 2a679483b2 Fix ARAP post processing
The formula of weights is "- tan(theta / 2) / length", with:
 tan ( theta / 2 ) = sin ( theta ) / ( 1 + cos ( theta ) )
                   = ( 2 * A / |v1| * |v2| ) / ( 1 + v1 . v2 / |v1| * |v2| )
		   = 2 * A / ( |v1| * |v2| + v1 . v2 )

with A the _unsigned_ area.
2022-10-16 16:22:29 +02:00
Mael Rouxel-Labbé 2fe82ec9d9 Add an example for ARAP parameterization 2022-10-16 16:22:15 +02:00
Laurent Rineau adc5bd4677 Merge pull request #6864 from janetournois/Mesh_3-fix_weighted_images-GF
Mesh 3 - fix construction of weights image for labeled image input
2022-10-13 15:14:11 +02:00
Laurent Rineau ae8101d615 Merge pull request #6931 from MaelRL/PMP-remove_degen_fix_bad_removal-GF
Purge to-be-border halfedges from edges-to-collapse sets
2022-10-13 15:14:09 +02:00
Laurent Rineau 28e6e7249f 5.4.x-branch now targets CGAL-5.4.4 2022-10-12 15:28:35 +02:00
Laurent Rineau e5687eb69f Merge pull request #6918 from lcaraffa/Triangulation-is_valid-lc
Triangulation_d: fix invalid triangulation after I/O
2022-10-07 15:46:11 +02:00
Laurent Rineau 437dbf82a9 Merge pull request #6925 from MaelRL/OBB-Do_not_use_void_as_default-GF
Do not use `void` as default for the geometric traits if Eigen is not present
2022-10-07 15:46:08 +02:00
Laurent Rineau 7db002804c Merge pull request #6927 from lrineau/Mesh_3-fix_leaks-GF
Mesh_3: Fix a memory leak in the parallel code
2022-10-07 15:46:06 +02:00
Jane Tournois 9bb4fb4d15 protect debug code with macro
and remove default filename ""
2022-10-06 15:10:37 +02:00
Jane Tournois c64a0d8648 add more details about how to choose sigma 2022-10-06 10:44:26 +02:00
Sébastien Loriot d6d2188cc7 fix warning 2022-10-05 19:33:00 +02:00
Laurent Rineau ea35fa8f88 Fix autotest_cgal_with_ctest
That commit makes the CMake variables `CGAL_TEST_SUITE` (the new one)
and `RUNNING_CGAL_AUTO_TEST` (the legacy one) completely equivalent.
2022-10-05 15:06:02 +02:00
Mael Rouxel-Labbé 60d50a8b57 Fix not purging to-be-border halfedges from edges-to-collapse sets 2022-10-04 22:57:37 +02:00
Laurent Rineau 207a1e896b Merge pull request #6796 from janetournois/Mesh_3-compare_distance_performance_issue-jtournois
Mesh_3 speedup (filter failures in `Compare_distance_3(Point_3, Segment_3, Point_3)` )
2022-10-04 13:48:18 +02:00
Laurent Rineau de80833223 Merge pull request #6845 from sloriot/PMP-coref_open_mesh_case
PMP corefinement: Handle inconsistency with open mesh as input
2022-10-04 13:48:16 +02:00
Laurent Rineau fef4d1b43b Merge pull request #6863 from lrineau/Polyhedron-demo_fix_display_of_protecting_spheres-GF
Polyhedron demo - Fix the display of protecting balls (second version)
2022-10-04 13:48:13 +02:00
Laurent Rineau ff2bab36b0 Merge pull request #6867 from sloriot/PMP-collision_detection_copy
Add default copy constructor and operator=
2022-10-04 13:48:11 +02:00
Laurent Rineau b8b8d98281 Merge pull request #6872 from MaelRL/PMP-Fix_keep_LCC-GF
Fix dry-run of keep_largest_CCs dumping the wrong faces
2022-10-04 13:48:08 +02:00
Sébastien Loriot 29d543c9f4 remove tabs 2022-10-04 09:16:32 +02:00
Sébastien Loriot 96b205d9b0 add test from issue #5275 2022-10-03 18:55:44 +02:00