Commit Graph

1285 Commits

Author SHA1 Message Date
Laurent Rineau 03e89cc97b fix periodic_3_triangulation_3_demo 2023-09-13 17:57:54 +02:00
Nicolas Saillant cf1b5fd46a Update CMakeLists for QT6 2023-09-13 11:38:45 +02:00
Laurent Rineau 873c3b26cf remove a few occurrences of "qt5"
There are still a lot!
2023-09-11 17:46:27 +02:00
Nicolas Saillant 1997bd02bc Merge remote-tracking branch 'refs/remotes/afabri/CGAL-Qt6-GF' into pr/afabri/7397 2023-09-11 16:21:34 +02:00
Nicolas Saillant 0d7280ea63 CMakeLists updates for Qt6 2023-09-11 16:10:20 +02:00
Laurent Rineau fed2af5547 Merge remote-tracking branch 'SaillantNicolas/pr/afabri/7397' into CGAL-Qt6-GF 2023-09-11 11:51:38 +02:00
Nicolas Saillant a4136707b2 More CMakeLists Updates for QT6 2023-09-11 09:51:06 +02:00
Laurent Rineau b286df4b96 fix warnings (and ASAN errors) 2023-09-08 11:49:32 +02:00
albert-github ad41766454 issue #7395 Improvement of layout of model relations
Corrected `cgalModels` to `cgalHasModes` inside `cgalHasNodelsBegin` / `cgalHasModelsEnd`
2023-07-18 13:23:37 +02:00
Mael c6fd1d0316
Merge branch 'master' into CGAL-Qt6-GF 2023-07-18 10:49:58 +02:00
albert-github de3ba0f47c Merge remote-tracking branch 'upstream/master' into feature/issue_7395 2023-07-17 10:17:34 +02:00
Laurent Rineau 074d63119a Merge pull request #7586 from MaelRL/P23T23-Unique_iterators-GF
Add unique simplex iterators for periodic triangulations
2023-07-17 09:52:23 +02:00
albert-github 4e5578d469 issue #7395 Improvement of layout of model relations
- based on review
2023-07-15 13:12:15 +02:00
Sébastien Loriot 125542eb62 Merge remote-tracking branch 'cgal/master' 2023-07-11 12:59:21 +02:00
albert-github 301728a8a9 issue #7395 Improvement of layout of model relations
- Completed the cgalModels part
2023-07-09 12:43:36 +02:00
Mael Rouxel-Labbé f41e69a5fe Misc fixes 2023-07-07 02:09:35 +02:00
Mael Rouxel-Labbé 5759ce49ae Add unique simplex iterators 2023-07-07 02:04:01 +02:00
albert-github ee2a55279d issue #7395 Improvement of layout of model relations
- Completed the cgalHasModel part
- corrected spelling of `Has Model` and `Is Model Of` to `Has model` and `Is model of`
2023-07-06 17:35:34 +02:00
Sébastien Loriot 573de7f29e Merge branch 'master' 2023-06-22 13:38:49 +02:00
Sébastien Loriot f936680600 Merge remote-tracking branch 'cgal/master' into HEAD 2023-06-15 18:48:39 +02:00
Sebastien Loriot b1b02d64fe
P3M3: Non-cubic domains, fixes, improvements (#7062)
## Summary of Changes

- Add a dummy point generator that is agnostic to the periodic domain's
geometry, allowing P3M3 to handle non-cubic domain.
- Add an example of P3M3 running on polyhedral domains.
- Fix a few issues in SMDS_3's tet soup reading relating to
non-manifoldness + general IO code speed improvements.
- Fix a few issues in P3M3's medit output and always duplicate facets to
reduce the quantity of non-manifoldness occurences.
- Fix an issue with including Mesh_3 headers before P3M3's.
- Fix periodic point projection (for Mesh_3 optimizers) badly computing
the projection direction
- Robustify a handful of P3M3 functions that were using intermediate
constructions rather than the <Point, Offset> API (which uses filtered
predicates and thus yields proper robustness)
- Misc minor code cleaning / modernization

ToDo:
- [x] Check if some medit IO issues are fixed
- [x] Add non-manifoldness flag to read_MEDIT
- [x] Fix value of orthosphere_radius_threshold
- [x] Check calls of insert_dummy_points() (use generic)
- [x] Check doc of P3M3 about cubic domains requirement

Not done:
- [ ] Fix sharp features for periodic polyhedral domains (problems due
to changing weights creating cover change...). Code:
https://gist.github.com/MaelRL/357c52dc04e16a162f13a3c6860a1398; WIP
diff: https://gist.github.com/MaelRL/f98809964acffbacb6d3f42793e2654e

## Release Management

* Affected package(s): `Mesh_3`,  `P3M3`, `P3T3`, `SMDS3`
* Issue(s) solved (if any): Fix #6997, Fix #7214
* Feature/Small Feature (if any): TODO
* License and copyright ownership: no change
2023-05-30 19:13:45 +02:00
Mael Rouxel-Labbé 5656a7d11c Rework P3M3 snapping
Can't guarantee that the double construction is correct, even by going
through an intermediate exact offset computation; so if there's an issue,
just snap the intermediate point to the domain (it should have been close
enough in the first place)

Remove all functions related to zealous snapping that are just to get
"nice" coordinates (and not 1e-17).
2023-05-26 11:18:52 +02:00
Laurent Rineau d079559577 Merge pull request #7413 from lrineau/CGAL-fix-Qt5-CMake-GF
Qt5::Svg is now only optional for CGAL_Qt5
2023-05-11 16:55:28 +02:00
Mael 532b82cb9b
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-05-04 17:28:47 +02:00
Mael Rouxel-Labbé d8f4bc059d Fix conversion warnings 2023-05-03 12:24:23 +02:00
Mael Rouxel-Labbé d0f63f52c7 Fix wrong argument type in P3T3 offset's operator[] 2023-05-02 14:14:27 +02:00
Laurent Rineau 0576e883f9 Merge branch 'CGAL-fix-Qt5-CMake-GF' into CGAL-Qt6-GF
# Conflicts:
#	AABB_tree/demo/AABB_tree/CMakeLists.txt
#	Alpha_shapes_3/demo/Alpha_shapes_3/CMakeLists.txt
#	Arrangement_on_surface_2/demo/Arrangement_on_surface_2/CMakeLists.txt
#	Circular_kernel_3/demo/Circular_kernel_3/CMakeLists.txt
#	GraphicsView/demo/Alpha_shapes_2/CMakeLists.txt
#	GraphicsView/demo/Apollonius_graph_2/CMakeLists.txt
#	GraphicsView/demo/Bounding_volumes/CMakeLists.txt
#	GraphicsView/demo/Circular_kernel_2/CMakeLists.txt
#	GraphicsView/demo/Generator/CMakeLists.txt
#	GraphicsView/demo/GraphicsView/CMakeLists.txt
#	GraphicsView/demo/L1_Voronoi_diagram_2/CMakeLists.txt
#	GraphicsView/demo/Largest_empty_rect_2/CMakeLists.txt
#	GraphicsView/demo/Periodic_2_triangulation_2/CMakeLists.txt
#	GraphicsView/demo/Polygon/CMakeLists.txt
#	GraphicsView/demo/Segment_Delaunay_graph_2/CMakeLists.txt
#	GraphicsView/demo/Segment_Delaunay_graph_Linf_2/CMakeLists.txt
#	GraphicsView/demo/Snap_rounding_2/CMakeLists.txt
#	GraphicsView/demo/Spatial_searching_2/CMakeLists.txt
#	GraphicsView/demo/Stream_lines_2/CMakeLists.txt
#	GraphicsView/include/CGAL/Qt/DemosMainWindow_impl.h
#	Hyperbolic_triangulation_2/demo/Hyperbolic_triangulation_2/CMakeLists.txt
#	Installation/cmake/modules/CGAL_add_test.cmake
#	Linear_cell_complex/demo/Linear_cell_complex/CMakeLists.txt
#	Optimal_transportation_reconstruction_2/demo/Optimal_transportation_reconstruction_2/CMakeLists.txt
#	Periodic_3_triangulation_3/demo/Periodic_3_triangulation_3/CMakeLists.txt
#	Periodic_3_triangulation_3/demo/Periodic_Lloyd_3/CMakeLists.txt
#	Polyhedron/demo/Polyhedron/polyhedron_demo_macros.cmake
#	Polyline_simplification_2/demo/Polyline_simplification_2/CMakeLists.txt
#	Principal_component_analysis/demo/Principal_component_analysis/CMakeLists.txt
#	Triangulation_3/demo/Triangulation_3/CMakeLists.txt
#	Triangulation_on_sphere_2/demo/Triangulation_on_sphere_2/CMakeLists.txt
2023-04-28 13:49:58 +02:00
Laurent Rineau fe5a36c08e fix all the CMakeLists.txt for Qt5 2023-04-27 17:27:37 +02:00
Sébastien Loriot a88af6c0c6 boost::array -> std::array 2023-04-23 22:37:07 +02:00
Andreas Fabri 0574c6ba4c Change the remaining CMakeLists.txt [skip ci] 2023-04-20 16:35:14 +01:00
Mael Rouxel-Labbé c593b76a38 Fix conversion warnings 2023-04-19 12:49:35 +02:00
Mael Rouxel-Labbé 1a5826f11a Merge remote-tracking branch 'cgal/master' into SLS-Weighted_skeleton-GF 2023-04-17 12:48:30 +02:00
Jane Tournois 170f54f0c0 avoid conversion warnings 2023-04-13 17:18:35 +02:00
Mael Rouxel-Labbé 58cc66188e Fix point() for P3T3/P3DT3/P3RT3/P3M3 2023-03-23 23:47:58 +01:00
Mael Rouxel-Labbé cd0c81a98a Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-03-20 10:14:27 +01:00
Mael Rouxel-Labbé 85911f1b64 Merge remote-tracking branch 'cgal/master' into SLS-Weighted_skeleton-GF 2023-03-20 10:06:38 +01:00
Mael Rouxel-Labbé 442770188f Cube > cuboid in P3M3 doc 2023-03-17 14:43:43 +01:00
Mael Rouxel-Labbé 4f6846776a Fix conversion warning 2023-03-17 14:43:26 +01:00
Andreas Fabri 0d320e48a8 Merge branch 'Number_types-fix_VC2017_boost_mp-GF' into CORE-boost_mp_number-GF 2023-03-17 08:28:10 +01:00
albert-github 2d60f46985 issue #7231 Improvement of layout of refines relations.
- Adjusted cgalRefines according to reviews
- Implemented it in all files
2023-03-14 17:37:50 +01:00
Sébastien Loriot 9e72361537 All packages depends now on CGAL_Core (like Kernel) 2023-02-20 15:24:16 +01:00
Mael Rouxel-Labbé 9d9a51731a Fix typo 2023-02-09 23:27:01 +01:00
Mael Rouxel-Labbé a8d38e84af Fix warnings 2023-01-31 11:22:54 +01:00
Mael Rouxel-Labbé d9b6eb856b Further robustify periodic circumcenter computations 2023-01-30 17:14:33 +01:00
Mael 153c603209
Merge branch 'master' into CGAL-Clean_CMakeLists.txt-GF 2023-01-27 22:09:02 +01:00
Mael 8f703b54cb
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-01-27 21:48:32 +01:00
Mael Rouxel-Labbé d982e8e359 Reduce the runtime of dummy covering tests
and actually test something...
2023-01-23 11:49:39 +01:00
Mael Rouxel-Labbé fca313bba9 Fix compilation with homogeneous exact number types 2023-01-23 11:30:49 +01:00
Mael Rouxel-Labbé efa486ca1c Remove useless typedef 2023-01-23 11:30:14 +01:00
Mael Rouxel-Labbé 3f4ebb1e0e Remove unused variables 2023-01-02 13:54:14 +01:00
Mael 0ff7882997
Merge branch 'master' into feature/bug_documentation_spell_20221113 2022-12-06 22:21:06 +01:00
Mael Rouxel-Labbé e1986b905e Fix some concept not matching actual requirements 2022-12-06 17:41:34 +01:00
Mael Rouxel-Labbé 2cdb9086dc Further robustify robust_canonicalize_point(): remove many constructions 2022-12-06 15:08:58 +01:00
Mael Rouxel-Labbé 6ab2a2f72c Add a macro to use a sparser dummy grid (can't be used with domain w/ features) 2022-12-06 14:50:17 +01:00
Mael Rouxel-Labbé c475f7de45 Add a comment to clarify that cells are destroyed when P3T3::remove rejects 2022-12-06 14:49:47 +01:00
Mael Rouxel-Labbé 28f672a5b4 Further robustification improvements to P3_mesh_triangulation_3:
avoid canonicalization (i.e. construction) when possible
2022-12-06 14:48:59 +01:00
Mael Rouxel-Labbé b115a680bf Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2022-12-06 09:47:46 +01:00
Mael 6538b22e06
Merge branch 'master' into CGAL-Clean_CMakeLists.txt-GF 2022-12-05 16:03:41 +01:00
Mael Rouxel-Labbé 7910d82c6c Misc minor changes 2022-12-01 12:34:50 +01:00
Mael Rouxel-Labbé c255b51b4b Generalize orthosphere radius threshold computation to non-cubic domains 2022-11-29 12:15:24 +01:00
Mael Rouxel-Labbé 0fdfec9ccb Same as 6021d5a9f1 for tr.point(Cell_handle, int) 2022-11-25 14:16:48 +01:00
Mael Rouxel-Labbé 6021d5a9f1 Fix making P3T3 an abstract class 2022-11-24 12:59:17 +01:00
Mael Rouxel-Labbé b5c21e1f5d Http -> https + update some dead links 2022-11-23 18:54:37 +01:00
Mael Rouxel-Labbé b10b84fb7f Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2022-11-18 16:47:07 +01:00
Mael Rouxel-Labbé a2b726de77 Add a test for the generic dummy point generator 2022-11-18 16:14:05 +01:00
Mael Rouxel-Labbé 9699035179 Add a dummy point generator that can handle non-cubic domains 2022-11-18 16:13:13 +01:00
Mael Rouxel-Labbé c7804eeca9 Add some precondition on offset values 2022-11-18 00:34:55 +01:00
Mael Rouxel-Labbé 1869294e50 Misc code improvements 2022-11-18 00:21:58 +01:00
Mael Rouxel-Labbé b434490de1 Add virtual functions point(VH) / point(CH, int) to the base P3T3 2022-11-18 00:19:24 +01:00
Mael Rouxel-Labbé c8a7b8864f Remove garbage in P3T3::move_point(): currently it is only remove + insert 2022-11-18 00:18:49 +01:00
Mael Rouxel-Labbé c682f8dc20 Add some comments 2022-11-18 00:17:22 +01:00
albert-github eed54a0ae5 spelling corrections
Some spelling corrections (Directories starting with `O`-`S` , first part),
some backward work
some forward work
2022-11-15 18:45:39 +01:00
albert-github 45478184de spelling corrections
Some spelling corrections (Directories starting with `E`-` L`),
some backward work
some forward work
2022-11-15 13:39:40 +01:00
Mael Rouxel-Labbé bd52dc631a Misc code cleaning 2022-10-26 10:20:44 +02:00
Mael Rouxel-Labbé 363d1daaef Some more conversions to non-package specific assertions 2022-09-23 15:20:24 +02:00
Andreas Fabri d3fca65ae5 CGAL: No longer per package assertions 2022-09-23 12:49:40 +01:00
Mael Rouxel-Labbé 7cb21c24b0 Uniformize message() for missing 3rd party libraries
STATUS for non-essential, NOTICE for important stuff
2022-09-06 16:07:31 +02:00
Laurent Rineau 2feb9a29ce Merge pull request #6655 from lrineau/Triangulation_3-fix_use_after_free-GF
Triangulation_3: fix a use-after-free in `T3::remove` and `T3::move*` methods
2022-06-15 10:20:48 +02:00
Laurent Rineau c2fa2cb9fe Merge pull request #6655 from lrineau/Triangulation_3-fix_use_after_free-GF
Triangulation_3: fix a use-after-free in `T3::remove` and `T3::move*` methods
2022-06-15 10:18:57 +02:00
Laurent Rineau 81ac3b9a11 One more use-after-free in P3T3 2022-06-10 09:46:09 +02:00
Laurent Rineau 2288225448 Massive update of CMake policies to version 3.23 2022-05-06 09:34:35 +02:00
Laurent Rineau 95b6bf33a7 Merge pull request #6395 from afabri/TDS-better_initialization_of_Unique_hash_map-GF
TDS: Initialize the size of Unique_hash_map
2022-03-18 15:58:28 +01:00
Andreas Fabri 4eac47f274 fix typo 2022-03-09 12:57:23 +00:00
Andreas Fabri cdbf0d7d9a Initialize the size of Unique_hash_map 2022-03-09 11:34:12 +00:00
Andreas Fabri b90d86edb3 Deal with P3T3 2022-01-18 18:53:02 +00:00
Laurent Rineau 3e877fa124 Merge pull request #6109 from afabri/CGAL-VC_max_warning-GF
PMP: Fix Warnings in Master
2021-11-18 12:27:21 +01:00
Sébastien Loriot ab48f63e30 update latest cmake version tested 2021-11-09 10:58:47 +01:00
Sébastien Loriot 58181afcdb remove useless include directives 2021-11-09 10:16:12 +01:00
Sébastien Loriot 6905342894 remove non-default copy constructor 2021-11-08 14:15:41 +01:00
Laurent Rineau f581ff74d3 Merge pull request #5427 from sloriot/CGAL_data-moving_files
Regroup data: moving files

# Conflicts:
#	Nef_3/archive/triangulation/include/CGAL/partition_is_valid_2.h
2021-10-07 14:44:01 +02:00
Mael Rouxel-Labbé 521c72d57e Fix typos 2021-10-04 13:34:07 +02:00
Sébastien Loriot 47028cd184 automatically move data files in data dir + update paths
Done for OFF/OBJ/STL/XYZ/PWN/PLY
2021-10-04 09:42:49 +02:00
Sébastien Loriot 250b8e9161 remove ./ prefix 2021-10-04 09:32:04 +02:00
Sébastien Loriot 5945e48a3e restore sub-directories accidently removed in 98e471849b 2021-09-17 08:14:06 +02:00
Sebastien Loriot 575939c64f
Merge pull request #5952 from sloriot/SS-remove_Polygon_dep
remove artificial dependency to Polygon
2021-09-10 17:40:20 +02:00
Sebastien Loriot 4610cf3c66
Merge pull request #5904 from sloriot/CGAL-remove_config_flags
Replace macros with inline functions and remove a config flag
2021-09-10 17:38:50 +02:00
Sébastien Loriot 8b228a450f remove probably useless pragma from 2014
CGAL_USE should do the job now
2021-09-07 12:28:15 +02:00
Sébastien Loriot f5d2fb28a2 remove artificial dependency to Polygon 2021-09-01 16:41:36 +02:00
Sébastien Loriot 2c889a3b52 remove unused files 2021-08-26 11:43:58 +02:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00