songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
48,698 Commits 3 Branches 156 Tags 974 MiB
Commit Graph

48698 Commits

Author SHA1 Message Date
Eric Berberich 5112dbdaab improved remark 2012-09-28 11:52:17 +00:00
Efi Fogel 44463d4951 updated 2012-09-26 20:25:39 +00:00
Efi Fogel 011ecd8334 1st revision 2012-09-26 20:24:17 +00:00
Eric Berberich 838f495582 phrasing improvement 2012-09-24 07:40:17 +00:00
Eric Berberich 5b3f9330ec the x-index needs a correction in some cases, when stored with a local minimum 2012-09-23 15:05:42 +00:00
Eric Berberich a6da5944fd relying on local minima does not require to check direction of curves anymore 2012-09-20 12:20:44 +00:00
Efi Fogel 475ed9f383 1st revision 2012-09-20 08:16:01 +00:00
Efi Fogel 75de1e2d4e 1st revision 2012-09-19 17:54:58 +00:00
Efi Fogel 20afae72e6 fixed typo 2012-09-18 22:40:28 +00:00
Efi Fogel 5b2f07e536 removed erroneous assertion 2012-09-18 22:31:48 +00:00
Eric Berberich 1de4431159 fixed typo 2012-09-04 07:10:44 +00:00
Eric Berberich 18b9097287 removed old code 2012-08-22 21:24:42 +00:00
Eric Berberich 9bcfe3f543 removed a compiler warning && || 2012-08-22 21:24:08 +00:00
Eric Berberich c06575dc75 two fixes: indices + codefactoring 
1) when deleting he1/he2 the start of the two loops might
lie on different sides of the identification, we added
a fix
2) the _compute_sign_and_local_minima for a closed loop
now also uses the _compute_indices function
 2012-08-21 22:11:39 +00:00
Eric Berberich 3567350e87 added images of testcases 2012-08-21 21:55:17 +00:00
Efi Fogel c8cabda314 inserting minima at the back so that if NULL is inserted it is always at the front 2012-08-17 01:10:29 +00:00
Efi Fogel 61bc918ef3 unfolded the loop in _compute_signs_and_local_minima 2012-08-17 00:53:08 +00:00
Efi Fogel 38034d615d unfolded the loop in _compute_signs_and_local_minima 2012-08-17 00:52:30 +00:00
Efi Fogel 6085ea8d58 cleanup 2012-08-16 22:35:04 +00:00
Eric Berberich fe61fd5f72 added TODO 2012-08-08 15:18:31 +00:00
Eric Berberich a379550e7b correct sign 2012-08-08 15:12:58 +00:00
Eric Berberich 093a15f156 more putput 2012-08-08 14:47:37 +00:00
Eric Berberich 4f68658679 fixed loop in _compute_signs_and_local_minima for closed cycles 
There are two variants: f1 == f2 and f1 != f2
In the second case he1 and he2 form closed outer ccbs that will be 
merged into one, in the first case, the removal of he1/he2 splits 
a single ccb into two (and we simulate to walk these two already)
Comment: test03 in spherical_removal does not yet work, everything 
else is ok
 2012-08-08 12:42:05 +00:00
Eric Berberich e3c59a5a08 added TODO 2012-08-07 16:04:45 +00:00
Eric Berberich ae11cc5e90 removed subsumed code 2012-08-07 15:51:44 +00:00
Eric Berberich d9014e1962 implement boundaries of same face in terms of comparing signs of ccbs 
the case for torus is not yet covered
 2012-08-07 15:50:59 +00:00
Eric Berberich 1716d3434a removed old Sign_of_path 2012-08-07 15:26:18 +00:00
Eric Berberich f486fffb8e prepare to compare signs to be used for 'boundaries of same face' 
also clean up: remove sign_of_path
 2012-08-07 15:25:16 +00:00
Eric Berberich aa8066d7db some documentation 2012-08-07 14:37:04 +00:00
Eric Berberich 77b79f3dda merge from next 2012-08-07 13:52:31 +00:00
Eric Berberich 0ecdae3143 removed old cold 2012-08-07 13:30:44 +00:00
Eric Berberich 5404590424 moved swapping for he with he->opposite on edge removal into _remove_edge 
Rationale: swapping requires to compute signs of ccbs, which will be
used in _remove_edge again (for hole_creation)
 2012-08-07 13:24:09 +00:00
Laurent Rineau af3bf45308 Workaround to svncommitemail 2012-08-07 12:27:53 +00:00
Philipp Möller 79b30908d5 WARNFIX: Silence a good part of unused variable/parameter warnings. 
Wextra results in a dreadful wall of yellow in the test-suite and is
scary when using CGAL. Reduce some of the noise by silencing the
obvious cases with CGAL_USE or comments.
 2012-08-07 11:04:32 +00:00
Efi Fogel 6d9973d15d updated 2012-08-07 09:46:18 +00:00
Laurent Rineau 2cec4e33c3 WARNFIX 
Fix the unused parameter Q2 of function intersection_test_edge() in
<CGAL/Triangle_2_Triangle_2_do_intersect.h>.

Fix also a set-by-unused variable in
<CGAL/Intersections_2/Triangle_2_Triangle_2_intersection_impl.h>.
 2012-08-06 15:32:55 +00:00
Laurent Rineau 640c7355ec Fix: was no longer working in out-of-source build! 2012-08-06 13:21:07 +00:00
Eric Berberich 18f35b051c ensure that upon a future merge, tests do not get accidentilly disabled 2012-08-06 13:05:17 +00:00
Eric Berberich 13f17350f5 adaptions to new signatures of internal insertion functions 
question open: Do we have to care about swapping of predecessors
halfedges, or do we have to disallow it?
 2012-08-06 12:53:40 +00:00
Laurent Rineau 02a085197c Save last version 2012-08-06 12:38:28 +00:00
Efi Fogel c2e6b9a033 updated 2012-08-06 11:51:31 +00:00
Efi Fogel 81be4d32e9 updated 2012-08-06 11:50:15 +00:00
Eric Berberich 44e8cf7893 init dummies 2012-08-06 11:28:43 +00:00
Eric Berberich 5afcc354b2 adaptions to new signatures of internal insertion functions 
question open: Do we have to care about swapping of predecessors
halfedges, or do we have to disallow it?
 2012-08-06 10:17:09 +00:00
Eric Berberich 16404bbc57 topology traits function face_split_after_edge_insertion now works with signs of implied ccbs 2012-08-06 09:49:28 +00:00
Eric Berberich cd16c29d63 first step to replace cmp with cv_dir 2012-08-06 09:29:39 +00:00
Eric Berberich 76f897b6ed cleanup and rename of prev1_on_outer_ccb_and_not_prev2 to swapped_predecessors 
The variable got a passive interpretation now, as it is the output of
_insert_at_vertices
 2012-08-06 09:22:36 +00:00
Eric Berberich 1ef730fd7b moved swapping of predecessor halfedges into _insert_vertices 
needed two adaptions in its signature:
1) add new bool-by-reference which returns whether swapping took place
2) add new bool which determines whether swapping is allowed (true by default)
Changes in Env_3 and Bsop_2 are still needed
 2012-08-05 22:29:45 +00:00
Laurent Rineau bbe4a92575 updated crontab (automated commit) 2012-08-05 18:18:04 +00:00
Laurent Rineau 1e0288a0b1 next targets CGAL-4.2 2012-08-05 17:56:34 +00:00