543d424f58
Periodic_triangulation_3: Fix warning in demo
2025-12-03 11:36:14 +01:00
0fc710e95d
Fix bad 'if' condition & warning ( #9126 )
...
## Summary of Changes
```
Building CXX object test/Stream_support/CMakeFiles/issue8155.dir/issue8155.cpp.o
cd /home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/test/Stream_support && /bin/clang++ -DCGAL_DATA_DIR=\"/mnt/testsuite/data\" -DCGAL_TEST_SUITE=1 -DCGAL_USE_GMPXX=1 -I/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/include -I/mnt/testsuite/include -isystem /usr/local/boost/include -Wall -O3 -std=c++20 -DCGAL_NDEBUG -MD -MT test/Stream_support/CMakeFiles/issue8155.dir/issue8155.cpp.o -MF CMakeFiles/issue8155.dir/issue8155.cpp.o.d -o CMakeFiles/issue8155.dir/issue8155.cpp.o -c /mnt/testsuite/test/Stream_support/issue8155.cpp
/mnt/testsuite/test/Stream_support/issue8155.cpp:27:17: warning: overlapping comparisons always evaluate to true [-Wtautological-overlap-compare]
27 | if (len > 0 || len != 1.0) {
| ~~~~~~~~^~~~~~~~~~~~~
1 warning generated.
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-36/Stream_support/TestReport_cgaltest_ArchLinux-clang-CXX20-Release.gz
## Release Management
* Affected package(s): `Stream_support`
* Issue(s) solved (if any): n/a
* Feature/Small Feature (if any): n/a
* License and copyright ownership: no change
2025-11-19 14:43:26 +01:00
dee5ed8cc2
Fix edge collapse with incident non-triangular faces ( #9117 )
...
Make collapse able to handle non-triangular faces. The fix is easy as
you simply don't need to join faces in case the face won't disappear
after collapse
**TODO:**
update doc and constrained version
2025-11-19 14:42:28 +01:00
737bcb264e
Doc: fixing thirdparty links ( #9134 )
...
## Summary of Changes
fixed Metis/Eigen3/Qt6 links in Thirdparty
removed LEDA from doc as it is outdated
## Release Management
* Affected package(s): Documentation
2025-11-19 14:41:58 +01:00
2f9854b422
Fix warning about discarding return type of function with [[nodiscard]] ( #9127 )
...
## Summary of Changes
```
Building CXX object test/Generator_Demo/CMakeFiles/Generator_2.dir/Generator_2.cpp.o
cd /home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/test/Generator_Demo && /bin/clang++ -DCGAL_TEST_SUITE=1 -DCGAL_USE_GMPXX=1 -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_KEYWORDS -DQT_OPENGLWIDGETS_LIB -DQT_OPENGL_LIB -DQT_WIDGETS_LIB -I/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/test/Generator_Demo -I/mnt/testsuite/test/Generator_Demo -I/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/include -I/mnt/testsuite/include -I/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/test/AABB_tree_Demo -isystem /home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/test/Generator_Demo/Generator_2_autogen/include -isystem /usr/include/qt6/QtCore -isystem /usr/include/qt6 -isystem /usr/lib/qt6/mkspecs/linux-g++ -isystem /usr/include/qt6/QtOpenGLWidgets -isystem /usr/include/qt6/QtOpenGL -isystem /usr/include/qt6/QtGui -isystem /usr/include/qt6/QtWidgets -Wall -fno-direct-access-external-data -MD -MT test/Generator_Demo/CMakeFiles/Generator_2.dir/Generator_2.cpp.o -MF CMakeFiles/Generator_2.dir/Generator_2.cpp.o.d -o CMakeFiles/Generator_2.dir/Generator_2.cpp.o -c /mnt/testsuite/test/Generator_Demo/Generator_2.cpp
In file included from /mnt/testsuite/test/Generator_Demo/Generator_2.cpp:27:
In file included from /mnt/testsuite/include/CGAL/Qt/DemosMainWindow.h:130:
/mnt/testsuite/include/CGAL/Qt/DemosMainWindow_impl.h:224:3: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
224 | about_CGAL.open(QIODevice::ReadOnly);
| ^~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-36/Generator_Demo/TestReport_gimeno_ArchLinux-clang.gz
## Release Management
* Affected package(s): `GraphicsView`
* Issue(s) solved (if any): n/a
* Feature/Small Feature (if any): n/a
* License and copyright ownership: no change
2025-11-19 14:41:07 +01:00
e12a760f03
fixed Metis/Eigen3/Qt6 links in Thirdparty
...
removed LEDA from doc as it is outdated
2025-11-13 16:32:40 +01:00
12445cc6e1
revert unintended modification
2025-11-13 11:52:21 +01:00
07347da411
Fix Ceres deprecation warning ( #9121 )
...
## Summary of Changes
Changing the used cmake target for Ceres to Ceres::ceres.
## Release Management
* Affected package(s): Installation, Polygon_mesh_processing
2025-11-13 10:02:36 +01:00
d226e504c4
fix a warning
...
use the correct implementation `popupAboutCGAL` from the base class
2025-11-12 16:48:59 +01:00
097fc2c5ab
fix memory leaks
2025-11-12 16:48:29 +01:00
066159f792
assertion should be before the removal...
2025-11-10 10:17:33 +01:00
31734df2ef
Fix warning about discarding return type of function with [[nodiscard]]
2025-11-07 17:16:31 +01:00
3ef43324bb
Fix bad 'if' condition & warning
2025-11-07 17:05:21 +01:00
3c7d507530
update doc + apply changes to the constrained version
2025-11-06 19:40:48 +01:00
faae741666
Eigen3 5.0.0 support ( #9112 )
...
## Summary of Changes
Adding support for Eigen3 5.0.0 by updating CMakeLists.txt scripts.
## Release Management
* Issue(s) solved (if any): fix #9110
2025-11-06 10:03:20 +01:00
9e36c6744b
adding support for Eigen3 5.0.0
...
moving the Eigen3 version check into CGAL_Eigen3_support.cmake
2025-11-06 10:01:01 +01:00
05bf3c4ffc
Changing cmake target for Ceres
2025-11-04 17:04:58 +01:00
25005a97d8
clean up
2025-11-03 09:24:31 +01:00
3fe83c7ce0
handle non-triangular faces
2025-10-31 11:36:44 +01:00
c60cc5049d
Workaround erros with recent gcc ( #9105 )
...
Should fix [those
errors](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-23/Stream_lines_2/TestReport_lrineau_Ubuntu-latest-GCC6-CXX1z.gz )
2025-10-30 20:17:22 +01:00
712464b690
try to please recent gcc
2025-10-21 08:26:34 +02:00
b08f0a4aae
Handle case of identical projected points ( #9100 )
...
Do not try to insert constraint if two points are projected onto the
same 2D vertex
2025-10-17 10:06:08 +02:00
42068f6009
handle case of identical projected points
2025-10-15 11:03:16 +02:00
754e57ac3c
[OTR2] Deterministic reconstruction ( #9092 )
...
## Summary of Changes
Using timestamps to make iteration through vertices, edges and faces
deterministic
## Release Management
* Affected package(s): Optimal_transportation_reconstruction_2
* Issue(s) solved (if any): fix #8745
2025-10-13 09:33:46 +02:00
2f6e3defa7
using timestamps to make iteration through vertices, edges and faces deterministic
2025-10-01 13:42:30 +02:00
dd51daea5e
next version on this branch will be 6.0.3
2025-09-18 10:53:49 +02:00
e13ef800cb
Add missing protection ( #9061 )
2025-09-15 09:23:30 +02:00
766be48f1b
add missing protection
2025-09-09 20:11:25 +02:00
616b2828b2
Hide warning messages that are too verbose ( #9054 )
...
Note that prior to 6.0 all those messages were written into a debug
file.
2025-09-09 19:50:55 +02:00
8c25c60052
Merge remote-tracking branch 'cgal/5.6.x-branch' into 'cgal/6.0.x-branch'
2025-09-03 16:55:14 +02:00
3654f780ae
Initialize the lower bound face in traversal of the AABB-tree for Hausdorff distance ( #9041 )
...
## Summary of Changes
Solve issue_7164
## Release Management
* Affected package(s): Polygon_mesh_processing
* Issue(s) solved (if any): fix #7164
* Feature/Small Feature (if any):
* Link to compiled documentation (obligatory for small feature) [*wrong
link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg)
* License and copyright ownership: GF
2025-09-03 16:43:23 +02:00
24f70c8b3d
add an example of issue_7164 with a closed model
2025-09-03 16:41:28 +02:00
37f9018997
Initialized the lower bound face in traversal of the AABB-tree to solve issue-7164
2025-09-03 16:41:15 +02:00
dc2b48bed4
Tolerance for FT without sqrt ( #9053 )
...
Used at a non critical part used for discretization
2025-09-03 16:37:43 +02:00
80fd398478
hide warning messages that are too verbose
2025-09-03 16:03:11 +02:00
7a08a00c7a
tolerance for FT without sqrt
2025-09-02 10:54:45 +02:00
b741ed91ea
Make sure Boost system is also found ( #8999 )
2025-08-19 11:22:47 +02:00
419057ece4
Merge remote-tracking branch 'cgal/5.6.x-branch' into 'cgal/6.0.x-branch'
2025-08-13 18:05:54 +02:00
2622016c43
Build targets only if Eigen is available ( #9020 )
...
Somehow fixes #9014
2025-08-13 18:02:02 +02:00
69dbbae2e9
Avoid cascade with EPECK centroid ( #9027 )
2025-08-13 18:01:32 +02:00
0d316c1d66
CH3: bugfix for indexed triangle list overload ( #8954 )
...
## Summary of Changes
Defaulting to Convex_hull_traits_3 instead of
Kernel_traits<Point_3>::type
Prevents crash for point sets with [collinear
points](https://gist.github.com/soesau/351a3fa69e550a27fa629fc8e085da6a )
## Release Management
* Affected package(s): Convex_hull_3
2025-08-13 18:01:07 +02:00
29e6836e9c
we need to support all types of objects
2025-08-07 18:44:34 +02:00
fdd7c17ec1
avoid large dag in centroid
2025-08-07 18:20:20 +02:00
b1f151e598
use only one specialization using FT
...
cannot get the specialization as an object inherits from Lazy
2025-08-07 18:19:02 +02:00
2659bae961
Triangulation_3: Fix move_if_no_collision() ( #8934 )
...
## Summary of Changes
The function did not move vertices in higher levels.
### Todo
- [x] Check if fixes have to be made in 2D as well
- [x] Check the other functions moving vertices in the hierarchy
classes.
## Release Management
* Affected package(s): Triangulation_3
* License and copyright ownership: unchanged
2025-08-05 16:05:08 +02:00
9c56293e8b
build targets only if Eigen is available
2025-08-05 15:14:06 +02:00
a9923e9e02
restore test
2025-08-04 09:41:42 +02:00
e668cb9ae6
restore logic and use traits helper in the free function
2025-08-04 09:33:03 +02:00
28eee36cb6
Merge remote-tracking branch 'cgal/5.6.x-branch' into 'cgal/6.0.x-branch'
2025-07-31 15:15:52 +02:00
1c1cf48bed
Lab: APIENTRY undefined (Qt 6.9.1) ( #8980 )
...
## Summary of Changes
Behavior of QOpenGL.h changed, with 6.9.1 it does not provide APIENTRY
from windows.h anymore, but QT_APIENTRY instead
added redefinition of APIENTRY in qglviewer.h based on QT_APIENTRY
## Release Management
* Affected package(s): Lab, GraphicsView
2025-07-31 15:09:00 +02:00
Andreas Fabri
Sebastien Loriot
Sven Oesau
Laurent Rineau
Mael Rouxel-Labbé
lvalque