songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
112,859 Commits 3 Branches 156 Tags 963 MiB
Commit Graph

4758 Commits

Author SHA1 Message Date
Jane Tournois c161fc1ccf with the point, snippet can't be found 2025-01-20 09:48:53 +01:00
Jane Tournois bc64faaab3 Laurent's review 2025-01-17 16:22:24 +01:00
Jane Tournois 7e3aa09f2a complete move file 2024-12-19 22:03:28 +01:00
Jane Tournois a98101aa75 move tuple_like_helpers.h to STL_Extension to avoid dependency on Mesh_3 2024-12-19 17:38:14 +01:00
Jane Tournois 84e55c3982 fix include 2024-12-19 17:23:57 +01:00
Jane Tournois 2ed54dfa3a add constructors documentation 2024-12-19 17:17:30 +01:00
Jane Tournois 1a4cc658f3 wip apply Laurent's reviews 2024-12-19 16:53:49 +01:00
Jane Tournois 7f4e5b7e84 make doc more clear 2024-12-19 12:45:29 +01:00
Laurent Rineau 2496122707 fix missing fix 2024-12-19 12:22:00 +01:00
Jane Tournois 7e5b9eec9b rename concept with _3 postfix 2024-12-19 12:04:10 +01:00
Jane Tournois 740863cb02 doc review 2024-12-19 11:50:10 +01:00
Laurent Rineau 51b9c4a4b2 cleanup 2024-12-18 18:50:02 +01:00
Laurent Rineau 9ef32fb832 remove memory leaks with VTK objects 2024-12-18 18:25:55 +01:00
Laurent Rineau 8e5fab0c98 allow the initial points generator to be non-const 
A lot of type erasure was necessary.
 2024-12-18 16:45:25 +01:00
Laurent Rineau eecff9d71a add initial_points to the list of available functors for mesh initialization 2024-12-18 13:48:21 +01:00
Laurent Rineau e2d11a0fc5 allow a range as parameter 
The preview implementation enforced the use of a full container.
 2024-12-18 13:44:54 +01:00
Laurent Rineau 820762da52 proposal for a rewrite using a lamba expression as the point generator 2024-12-18 11:00:55 +01:00
Laurent Rineau 9803ab49dc add test of initial_points_generator with a generator generating tuple-like object 2024-12-17 18:37:29 +01:00
Laurent Rineau 79ebe7aa4d minor fixes 2024-12-17 18:35:00 +01:00
Laurent Rineau 5c70d487a1 actually allow tuple-like objects, and test that feature 2024-12-17 18:27:13 +01:00
Sébastien Loriot b32558b87e Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface 2024-12-16 11:47:34 +01:00
Sebastien Loriot 166681a6ce
Periodic_3_mesh_3: Avoid Making Copies (#8639) 
## Summary of Changes

Turn several copies into `const&` to avoid allocation of data members of
traits object with multiprecision coordinates. In release mode the gain
is around 10%..

To address the timeouts in the testsuite in Debug mode, I also changed
cell size and approximation error.

## Release Management

* Affected package(s): Periodic_triangulation_3_mesh_3
* License and copyright ownership: unchanged
 2024-12-10 16:24:25 +01:00
Andreas Fabri e9775789e5
Apply suggestions from code review 
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
 2024-12-06 14:49:33 +01:00
Sébastien Loriot caf716cf47 Merge remote-tracking branch 'cgal/6.0.x-branch' in master 2024-12-06 09:58:43 +01:00
Jane Tournois 18a0f69ca2 Merge remote-tracking branch 'cgal/master' into Mesh-3-rework-make-mesh-point-initialization-2-aclement 
# Conflicts:
#	Installation/CHANGES.md
 2024-12-05 10:17:14 +01:00
Andreas Fabri fc0f1977f6 Add a const& 2024-12-03 08:27:37 +00:00
Jane Tournois 47e575b779 remove extra "else" 2024-11-29 10:33:11 +01:00
Andreas Fabri 0261184dee WIP 2024-11-28 14:31:01 +00:00
Jane Tournois 7e1f24e5fb when sizing field is smaller than min_size, return min_size! 2024-11-26 18:08:10 +01:00
Jane Tournois d08d6643e8 Merge remote-tracking branch 'cgal/master' into Mesh-3-rework-make-mesh-point-initialization-2-aclement 
# Conflicts:
#	Installation/CHANGES.md
 2024-11-07 12:45:40 +01:00
Jane Tournois d5203e3124
doc 
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
 2024-11-07 09:27:10 +01:00
Sebastien Loriot 13328c335e
fix warning 
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
 2024-11-06 13:34:52 +01:00
Sébastien Loriot 335f9b381e less or more for the interior 2024-11-05 17:30:02 +01:00
Sébastien Loriot dd334d3f19 Merge pull request #8242 from janetournois/Mesh_3-avoid_tuples-jtournois 
Mesh 3 - avoid tuples in internal code
 2024-11-05 17:10:09 +01:00
Jane Tournois 75d3d30cb4 fix unused variable warnings and add a const 2024-11-05 10:27:54 +01:00
Jane Tournois f3abf598ed Merge remote-tracking branch 'cgal/master' into Mesh-3-rework-make-mesh-point-initialization-2-aclement 
# Conflicts:
#	Mesh_3/examples/Mesh_3/CMakeLists.txt
 2024-11-04 12:42:37 +01:00
Jane Tournois f77f9c6847 Merge remote-tracking branch 'cgal/master' into Mesh-3-rework-make-mesh-point-initialization-2-aclement 
# Conflicts:
#	Installation/CHANGES.md
 2024-10-23 16:35:56 +02:00
Sébastien Loriot aef524f09f remove extra -D 2024-10-23 11:44:27 +02:00
Sébastien Loriot 0833af4680 Merge remote-tracking branch 'cgal/master' into HEAD 2024-10-22 08:21:55 +02:00
Sébastien Loriot fb605cdd39 remove -D that is not compatible with "older" cmake versions 2024-10-22 08:19:49 +02:00
Laurent Rineau 96cd3e6f09 Merge remote-tracking branch 'cgal/master' into pr/afabri/8528 2024-10-17 00:25:24 +02:00
Sven Oesau a06002ab2b Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface 2024-10-14 14:42:46 +02:00
Sébastien Loriot a99dcceae8 Merge pull request #8519 from albert-github/feature/issue_8515_1 
issue #8515 Spelling mistakes found checking `en-GB` to `en-US`
 2024-10-14 09:42:14 +02:00
Sébastien Loriot f9734b2d2b Merge pull request #8514 from afabri/CGAL-labeled-GF 
Typo: labelled is UK English
 2024-10-14 09:41:58 +02:00
Andreas Fabri 63d2a26c00 Use Boost::serialization and Boost::iostreams 2024-10-09 13:21:51 +01:00
Andreas Fabri 9e75ab340d Use add_compile_definitions 2024-10-09 11:58:52 +01:00
Andreas Fabri 527569346e CGAL: Modernize CMakeLists.txt 2024-10-08 17:02:41 +01:00
albert-github dd02af92a2 issue #8515 Spelling mistakes found checking `en-GB` to `en-US` 
Spelling corrections, `en-GB` -> `en-US`
 2024-10-05 11:28:29 +02:00
Andreas Fabri 5fe32284af Typo: labelled is UK English 2024-10-03 11:23:23 +01:00
Jane Tournois 435ea6ea9c doc 2024-09-30 14:29:47 +02:00
Jane Tournois 4573f78d8b doc 2024-09-30 14:02:50 +02:00
Jane Tournois c1f2236ee3 Merge remote-tracking branch 'cgal/master' into Mesh-3-rework-make-mesh-point-initialization-2-aclement 
# Conflicts:
#	Installation/CHANGES.md
 2024-09-30 14:02:09 +02:00
Jane Tournois 32f147f6e2 cleaning 2024-09-30 13:06:47 +02:00
Jane Tournois 96455895a1
apply Mael's suggestions 
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
 2024-09-30 12:49:23 +02:00
Jane Tournois f3b9a5ac84 doc (Mael's review) 2024-09-30 12:46:29 +02:00
Jane Tournois 76ee84e88e mention features initialization in the insertion order description 2024-09-30 12:12:35 +02:00
Jane Tournois 88457ee5b3 make initialization logic consistent 
and fix doc accordingly

1. protect features
2. insert initial_points() range
3. use initial_points_generator(), if provided
4. use domain.construct_initial_points_object(), if initialization not complete
 2024-09-30 11:10:14 +02:00
Laurent Rineau 01bc8fec37 Merge pull request #8373 from janetournois/Mesh_3-document_example-jtournois 
Mesh_3 - document example Weighted image + triple lines
 2024-09-27 10:59:55 +02:00
Jane Tournois f3b5333b69 doc 2024-09-26 11:51:45 +02:00
Jane Tournois 8d6e7f2fb4 doc 2024-09-26 11:36:17 +02:00
Jane Tournois 490a6ad589 update doc 2024-09-24 12:22:32 +02:00
Jane Tournois b3a8530dcf use new API with named paremeter initial_points_generator in demo 
and fix compilation issues
 2024-09-24 11:05:41 +02:00
Jane Tournois 39254bb7db introduce Dummy_initial_points_generator 
fix compilation of Mesh_3 tests and examples
 2024-09-20 17:17:41 +02:00
Jane Tournois b5740393b2 compilation of examples fixed 2024-09-20 13:58:24 +02:00
Jane Tournois 026850cf97 use initial points vector 2024-09-19 12:24:18 +02:00
Jane Tournois ce9cd9e596 wip PR https://github.com/CGAL/cgal/pull/7798 2024-09-17 18:04:40 +02:00
Jane Tournois c55477cda3 document n 2024-09-12 15:36:13 +02:00
Jane Tournois 636fceb129 remove the hardly readable std::tuple and use MeshDomain::Intersection instead 2024-09-12 14:41:21 +02:00
Jane Tournois 4d40a050c3 doc 2024-09-12 12:52:49 +02:00
Jane Tournois f09c8d9a57 cleaning 2024-09-12 12:26:56 +02:00
Jane Tournois b75443637a tell more about the "all connected components" thing 2024-09-12 12:26:44 +02:00
Jane Tournois 86edcf8e04 rename Functions to Functors 2024-09-12 11:55:31 +02:00
Jane Tournois 2f25527e94 "at least n" 2024-09-12 11:54:52 +02:00
Sebastien Loriot 9ded34f6dd
Mesh_3 - bug fixes for `edge_distance` and `edge_min_size` (#8405) 
## Summary of Changes

While experimenting on self-intersecting polyhedral surfaces, I met two
bugs:
* `edge_min_size` was not enough taken into account in
`Protect_edges_sizing_field`,
* `edge_distance` was missing the information of which `curve_id` the
edge belongs to (available using internal code)
causing crashes.

## Release Management

* Affected package(s): Mesh_3
* License and copyright ownership: unchanged
 2024-08-26 15:24:29 +02:00
Jane Tournois 93fd7f87c7 vertices(edge) is not available in P3T3 2024-08-20 10:58:38 +02:00
Jane Tournois 4a35823f1f ease dump code reading 2024-08-19 12:24:59 +02:00
Jane Tournois 481de41e2f use c++11 for loops 2024-08-19 12:24:32 +02:00
Jane Tournois 14a9db6d00 weight_modifier was likely to make the weight too small 
let's keep the minimal weight as given in meshing criteria
 2024-08-19 12:23:32 +02:00
Sebastien Loriot 862a3b6539
Update CMakeLists.txt for recent VTK to fix CMake Warning (#8279) 
## Summary of Changes

Versions >= 9 of VTK trigger the following CMake warning using CGAL's
CMakeLists
```
CMake Deprecation Warning at C:/dev/VTK-9.2.2/build/lib/cmake/vtk-9.2/vtk-use-file-deprecated.cmake:1 (message):
  The `VTK_USE_FILE` is no longer used starting with 8.90.
Call Stack (most recent call first):
  CMakeLists.txt:32 (include)
```

I suggest this modification of the CMakeLists of Mesh_3 examples, that
also requires moving to VTK 9 (9.0 was released in 2020).
If this modification and new requirement are validated, I can apply the
change everywhere.

## Release Management

* Affected package(s): Mesh_3 for now
* License and copyright ownership: unchanged
 2024-08-19 11:14:31 +02:00
Jane Tournois fd498e398a fix approx_is_too_large(edge) that needs the corresponding curve_index to be valid 
use minimal_size instead of 0

fix 5e64bced8e37ce076f26317e9ea7638a14c9696c

fix approx_is_too_large(edge) that needs the corresponding curve_index to be valid

and fix the default edge_min_size
 2024-08-12 12:37:03 +01:00
Jane Tournois 0bc3658893 use the 5 parameters version to avoid re-calling locate(p) and locate(q) 2024-08-08 15:28:09 +02:00
Jane Tournois f8de6e72b8 take min_size into account inside Mesh_edge_criteria_3 2024-08-08 15:26:59 +02:00
Jane Tournois 5771547e36 replace typedef's by using's 2024-07-23 10:56:46 +02:00
Jane Tournois a93f78d8ad remove debug macros 2024-07-23 10:18:40 +02:00
Jane Tournois 47b5f73a96 document example weighted image + feature detection 2024-07-23 10:18:27 +02:00
Jane Tournois 5d814aee2a remove ref (can become invalid) 2024-06-25 15:16:07 +02:00
Mael Rouxel-Labbé 67aba3fefe Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface 2024-06-20 10:18:49 +02:00
Laurent Rineau 089cb17bcf
Poisson: fix dependencies (#8282) 2024-06-13 12:55:34 +02:00
Laurent Rineau 6f4b598b6a Merge pull request #8278 from albert-github/feature/bug_spell_20240511 
Spelling correction
 2024-06-13 12:48:43 +02:00
Sébastien Loriot 86866e232e remove Surface_mesher from doc deps 2024-06-12 20:34:54 +02:00
Laurent Rineau 32893b91c0 Merge pull request #8263 from lrineau/CGAL-update_minimal_cmake-GF 
cmake_minimum_required(VERSION 3.12...3.29)
 2024-06-12 10:06:12 +02:00
Laurent Rineau d5aa8b1a44 Merge pull request #8268 from janetournois/Mesh_3-fix_concept-jtournois 
Mesh_3 - fix concept `MeshFacetCriteria_3`
 2024-06-12 10:06:08 +02:00
Laurent Rineau f3b409a807 require VTK version 9.0 or later 2024-06-11 15:57:25 +02:00
albert-github c35a0a7f11 Spelling correction 
Spelling correction due to updated dictionary.
(dictionary was updated after the previous spelling correction :-( )
 2024-06-11 10:12:12 +02:00
Jane Tournois 05c3fc9e94 update CMakeLists.txt for recent VTK 2024-06-11 10:00:36 +02:00
Laurent Rineau 5b003a7808 Merge pull request #8246 from albert-github/feature/bug_spell_20240531 
Spelling corrections
 2024-06-10 18:47:22 +02:00
Jane Tournois 8d6d934395 convert tuple to struct for Facets_erase_counters 2024-06-10 15:52:09 +02:00
Jane Tournois accfc2aa31 convert tuple to struct for Move 2024-06-10 15:51:31 +02:00
Jane Tournois 8e39809c58 remove more tuples 2024-06-07 17:38:02 +02:00
Jane Tournois 7be4da73a3 remove useless tuple 2024-06-07 17:37:34 +02:00