Commit Graph

4758 Commits

Author SHA1 Message Date
Laurent Rineau bdd7988a4a remove CMake warnings about CMP0167
The issue was when VTK/ITK was searched. The
variable `CMAKE_POLICY_DEFAULT_CMP0167` can be
used to workaround that.
2025-05-27 13:02:04 +02:00
Sebastien Loriot ac763ef561
Mesh_3: Specific domain for Poisson reconstruction (#8771)
## Summary of Changes

Creating Poisson_mesh_domain including optimizations for Poisson from
Surface_mesher

## Release Management

* Affected package(s): Mesh_3, Poisson_reconstruction_3
* small feature:
https://cgalwiki.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Poisson_mesh_domain
-- pre-approved 18 April 2025
* Issue(s) solved (if any): fix #8266
2025-05-07 09:42:25 +02:00
Sven Oesau a8cd0902a8 integrating reviews 2025-04-17 15:46:21 +02:00
Sébastien Loriot cc77715588 Merge pull request #6849 from JulyCode/gsoc2022-isosurface
Isosurfacing_3 (new package)
2025-04-03 21:41:22 +02:00
Sven Oesau 96664743f5 remove default value for named parameter object 2025-04-02 16:58:47 +02:00
Sven Oesau 25443ddc54 pass on code and doc following reviews 2025-04-02 11:53:31 +02:00
Sven Oesau e1c6a9365e
Merge branch 'master' into Mesh_3-Poisson_domain-GF 2025-03-31 14:48:20 +02:00
Mael Rouxel-Labbé e38e29f279 dont > don't 2025-03-28 20:52:22 +01:00
Mael Rouxel-Labbé 7970fb99e7 later > latter 2025-03-28 20:41:37 +01:00
albert-github bf4d79b64b Spelling correction
Spelling correction
2025-03-28 18:41:36 +01:00
Sebastien Loriot 3483e40b10
Mesh_3 - add `surface_only()` named parameter (#8781)
## Summary of Changes

Add the option `surface_only()` to `make_mesh_3()`, to completely skip
the "refine_cells" part of Mesh_3, and cancel perturbation and
exudation.
@soesau and I noticed that scanning cells, even in the context of
"Surface mesher", takes a lot of useless time.


@soesau you can use this branch for your benchmark

@lrineau do you think `surface_only` should be a member of `Mesher_3` or
a parameter of `Mesher_3::refine_mesh()` (as done here)?

## Release Management

* Affected package(s): Mesh_3
* [Small
Feature](https://cgalwiki.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Mesh_3_surface_only())
Pre-approved by
[User:Sloriot](https://cgalwiki.geometryfactory.com/CGAL/Members/wiki/User:Sloriot)
-- 2025/03/17
* Link to compiled documentation
[make_mesh_3()](https://cgal.github.io/8781/v0/Mesh_3/group__PkgMesh3Functions.html#gac8599a0c967075f740bf8e2e92c4770e)
and
[parameters::surface_only()](https://cgal.github.io/8781/v0/Mesh_3/group__PkgMesh3Parameters.html#gaa2618c09b6117d7caab12dccca16ee58)
* License and copyright ownership: unchanged
2025-03-28 18:23:22 +01:00
Jane Tournois a91d5783ab
not using tbb
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
2025-03-27 12:23:23 +01:00
Laurent Rineau 2b8c2ef36f Merge remote-tracking branch 'cgal/master' into pr/soesau/8771-2 2025-03-26 14:30:50 +01:00
Jane Tournois 78d7ddc5e5 add missing this-> 2025-03-25 13:14:44 +01:00
Jane Tournois ffce97431f add test_remeshing_polyhedron 2025-03-25 12:45:48 +01:00
Jane Tournois 4ebd95c86a doc 2025-03-25 11:17:38 +01:00
Jane Tournois 76662f75eb detect that input polyhedral surface is "surface only" 2025-03-25 10:46:59 +01:00
Mael Rouxel-Labbé 691fd789f9 Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface 2025-03-24 21:34:55 +01:00
Jane Tournois a2f6030f55 update example and user manual 2025-03-24 15:30:42 +01:00
Jane Tournois bbc790bc5e wording 2025-03-24 12:56:43 +01:00
Sebastien Loriot 2f511f0330
fix issue #8773 "c3t3 -> binary -> c3t3 -> vtu writes invalid vtu files" (#8778)
## Summary of Changes

fix issue #8773: c3t3 -> binary -> c3t3 -> vtu writes invalid vtu files

When a c3t3 is loaded, its far vertices were not loaded correctly.

## Release Management

* Affected package(s): Mesh_3/SMDS_3
* Issue(s) solved (if any): fix #0000, fix #8773
* License and copyright ownership: maintenance by GF
2025-03-14 20:09:42 +01:00
Jane Tournois dae8504521 add missing () 2025-03-13 17:10:51 +01:00
Jane Tournois bdaa0a915a fix function name in doc 2025-03-13 17:08:53 +01:00
Jane Tournois 76a9f5a4f8 fix function name in doc 2025-03-13 17:06:37 +01:00
Jane Tournois 25e72cb84e doc 2025-03-13 12:46:26 +01:00
Jane Tournois de11a58583 more doc 2025-03-13 11:53:35 +01:00
Jane Tournois c1b9c561da add surface_only() to doc 2025-03-13 11:51:02 +01:00
Jane Tournois 4d33aeb2b1 use surface_only() in surface_Delaunay_remeshing() 2025-03-13 09:49:23 +01:00
Jane Tournois 3a94fcb68a add surface_only() as a named parameter to make_mesh_3()
to completely skip the "refine_cells" part of Mesh_3
2025-03-11 16:58:28 +01:00
Laurent Rineau 4f4f78979d
remove verbose macros 2025-03-10 17:18:09 +01:00
Laurent Rineau 2bd90e5d9c fix issue #8773 "c3t3 -> binary -> c3t3 -> vtu writes invalid vtu files"
When a c3t3 is loaded, its far vertices were not loaded correctly.
2025-03-10 17:12:41 +01:00
Sébastien Loriot ad7e4754aa Merge remote-tracking branch 'cgal/6.0.x-branch' into master 2025-03-07 17:26:54 +01:00
Sven Oesau 45d2053a7d moving Poisson_mesh_domain_3 to Poisson reconstruction package 2025-03-05 11:22:11 +01:00
Sven Oesau 5a4e42c0ab fix for ci
changes following review
2025-03-05 10:07:50 +01:00
Sven Oesau 95c4204e37 renaming create_poisson_mesh_domain -> create_Poisson_mesh_domain 2025-03-05 09:59:36 +01:00
Sven Oesau 80c951e88f update on tests and examples
some documentation fixes
2025-03-05 08:05:07 +01:00
Sven Oesau 161934a392 adding Poisson_mesh_domain_3 2025-03-04 20:57:35 +01:00
Sébastien Loriot 48d8f54796 use previous vertex as hint 2025-03-03 18:22:05 +01:00
Jane Tournois de16b71eba use minimal_weight (i.e. edge_min_size) in insert_corners() 2025-03-03 14:52:04 +00:00
Sebastien Loriot 636368ed8f
Always init time_stamp to -2 (#8714)
It is not clear to me that this is the right thing to do:
- it is done for some classes
- but in some test, a comment mention that it should be uninitialized
(the test works if init to -1 but not to 0).
- Base_time_stamper is doing an init to -2
2025-02-12 19:40:27 +01:00
Sebastien Loriot 14b83f0d3e
boost::tie -> std::tie (#8715) 2025-02-12 19:36:19 +01:00
Sebastien Loriot e871025f36
update our CMake supported versions to ...3.31 (#8727)
## Summary of Changes

Update our CMake supported versions to ...3.31. That will suppress the
warnings about `CMP0167` (from CMake 3.30):

```
CMake Warning (dev) at cmake/modules/display-third-party-libs-versions.cmake:37 (find_package):
  Policy CMP0167 is not set: The FindBoost module is removed.  Run "cmake
  --help-policy CMP0167" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.
```

## Release Management

* Affected package(s): all cmake scripts
* License and copyright ownership: maintenance by GF
2025-02-07 14:03:47 +01:00
albert-github 26c3e9cd21 Spelling correction
Spelling correction
2025-02-05 10:28:46 +01:00
Sebastien Loriot 54bfdfe04d
Mesh 3 : initial_points_generator parameter for make_mesh_3 point initialization (#7798)
## Summary of Changes

Added a `initial_points_generator` parameter in make_mesh_3.
With this parameter, we can use a custom functor when initializing the
C3t3 complex.
This functor must follow the
[Initial_points_generator](https://cgal.github.io/7798/v0/Mesh_3/classInitialPointsGenerator.html)
concept.

Tasks:
 - [x] Add `initial_points_generator` parameter in `make_mesh_3`
 - [x] Make an example
 - [x] Write `Construct_initial_points_labeled_image` into a header
- [x] Make `initialize_triangulation_from_labeled_image` use
`Construct_initial_points_labeled_image`
- [x] Change definition of concept `InitialPointsGenerator` to output
`std::tuple<MeshDomain::Point_3, int dimension, MeshDomain::Index>`
(instead of `std::pair<MeshDomain::Point_3, MeshDomain::Index>`)
 - [x] Make it pass checks
 - [x] Document `initial_points_generator` parameter in `make_mesh_3`
 - [x] Document `Construct_initial_points_labeled_image` header
 - [x] Document example
- [x] Delete `initialize_triangulation_from_labeled_image` and
`initialize_triangulation_from_gray_image`
- [x] Make an example of labelled and gray image initialisation with the
parameter or the old custom initialization.
 - [x] Make small feature page
- [x] add `Construct_initial_points_gray_image.h`, similar to
`Construct_initial_points_labeled_image.h`
 - [x] Maybe add a test ?
- [x] announce in `CHANGES.md`, see
https://github.com/CGAL/cgal/pull/7798#issuecomment-2082701644

## Release Management

* Affected package(s): Mesh_3
* Issue(s) solved (if any): 
  * fix #922
  * fix #7469 
  * discussion #7537
  * previous closed PR #7757
* Feature/Small Feature (if any):
[Mesh_3_initial_points_generator_parameter](https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Mesh_3_initial_points_generator_parameter)
* Link to compiled documentation
[*here*](https://cgal.github.io/7798/v4/Manual/index.html):
*
[make_mesh_3](https://cgal.github.io/7798/v4/Mesh_3/group__PkgMesh3Functions.html#gac8599a0c967075f740bf8e2e92c4770e)
has been modified to receive the parameters :
*
[initial_points_generator](https://cgal.github.io/7798/v4/Mesh_3/group__PkgMesh3Parameters.html#gaf53777b83f1b2f3e7d49275dbab6e46b)
*
[initial_points](https://cgal.github.io/7798/v4/Mesh_3/group__PkgMesh3Parameters.html#gae94f38c6cd23cce45a55608e881a546a)
* The
[InitialPointsGenerator](https://cgal.github.io/7798/v4/Mesh_3/classInitialPointsGenerator.html)
concept that the functor must be a model of.
* A model of this concept :
[Construct_initial_points_labeled_image](https://cgal.github.io/7798/v4/Mesh_3/structCGAL_1_1Construct__initial__points__labeled__image.html)
* License and copyright ownership:
2025-02-05 08:29:06 +01:00
Laurent Rineau e5001d1a50 update our CMake version 3.18...3.31
That will suppress the warnings about `CMP0167` (from CMake 3.30):

```
CMake Warning (dev) at cmake/modules/display-third-party-libs-versions.cmake:37 (find_package):
  Policy CMP0167 is not set: The FindBoost module is removed.  Run "cmake
  --help-policy CMP0167" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.
```
2025-02-04 14:32:37 +01:00
Laurent Rineau fad5e30a54 initialize to -2, to use the debugging assertions 2025-01-31 18:09:07 +01:00
Sébastien Loriot 107f3696dc boost::tie -> std::tie 2025-01-24 14:20:00 +01:00
Sébastien Loriot eb0da467ed always init time_stamp to -1 2025-01-24 11:08:34 +01:00
Laurent Rineau 1d6e3056b7 typo 2025-01-20 16:59:47 +01:00
Jane Tournois 1950235653 remove extra point 2025-01-20 16:28:36 +01:00