songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
112,593 Commits 3 Branches 156 Tags 958 MiB
Commit Graph

4764 Commits

Author SHA1 Message Date
Andreas Fabri 63d2a26c00 Use Boost::serialization and Boost::iostreams 2024-10-09 13:21:51 +01:00
Andreas Fabri 9e75ab340d Use add_compile_definitions 2024-10-09 11:58:52 +01:00
Andreas Fabri 527569346e CGAL: Modernize CMakeLists.txt 2024-10-08 17:02:41 +01:00
albert-github dd02af92a2 issue #8515 Spelling mistakes found checking `en-GB` to `en-US` 
Spelling corrections, `en-GB` -> `en-US`
 2024-10-05 11:28:29 +02:00
Andreas Fabri 5fe32284af Typo: labelled is UK English 2024-10-03 11:23:23 +01:00
Jane Tournois 435ea6ea9c doc 2024-09-30 14:29:47 +02:00
Jane Tournois 4573f78d8b doc 2024-09-30 14:02:50 +02:00
Jane Tournois c1f2236ee3 Merge remote-tracking branch 'cgal/master' into Mesh-3-rework-make-mesh-point-initialization-2-aclement 
# Conflicts:
#	Installation/CHANGES.md
 2024-09-30 14:02:09 +02:00
Jane Tournois 32f147f6e2 cleaning 2024-09-30 13:06:47 +02:00
Jane Tournois 96455895a1
apply Mael's suggestions 
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
 2024-09-30 12:49:23 +02:00
Jane Tournois f3b9a5ac84 doc (Mael's review) 2024-09-30 12:46:29 +02:00
Jane Tournois 76ee84e88e mention features initialization in the insertion order description 2024-09-30 12:12:35 +02:00
Jane Tournois 88457ee5b3 make initialization logic consistent 
and fix doc accordingly

1. protect features
2. insert initial_points() range
3. use initial_points_generator(), if provided
4. use domain.construct_initial_points_object(), if initialization not complete
 2024-09-30 11:10:14 +02:00
Laurent Rineau 01bc8fec37 Merge pull request #8373 from janetournois/Mesh_3-document_example-jtournois 
Mesh_3 - document example Weighted image + triple lines
 2024-09-27 10:59:55 +02:00
Jane Tournois f3b5333b69 doc 2024-09-26 11:51:45 +02:00
Jane Tournois 8d6e7f2fb4 doc 2024-09-26 11:36:17 +02:00
Jane Tournois 490a6ad589 update doc 2024-09-24 12:22:32 +02:00
Jane Tournois b3a8530dcf use new API with named paremeter initial_points_generator in demo 
and fix compilation issues
 2024-09-24 11:05:41 +02:00
Jane Tournois 39254bb7db introduce Dummy_initial_points_generator 
fix compilation of Mesh_3 tests and examples
 2024-09-20 17:17:41 +02:00
Jane Tournois b5740393b2 compilation of examples fixed 2024-09-20 13:58:24 +02:00
Jane Tournois 026850cf97 use initial points vector 2024-09-19 12:24:18 +02:00
Jane Tournois ce9cd9e596 wip PR https://github.com/CGAL/cgal/pull/7798 2024-09-17 18:04:40 +02:00
Jane Tournois c55477cda3 document n 2024-09-12 15:36:13 +02:00
Jane Tournois 636fceb129 remove the hardly readable std::tuple and use MeshDomain::Intersection instead 2024-09-12 14:41:21 +02:00
Jane Tournois 4d40a050c3 doc 2024-09-12 12:52:49 +02:00
Jane Tournois f09c8d9a57 cleaning 2024-09-12 12:26:56 +02:00
Jane Tournois b75443637a tell more about the "all connected components" thing 2024-09-12 12:26:44 +02:00
Jane Tournois 86edcf8e04 rename Functions to Functors 2024-09-12 11:55:31 +02:00
Jane Tournois 2f25527e94 "at least n" 2024-09-12 11:54:52 +02:00
Sebastien Loriot 9ded34f6dd
Mesh_3 - bug fixes for `edge_distance` and `edge_min_size` (#8405) 
## Summary of Changes

While experimenting on self-intersecting polyhedral surfaces, I met two
bugs:
* `edge_min_size` was not enough taken into account in
`Protect_edges_sizing_field`,
* `edge_distance` was missing the information of which `curve_id` the
edge belongs to (available using internal code)
causing crashes.

## Release Management

* Affected package(s): Mesh_3
* License and copyright ownership: unchanged
 2024-08-26 15:24:29 +02:00
Jane Tournois 93fd7f87c7 vertices(edge) is not available in P3T3 2024-08-20 10:58:38 +02:00
Jane Tournois 4a35823f1f ease dump code reading 2024-08-19 12:24:59 +02:00
Jane Tournois 481de41e2f use c++11 for loops 2024-08-19 12:24:32 +02:00
Jane Tournois 14a9db6d00 weight_modifier was likely to make the weight too small 
let's keep the minimal weight as given in meshing criteria
 2024-08-19 12:23:32 +02:00
Sebastien Loriot 862a3b6539
Update CMakeLists.txt for recent VTK to fix CMake Warning (#8279) 
## Summary of Changes

Versions >= 9 of VTK trigger the following CMake warning using CGAL's
CMakeLists
```
CMake Deprecation Warning at C:/dev/VTK-9.2.2/build/lib/cmake/vtk-9.2/vtk-use-file-deprecated.cmake:1 (message):
  The `VTK_USE_FILE` is no longer used starting with 8.90.
Call Stack (most recent call first):
  CMakeLists.txt:32 (include)
```

I suggest this modification of the CMakeLists of Mesh_3 examples, that
also requires moving to VTK 9 (9.0 was released in 2020).
If this modification and new requirement are validated, I can apply the
change everywhere.

## Release Management

* Affected package(s): Mesh_3 for now
* License and copyright ownership: unchanged
 2024-08-19 11:14:31 +02:00
Jane Tournois fd498e398a fix approx_is_too_large(edge) that needs the corresponding curve_index to be valid 
use minimal_size instead of 0

fix 5e64bced8e37ce076f26317e9ea7638a14c9696c

fix approx_is_too_large(edge) that needs the corresponding curve_index to be valid

and fix the default edge_min_size
 2024-08-12 12:37:03 +01:00
Jane Tournois 0bc3658893 use the 5 parameters version to avoid re-calling locate(p) and locate(q) 2024-08-08 15:28:09 +02:00
Jane Tournois f8de6e72b8 take min_size into account inside Mesh_edge_criteria_3 2024-08-08 15:26:59 +02:00
Jane Tournois 5771547e36 replace typedef's by using's 2024-07-23 10:56:46 +02:00
Jane Tournois a93f78d8ad remove debug macros 2024-07-23 10:18:40 +02:00
Jane Tournois 47b5f73a96 document example weighted image + feature detection 2024-07-23 10:18:27 +02:00
Jane Tournois 5d814aee2a remove ref (can become invalid) 2024-06-25 15:16:07 +02:00
Mael Rouxel-Labbé 67aba3fefe Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface 2024-06-20 10:18:49 +02:00
Laurent Rineau 089cb17bcf
Poisson: fix dependencies (#8282) 2024-06-13 12:55:34 +02:00
Laurent Rineau 6f4b598b6a Merge pull request #8278 from albert-github/feature/bug_spell_20240511 
Spelling correction
 2024-06-13 12:48:43 +02:00
Sébastien Loriot 86866e232e remove Surface_mesher from doc deps 2024-06-12 20:34:54 +02:00
Laurent Rineau 32893b91c0 Merge pull request #8263 from lrineau/CGAL-update_minimal_cmake-GF 
cmake_minimum_required(VERSION 3.12...3.29)
 2024-06-12 10:06:12 +02:00
Laurent Rineau d5aa8b1a44 Merge pull request #8268 from janetournois/Mesh_3-fix_concept-jtournois 
Mesh_3 - fix concept `MeshFacetCriteria_3`
 2024-06-12 10:06:08 +02:00
Laurent Rineau f3b409a807 require VTK version 9.0 or later 2024-06-11 15:57:25 +02:00
albert-github c35a0a7f11 Spelling correction 
Spelling correction due to updated dictionary.
(dictionary was updated after the previous spelling correction :-( )
 2024-06-11 10:12:12 +02:00
Jane Tournois 05c3fc9e94 update CMakeLists.txt for recent VTK 2024-06-11 10:00:36 +02:00
Laurent Rineau 5b003a7808 Merge pull request #8246 from albert-github/feature/bug_spell_20240531 
Spelling corrections
 2024-06-10 18:47:22 +02:00
Jane Tournois 8d6d934395 convert tuple to struct for Facets_erase_counters 2024-06-10 15:52:09 +02:00
Jane Tournois accfc2aa31 convert tuple to struct for Move 2024-06-10 15:51:31 +02:00
Jane Tournois 8e39809c58 remove more tuples 2024-06-07 17:38:02 +02:00
Jane Tournois 7be4da73a3 remove useless tuple 2024-06-07 17:37:34 +02:00
Jane Tournois 986b596d10 Merge remote-tracking branch 'cgal/master' into Mesh_3-avoid_tuples-jtournois 
# Conflicts:
#	Mesh_3/include/CGAL/Mesh_3/Refine_facets_3.h
 2024-06-07 15:48:31 +02:00
Jane Tournois 4d486527d2 fix doc 2024-06-07 15:18:57 +02:00
Laurent Rineau 3a223ebd1e cmake_minimum_required(VERSION 3.12...3.29) 2024-06-06 20:19:44 +02:00
Jane Tournois 3cf86606d8 avoid compiler warning 2024-06-04 08:55:48 +02:00
Jane Tournois bb0c3f22f6 use typedefs 2024-06-04 08:52:08 +02:00
Laurent Rineau 212c6bc5ce Merge pull request #8241 from lrineau/Mesh_3-add_a_scope_after_if-GF 
Mesh_3: add a scope after if(...)
 2024-06-03 17:40:24 +02:00
Jane Tournois b2a679ee78 typedefs 2024-05-31 19:05:38 +02:00
albert-github 36c8b7589d Spelling corrections 
Last batch (for now) of spelling corrections in doxygen and normal comments
 2024-05-31 19:05:34 +02:00
Jane Tournois 5b1a406dcc use c++17 to simplify code 2024-05-31 09:38:20 +02:00
Jane Tournois fe6e71724b replace tuple with struct to improve readability 2024-05-30 15:33:29 +01:00
Jane Tournois c0f53c4a3e avoid using the get<i>(tuple) API, hardly readable 2024-05-30 15:33:22 +01:00
Laurent Rineau c538ff16c2 Mesh_3: add a scope after if(...) 2024-05-30 15:24:19 +02:00
Mael Rouxel-Labbé 4ba0ec0421 Merge remote-tracking branch 'cgal/master' into Mesh_3-update_benchmark-jtournois 2024-05-29 12:57:39 +02:00
Sebastien Loriot d06a57a292
Mesh_3 edge_distance criterion : an upper bound for the distances of the feature edge to the input feature (#7532) 
## Summary of Changes

Fixes issue #5110.
Adds a edge_distance criteria to the mesh generation process.
This criteria is an upper bound for the distance from the edge to the 1D
feature.

## Release Management

* Affected package(s): Mesh_3
* Issue(s) solved (if any): fix #5110
* Link to small feature page :
[Mesh_3_edge_distance_criteria](https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Mesh_3_edge_distance_criteria)
* Link to compiled documentation
[*here*](https://cgal.github.io/7532/v1/Manual/index.html):
*
[Mesh_edge_criteria_3](https://cgal.github.io/7532/v1/Mesh_3/classCGAL_1_1Mesh__edge__criteria__3.html)
  * [Mesh_criteria_3](https://cgal.github.io/7532/v1/Mesh_3)
 2024-05-27 10:58:15 +02:00
Sebastien Loriot abe1bba8bd
CGAL improvement backported from CDT_3 branch (#8170) 
## Summary of Changes

Important various fixes and improvements, from an experimental branch of
mine about CDT_3.

- <s>remove CMake warnings about `VTK_USE_FILE`</s> (our testsuite tests
with [VTK-8.2](https://docs.vtk.org/en/latest/release_details/8.2.html),
whereas
[VTK-9.0](https://docs.vtk.org/en/latest/release_details/9.0.html) was
released four years ago).
- make `Circulator_from_container` compatible with ranges (instead of
just containers)
- `Hash_map` is move-constructible and -assignable
- add preliminary support for C++20 concepts and `<format>`
- [x] add `Compare_angle_3(Point_3, Point_3, Point_3, Point_3, Point_3,
Point_3)` (with six points) **TODO: needs doc**... will be handled later
in issue #8219
- [x] **breaking changes:** add `Compare_xy_2` to
`TriangulationTraits_2` <s>TODO: needs announcement</s>
- fix `Compact_container` time stamp feature
- [x] commits from #7410 **That is probably a problem, to be fixed.**
**fixed in #7410 and then my the merge
70464ea107**
- add `CGAL::Scope_exit`, `CGAL::make_scope_exit`, for CGAL developers
(undocumented)
- add an overload of `make_sorted_pair` with only one pair-like argument
- improve `CGAL::IO::Output_ref` and `oformat`
- perf improvements in
`TDS_3/include/CGAL/Triangulation_data_structure_3.h` (`is_edge` is 7
times faster)
- <s>perf improvement in
`Triangulation_2/include/CGAL/Triangulation_2/internal/Polyline_constraint_hierarchy_2.h`
(with the use of `unordered_flat_map` from Boost>=1.80</s>
- less filter failures in `Triangulation_segment_cell_iterator_3`
- add `Triangulation_3::is_facet(u, v, w)` (without `, c, i, j, k`)

## Release Management

* Affected package(s): Installation, T_2, TDS_2, T_3, TDS_3, SMDS_3,
Kernel, STL_Extension, Stream_support
* Feature/Small Feature (if any):
* License and copyright ownership: maintenance by GeometryFactory
 2024-05-26 17:48:10 +02:00
Sebastien Loriot afe7f90a73
Mesh_3::Add handling of *.nii files in one example (#7823) 
## Summary of Changes

While the Polyhedron demo can read `*.nii` files there is no example in
`examples/Mesh_3/`.
This PR adds the functionality to the example that uses vtk to read
DICOM data.

This is triggered by [this
question](https://stackoverflow.com/questions/77331075/is-there-an-easy-way-to-convert-from-nifti-nii-image-format-to-inr)
on stackoverflow.

- [ ] Support of `*.nrrd` format
- [ ] example for segmented images
- [ ] Add example data for the file formats.

## Release Management

* Affected package(s): Mesh_3
* License and copyright ownership: unchanged
 2024-05-26 17:45:48 +02:00
Laurent Rineau 0c0b22ba92 add tests and assertions for the timestamper 2024-05-23 16:35:54 +02:00
Laurent Rineau df28ddc43a Revert "Fix CMake warning: remove usage of VTK_USE_FILE" 
This reverts commit f39b90670b.
 2024-05-22 12:55:43 +02:00
Laurent Rineau 70464ea107 Merge remote-tracking branch 'afabri/STL_extension-Fix_Prevent_deref-GF' into pr/lrineau/8170 2024-05-21 18:55:11 +02:00
Laurent Rineau 022b19d3ca Merge pull request #8057 from sloriot/AABB_tree-2d_and_3d 
Updating the AABB-tree to work in both 2D and 3D
 2024-05-15 16:12:19 +02:00
Jane Tournois 47b74e419d the nb of vertices in parallel mode has a pretty large variability 
(from 745 to 893 in my experiments)
so testing their number wrt a reference value does not make much sense

This commit changes to test not to test meshing without comparing nbv and nbf
in parallel mode
 2024-05-10 16:00:15 +02:00
Jane Tournois 1638c4b6fa warning unused parameters 2024-05-07 10:22:42 +02:00
Jane Tournois 29de7aceaa fix compilation of test 2024-05-03 14:28:21 +02:00
ange-clement 8575f53583 Doc upgrades + simplified initial_points_generator parameter + fixed memory leaks 2024-05-02 17:29:23 +02:00
ange-clement 50dfc18d4a Merge branch 'Mesh-3-rework-make-mesh-point-initialization-2-aclement' of https://github.com/ange-clement/cgal into Mesh-3-rework-make-mesh-point-initialization-2-aclement 2024-05-02 17:19:57 +02:00
ange-clement fa6e044414 Merge branch 'master' of https://github.com/CGAL/cgal into Mesh-3-rework-make-mesh-point-initialization-2-aclement 2024-05-02 14:47:50 +02:00
Laurent Rineau 2813d53c7f other changes I forgot to commit 2024-04-29 16:47:15 +02:00
Laurent Rineau d7ea101231 improve the doc sentences 2024-04-29 16:19:52 +02:00
Jane Tournois 1bbcc40ee3 Merge branch 'Mesh-3-edge-distance-criterium-aclement' of https://github.com/ange-clement/cgal into Mesh-3-edge-distance-criterium-aclement 2024-04-29 15:16:42 +02:00
Jane Tournois fe09beb53e fix template parameters doc 2024-04-29 15:15:46 +02:00
Laurent Rineau da893f8f8b minor changes 2024-04-29 14:58:10 +02:00
Laurent Rineau f39b90670b Fix CMake warning: remove usage of VTK_USE_FILE 
Backport: master, 5.5.x, 5.4.x
 2024-04-26 13:54:44 +02:00
Laurent Rineau 07eb230ed8 Merge pull request #8149 from lrineau/cgallab-cont 
Rename Polyhedron demo to CGAL Lab everywhere
 2024-04-25 11:30:08 +02:00
Laurent Rineau 2a2031df3b Rename cgallab to CGALlab 
@janetournois (see https://github.com/CGAL/cgal/pull/8149#issuecomment-2066444180
 2024-04-23 15:09:51 +02:00
Laurent Rineau 67466144bb Merge pull request #8139 from janetournois/Mesh_3-revert_encroachment_loop-jtournois 
Mesh_3 - revert encroachment rule modification, and fix infinite refinement
 2024-04-22 14:53:50 +02:00
Laurent Rineau 621859b526 Rename Polyhedron demo to CGAL Lab 
And announce it in the `CHANGES.md`.
 2024-04-18 12:39:30 +02:00
Jane Tournois 7a8075ebd9 comments 2024-04-16 16:54:21 +02:00
Jane Tournois 973f8a1f66 make default edge distance be 0 for consistency with other criteria (instead of DBL_MAX) 
rename check_distance_field() to has_distance_field()
 2024-04-16 15:32:59 +02:00
Jane Tournois 3d8346c8e0 fix concept : edge criteria do not belong to MeshCriteria_3 but to MeshCriteriaWithFeatures_3 2024-04-16 14:39:56 +02:00
Laurent Rineau cf01bdc179 simplify the snippets 2024-04-15 15:37:26 +02:00
ange-clement 3cb583ade7 Added nii image "squircle.nii" + 
Updated example to work with a default dataset.
 2024-04-12 12:16:25 +02:00
Jane Tournois a8debb0d2d Revert "Fix sometimes creating holes in the C3T3" 
This reverts commit 06d272169f.

There may be an inconsistency between exact and inexact computations,
in the facet encroachment rule

This code was leading to a local infinite refinement loop during cells refinement
 2024-04-11 14:16:41 +02:00
Sébastien Loriot 2701314055 fix warnings 2024-04-09 13:53:47 +02:00
ange-clement 6e8dacff2b Fixed test 2024-04-05 14:21:39 +02:00
ange-clement 37798b73d7 Optimisation in refine_balls : added a is_edge_in_complex boolean, the check is processed once instead of twice. 2024-04-04 12:42:41 +02:00
ange-clement e558f43e01 Added check_distance_field in Edge criteria so that refine_balls() only check edge distance when necessary. 2024-04-04 12:08:13 +02:00
ange-clement b1fb29c22a InitialPointsGenerator parameter 'n' explanation 2024-03-29 17:03:20 +01:00
ange-clement ae0f8f37c9 Finished Merge 2024-03-29 16:49:33 +01:00
ange-clement 5b0f1fc4c2 Merge branch 'master' of https://github.com/CGAL/cgal into Mesh-3-rework-make-mesh-point-initialization-2-aclement 2024-03-29 16:46:24 +01:00
ange-clement e64e28d5ef Made initial_point parameter work with any Range 
With doc and example (
 example "mesh_3D_image_with_initial_points.cpp" has been renamed to  "mesh_3D_image_with_image_initialization.cpp")
 2024-03-29 16:29:07 +01:00
ange-clement b2203b4c52 Doc + cleanup 2024-03-28 15:50:53 +01:00
ange-clement 2c9fb5cd4e doc 2024-03-28 14:14:29 +01:00
ange-clement 3cfea618e5 as in PR #7844, removed _sizing_field parameter for edge_distance. 2024-03-28 11:39:33 +01:00
ange-clement 70fd9113e7 Merge branch 'master' of https://github.com/CGAL/cgal into Mesh-3-edge-distance-criterium-aclement 2024-03-28 11:36:39 +01:00
ange-clement 74b5429160 Changed distance_bound to edge_distance in CHANGES.md + 
doc
 2024-03-27 22:58:57 +01:00
Sébastien Loriot 5254404517 Merge remote-tracking branch 'cgal/master' into HEAD 2024-03-27 22:25:41 +01:00
Sven Oesau f0d32fe869
Merge branch 'master' into AABB_tree-2d_and_3d 2024-03-26 16:03:19 +01:00
Sven Oesau 65be6133d8 removing deprecated AABB types 2024-03-26 15:56:45 +01:00
Laurent Rineau bffa8f213e Merge pull request #8072 from janetournois/Mesh_3-use_one_step_loop-jtournois 
Mesh_3 - fix mesher using the `one_step()` loop

# Conflicts:
#	Mesh_3/include/CGAL/Mesh_3/Triangulation_helpers.h
 2024-03-26 10:21:00 +01:00
Mael Rouxel-Labbé 5e38ed54df Fix double "Figure" in doc 2024-03-22 17:33:43 +01:00
Jane Tournois ad98ab16b7 unused argc, argv 2024-03-22 10:22:48 +01:00
Jane Tournois 644d6493eb nearest_power_vertex() does not work on an empty triangulation 2024-03-21 16:33:26 +01:00
Jane Tournois 44e176b88a
unused typedef 
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
 2024-03-21 16:13:30 +01:00
Jane Tournois 5b004ffbe6 add a test for one_step() loop with features on tiny data 2024-03-14 17:27:47 +01:00
Jane Tournois 80fd8759dd avoid insertion of points inside protecting balls, during initialization step 2024-03-14 16:40:28 +01:00
Jane Tournois 4e81649dd9 use set_surface_only() to be more explicit 2024-03-14 16:32:29 +01:00
Jane Tournois d085faba0c remove duplicate 2024-03-14 16:31:11 +01:00
Jane Tournois 83c88da327 move clear_cells_and_facets_from_c3t3() inside the constructor of Mesher_3 
to make sure the input c3t3 is fully clean before starting refinement
 2024-03-14 16:28:46 +01:00
Andreas Fabri eb49100a96 Replace deprecated classes 2024-03-05 07:08:51 +00:00
Sébastien Loriot 910945eb5f undo dependency changes + always use core if not disabled 2024-02-27 16:19:28 +01:00
Sébastien Loriot 3b30756cd3 do not depend on CGAL_Core 2024-02-27 14:46:18 +01:00
Andreas Fabri e4558a4d4b Merge branch 'master' into CORE-boost_mp_number-GF 2024-02-23 17:04:37 +01:00
Laurent Rineau a32899f73c Merge pull request #8029 from janetournois/Mesh_3-edge_min_size-jtournois 
Mesh_3 with `edge_min_size` - make uses of `curve_segment_length()` consistent
 2024-02-16 18:03:13 +01:00
Laurent Rineau d9ebccd627 Merge pull request #8030 from janetournois/Mesh_3-perturber_doc-jtournois 
Mesh_3 - fix perturber doc
 2024-02-16 18:03:10 +01:00
Laurent Rineau f407ea44ee Merge pull request #8029 from janetournois/Mesh_3-edge_min_size-jtournois 
Mesh_3 with `edge_min_size` - make uses of `curve_segment_length()` consistent
 2024-02-16 18:02:36 +01:00
Sébastien Loriot 0e3074689b fix warning 2024-02-14 11:03:10 +01:00
Jane Tournois 51ebe945de fix the perturber doc, that was mixed with exuder (in 5.5, doc is valid) 2024-02-12 12:12:10 +01:00
Jane Tournois 34514d33f7 factorize code using curve_segment_length to one function 
and use it everywhere
 2024-02-12 11:46:33 +01:00
Sebastien Loriot caecbe29c7
Replace boost::mpl (#7813) 
- `boost::mpl::if_` --> `std::conditional`
- `boost::enable_if` -> `std::enable_if`
- `boost::mpl::and_` -> `&&`
- `boost::mpl::or_` -> `||`
- `boost::constant::bool_` -> `std::bool_constant`
- ...
 2023-12-26 17:33:36 +01:00
Sébastien Loriot 15aa810876 Merge remote-tracking branch 'cgal/5.6.x-branch' 2023-12-22 17:16:49 +01:00
Sebastien Loriot eb659137e6
Mesh_3 - `edge_min_size` may cause hanging (#7863) 
## Summary of Changes

When the criterion `edge_min_size` is set, the graph of features is
likely to be invalid or at least inconsistent with the input graph.
Checking its topology does not make any sense and could lead to hanging
when trying to compute polyline feature lengths (because it's trying to
walk on different curves, jumping from one to the other, etc).

This PR disables the check-features-after-protect step when
`edge_min_size` is used, since we anyway do not expect the feature graph
to be exactly matching the one of the input.

## Release Management

* Affected package(s): Mesh_3
* License and copyright ownership: unchanged
 2023-12-22 17:15:37 +01:00
Jane Tournois a66e78a672 when curves topology is valid, use curve_segment_length 2023-12-15 15:52:02 +01:00
Jane Tournois 3ef2ce9163 check_and_repopulate_edges() reactivated with minimal size 
disabling it may give too bad results
change the arc_length computation when minimal size is used, instead,
by approximating it by the segment length
 2023-12-15 14:44:33 +01:00
Jane Tournois 7fa2db8dfc add helper function minimal_weight() 2023-12-14 19:01:57 +01:00
Jane Tournois 85b8da120d constify more 2023-12-14 15:36:57 +01:00
Jane Tournois 54677b388c set default minimal_size_ to -1 and add helper function to check if it is set 2023-12-14 15:35:06 +01:00
Laurent Rineau ef881a1aa9 Merge pull request #7844 from janetournois/Mesh_3-remove_unused_criteria-GF 
Mesh_3 - `Mesh_criteria_3` cleaning
 2023-12-11 13:56:26 +01:00
Laurent Rineau b4820031eb Merge pull request #7911 from sloriot/M3-params_errors 
Mesh_3: Fix copy/paste errors in parameters
 2023-12-11 13:54:47 +01:00
Mael Rouxel-Labbé ef2a7b389f Do not tolerate degenerate faces in inputs 2023-12-11 12:28:19 +01:00
Mael Rouxel-Labbé 17356404e0 Fix typo 2023-12-11 12:14:30 +01:00
Mael Rouxel-Labbé 6a8fc7e093 Avoid some segfaults 2023-12-11 12:08:31 +01:00
Mael Rouxel-Labbé ed14d04a61 Add benchmarking and charting scrips 2023-12-08 17:17:21 +01:00
Mael Rouxel-Labbé 7ecdabf6c3 Add benchmark_mesh_3.cpp 2023-12-08 17:16:05 +01:00
Mael Rouxel-Labbé dc38d13066 Fix a few performance data exports 2023-12-07 20:56:52 +01:00