Commit Graph

4764 Commits

Author SHA1 Message Date
ange-clement 37798b73d7 Optimisation in refine_balls : added a is_edge_in_complex boolean, the check is processed once instead of twice. 2024-04-04 12:42:41 +02:00
ange-clement e558f43e01 Added check_distance_field in Edge criteria so that refine_balls() only check edge distance when necessary. 2024-04-04 12:08:13 +02:00
ange-clement b1fb29c22a InitialPointsGenerator parameter 'n' explanation 2024-03-29 17:03:20 +01:00
ange-clement ae0f8f37c9 Finished Merge 2024-03-29 16:49:33 +01:00
ange-clement 5b0f1fc4c2 Merge branch 'master' of https://github.com/CGAL/cgal into Mesh-3-rework-make-mesh-point-initialization-2-aclement 2024-03-29 16:46:24 +01:00
ange-clement e64e28d5ef Made initial_point parameter work with any Range
With doc and example (
 example "mesh_3D_image_with_initial_points.cpp" has been renamed to  "mesh_3D_image_with_image_initialization.cpp")
2024-03-29 16:29:07 +01:00
ange-clement b2203b4c52 Doc + cleanup 2024-03-28 15:50:53 +01:00
ange-clement 2c9fb5cd4e doc 2024-03-28 14:14:29 +01:00
ange-clement 3cfea618e5 as in PR #7844, removed _sizing_field parameter for edge_distance. 2024-03-28 11:39:33 +01:00
ange-clement 70fd9113e7 Merge branch 'master' of https://github.com/CGAL/cgal into Mesh-3-edge-distance-criterium-aclement 2024-03-28 11:36:39 +01:00
ange-clement 74b5429160 Changed distance_bound to edge_distance in CHANGES.md +
doc
2024-03-27 22:58:57 +01:00
Sébastien Loriot 5254404517 Merge remote-tracking branch 'cgal/master' into HEAD 2024-03-27 22:25:41 +01:00
Sven Oesau f0d32fe869
Merge branch 'master' into AABB_tree-2d_and_3d 2024-03-26 16:03:19 +01:00
Sven Oesau 65be6133d8 removing deprecated AABB types 2024-03-26 15:56:45 +01:00
Laurent Rineau bffa8f213e Merge pull request #8072 from janetournois/Mesh_3-use_one_step_loop-jtournois
Mesh_3 - fix mesher using the `one_step()` loop

# Conflicts:
#	Mesh_3/include/CGAL/Mesh_3/Triangulation_helpers.h
2024-03-26 10:21:00 +01:00
Mael Rouxel-Labbé 5e38ed54df Fix double "Figure" in doc 2024-03-22 17:33:43 +01:00
Jane Tournois ad98ab16b7 unused argc, argv 2024-03-22 10:22:48 +01:00
Jane Tournois 644d6493eb nearest_power_vertex() does not work on an empty triangulation 2024-03-21 16:33:26 +01:00
Jane Tournois 44e176b88a
unused typedef
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2024-03-21 16:13:30 +01:00
Jane Tournois 5b004ffbe6 add a test for one_step() loop with features on tiny data 2024-03-14 17:27:47 +01:00
Jane Tournois 80fd8759dd avoid insertion of points inside protecting balls, during initialization step 2024-03-14 16:40:28 +01:00
Jane Tournois 4e81649dd9 use set_surface_only() to be more explicit 2024-03-14 16:32:29 +01:00
Jane Tournois d085faba0c remove duplicate 2024-03-14 16:31:11 +01:00
Jane Tournois 83c88da327 move clear_cells_and_facets_from_c3t3() inside the constructor of Mesher_3
to make sure the input c3t3 is fully clean before starting refinement
2024-03-14 16:28:46 +01:00
Andreas Fabri eb49100a96 Replace deprecated classes 2024-03-05 07:08:51 +00:00
Sébastien Loriot 910945eb5f undo dependency changes + always use core if not disabled 2024-02-27 16:19:28 +01:00
Sébastien Loriot 3b30756cd3 do not depend on CGAL_Core 2024-02-27 14:46:18 +01:00
Andreas Fabri e4558a4d4b Merge branch 'master' into CORE-boost_mp_number-GF 2024-02-23 17:04:37 +01:00
Laurent Rineau a32899f73c Merge pull request #8029 from janetournois/Mesh_3-edge_min_size-jtournois
Mesh_3 with `edge_min_size` - make uses of `curve_segment_length()` consistent
2024-02-16 18:03:13 +01:00
Laurent Rineau d9ebccd627 Merge pull request #8030 from janetournois/Mesh_3-perturber_doc-jtournois
Mesh_3 - fix perturber doc
2024-02-16 18:03:10 +01:00
Laurent Rineau f407ea44ee Merge pull request #8029 from janetournois/Mesh_3-edge_min_size-jtournois
Mesh_3 with `edge_min_size` - make uses of `curve_segment_length()` consistent
2024-02-16 18:02:36 +01:00
Sébastien Loriot 0e3074689b fix warning 2024-02-14 11:03:10 +01:00
Jane Tournois 51ebe945de fix the perturber doc, that was mixed with exuder (in 5.5, doc is valid) 2024-02-12 12:12:10 +01:00
Jane Tournois 34514d33f7 factorize code using curve_segment_length to one function
and use it everywhere
2024-02-12 11:46:33 +01:00
Sebastien Loriot caecbe29c7
Replace boost::mpl (#7813)
- `boost::mpl::if_` --> `std::conditional`
- `boost::enable_if` -> `std::enable_if`
- `boost::mpl::and_` -> `&&`
- `boost::mpl::or_` -> `||`
- `boost::constant::bool_` -> `std::bool_constant`
- ...
2023-12-26 17:33:36 +01:00
Sébastien Loriot 15aa810876 Merge remote-tracking branch 'cgal/5.6.x-branch' 2023-12-22 17:16:49 +01:00
Sebastien Loriot eb659137e6
Mesh_3 - `edge_min_size` may cause hanging (#7863)
## Summary of Changes

When the criterion `edge_min_size` is set, the graph of features is
likely to be invalid or at least inconsistent with the input graph.
Checking its topology does not make any sense and could lead to hanging
when trying to compute polyline feature lengths (because it's trying to
walk on different curves, jumping from one to the other, etc).

This PR disables the check-features-after-protect step when
`edge_min_size` is used, since we anyway do not expect the feature graph
to be exactly matching the one of the input.

## Release Management

* Affected package(s): Mesh_3
* License and copyright ownership: unchanged
2023-12-22 17:15:37 +01:00
Jane Tournois a66e78a672 when curves topology is valid, use curve_segment_length 2023-12-15 15:52:02 +01:00
Jane Tournois 3ef2ce9163 check_and_repopulate_edges() reactivated with minimal size
disabling it may give too bad results
change the arc_length computation when minimal size is used, instead,
by approximating it by the segment length
2023-12-15 14:44:33 +01:00
Jane Tournois 7fa2db8dfc add helper function minimal_weight() 2023-12-14 19:01:57 +01:00
Jane Tournois 85b8da120d constify more 2023-12-14 15:36:57 +01:00
Jane Tournois 54677b388c set default minimal_size_ to -1 and add helper function to check if it is set 2023-12-14 15:35:06 +01:00
Laurent Rineau ef881a1aa9 Merge pull request #7844 from janetournois/Mesh_3-remove_unused_criteria-GF
Mesh_3 - `Mesh_criteria_3` cleaning
2023-12-11 13:56:26 +01:00
Laurent Rineau b4820031eb Merge pull request #7911 from sloriot/M3-params_errors
Mesh_3: Fix copy/paste errors in parameters
2023-12-11 13:54:47 +01:00
Mael Rouxel-Labbé ef2a7b389f Do not tolerate degenerate faces in inputs 2023-12-11 12:28:19 +01:00
Mael Rouxel-Labbé 17356404e0 Fix typo 2023-12-11 12:14:30 +01:00
Mael Rouxel-Labbé 6a8fc7e093 Avoid some segfaults 2023-12-11 12:08:31 +01:00
Mael Rouxel-Labbé ed14d04a61 Add benchmarking and charting scrips 2023-12-08 17:17:21 +01:00
Mael Rouxel-Labbé 7ecdabf6c3 Add benchmark_mesh_3.cpp 2023-12-08 17:16:05 +01:00
Mael Rouxel-Labbé dc38d13066 Fix a few performance data exports 2023-12-07 20:56:52 +01:00
Mael Rouxel-Labbé d715a658a0 Minor indentation fix 2023-12-07 20:56:30 +01:00
Mael Rouxel-Labbé 024651390f Add the number of threads to the conccurent mesher config 2023-12-07 20:55:15 +01:00
Mael Rouxel-Labbé 27633e2f44 Fix doc 2023-12-07 10:13:58 +01:00
Mael Rouxel-Labbé b4d465ce85 Add a test 2023-12-05 22:34:00 +01:00
Mael Rouxel-Labbé 9c4117162b Clean CMakeLists.txt 2023-12-01 10:45:21 +01:00
Mael Rouxel-Labbé 2e8bfb18f8 Get rid of MSVC-specific precompiled header mechanisms 2023-12-01 10:40:44 +01:00
Mael Rouxel-Labbé cf7c6681f9 Merge remote-tracking branch 'cgal/master' into Mesh_3-update_benchmark-jtournois 2023-12-01 10:09:07 +01:00
Jane Tournois 0aa0242979 fix tbb new API, and add total refinement time 2023-12-01 10:01:54 +01:00
Jane Tournois 8a4c99f19b remove unused variables
now there is only one possible sizing definition left, they have
become useless
2023-11-30 09:53:04 +01:00
Laurent Rineau 0744eba4bf Merge pull request #7754 from janetournois/Mesh_3-manifold_and_min_size-jtournois
Mesh_3 - use `manifold()` and `facet_min_size` together
2023-11-29 17:23:25 +01:00
Laurent Rineau 95b83b1214 Merge pull request #7845 from puneetmatharu/patch-cgal-dont-override-build-testing
Patch usage of BUILD_TESTING to handle the case that CGAL is a subproject
2023-11-29 17:22:54 +01:00
Laurent Rineau eb59cc6105 Merge remote-tracking branch 'cgal/master' into Installation-ITK-jtournois 2023-11-24 10:50:26 +01:00
Jane Tournois 33b9d44797 update files location that are in Data/data/meshes 2023-11-24 10:42:20 +01:00
Jane Tournois 0b94f02516 upate the use of TBB with new API 2023-11-24 10:38:32 +01:00
Laurent Rineau 9262c6a8b6 Re-add CGAL_ITK_support.cmake
That will allow to be compatible with ITK version 4.13 and 5.x.
2023-11-23 17:25:18 +01:00
Jane Tournois 7fdc36dbbe remove *_sizing_field criteria from test 2023-11-23 15:48:46 +01:00
Jane Tournois 4f2ec8abe0 increase facet size 2023-11-17 16:21:37 +01:00
Jane Tournois 850c99e0f2 make data match exactly at vertices
with no degenerate border edges
2023-11-17 16:18:04 +01:00
Laurent Rineau 7b8c90ec3b
Merge branch 'master' into Mesh-3-edge-distance-criterium-aclement 2023-11-16 14:53:25 +01:00
Sébastien Loriot cfac63f156 Merge remote-tracking branch 'cgal/master' into HEAD 2023-11-16 11:35:35 +01:00
Jane Tournois e4e13e2f57 do not check the graph of features after protection when minimal_size is set
when minimal_size is set, the graph of features is likely to be invalid

or at least inconsistent with the input graph
so checking its topology does not make any sense and could lead to
- assertions failing in debug mode,
- hanging in release mode
2023-11-14 12:28:18 +01:00
ange-clement 0450b2f0bb Updated example explication +
Deleted commented code and added const refs
2023-11-13 13:45:38 +01:00
Jane Tournois 0b73361226 remove CGAL_ITK_support.cmake
and adapt the CMakeLists that were using it
2023-11-13 12:47:39 +01:00
ange-clement d9f0f258a5 Added initial_points to the parameter doc 2023-11-13 11:53:55 +01:00
ange-clement ec7a6ac876 Added meshing parameter : initial_points 2023-11-10 17:06:04 +01:00
ange-clement b01727b3ca Fixed wrong file name 2023-11-10 13:12:39 +01:00
ange-clement ca605fe57f Fix doc build 2023-11-07 16:24:59 +01:00
ange-clement ca7548b341 Removed example +
Modified example mesh_3D_image_with_custom_initialization to use new API
+ Changed InitialPointsGenerator concept : outputs
std::tuple<Weighted_point_3, int, Index> instead of
std::tuple<Point_3, int, Index>
+ custom initialization will be called even if a feature detector is set
2023-11-07 15:25:50 +01:00
ange-clement ea11f328d6 Doc update +
Changed initial_point_generator default parameter +
Fix previous change from pair to tuple
2023-11-03 17:44:05 +01:00
ange-clement 48a8796248 Corrected changes.md +
Removed word "distancing" +
Renamed distance_bound_field to distance_field +
Commented example output +
Removed use of sizing_field_param for edge_distance +
Renamed SizingField2 to DistanceField +
Added function query_size
2023-11-03 12:38:05 +01:00
Jane Tournois c85711d58f test cleaning 2023-11-03 09:50:25 +01:00
Puneet Matharu 7944441068 Patch usage of BUILD_TESTING to handle the case that CGAL is a subproject. 2023-11-02 18:09:03 +00:00
Jane Tournois 5b6bf12745 use get_parameter_reference for all the possibly-field parameters 2023-11-02 14:39:34 +01:00
Jane Tournois 093660ce43 remove unused and undocumented criterion cell_radius_edge 2023-11-02 14:27:31 +01:00
Jane Tournois 361c5c5009 remove all the _sizing_field parameters that have never been used
they were removed from the documentation before being merged in the master branch
see SVN commit
1614a89e32
2023-11-02 14:13:07 +01:00
Jane Tournois f76161be3c store squared min_size instead of min_size 2023-11-02 09:27:27 +01:00
Laurent Rineau 51627e3505 Merge remote-tracking branch 'cgal/master' into CGAL-Qt6-GF
# Conflicts:
#	GraphicsView/demo/Bounding_volumes/CMakeLists.txt
2023-11-01 20:59:44 +01:00
ange-clement d7f110e428 Changed InitialPointsGenerator concept :
The points' dimensions are also outputed by the initialisation.
2023-10-31 15:34:42 +01:00
ange-clement 9d22242b63 Removed useless initialization files
Removed initialize_triangulation_from_labeled_image
Removed initialize_triangulation_from_gray_image
2023-10-31 12:21:52 +01:00
Jane Tournois 3204b527e8 reduce perturb_mesh_3 angle bound to fit timeout on more platforms 2023-10-30 12:11:24 +01:00
ange-clement 15e75d0d04 Small doc fix 2023-10-25 15:08:30 +02:00
ange-clement ec5539eac3 Revision 1 :
Doc fix +
Deleted default_initial_points_generation() +
Created Construct_initial_points_gray_image.h
2023-10-25 14:57:48 +02:00
ange-clement 976e73cf89
Update Mesh_3/doc/Mesh_3/Mesh_3.txt
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-10-25 12:09:35 +02:00
ange-clement c014741454 Doc add example +
Fix for initialize_triangulation_from_gray_image
2023-10-25 10:35:25 +02:00
Jane Tournois 4bbbc482cf reduce the target dihedral angle to fit in the testsuite timeout 2023-10-24 17:21:29 +02:00
Andreas Fabri 0e9905c490 Fixes 2023-10-24 14:43:24 +01:00
Andreas Fabri 1db8ff6e68 Mesh_3::Add handling of *.nii files in one example 2023-10-24 13:11:12 +01:00
Jane Tournois 99c0df22ad Merge remote-tracking branch 'cgal/master' into Mesh_3-manifold_and_min_size-jtournois
# Conflicts:
#	Polyhedron/demo/Polyhedron/resources/shader_c3t3.frag
2023-10-24 12:55:09 +02:00
ange-clement 7eff272545 Fix doc missing ref 2023-10-19 09:41:31 +02:00
ange-clement 6955dbdd5a Doc operator()
of Construct_initial_points_labeled_image
2023-10-18 15:20:42 +02:00
ange-clement 3ac063992f Small doc fix 2023-10-18 14:11:57 +02:00
ange-clement df6d1ed6fd Fix Doc :
Added Construct_initial_points_labeled_image to doxyfile
2023-10-18 13:41:03 +02:00
ange-clement 932e8a2b34 Fix Doc missing end of description 2023-10-18 12:46:44 +02:00
ange-clement 23af3eb0e2 Updated doc example snippets +
Added group "Mesh Initialization Functions" +
Added concept "InitialPointsGenerator" +
Documented model "Construct_initial_points_labeled_image" +
Updated demo parametters +
Fix reneming errors
2023-10-18 12:38:03 +02:00
ange-clement 4ae4425fbc fixed missing typename in tests 2023-10-18 11:17:17 +02:00
ange-clement 91d66d0bfc Renamed Construct_initial_points_from_labeled_image.h 2023-10-18 11:01:50 +02:00
ange-clement 6558190eda Fixed doc 2023-10-18 10:37:34 +02:00
ange-clement cb715951d0 Doc changed example +
Doc added parameter +
Doc make_mesh_3 +
Doc Construct_initial_points_labeled_image header +
Remove unwanted duplicata
2023-10-18 10:31:19 +02:00
ange-clement c232929fd1 Fix error when no initial_points_generator 2023-10-17 16:12:48 +02:00
ange-clement 4ee4dff969 Doc change + small fix 2023-10-17 16:02:28 +02:00
ange-clement f2af65444d Use parameters instead of template
Allows easier initialisation
2023-10-17 15:39:42 +02:00
ange-clement 9fc7230e64 Fix CI 2023-10-16 14:04:45 +02:00
ange-clement 0d0c1f3213 Fix CI 2023-10-16 13:26:20 +02:00
ange-clement bec5358ff1 Fix CI 2023-10-16 12:39:04 +02:00
Laurent Rineau 98a6bf7934 Merge pull request #7744 from lrineau/CGAl-fix_IO_oformat_iformat-GF
fix : iformat/oformat are in CGAL::IO
2023-10-16 11:13:21 +02:00
ange-clement 2732dad5e4 Fix CI 2023-10-16 10:17:37 +02:00
ange-clement 3937c5df34 Implemented make_mesh_3 param :
initial_points_generator
2023-10-13 14:51:43 +02:00
ange-clement 00514ec7dc Merge branch 'master' of https://github.com/CGAL/cgal into Mesh-3-edge-distance-criterium-aclement 2023-10-10 15:06:02 +02:00
albert-github 6f560fcdce issue #7767 Problem with the documenation of Mesh_3
removing files that were removed by #7445 but reintroduced by #7395
2023-10-09 16:03:49 +02:00
Jane Tournois 2c0e04c4fd replace min_facet_size by squared version to avoid multiple redundant computations 2023-10-06 09:44:53 +02:00
Jane Tournois 7dc1f889e0 wip adding a test 2023-10-06 09:44:04 +02:00
Jane Tournois d46efd537f avoid computing twice the biggest incident facet 2023-10-02 16:59:42 +02:00
Jane Tournois 05b80838e7 check min_size before inserting facets or edges in refinement queues 2023-10-02 16:31:29 +02:00
Jane Tournois e8651b8a58 add min_radius_bound member and accessor 2023-10-02 16:30:21 +02:00
Jane Tournois 1d79ab5023 rename B_ 2023-10-02 16:28:04 +02:00
Jane Tournois eacc3ab4d1 add missing typedef 2023-10-02 12:13:54 +02:00
ange-clement 891da07cf4 Added CGAL:: to global calls 2023-10-02 09:49:55 +02:00
ange-clement 8cca7b57e3 Updated doc : Concept MeshCriteria_3, and CamelCase for template in CGAL::Mesh_edge_criteria_3 2023-09-28 10:14:30 +02:00
Laurent Rineau ebdfddbf5b add a link to TBB 2023-09-25 16:30:47 +02:00
Laurent Rineau 1d29a75c9a iformat/oformat are in CGAL::IO
The calls without the `IO::` namespace are deprecated.
2023-09-25 16:09:41 +02:00
Sébastien Loriot 8700394122 boost::mpl::if_ -> std::conditional 2023-09-24 22:57:20 +02:00
Laurent Rineau 28632f21fc Merge branch 'master' into CGAL-Qt6-GF
# Conflicts:
#	Installation/CHANGES.md
2023-09-14 17:40:05 +02:00
Laurent Rineau b05e1e9e46 Remove UseCGAL.cmake
and our old CMake macros `use_lib` and `use_component`.
2023-09-14 17:32:55 +02:00
Laurent Rineau 3cf928a4c7 Merge pull request #7704 from sloriot/Mesh_3-PCMD_in_domain_bug
Fix Is_in_domain potential infinite loop

# Conflicts:
#	Mesh_3/include/CGAL/Polyhedral_complex_mesh_domain_3.h
2023-09-13 16:16:23 +02:00
Sebastien Loriot b2c6cec8af
A missing ref
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2023-09-12 11:08:21 +02:00
ange-clement 96b3fbefad Updated CHANGES.md and small fixes 2023-09-08 11:43:34 +02:00
ange-clement 83b1cb6e1a Merge branch 'Mesh-3-edge-distance-criterium-aclement' of https://github.com/ange-clement/cgal into Mesh-3-edge-distance-criterium-aclement 2023-09-07 18:03:42 +02:00
ange-clement 98a1d0ce71 Fixed edge_distance test 2023-09-07 18:03:29 +02:00
ange-clement f6de72af39 Fixed default construction for mesh_edge_criteria and protect_edges_sizing_field 2023-09-07 17:40:00 +02:00
Sébastien Loriot ed521e03b0 rename macro 2023-09-07 17:33:41 +02:00
Sébastien Loriot dd383da307 avoid an infinite loop in the case the source of the ray in on the face 2023-09-07 17:33:17 +02:00
ange-clement 8883628c06 Added testing on edge approximation 2023-09-07 14:46:52 +02:00
ange-clement 8668b493c8
Update Mesh_3/doc/Mesh_3/Mesh_3.txt
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-09-07 12:11:05 +02:00
ange-clement 25e9b67852 Removed white space 2023-09-07 11:37:07 +02:00
ange-clement a9d028e15f fixed merge problem 2023-09-07 11:08:04 +02:00
ange-clement a23c9d44ca Merge branch 'master' into Mesh-3-edge-distance-criterium-aclement 2023-09-07 10:54:10 +02:00
Laurent Rineau 46923342ad Merge pull request #7576 from albert-github/feature/issue_7395
issue #7395 Improvement of layout of model relations

# Conflicts:
#	Kernel_23/doc/Kernel_23/CGAL/Vector_2.h
2023-09-07 10:48:34 +02:00
ange-clement c73da52cf4 Rework of Mesh_edge_criteria's constructor.
Now using same principle as Mesh_facet_criteria.
2023-09-06 10:41:31 +02:00
ange-clement c0e92057ee Created dummy NoDistanceFunction.
DistanceFunction can now be ommited,
even if the SizingFunction is not default-constructible.
2023-09-05 13:53:28 +02:00
ange-clement 7136ce6499 More precise testing
test if edges generated with a max distance are smaller.
2023-09-05 12:05:11 +02:00
ange-clement 6b1627d539 fixed typos 2023-09-05 10:55:11 +02:00
ange-clement 96eb93c497 minor edge_distance example correction 2023-09-05 10:30:12 +02:00
ange-clement c5cb6646e4 moved edge_distance example after sizing field example 2023-09-05 10:27:55 +02:00
Laurent Rineau f499b63534
Update features_detection.h 2023-08-28 14:07:24 +02:00
albert-github 93001308f4 Merge branch 'master' into feature/issue_7395
# Conflicts:
#	Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Concepts/ArrangementPointLocation_2.h
#	Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Concepts/ArrangementVerticalRayShoot_2.h
2023-08-18 11:10:42 +02:00
Sébastien Loriot 28f904f4e2 Merge remote-tracking branch 'cgal/master' 2023-08-15 07:16:14 +02:00
Sébastien Loriot eada3ee8ca Merge branch 'master' into 'sloriot/CGAL-using_c++17_stl' 2023-08-14 14:19:25 +02:00
Sébastien Loriot ed71cfdaa0 Merge pull request #7445 from afabri/Mesh_3-doc_fixes-GF
Mesh_3: Improvements of the Documentation
2023-08-14 14:06:16 +02:00
Sébastien Loriot 61874d15e1 do not use deprecated code 2023-08-09 08:36:44 +02:00
Andreas Fabri 959443253d Remove deprecated file 2023-07-28 12:41:45 +01:00
Andreas Fabri b843f0b2a8 CamelCase 2023-07-28 11:35:42 +01:00
Andreas Fabri de85effe56
Update Mesh_3/include/CGAL/Mesh_polyhedron_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-28 11:54:26 +02:00
Andreas Fabri 50f47a3f57
Update Mesh_3/include/CGAL/Polyhedral_mesh_domain_with_features_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-28 11:51:23 +02:00
Andreas Fabri 2ef1bb4e48
Update Mesh_3/include/CGAL/Mesh_polyhedron_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-28 11:50:57 +02:00
Andreas Fabri 913e8848c6
Update Mesh_3/include/CGAL/Polyhedral_mesh_domain_with_features_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-28 11:50:18 +02:00
Andreas Fabri 626f0578f7
Update Mesh_3/include/CGAL/Mesh_domain_with_polyline_features_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-28 11:48:33 +02:00
Andreas Fabri c70d8670b3
Update Mesh_3/include/CGAL/Mesh_domain_with_polyline_features_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-28 11:47:50 +02:00
Andreas Fabri c42aa48949
Update Mesh_3/include/CGAL/Mesh_domain_with_polyline_features_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-28 11:47:16 +02:00
Andreas Fabri da5b2ae862
Update Mesh_3/include/CGAL/Mesh_domain_with_polyline_features_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-28 11:46:33 +02:00
Andreas Fabri 41ae66aedf
Update Mesh_3/include/CGAL/Implicit_to_labeling_function_wrapper.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-28 11:42:59 +02:00
Andreas Fabri ba0172a544
Update Mesh_3/doc/Mesh_3/PackageDescription.txt
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:59:30 +02:00
Andreas Fabri acdb2d40c5
Update Mesh_3/include/CGAL/Mesh_facet_criteria_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:58:24 +02:00
Andreas Fabri 5b08570345
Update Mesh_3/include/CGAL/Polyhedral_mesh_domain_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:57:41 +02:00
Andreas Fabri 21b9f6dfb5
Update Mesh_3/include/CGAL/Mesh_cell_criteria_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:57:09 +02:00
Andreas Fabri 1963697d84
Update Mesh_3/include/CGAL/Mesh_cell_criteria_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:56:32 +02:00
Andreas Fabri 7bc4b30501
Update Mesh_3/include/CGAL/Polyhedral_mesh_domain_with_features_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:52:13 +02:00
Andreas Fabri 54fbebf2b6
Update Mesh_3/include/CGAL/Polyhedral_mesh_domain_with_features_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:51:38 +02:00
Andreas Fabri 7f20c6b773
Update Mesh_3/include/CGAL/Polyhedral_mesh_domain_with_features_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:51:13 +02:00
Andreas Fabri 81bbc3e0db
Update Mesh_3/doc/Mesh_3/Mesh_3.txt
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:50:23 +02:00
Andreas Fabri fb3680f8f5
Update Mesh_3/doc/Mesh_3/Mesh_3.txt
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:48:55 +02:00
Laurent Rineau a746283359 Merge pull request #7552 from MaelRL/Mesh_3-PMD_init_bug_fixes-GF
Fix initialisation issues in Mesh_3
2023-07-26 17:34:33 +02:00
Laurent Rineau 820b1c5609 Merge pull request #7552 from MaelRL/Mesh_3-PMD_init_bug_fixes-GF
Fix initialisation issues in Mesh_3
2023-07-26 17:30:40 +02:00
Mael Rouxel-Labbé 1f258bc84d Fix initialization failing if the ray's source is on the domain
This is a band aid fix, a proper fix is to rework the full initilization
pipeline. This is the purpose of the following pull request:
https://github.com/CGAL/cgal/pull/7606
2023-07-19 12:46:13 +02:00
albert-github ad41766454 issue #7395 Improvement of layout of model relations
Corrected `cgalModels` to `cgalHasModes` inside `cgalHasNodelsBegin` / `cgalHasModelsEnd`
2023-07-18 13:23:37 +02:00
albert-github de3ba0f47c Merge remote-tracking branch 'upstream/master' into feature/issue_7395 2023-07-17 10:17:34 +02:00
albert-github 4e5578d469 issue #7395 Improvement of layout of model relations
- based on review
2023-07-15 13:12:15 +02:00
Laurent Rineau d10e9387c2 Merge branch 'master' into CGAL-add_missing_test
# Conflicts:
#	STL_Extension/test/STL_Extension/test_skiplist.cpp
2023-07-12 15:48:42 +02:00
Mael Rouxel-Labbé 0d3458504b Add some debug code 2023-07-12 10:47:17 +02:00
Mael Rouxel-Labbé 49bb14b6d2 Fix not rescaling some balls in 2D protection with non-zero minimal weight
The code break'd but did not restart if a special ball was encountered
2023-07-12 10:03:14 +02:00
Mael Rouxel-Labbé 6f65ecf246 Check the cached Boolean before doing more complex geometrical checks 2023-07-12 09:44:03 +02:00
albert-github 301728a8a9 issue #7395 Improvement of layout of model relations
- Completed the cgalModels part
2023-07-09 12:43:36 +02:00
albert-github ee2a55279d issue #7395 Improvement of layout of model relations
- Completed the cgalHasModel part
- corrected spelling of `Has Model` and `Is Model Of` to `Has model` and `Is model of`
2023-07-06 17:35:34 +02:00
Sébastien Loriot b66afab814 Merge remote-tracking branch 'sloriot/CGAL-using_c++17_stl' into HEAD 2023-07-05 11:29:35 +02:00
Sébastien Loriot 68813c5c63 Merge pull request #7403 from sloriot/CGAL-replace_boost_by_std
Replace boost by std
2023-07-05 11:08:36 +02:00
Andreas Fabri 7a26a6af58 Remove files in test that are also in examples (and compiled there) 2023-06-29 10:14:48 +01:00
Sébastien Loriot 62f22e9a6c use oformat for optional 2023-06-29 10:43:56 +02:00
Sébastien Loriot efd8b2d38b add more missing tests 2023-06-27 11:18:20 +02:00
Mael Rouxel-Labbé 39c0a9fb33 Fix returning no intersection for a ray with spawn in a triangle 2023-06-26 17:15:49 +02:00
Mael Rouxel-Labbé 308ee5c967 Minor debug readability improvements 2023-06-26 17:10:58 +02:00
Mael Rouxel-Labbé fbecb18f49 Fix bad comparison 2023-06-26 17:10:06 +02:00
Andreas Fabri 28dbd6b8ee allow -> enable 2023-06-24 10:37:39 +01:00
Andreas Fabri 0f4f903f60 merge cgal/master 2023-06-24 10:24:15 +01:00
Ange Clement 99e78ec13a more fixes 2023-06-23 10:58:11 +02:00
Ange Clement f0fdc5cbfa fixes 2023-06-23 10:44:48 +02:00
Ange Clement f3f1069ee7 Added example to the documentation + Corrected edge_distance documentation 2023-06-23 10:34:32 +02:00
Ange Clement 447eace7d2 Added testing for edge_distance : - Modified test_mesh_criteria_creation.cpp to test the creation with or without a SizingField - Modified test_meshing_determinism.cpp to test determinism of mesh creation - Added test_max_edge_distance.cpp that estimate number of vertices and facets and test that it is greater than without the parameter 2023-06-22 17:43:07 +02:00
Sébastien Loriot dfc386d65b Merge branch 'master' into HEAD 2023-06-22 14:05:45 +02:00
Ange Clement 8998f459b1 Added a undocumented test 2023-06-22 13:03:27 +02:00
Laurent Rineau 70ac38bed0 Merge pull request #7523 from nmnobre/doc_segmentation
Fix typos in multiple manuals
2023-06-22 11:59:32 +02:00
Laurent Rineau 4afd96e95d Merge pull request #7527 from janetournois/Mesh_3-fix_weighted_image_oracle-jtournois
Mesh_3 for weighted images - fix translated labeled image case
2023-06-22 11:59:29 +02:00
Laurent Rineau 6e5070c302 Merge pull request #7523 from nmnobre/doc_segmentation
Fix typos in multiple manuals
2023-06-22 11:58:48 +02:00
Laurent Rineau 63398aa5a0 Merge pull request #7527 from janetournois/Mesh_3-fix_weighted_image_oracle-jtournois
Mesh_3 for weighted images - fix translated labeled image case
2023-06-22 11:58:45 +02:00
Ange Clement d8f9ea3162 Clean whitespace in Protect_edges_sizing_field.h 2023-06-21 12:28:52 +02:00
Ange Clement 732fe69f83 edge_distance now works on images domains too 2023-06-21 11:36:51 +02:00
Ange Clement 53704ac50f edge_distance changed from a value to a scalar field 2023-06-20 14:40:58 +02:00
Nuno Miguel Nobre 0469f46105 Fix plurals in a number of manuals 2023-06-20 13:29:44 +01:00
Ange Clement f5b1deb12d Removed non necessary check 2023-06-20 09:58:02 +02:00
Ange Clement 5e6b4b9db6 First result with method that look at geodesic distance of the midpoint. Only works for domain Polyhedral_mesh_domain_with_features_3 2023-06-20 09:26:16 +02:00
Sébastien Loriot 0ee31a5d4f remove extra parenthesis 2023-06-19 19:17:49 +02:00
Ange Clement d2b8627fba framework for edge_distance criterium 2023-06-19 12:46:17 +02:00
Sébastien Loriot f936680600 Merge remote-tracking branch 'cgal/master' into HEAD 2023-06-15 18:48:39 +02:00
Jane Tournois c9b04ebc97 apply input image translation to image with weights wrapper 2023-06-15 15:05:39 +02:00
Sébastien Loriot bdfa15c08f fixes after merge 2023-06-15 11:34:14 +02:00
Sébastien Loriot 9cdfe70abb Merge remote-tracking branch 'sloriot/CGAL-toward_6.0' 2023-06-15 11:34:09 +02:00
Sébastien Loriot bbc48b2c7e more fixes
use Mesh_3::internal::get_index
std::dynamic_point_cast
std::get_if
2023-06-15 10:57:10 +02:00
Sébastien Loriot 56499e017d do not use API that did not go into the standard 2023-06-15 10:57:10 +02:00
Sébastien Loriot 9a0bdb5d96 boost::variant ---> std::variant 2023-06-15 10:57:10 +02:00
Sébastien Loriot 604dcdc435 boost::optional => std::optional 2023-06-15 10:57:09 +02:00
Sébastien Loriot bbc4d08ee0 Merge remote-tracking branch 'cgal/master' into HEAD 2023-06-15 10:47:07 +02:00
Sébastien Loriot c8a88b9014 remove CGAL_static_assertion* 2023-06-15 10:42:10 +02:00
Sébastien Loriot e54408370b remove CGAL_CXX17 macro
... and no longer used macros
2023-06-15 10:41:56 +02:00
Mael Rouxel-Labbé 21358ac490 Clean CMakelists.txt 2023-05-31 17:41:39 +02:00
Mael Rouxel-Labbé 8f0a9dd996 Fix two links 2023-05-31 11:34:37 +02:00
Mael Rouxel-Labbé cab9751987 Merge remote-tracking branch 'cgal/master' into Mesh_3-doc_fixes-GF 2023-05-31 11:30:19 +02:00
Sebastien Loriot b1b02d64fe
P3M3: Non-cubic domains, fixes, improvements (#7062)
## Summary of Changes

- Add a dummy point generator that is agnostic to the periodic domain's
geometry, allowing P3M3 to handle non-cubic domain.
- Add an example of P3M3 running on polyhedral domains.
- Fix a few issues in SMDS_3's tet soup reading relating to
non-manifoldness + general IO code speed improvements.
- Fix a few issues in P3M3's medit output and always duplicate facets to
reduce the quantity of non-manifoldness occurences.
- Fix an issue with including Mesh_3 headers before P3M3's.
- Fix periodic point projection (for Mesh_3 optimizers) badly computing
the projection direction
- Robustify a handful of P3M3 functions that were using intermediate
constructions rather than the <Point, Offset> API (which uses filtered
predicates and thus yields proper robustness)
- Misc minor code cleaning / modernization

ToDo:
- [x] Check if some medit IO issues are fixed
- [x] Add non-manifoldness flag to read_MEDIT
- [x] Fix value of orthosphere_radius_threshold
- [x] Check calls of insert_dummy_points() (use generic)
- [x] Check doc of P3M3 about cubic domains requirement

Not done:
- [ ] Fix sharp features for periodic polyhedral domains (problems due
to changing weights creating cover change...). Code:
https://gist.github.com/MaelRL/357c52dc04e16a162f13a3c6860a1398; WIP
diff: https://gist.github.com/MaelRL/f98809964acffbacb6d3f42793e2654e

## Release Management

* Affected package(s): `Mesh_3`,  `P3M3`, `P3T3`, `SMDS3`
* Issue(s) solved (if any): Fix #6997, Fix #7214
* Feature/Small Feature (if any): TODO
* License and copyright ownership: no change
2023-05-30 19:13:45 +02:00
Mael Rouxel-Labbé 7b91a3d972 Fix compilation 2023-05-26 13:47:20 +02:00
Mael Rouxel-Labbé b3fe07a51d Remove deprecated labeled mesh domains 2023-05-26 13:47:15 +02:00
Mael Rouxel-Labbé 97097f1f04 misc fixes 2023-05-26 13:19:19 +02:00
Mael Rouxel-Labbé 525338eec2 Haronize Gt/GT/etc. 2023-05-26 12:52:35 +02:00
Mael Rouxel-Labbé abad43a63d Add missing doc dependency 2023-05-25 15:19:36 +02:00
Mael Rouxel-Labbé 6d3d60c6e2 Do not document Mesh_3 classes' members that are not explicitely documented 2023-05-25 15:19:13 +02:00
Mael Rouxel-Labbé c3873374ce Carry the template parameter (as it should be if it were actually in use)
It is in fact CGAL::Default and unused everywhere, but it's clearer
this way.
2023-05-25 14:56:46 +02:00
Mael Rouxel-Labbé 13f8044027 Remove more (needless) doc appearances of TriangleAccessor 2023-05-25 14:56:16 +02:00
Mael Rouxel-Labbé bc45a00194 Undocument TriangleAccessor_3 and CGAL::Triangle_accessor_3 as they are unused 2023-05-25 12:08:01 +02:00
Andreas Fabri 0c29013c3d Polish 2023-05-23 09:58:41 +01:00
Andreas Fabri 79ce772e71 various 2023-05-22 18:46:09 +01:00
Sébastien Loriot 78ab4fab70 add special cases for header only packages 2023-05-22 18:24:06 +02:00
Andreas Fabri 95f150a16c various 2023-05-22 16:51:33 +01:00
Andreas Fabri 585dc0f424 various 2023-05-22 13:36:24 +01:00
Andreas Fabri 710219ed6d various 2023-05-22 13:12:46 +01:00