a6eff02a62
Merge remote-tracking branch 'cgal/6.0.x-branch' into master
2025-02-05 08:42:33 +01:00
5a61b6a994
Merge remote-tracking branch 'cgal/5.6.x-branch' into cgal/6.0.x-branch
2025-02-05 08:40:26 +01:00
54bfdfe04d
Mesh 3 : initial_points_generator parameter for make_mesh_3 point initialization ( #7798 )
...
## Summary of Changes
Added a `initial_points_generator` parameter in make_mesh_3.
With this parameter, we can use a custom functor when initializing the
C3t3 complex.
This functor must follow the
[Initial_points_generator](https://cgal.github.io/7798/v0/Mesh_3/classInitialPointsGenerator.html )
concept.
Tasks:
- [x] Add `initial_points_generator` parameter in `make_mesh_3`
- [x] Make an example
- [x] Write `Construct_initial_points_labeled_image` into a header
- [x] Make `initialize_triangulation_from_labeled_image` use
`Construct_initial_points_labeled_image`
- [x] Change definition of concept `InitialPointsGenerator` to output
`std::tuple<MeshDomain::Point_3, int dimension, MeshDomain::Index>`
(instead of `std::pair<MeshDomain::Point_3, MeshDomain::Index>`)
- [x] Make it pass checks
- [x] Document `initial_points_generator` parameter in `make_mesh_3`
- [x] Document `Construct_initial_points_labeled_image` header
- [x] Document example
- [x] Delete `initialize_triangulation_from_labeled_image` and
`initialize_triangulation_from_gray_image`
- [x] Make an example of labelled and gray image initialisation with the
parameter or the old custom initialization.
- [x] Make small feature page
- [x] add `Construct_initial_points_gray_image.h`, similar to
`Construct_initial_points_labeled_image.h`
- [x] Maybe add a test ?
- [x] announce in `CHANGES.md`, see
https://github.com/CGAL/cgal/pull/7798#issuecomment-2082701644
## Release Management
* Affected package(s): Mesh_3
* Issue(s) solved (if any):
* fix #922
* fix #7469
* discussion #7537
* previous closed PR #7757
* Feature/Small Feature (if any):
[Mesh_3_initial_points_generator_parameter](https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Mesh_3_initial_points_generator_parameter )
* Link to compiled documentation
[*here*](https://cgal.github.io/7798/v4/Manual/index.html ):
*
[make_mesh_3](https://cgal.github.io/7798/v4/Mesh_3/group__PkgMesh3Functions.html#gac8599a0c967075f740bf8e2e92c4770e )
has been modified to receive the parameters :
*
[initial_points_generator](https://cgal.github.io/7798/v4/Mesh_3/group__PkgMesh3Parameters.html#gaf53777b83f1b2f3e7d49275dbab6e46b )
*
[initial_points](https://cgal.github.io/7798/v4/Mesh_3/group__PkgMesh3Parameters.html#gae94f38c6cd23cce45a55608e881a546a )
* The
[InitialPointsGenerator](https://cgal.github.io/7798/v4/Mesh_3/classInitialPointsGenerator.html )
concept that the functor must be a model of.
* A model of this concept :
[Construct_initial_points_labeled_image](https://cgal.github.io/7798/v4/Mesh_3/structCGAL_1_1Construct__initial__points__labeled__image.html )
* License and copyright ownership:
2025-02-05 08:29:06 +01:00
8675d06ea1
Nef_3: Fix issue with the size of the inf box ( #8646 )
...
## Summary of Changes
Fixes Issue #8644
## Release Management
* Affected package(s): Nef_3
* Issue(s) solved (if any): fix #
* License and copyright ownership: unchanged
2025-02-05 08:26:27 +01:00
224acc14c7
Merge remote-tracking branch 'cgal/5.6.x-branch' into cgal/6.0.x-branch
2025-02-05 08:25:32 +01:00
1523772379
Merge pull request #8690 from MaelRL/SLS-API_fixes-6.0.x-GF
...
Fix API issues in 2D Straight Skeletons (6.0.x)
2025-02-05 08:25:27 +01:00
b81fce1e96
Fix API issues in 2D Straight Skeletons (5.6.x) ( #8688 )
...
## Summary of Changes
Fix a number of doc / API issues in 2D straight skeletons, and add more
tests.
TODO:
- [x] More API tests in weighted skeletons
- [x] 6.0.1 version to deal with boost::shared_ptr -> std::shared_ptr
## Release Management
* Affected package(s): `Straight_skeleton_2`
* Issue(s) solved (if any): fix #8686
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2025-02-05 08:24:24 +01:00
f72e69f8af
Fix warnings ( #8712 )
...
Revealed by #8704
2025-02-05 08:20:29 +01:00
3abe02075b
GMP is not always available
2025-02-01 23:11:25 +01:00
ca17f813b6
fix debug
2025-01-31 08:57:21 +01:00
f20af1a946
fix the value used creating the infimax box used for pairing halfedges
...
without the abs the intersection line of x=-1 and z=-1 would be on the box
leading to invalid behavior (and degenerate halfedges)
2025-01-31 08:54:42 +01:00
f7a57a6c41
Add smaller failing issue
2025-01-31 08:54:29 +01:00
3d260ba6eb
typo
2025-01-27 10:18:42 +01:00
e4c7edc436
undo init (will be done globally in another PR)
2025-01-24 10:00:20 +01:00
49b0f52f00
remove no longer valid comment
2025-01-24 08:10:05 +01:00
b19515e1f8
Merge remote-tracking branch 'cgal/6.0.x-branch'
2025-01-24 08:09:18 +01:00
7720caa9dc
Merge remote-tracking branch 'cgal/5.6.x-branch' into HEAD
2025-01-24 08:08:33 +01:00
9a7755b31f
Fix bad detection of warnings + remove outdated scripts ( #8704 )
...
for examples/tests a warning might be reported as `t`
2025-01-24 08:06:52 +01:00
8f78a020ed
Correct icon sizes ( #8703 )
...
Correct icon sizes
**Without correction**
**With correction**
2025-01-24 08:06:03 +01:00
8824b917ae
Update Documentation/doc/resources/1.8.13/cgal_stylesheet.css
...
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-01-24 08:04:50 +01:00
8a5cbddf72
Update Documentation/doc/resources/1.8.13/cgal_stylesheet.css
...
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-01-24 08:04:50 +01:00
3aa58ef5fb
Update Documentation/doc/resources/1.8.13/cgal_stylesheet.css
...
Looks like it is not necesary for the 1.8.13 version
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-01-24 08:04:50 +01:00
e36065c773
Correct icon sizes
...
Correct icon sizes
2025-01-24 08:04:50 +01:00
0bb274d169
fix warnings
2025-01-23 11:45:06 +01:00
88ed74a164
script not used
2025-01-22 14:42:00 +01:00
d8106aab4b
we now use ctest for testing + extra clean up
2025-01-22 11:42:50 +01:00
c313da8791
Merge remote-tracking branch 'cgal/6.0.x-branch'
2025-01-22 10:55:21 +01:00
5139e6ed09
Merge remote-tracking branch 'cgal/5.6.x-branch' into HEAD
2025-01-22 10:54:25 +01:00
6d458bbd31
Triangulation_3 traverser benchmark and doc fixes ( #8708 )
...
## Summary of Changes
Use the public API of traverser, fix compilation and documentation of
`Triangulation_simplex_3<Tds>`
This PR follows #8694
## Release Management
* Affected package(s): Triangulation_3, TDS doc
2025-01-22 10:50:41 +01:00
db45571323
refactor: remove duplicate header file inclusion ( #8692 )
...
## Summary of Changes
remove duplicate header file inclusion
## Release Management
* Affected package(s): Polygon_mesh_processing
2025-01-22 10:46:18 +01:00
fbaccdb075
fix compilation on msvc and use public API
2025-01-21 15:55:25 +01:00
b721064782
fix doc of Triangulation_simplex_3 (the template param is TDS)
2025-01-21 15:54:49 +01:00
f9b6f0227a
remove no longer used action
2025-01-21 11:31:41 +01:00
e4adcceaad
more clean up
2025-01-21 11:30:48 +01:00
40c8d76834
remove no longer used scripts
2025-01-21 11:26:01 +01:00
ebe9c3af98
also report warnings in example and test files
2025-01-21 11:21:57 +01:00
892c8c8454
Merge branch 'SLS-API_fixes-GF' into SLS-API_fixes-6.0.x-GF
2025-01-21 09:00:05 +01:00
74cab200c1
Fix warning
2025-01-21 08:59:26 +01:00
1d6e3056b7
typo
2025-01-20 16:59:47 +01:00
1950235653
remove extra point
2025-01-20 16:28:36 +01:00
bba9db1ff7
Merge branch 'SLS-API_fixes-GF' into SLS-API_fixes-6.0.x-GF
2025-01-20 10:46:00 +01:00
79d6f4c4d4
Fix warnings
2025-01-20 10:43:45 +01:00
b4a8c00e09
Merge remote-tracking branch 'cgal/6.0.x-branch'
2025-01-20 10:19:17 +01:00
816cd11e3a
Replace boost::optional with std::optional ( #8695 )
...
## Summary of Changes
Some occurrences that slipped through.
See https://github.com/CGAL/cgal/pull/7526
## Release Management
* Affected package(s): `Tetrahedral_remeshing`, `Triangulation_3`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2025-01-20 10:13:50 +01:00
76321c4be1
Aos 2 fixes efif ( #8666 )
...
## Fixed the Landmark point-location strategy of the Aos_2 package, so
that it can be applied to arrangements on a sphere.
The title says it all.
I slightly changed one paragraph in the user manual.
Here is the new version:
The arrangement attached to the landmark strategy must be either (i) an
instance of the `Arrangement_2]<Geom,Dcel>` class template, where the
`Traits` parameter is substituted by a geometry-traits class that models
the `ArrangementLandmarkTraits_2` concept, or (ii) an instance of the
`Arrangement_on_surface_2<GeomTraits,TopolTraits>` class template, where
the `GeometryTraits` is similarly substituted; see Section The Landmark
Concept for details about this concept.
## Release Management
* Affected package(s): Arrangement_on_surface_2
* Issue(s) solved (if any): NA
* Feature/Small Feature (if any): NA
* Link to compiled documentation: Changed one paragraph; see above.
* License and copyright ownership: TAU
2025-01-20 10:05:42 +01:00
c161fc1ccf
with the point, snippet can't be found
2025-01-20 09:48:53 +01:00
81076472b1
try to fix CI
2025-01-17 19:05:39 +01:00
01647a0019
Fix compilation of T3 traverser benchmark ( #8694 )
...
## Release Management
* Affected package(s): `Triangulation_3`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2025-01-17 19:00:50 +01:00
6d20c44ccf
Merge remote-tracking branch 'cgal/6.0.x-branch'
2025-01-17 18:52:55 +01:00
bcd33215a7
Merge remote-tracking branch 'cgal/5.6.x-branch'
2025-01-17 18:52:19 +01:00
Sébastien Loriot
Andreas Fabri
albert-github
Jane Tournois
Mael Rouxel-Labbé
Laurent Rineau