Commit Graph

109722 Commits

Author SHA1 Message Date
Sebastien Loriot aaede41f81
Spelling corrections (#8451)
Spelling corrections
2024-09-02 13:01:09 +02:00
albert-github 37218301bb Spelling corrections
Spelling corrections
2024-09-02 12:32:30 +02:00
Sébastien Loriot 38871d9b12 Merge remote-tracking branch 'cgal/5.6.x-branch' 2024-08-29 09:31:54 +02:00
Sébastien Loriot afb52e937d Merge remote-tracking branch 'cgal/5.5.x-branch' into HEAD 2024-08-29 09:31:12 +02:00
Sébastien Loriot fdd8f7f374 data dir does not exist 2024-08-29 09:08:14 +02:00
Sébastien Loriot 63d6e6505f backport of https://github.com/CGAL/cgal/pull/7382 2024-08-28 11:58:03 +02:00
Sébastien Loriot 706c5f12ae backport of https://github.com/CGAL/cgal/pull/7499 2024-08-28 11:49:45 +02:00
Laurent Rineau 12f278e431 Merge branch '5.6.x-branch' 2024-08-28 11:46:19 +02:00
Sebastien Loriot 21c75a1f0b
[PSR] Fixed example saving paths (#8437)
## Summary of Changes

Results of examples were using a file path with a folder.

## Release Management

* Affected package(s): Polygonal Surface Reconstruction
2024-08-28 11:45:41 +02:00
Laurent Rineau dc25703d6f Merge branch '5.5.x-branch' into 5.6.x-branch 2024-08-28 11:44:36 +02:00
Laurent Rineau 377e2f11bc create_new_release with SELinux: call restorecon 2024-08-28 11:37:57 +02:00
Sébastien Loriot 860f60b090 need c++17 2024-08-28 11:23:06 +02:00
Sven Oesau 4eb51f79d0 fixed saving paths 2024-08-28 10:46:59 +02:00
Laurent Rineau 261bf3aa81 try to create bug-fixes releases 2024-08-27 17:53:22 +02:00
Laurent Rineau 62cb850d5b create_new_release with SELinux: call restorecon 2024-08-26 15:39:02 +02:00
Sebastien Loriot e432e6558d
reformat the REUSE.toml file (readability), add natvis files (#8431)
## Summary of Changes

Simple reformating of those files.

## Release Management

* Affected package(s): Installation

No need to test in testsuite: test only the CI Action "REUSE" .
2024-08-26 15:25:29 +02:00
Sebastien Loriot 9ded34f6dd
Mesh_3 - bug fixes for `edge_distance` and `edge_min_size` (#8405)
## Summary of Changes

While experimenting on self-intersecting polyhedral surfaces, I met two
bugs:
* `edge_min_size` was not enough taken into account in
`Protect_edges_sizing_field`,
* `edge_distance` was missing the information of which `curve_id` the
edge belongs to (available using internal code)
causing crashes.

## Release Management

* Affected package(s): Mesh_3
* License and copyright ownership: unchanged
2024-08-26 15:24:29 +02:00
Sebastien Loriot fb9120fb30
Remove outdated Qt version checks (#8402)
## Summary of Changes

This PR removes outdated conditional blocks that check for specific Qt
versions since CGAL now uses Qt6 exclusively.

## Release Management

* Issue(s) solved (if any): #8381
2024-08-26 15:23:54 +02:00
Sébastien Loriot 1805701903 Merge remote-tracking branch 'cgal/5.6.x-branch' 2024-08-26 15:23:41 +02:00
Sébastien Loriot b682c47c56 Merge remote-tracking branch 'cgal/5.5.x-branch' into HEAD 2024-08-26 15:22:53 +02:00
Sebastien Loriot 5791f2115c
Nef_3: Fix conversion to a FaceGraph (#6727)
## Summary of Changes

Fix the case of surfaces with borders. Then they may be incident to only
the unbounded volume which so far was ignored.

## Release Management

* Affected package(s): Nef_polyhedron_3
* Issue(s) solved (if any): fix #6423
2024-08-26 15:21:47 +02:00
Sebastien Loriot 9dea168da5
Fix for Line_3 Ray_3 do_intersect (#8398)
## Summary of Changes

Some non intersection is wrongfully detected as an intersection for the
Line_3 Ray_3 combination. Here is an illustration:


![image](https://github.com/user-attachments/assets/f18fd662-5ad6-4a01-9a49-a8d0c62cf7fe)

The base code is :
```cpp
  if(!do_intersect(l, r.supporting_line()))
    return false;

  typename K::Coplanar_orientation_3 pred = k.coplanar_orientation_3_object();
  CGAL::Orientation p0p1s = pred(l.point(0), l.point(1), r.source());
  if(p0p1s == COLLINEAR)
    return true;

  CGAL::Orientation stp0 = pred(r.source(), r.second_point(), l.point(0));
  if(stp0 == COLLINEAR)
    return Ray_3_has_on_collinear_Point_3(r,l.point(0),k);

  return (p0p1s != stp0);
```

The supporting line of the ray intersects the line, and then nothing is
collinear, so we check L0,L1,R1 vs R0,R1,L0, which are of opposite sign
so there is an intersection... but there is none.

This check is very similar to what is done in Ray_3-Ray_3, where it is
correct.

I did a naive fix for now: without loss of generality we can go to the
configuration below


![image](https://github.com/user-attachments/assets/5f004941-7f58-4bf3-8416-7dc2144a891f)

and so we have an intersection as long as the ray "points" in the other
slab wrt to the line. And so, in coplanar orientation checks, if the
orientation L0,L1,R0 differs from L0, L1, (L0 + (R1-R0)).

I feel like I could probably skip at least a translation by having
something like Coplanar_orientation(P3, P3, P3, V3), and maybe even
more...

## Release Management

* Affected package(s): `Intersections_3`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2024-08-26 15:21:21 +02:00
Sebastien Loriot 51c2cd9e90
Avoid creating degenerate planes (#8416) 2024-08-26 15:20:57 +02:00
Sebastien Loriot f32c7b015d
run_doxygen_testsuite: fix SELinux contexts so that the web server can offer the files (#8432) 2024-08-26 15:20:40 +02:00
Laurent Rineau 7838b95b94 generate review of the code 2024-08-23 15:55:55 +02:00
Laurent Rineau ac46e56236 fix SELinux contexts so that the web server can offer the files 2024-08-23 15:49:20 +02:00
Laurent Rineau 02a38472a1 reformat the REUSE.toml file (readability), add natvis files 2024-08-23 15:43:53 +02:00
Sébastien Loriot 483d43cdf2 use default that is fine for most of the packages 2024-08-23 11:12:01 +02:00
Sébastien Loriot 13b5f3676a remove extra wording 2024-08-23 10:09:45 +02:00
Laurent Rineau 959e3bc812
TestSuite: Add condition to check if CXXFLAGS variable is empty (#8421)
## Summary of Changes

Added a check to avoid duplicating CXXFLAGS in the test suite
2024-08-21 16:38:31 +02:00
Nicolas Saillant 35b5c086af Add condition to check if CXXFLAGS variable is empty 2024-08-21 16:13:38 +02:00
Laurent Rineau d5e4116485 bug fixes to adapt to the new cgal.geometryfactory.com machine 2024-08-20 15:46:21 +02:00
Jane Tournois 93fd7f87c7 vertices(edge) is not available in P3T3 2024-08-20 10:58:38 +02:00
Sébastien Loriot ca2907fbfc avoid creating degenerate planes 2024-08-20 10:09:23 +02:00
Sébastien Loriot a1a7b65275 remove remaining QT_VERSION_CHECK 2024-08-19 13:01:09 +02:00
Sebastien Loriot 2bc86f90ca
keep correct variant 2024-08-19 12:54:46 +02:00
Sebastien Loriot ac9a701342
remove leftover 2024-08-19 12:53:37 +02:00
Jane Tournois 4a35823f1f ease dump code reading 2024-08-19 12:24:59 +02:00
Jane Tournois 481de41e2f use c++11 for loops 2024-08-19 12:24:32 +02:00
Jane Tournois 14a9db6d00 weight_modifier was likely to make the weight too small
let's keep the minimal weight as given in meshing criteria
2024-08-19 12:23:32 +02:00
Nicolas Saillant 1286d8b636 Remove deprecated Qt version checks 2024-08-19 12:02:19 +02:00
Sébastien Loriot ce678a62b9 Merge remote-tracking branch 'cgal/5.6.x-branch' 2024-08-19 11:23:25 +02:00
Sebastien Loriot 8730ff5d55
Shape_detection: using proper triangulated polygonal faces for linear_least_squares (#8314)
## Summary of Changes

Polygonal faces are now triangulated and face normals are calculated
using PMP::compute_face_normal.

The calculated face normals and triangulations are buffered in
Least_squares_plane_fit_region. However, Least_squares_plane_fit_sorting
is independent and does not benefit from that buffered data.

## Release Management

* Affected package(s): Shape_detection
* Issue(s) solved (if any): fix #7992
2024-08-19 11:22:41 +02:00
Sébastien Loriot 060f81452a Merge remote-tracking branch 'cgal/5.5.x-branch' into HEAD 2024-08-19 11:19:24 +02:00
Sebastien Loriot 07d33dc316
Update to REUSE tools v4 (#8350) 2024-08-19 11:18:34 +02:00
Sebastien Loriot 393f033c19
Move point cloud to the right directory (#8408) 2024-08-19 11:18:02 +02:00
Sebastien Loriot 47c417a785
Deal with duplicate lines (#8396)
## Summary of Changes

Deal with Issue #8348 

## Release Management

* Affected package(s):  Triangulation_2 and Periodic_triangulation_2
* Issue(s) solved (if any): fix #8348 
* License and copyright ownership:  unchanged
2024-08-19 11:17:50 +02:00
Sebastien Loriot e80fe2716c
add validation for the range case (#8410)
Fixes  #6840

@efifogel I did not use expensive assertion as you mentioned because it
is already done this way in intersection and symmetric_difference.
2024-08-19 11:15:58 +02:00
Sebastien Loriot 078fe188c5
Use default surface topology criteria (#8409)
Fixes #7406
2024-08-19 11:15:45 +02:00
Sebastien Loriot 1b8be7bb67
Speed up copy_face_graph (#8380)
Mostly when tm is not empty and almost make it less dependent on tm size

<s>Should probably be backported</s>
2024-08-19 11:15:28 +02:00