Commit Graph

77652 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé b080804f09 Fixed missing bound check in the sequential insertion phase
If the input point set is degenerate, dimension() < 3 is always 'true'
and we will eventually try to read beyond the end of the points vector.

See issue https://github.com/CGAL/cgal/issues/2922
2018-03-13 11:14:06 +01:00
Laurent Rineau 29747165f7 Merge pull request #2903 from maxGimeno/Fix_doc_ts_display-GF
Documentation: change header
2018-03-09 18:39:08 +01:00
Laurent Rineau cb9f03a93f Merge pull request #2910 from luis4a0/Algebraic_kernel_d-RS_MPFR_compatibility-Luis
Algebraic kernel d RS-Fix compatibility of MPFR, MPFI and RS.
2018-03-09 18:38:58 +01:00
Luis Peñaranda a8c8d6f152 Fix MPFR/MPFI check when MPFI is not present. 2018-03-08 10:05:26 -03:00
Luis Peñaranda 6200edcfaf Forbid MPFR 3.1.[3456] when using RS. 2018-03-08 10:12:42 +01:00
Luis Peñaranda ec8ddadac8 Check that MPFR/MPFI versions match.
MPFI >=1.5.2 only works with MPFR >=4.0.0.
MPFI < 1.5.2 only works with MPFR < 4.0.0.
This check is performed at CMake level, when configuring MPFI.
2018-03-08 10:12:42 +01:00
Maxime Gimeno 2ec9b106aa Back port the modifications of header. 2018-03-07 08:36:12 +01:00
Laurent Rineau 1b88e8154a Merge pull request #2873 from sgiraudot/Kernel-Fix_pair_bug_in_circle_3-GF
Bugfix: pair not compatible with Circle_3 (clang)
2018-03-02 16:29:54 +01:00
Laurent Rineau 8fced384cc This branch now targets CGAL-4.11.2 2018-02-27 18:35:14 +01:00
Laurent Rineau 27859944b4 Announcement for CGAL-4.11.1 2018-02-27 11:03:14 +01:00
Simon Giraudot e9505dc840 Bugfix: pair not compatible with Circle_3 (clang) 2018-02-26 15:12:53 +01:00
Laurent Rineau 74a8eb1b6f Merge pull request #2853 from MaelRL/Generator-Fix_missing_domain_check-GF
Generator: Fix `random_points_in_triangle_mesh_2`
2018-02-23 17:24:52 +01:00
Laurent Rineau 705056526c Merge pull request #2828 from lrineau/CGAL-fix_various_issues-GF
fix various minor issues
2018-02-19 14:24:32 +01:00
Laurent Rineau 2afbcc7fa5 Merge pull request #2772 from MaelRL/SMP-Clean_internal_from_example-GF
SMP: Documented some functions used in the Orbifold Tutte parameterizer
2018-02-19 14:24:23 +01:00
Laurent Rineau cc700d1268 Merge pull request #2808 from kkatrio/issue2790-mprf4
Issue2790 mprf4 - deprecated functions
2018-02-19 14:24:15 +01:00
Mael Rouxel-Labbé 6b77d5149b
Fixed typo 2018-02-19 12:07:14 +01:00
Mael Rouxel-Labbé 5dfd491622 Added a precondition
An empty range will mean a segfault when calling weights.back(), with the
precondition, it will be more obvious.
2018-02-16 16:41:04 +01:00
Mael Rouxel-Labbé 58a8eb0504 Fixed random points on triangle mesh example
No mesh means no inside/outside...
2018-02-16 16:37:51 +01:00
Mael Rouxel-Labbé a125f08e8f Improved point generators tests 2018-02-16 16:10:21 +01:00
Mael Rouxel-Labbé 55b928b08c Fixed random_points_in_triangle_mesh_2 to actually filter out-of-domain faces 2018-02-16 16:10:09 +01:00
Laurent Rineau 861838bf2e Merge pull request #2798 from sgiraudot/Polyhedron_demo-Fix_reconstruction_angle_parameter-GF
Polyhedron Demo Surface Reco. Plugin: Fix missing conversion from degrees to radiants
2018-02-14 15:19:11 +01:00
Laurent Rineau 15069c1a4e Merge pull request #2774 from MaelRL/T3-Fix_is_Gabriel-GF
T3/P3T3: Fix Is_Gabriel(Vertex_handle) for regular triangulations
2018-02-14 15:19:04 +01:00
Laurent Rineau 7ed0615387 Merge pull request #2786 from MaelRL/T2-Fix_graph_traits-GF
Triangulation_2: Fix template parameter in RT_2's graph traits
2018-02-14 15:18:54 +01:00
Laurent Rineau f520bc7c64 Merge pull request #2817 from lrineau/STL_Extensions-cpp17_uncaught_exceptions-GF
Use std::uncaught_exceptions() when available
2018-02-14 15:18:47 +01:00
Laurent Rineau 02540257cf fixup! Remove CMake Warning about /usr/share/cmake/Modules/FindBoost
My previous commit was... well... stupid!
2018-02-14 10:14:48 +01:00
Laurent Rineau 7ee11b7afc Remove CMake Warning about /usr/share/cmake/Modules/FindBoost
Those warnings are annoying because:
  - they happen on Linux rolling releases as soon as Boost version is more
    recent than CMake version,
  - we cannot do anything about them.

Example:
```
CMake Warning at /usr/share/cmake/Modules/FindBoost.cmake:801 (message):
  New Boost version may have incorrect or missing dependencies and imported
  targets
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)
  /usr/share/cmake/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)
  /mnt/testsuite/cmake/modules/CGAL_Macros.cmake:293 (find_package)
  /mnt/testsuite/cmake/modules/UseCGAL.cmake:46 (use_component)
  CMakeLists.txt:13 (include)
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-4.12-Ic-173/Algebraic_foundations/TestReport_gimeno_Fedora-rawhide-Release.gz
2018-02-13 16:02:09 +01:00
Laurent Rineau 741dbaf9f3 Fix a bug in demo/Polyhedron/Plugins/Mesh_3/CMakeLists.txt
The file "Polyhedron_demo_mesh_3_plugin_cgal_code.cpp" was renamed *long*
ago. I do not know why I got that CMake error only recently.
2018-02-13 16:00:29 +01:00
Laurent Rineau 47307b4bfb
Add the missing semi-colon 2018-02-13 11:51:39 +00:00
Laurent Rineau ce09744a4a Use std::uncaught_exceptions() when available
That should fix the following warning.
```
[ 50%] Building CXX object CMakeFiles/dynamic_properties_test.dir/dynamic_properties_test.cpp.o
/usr/local/bin/c++   -DCGAL_TEST_SUITE=1 -DCGAL_USE_GMP -DCGAL_USE_MPFR -I/home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-CXX1z/test/Property_map/../../include -isystem /usr/include/x86_64-linux-gnu -I/home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-CXX1z/test/Property_map -I/home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-CXX1z/include -I/mnt/testsuite/include  -DDONT_USE_BOOST_PROGRAM_OPTIONS -Wall -Wextra -std=c++1z -frounding-math   -Wall -frounding-math -o CMakeFiles/dynamic_properties_test.dir/dynamic_properties_test.cpp.o -c /home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-CXX1z/test/Property_map/dynamic_properties_test.cpp
In file included from /mnt/testsuite/include/CGAL/basic.h:43,
                 from /mnt/testsuite/include/CGAL/Cartesian/Cartesian_base.h:29,
                 from /mnt/testsuite/include/CGAL/Simple_cartesian.h:29,
                 from /mnt/testsuite/include/CGAL/Exact_predicates_inexact_constructions_kernel.h:29,
                 from /home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-CXX1z/test/Property_map/dynamic_properties_test.cpp:2:
/mnt/testsuite/include/CGAL/Polyhedron_incremental_builder_3.h: In destructor 'CGAL::Polyhedron_incremental_builder_3<HalfedgeDS_>::~Polyhedron_incremental_builder_3()':
/mnt/testsuite/include/CGAL/assertions.h:104:30: warning: 'bool std::uncaught_exception()' is deprecated [-Wdeprecated-declarations]
    (CGAL::possibly(EX)||std::uncaught_exception()?(static_cast<void>(0)): ::CGAL::assertion_fail( # EX , __FILE__, __LINE__))
                              ^~~~~~~~~~~~~~~~~~
/mnt/testsuite/include/CGAL/Polyhedron_incremental_builder_3.h:204:9: note: in expansion of macro 'CGAL_destructor_assertion'
         CGAL_destructor_assertion( check_protocoll == 0);
         ^~~~~~~~~~~~~~~~~~~~~~~~~
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-4.12-Ic-168/Property_map/TestReport_lrineau_Ubuntu-latest-GCC6-CXX1z.gz

Fix #2806.
2018-02-09 18:46:16 +01:00
Konstantinos Katrioplas 330550627b conditional macros 2018-02-08 10:47:33 +01:00
Konstantinos Katrioplas 7aae8eae38 replace deprecated function 2018-02-08 10:47:33 +01:00
Simon Giraudot d84119056b Fix missing conversion from degrees to radiants 2018-02-06 14:10:41 +01:00
Mael Rouxel-Labbé f23547ef8e
Reworded sentence 2018-02-05 20:28:20 +01:00
Mael Rouxel-Labbé b5b3782aaa
Fixed typo... 2018-02-05 20:24:04 +01:00
Mael Rouxel-Labbé 17594d2795 Reduced the amount of \sa in SMP's doc
(no need to \sa every other parameterizer)
2018-02-05 12:31:40 +01:00
Mael Rouxel-Labbé 123dafc5cf Doc fixes 2018-02-05 10:30:45 +01:00
Mael Rouxel-Labbé f32e265648 Tr_Base > Triangulation_base to avoid a conflict with a typedef in the T2 hierarchy 2018-02-05 10:20:04 +01:00
Laurent Rineau 24b50f5c5c Merge pull request #2777 from MaelRL/IO-Fix_dxf_reader-GF
Circular_kernel_2: Fix the circle reading in the `.dxf ` file reader
2018-02-02 16:06:09 +01:00
Laurent Rineau d2ac299266 Merge pull request #2776 from sgiraudot/Shape_detection-Fix_infinite_loop-GF
Shape Detection: Fix Infinite Loop
2018-02-02 16:06:01 +01:00
Mael Rouxel-Labbé 2b82dc67d9 Fixed wrong template in regular_triangulation_2's graph traits 2018-02-02 14:25:47 +01:00
Mael Rouxel-Labbé 558465d2a6 Fixed dxf circle reader (in .dxf, the radius is not squared)
Removed dead link
2018-02-01 12:27:43 +01:00
Simon Giraudot 2b6e30f95d Fix infinite loop in RANSAC 2018-02-01 10:49:30 +01:00
Mael Rouxel-Labbé baa1915edf Changed variable name and initialization 2018-02-01 10:39:36 +01:00
Mael Rouxel-Labbé 92ac7b0eef
Fixed some variable name inconsistencies 2018-02-01 10:28:38 +01:00
Mael Rouxel-Labbé 62368d8b3f
Reverted useless line addition 2018-01-31 15:41:37 +01:00
Mael Rouxel-Labbé 05c31eac52 Fixed is_Gabriel(Vertex_handle) for RT3 2018-01-31 15:29:18 +01:00
Mael Rouxel-Labbé 95f36b1f12 Added a test P3RT3 is_Gabriel 2018-01-31 15:29:18 +01:00
Mael Rouxel-Labbé 6331d0f238 Fixed is_Gabriel(Vertex_handle) for P3RT3 2018-01-31 15:29:11 +01:00
Mael Rouxel-Labbé c88044d40a Fixed nearest_power_vertex for P3RT3 2018-01-31 15:27:39 +01:00
Mael Rouxel-Labbé bd4c643868 Fixed T3/P3T3 concepts
- Fixed RT/DT/P3RT3/P3DT3 not requiring (power)side_of_bounded_(power)_sphere
- No need to specify offset-less predicates in Periodic concepts
2018-01-31 15:27:15 +01:00