Commit Graph

101011 Commits

Author SHA1 Message Date
Laurent Rineau b363b7e4af Merge pull request #6935 from lrineau/CGAL-fix_autotest_with_ctest-GF
Fix autotest_cgal_with_ctest
2022-11-25 10:14:18 +01:00
Laurent Rineau 4ef4f036af Merge pull request #7056 from MaelRL/BGL-Clarify_pmap_value_type-GF
Fix implicit conversion from `std::size_t` to `bool` creating ambiguous calls
2022-11-25 10:14:16 +01:00
Laurent Rineau 1c00367691 Merge pull request #7068 from sloriot/PMP-repair_si_fix_include
Fix include
2022-11-25 10:14:13 +01:00
Sébastien Loriot 6fd4c16942 TWS 2022-11-22 17:47:19 +01:00
Sébastien Loriot c0ba9b479e fix compilation issues 2022-11-22 17:42:02 +01:00
Sébastien Loriot 718214bf4f fix include 2022-11-21 19:26:35 +01:00
Sébastien Loriot 7322c7908d try to workaround warnings 2022-11-21 14:09:08 +01:00
Sébastien Loriot b8aa2558fd add missing using 2022-11-17 19:40:38 +01:00
Sébastien Loriot 285dbb96bf value must be removed
Was reported as a warning by MSVC 2022
2022-11-17 19:17:32 +01:00
Sébastien Loriot 8bbbf8d494 try workaround warnings 2022-11-17 19:11:00 +01:00
Sébastien Loriot 4d797b55c4 try working around a warning 2022-11-17 19:03:30 +01:00
Sébastien Loriot 33cfc700b2 fix unused warning 2022-11-17 12:12:01 +01:00
Mael Rouxel-Labbé 8437eec29d Fix implicit conversion from std::size_t to bool creating ambiguous calls 2022-11-17 11:17:54 +01:00
Laurent Rineau 4c99cfb170 Merge branch '5.4.x-branch' into 5.5.x-branch 2022-11-15 17:01:01 +01:00
Laurent Rineau 52dd99bb4b Merge pull request #7020 from janetournois/Polyhedron_demo-mesh_3_plugin_cleaning-jtournois
Polyhedron demo - meshing from images of any word type
2022-11-15 17:00:50 +01:00
Laurent Rineau e3b3774ddb Merge pull request #7028 from afabri/Orthtree-CC-GF
Orthtree:  Fix memory leak
2022-11-15 17:00:48 +01:00
Laurent Rineau 868793754b Merge pull request #7034 from sloriot/PMP-coref_open_mesh_case_fix
Fix inconsistency check
2022-11-15 17:00:45 +01:00
Laurent Rineau ba40f768b5 Merge pull request #7028 from afabri/Orthtree-CC-GF
Orthtree:  Fix memory leak
2022-11-15 16:59:29 +01:00
Laurent Rineau 48811a4622 Merge pull request #7034 from sloriot/PMP-coref_open_mesh_case_fix
Fix inconsistency check
2022-11-15 16:59:27 +01:00
Sébastien Loriot cd4de51a40 fix inconsistency check 2022-11-09 18:17:31 +01:00
Andreas Fabri 331ea2898a Orthtree: Fix memory leak 2022-11-09 08:47:54 +00:00
Andreas Fabri d1eca8310f typo 2022-11-09 08:47:37 +00:00
Jane Tournois 26472284e4 the demo can now mesh images with any word type
thanks to the new domain constructors that do not
need to be defined explicitly a priori
2022-11-07 12:01:23 +00:00
Laurent Rineau db9c75a390 Merge branch '5.4.x-branch' into 5.5.x-branch 2022-11-07 10:07:34 +01:00
Laurent Rineau 714e4445a2 Merge pull request #6978 from janetournois/Mesh_3-detect_cc_in_labeled_images-GF
Mesh 3 for labeled images - avoid vertex clusters on surfaces
2022-11-07 10:06:42 +01:00
Laurent Rineau 53c63973ba Merge pull request #7003 from sloriot/BGL-OpenMesh_const_point_operator
Add a const version of the operator
2022-11-07 10:06:37 +01:00
Laurent Rineau 8d3b7c72a0 Merge pull request #6978 from janetournois/Mesh_3-detect_cc_in_labeled_images-GF
Mesh 3 for labeled images - avoid vertex clusters on surfaces
2022-11-07 10:06:17 +01:00
Laurent Rineau 0b26507579 Merge pull request #7003 from sloriot/BGL-OpenMesh_const_point_operator
Add a const version of the operator
2022-11-07 10:06:13 +01:00
Sébastien Loriot 54629efea2 make the operator const 2022-11-03 15:51:11 +01:00
Jane Tournois 3816d8c2af boost::optional has_value() is available only since boost 1.68
and CGAL supports boost >= 1.66
2022-11-03 14:27:54 +01:00
Jane Tournois 7f70d48ab9 seed_cell cannot be infinite 2022-11-03 14:27:53 +01:00
Sebastien Loriot 168825a7f1 fix warning 2022-11-03 14:27:53 +01:00
Jane Tournois a8877c5a44 add struct Seed for better readability
and avoid using boost::none to be ready for std::optional (C++17)
2022-11-03 14:27:53 +01:00
Jane Tournois 7faa73bb27 locate of seed that is outside affine hull returns Cell_handle()
accessing the circumcenter was then failing
2022-11-03 14:27:52 +01:00
Jane Tournois 8b76b55b82 remove useless include 2022-11-03 14:27:52 +01:00
Jane Tournois 28a6946070 do not run random shooting in connected components that already are represented
during feature protection, most of the connected components, in particular on
the bbox boundary, are already represented and ready to start/hint Delaunay
refinement

if the chosen seed lies in a cell that already belongs (wrt Is_in_domain(cc))
to the right connected component, random shooting is canceled and
the loop continues to next seed
2022-11-03 14:27:52 +01:00
Jane Tournois db6b051973 on image boundaries, construct point away from the surface
this avoids creating point clusters on surfaces
2022-11-03 14:27:51 +01:00
Laurent Rineau d65e53fda9 Merge branch '5.4.x-branch' into 5.5.x-branch 2022-11-02 16:19:20 +01:00
Laurent Rineau a61693582d Merge pull request #6970 from MaelRL/SMP-Fix_ARAP_post_process-GF
Fix weights in ARAP parameterization's post processing
2022-11-02 16:19:15 +01:00
Laurent Rineau 27cece3914 Merge pull request #6970 from MaelRL/SMP-Fix_ARAP_post_process-GF
Fix weights in ARAP parameterization's post processing
2022-11-02 16:18:58 +01:00
Laurent Rineau 1501d9943a Fix the bug!
See the empty columns in https://cgal.geometryfactory.com/CGAL/testsuite/results-5.6-Ic-100.shtml
and the CMake output at
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.6-Ic-100/Installation/TestReport_Christo_MSVC-2022-Community-Release.gz

With `Scripts/developer_scripts/run_testsuite_with_ctest`, CMake is
called with `-DWITH_tests=ON -DCGAL_TEST_SUITE=ON`.

We do not want to disable that option `-DWITH_tests=ON` because it
is crucial for the correct behavior of `run_testsuite_with_ctest`.
2022-10-28 15:19:09 +02:00
Mael Rouxel-Labbé 2a679483b2 Fix ARAP post processing
The formula of weights is "- tan(theta / 2) / length", with:
 tan ( theta / 2 ) = sin ( theta ) / ( 1 + cos ( theta ) )
                   = ( 2 * A / |v1| * |v2| ) / ( 1 + v1 . v2 / |v1| * |v2| )
		   = 2 * A / ( |v1| * |v2| + v1 . v2 )

with A the _unsigned_ area.
2022-10-16 16:22:29 +02:00
Mael Rouxel-Labbé 2fe82ec9d9 Add an example for ARAP parameterization 2022-10-16 16:22:15 +02:00
Laurent Rineau 50d81e5c4c Merge branch '5.4.x-branch' into 5.5.x-branch 2022-10-13 15:16:34 +02:00
Laurent Rineau 1a8e03cc85 Merge pull request #6864 from janetournois/Mesh_3-fix_weighted_images-GF
Mesh 3 - fix construction of weights image for labeled image input
2022-10-13 15:15:22 +02:00
Laurent Rineau 2b5b4be5d4 Merge pull request #6931 from MaelRL/PMP-remove_degen_fix_bad_removal-GF
Purge to-be-border halfedges from edges-to-collapse sets
2022-10-13 15:15:19 +02:00
Laurent Rineau 49635d2482 Merge pull request #6959 from lrineau/Number_types-fix_testsuite_with_min_max-GF
test/Number_types/to_interval_test_boost.cpp: parenthesis to fix testsuite on Window (min/max)
2022-10-13 15:15:17 +02:00
Laurent Rineau adc5bd4677 Merge pull request #6864 from janetournois/Mesh_3-fix_weighted_images-GF
Mesh 3 - fix construction of weights image for labeled image input
2022-10-13 15:14:11 +02:00
Laurent Rineau ae8101d615 Merge pull request #6931 from MaelRL/PMP-remove_degen_fix_bad_removal-GF
Purge to-be-border halfedges from edges-to-collapse sets
2022-10-13 15:14:09 +02:00
Laurent Rineau 087cc812cb Merge branch '5.4.x-branch' into 5.5.x-branch 2022-10-12 15:30:52 +02:00