Commit Graph

4460 Commits

Author SHA1 Message Date
hoskillua 4e669b79a7 conversion warnings 2023-01-29 06:26:16 +02:00
hoskillua 8d2043d0aa renaming
mostly to pass the max path error
2023-01-28 15:54:35 +02:00
Laurent Rineau 5f8930db8c Merge branch '5.5.x-branch'
# Conflicts:
#	Convex_hull_2/test/Convex_hull_2/ch_test_CH.cpp
#	Convex_hull_2/test/Convex_hull_2/ch_test_SC.cpp
#	Convex_hull_2/test/Convex_hull_2/ch_test_SH.cpp
#	Convex_hull_2/test/Convex_hull_2/ch_test_SS.cpp
#	Straight_skeleton_2/include/CGAL/constructions/Straight_skeleton_cons_ftC2.h
#	Straight_skeleton_2/include/CGAL/predicates/Straight_skeleton_pred_ftC2.h
2023-01-27 21:16:14 +01:00
Laurent Rineau 122141dda6 Merge pull request #7076 from MaelRL/PMP-Improve_normal_doc-GF
Improve documentation of PMP::compute_vertex_normal()
2023-01-27 21:02:24 +01:00
Laurent Rineau 36bc3d1154 Merge pull request #7126 from sloriot/PMP-repair_si_no_smooth_by_default
Make smooth an option that is OFF by default
2023-01-27 20:52:29 +01:00
Laurent Rineau 119cea4add Merge pull request #7127 from sloriot/PMP-cond_assert
Conditional assertions
2023-01-27 20:52:27 +01:00
Sébastien Loriot ee246c87c5 fix function name and add missing constructor 2023-01-25 17:08:27 +01:00
hoskillua 6f2f912c4d minor fix 2023-01-24 18:41:25 +02:00
hoskillua 7303c7401e move function + minor func doc fix 2023-01-24 14:42:39 +02:00
hoskillua 864eb9be4e Merge remote-tracking branch 'cgal-fork/gsoc2022' into gsoc2022-ICC-hoskillua 2023-01-24 14:38:02 +02:00
hoskillua 999b475e4c tests (incomplete) + minor typename fix
still not passing single vertex on polyhedron due to a problem with vertex normal map
2023-01-24 14:08:02 +02:00
Andreas Fabri 35ffe120e1 fix merge conflict 2023-01-24 10:41:22 +00:00
Sébastien Loriot 69c21bccc3 Merge 'master' 2023-01-24 11:29:48 +01:00
Sébastien Loriot 69610f6958 move function 2023-01-24 11:15:04 +01:00
Sébastien Loriot 50ba18725c fix typename usage 2023-01-24 11:10:29 +01:00
hoskillua 483e8b8e50 User manual + add example file for 1 vertex curvature 2023-01-24 08:44:09 +02:00
hoskillua 8af5c620fa reference documentation + minor fix
+ added documentation for the at_vertext curvature functions
- removed dynamically allocated pointers for storing the curvature on vertex
2023-01-23 13:49:34 +02:00
Mael 86ec9ce186
Fix indentation 2023-01-20 22:28:05 +01:00
Sébastien Loriot cd76994056 rename property map and deprecated old name 2023-01-18 13:45:37 +01:00
Mael d67d7cd4b6
Remove extra `to_double` 2023-01-18 11:15:17 +01:00
Sebastien Loriot 343735b9d7
missing return 2023-01-17 09:58:38 +01:00
Sébastien Loriot 6a7bd8b0e3 fix angle return type 2023-01-16 19:47:25 +01:00
albert-github 9c2f8ff60e Spelling correction in respect to function / variable names
As indicated in #7041 (Spelling corrections) theer were still some open corrections in respect to variables / functions, these have been addressed heer.
2023-01-13 18:51:28 +01:00
Andreas Fabri 7305e1bb38 Fix typo (thank you Albert) 2023-01-12 17:29:30 +00:00
Andreas Fabri c8b8792275 PMP: Guarantee that the longest_border() halfedge is among extract_boundary_cycles() 2023-01-12 17:01:19 +00:00
Mael 4d22c90474
Merge branch 'master' into feature/bug_documentation_spell_20221113 2023-01-04 10:06:45 +01:00
hoskillua f6855fef22 single vertex computation
implemented single vertex curvature computation
compared against the whole mesh computation on both cases of no radius and with radius on some vertices
still need to add tests, documentation and an example file
2023-01-03 12:13:26 +02:00
Mael Rouxel-Labbé 5e101566fb Remove obsolete typedefs 2023-01-02 10:34:27 +01:00
Sébastien Loriot 6e7eda918c remove PCA version 2022-12-23 16:12:33 +01:00
Sébastien Loriot 898142d739 wrong type 2022-12-22 09:49:35 +01:00
Sébastien Loriot f993ad50c9 conditions of inconsistenit_classification() also apply to assertions 2022-12-19 17:43:12 +01:00
Sébastien Loriot f372bbe7c2 make smooth an option that is OFF by default 2022-12-19 14:35:16 +01:00
Mael Rouxel-Labbé 70efea3bcb Tiny code modernization 2022-12-16 16:28:53 +01:00
Mael Rouxel-Labbé 92bd00f612 Change PMP::refine() is_flippable criterion
The current criterion is some kind of Delaunay ball, which might work OK
for flat regions, but can produce super thin wedges (see issue:
https://github.com/CGAL/cgal/issues/6982) when the mesh is not flat.

The criterion used instead is the one used in PMP::isotropic_remeshing
and PMP::remove_almost_degenerate_faces(), which is the typical angle-based
surface Delaunay criterion.
2022-12-16 16:26:43 +01:00
Mael Rouxel-Labbé 52fc2ffdd4 Change criterion used in "should_flip"
The criterion that takes the scalar_product of the cross products
is maybe adapted to minimize the curvature when triangulating faces,
but should_flip() is used in PMP::isotropic_remeshing, (soon) PMP::refine(),
and PMP::remove_almost_degenerate_faces(). These algorithms aim to
produce well-shaped elements. The criterion is not adapted to these
algorithms: for example, on a flat mesh the scalar product is meaningless
so it will pick the diagonal which maximizes the product of the lengths
and product of sines, but this might create very anisotropic elements
since the sine of obtuse angles is still positive.

The "new" criterion is simply the criterion used in mesh smoothing
and the typical Delaunay criterion for surfaces.
2022-12-16 16:21:46 +01:00
Laurent Rineau f1e1878b8d
Merge pull request #7094 from afabri/PMP_named_parameters-GF
PMP: Replace parameter with named parameter
2022-12-16 10:52:17 +01:00
Laurent Rineau c419f52799 Merge pull request #7103 from sloriot/PMP-repair_si_conditional_smoothing
Do not apply smoothing if the CC has some degenerate faces
2022-12-14 10:39:48 +01:00
Laurent Rineau f3e0f45054 Merge pull request #7108 from afabri/PMP-Envelope_warning-GF
PMP: Fix for a -Wmaybe-uninitialized
2022-12-14 10:39:45 +01:00
Laurent Rineau 46b1d230f5 Merge pull request #7103 from sloriot/PMP-repair_si_conditional_smoothing
Do not apply smoothing if the CC has some degenerate faces
2022-12-14 10:18:21 +01:00
Laurent Rineau 2b71438c04 Merge pull request #7108 from afabri/PMP-Envelope_warning-GF
PMP: Fix for a -Wmaybe-uninitialized
2022-12-14 10:18:19 +01:00
Andreas Fabri 39ebebdb5b merge master 2022-12-08 16:49:09 +00:00
Sebastien Loriot f5c41bd712
Merge pull request #7022 from MaelRL/Weights-v2.0-GF-master
Weights fixes (master)
2022-12-08 15:22:19 +01:00
Sebastien Loriot b9a87af07e
Merge pull request #7023 from MaelRL/Weights-v2.0-GF-5.5.x
Weights fixes (5.5.x)
2022-12-08 15:21:58 +01:00
Sebastien Loriot fa72ad2ad0
Merge pull request #6977 from MaelRL/Weights-v2.0-GF
Weights fixes (5.4.x)
2022-12-08 15:21:43 +01:00
Mael Rouxel-Labbé a2316e3f21 Minor improvements 2022-12-08 14:38:36 +01:00
Mael Rouxel-Labbé 28663265c6 Merge remote-tracking branch 'cgal/master' into PMP-snap_no_deg_faces_created 2022-12-08 14:35:48 +01:00
Andreas Fabri 9159816fb4 PMP: Fix for a -Wmaybe-uninitialized 2022-12-07 08:02:35 +00:00
Mael 0ff7882997
Merge branch 'master' into feature/bug_documentation_spell_20221113 2022-12-06 22:21:06 +01:00
Mael db81e4a3fb
Further clarify doc 2022-12-06 22:13:05 +01:00
Andreas Fabri 1adb13edc8 Do not use deprecated functions 2022-12-06 12:34:26 +00:00
Laurent Rineau 90f6546d77 Merge pull request #7069 from sloriot/PMP-split_repair_5.5
Split repair
2022-12-05 13:50:25 +01:00
Laurent Rineau 42c8c4f9e1 Merge pull request #7070 from sloriot/PMP-split_repair
Split repair (master version)
2022-12-05 12:23:19 +01:00
Laurent Rineau 041df61a70 Merge pull request #7074 from sloriot/PMP-compatible_orientation_missing_option
CGAL::PMP::compatible_orientations: add missing option
2022-12-05 12:22:09 +01:00
Laurent Rineau 17fd74e432 Merge pull request #7090 from afabri/PMP-assertion_bug-GF
Polygon Mesh Processing:  Fix CGAL_assertion_msg
2022-12-05 12:21:51 +01:00
Laurent Rineau 33cffd9c26 Merge pull request #7074 from sloriot/PMP-compatible_orientation_missing_option
CGAL::PMP::compatible_orientations: add missing option
2022-12-05 11:57:16 +01:00
Laurent Rineau ead1795d85 Merge pull request #7090 from afabri/PMP-assertion_bug-GF
Polygon Mesh Processing:  Fix CGAL_assertion_msg
2022-12-05 11:57:06 +01:00
Sébastien Loriot ffc20ffbd1 do not apply smoothing if the CC has some degenerate faces 2022-12-01 04:33:53 +01:00
albert-github f79d8bb542 Spelling corrections
After review
2022-11-30 10:31:13 +01:00
Andreas Fabri 2b26b8dd31 Don't use deprecated code in examples 2022-11-30 07:58:02 +00:00
Andreas Fabri a2e599b23d Fix typos 2022-11-29 16:55:43 +00:00
Andreas Fabri 63ffb5e82f Do the same for the other hole filling functions 2022-11-29 14:49:59 +00:00
Sébastien Loriot 352860ffa4 one solution for the return type 2022-11-29 14:24:11 +01:00
Sébastien Loriot 8708d348dd remove extra _t 2022-11-29 13:58:40 +01:00
Andreas Fabri 7babddf443 PMP: Replace parameter with named parameter 2022-11-29 12:45:47 +00:00
Sébastien Loriot 128cc719fe missing } 2022-11-29 11:14:22 +01:00
Andreas Fabri 6572a8fb58 It's a warning not an assertion 2022-11-28 14:39:20 +00:00
Andreas Fabri 0b56297ea2 Polygon Mesh Processing: Fix CGAL_assertion_msg 2022-11-28 14:05:59 +00:00
Laurent Rineau 33a7ae51d4 Merge pull request #7068 from sloriot/PMP-repair_si_fix_include
Fix include
2022-11-25 10:14:57 +01:00
Mael 208a4c24a5
Absolve doc 2022-11-24 13:15:12 +01:00
Mael Rouxel-Labbé deb1533957 Improve documentation of PMP::compute_vertex_normal() 2022-11-23 20:16:17 +01:00
Sébastien Loriot 75e08a9736 typo 2022-11-23 18:36:43 +01:00
Sébastien Loriot 876e69aeb4 add missing option that make the function almost useless if not present 2022-11-23 18:18:09 +01:00
Sébastien Loriot 550d86cc0d update doc 2022-11-22 10:48:27 +01:00
Sébastien Loriot 1520ac93e4 Merge branch 'sloriot/PMP-split_repair_5.5' into master 2022-11-22 10:38:00 +01:00
Sébastien Loriot 5a992f60a4 split repair 2022-11-22 10:31:34 +01:00
Sébastien Loriot 718214bf4f fix include 2022-11-21 19:26:35 +01:00
hoskillua d5a2cf1f05 fixed an expansion bug
when mesh has boundary and no input radius is specified
2022-11-19 19:27:33 +02:00
hoskillua 0ac812bd2f minor change, position shouldn't be optional
that is, in area and mean measures, in gaussian, it is not needed
2022-11-19 17:23:15 +02:00
hoskillua d96dca1264 Skipping concave n-gons case for now
remove face triangulation function draft
2022-11-19 17:16:28 +02:00
hoskillua f35faf60e1 minor doc fixes and renaming 2022-11-19 11:54:20 +02:00
hoskillua e302b02f76 Docs: adding bibtex, ack of DGtal, Authors + Renaming vars + minor fix
+ removing last commit's approach
2022-11-19 11:02:26 +02:00
hoskillua 716f081d27 Merge remote-tracking branch 'cgal-fork/gsoc2022' into gsoc2022-ICC-hoskillua 2022-11-18 12:56:41 +02:00
hoskillua 80e3522eaa incomplete (single vertex curvature) 2022-11-18 12:56:08 +02:00
Sébastien Loriot 400f9de47c first draft version for getting the triangulation of a face
WARNING: COMPILATION NOT TESTED!
2022-11-17 19:49:42 +01:00
albert-github 781f9a2943 spelling corrections
After review:
- outputhing -> outputting
- neighbour -> neighbor
2022-11-17 10:25:10 +01:00
albert-github 01a7852f70 Merge branch 'master' into feature/bug_documentation_spell_20221113
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.

Synchronize with master
2022-11-16 13:58:05 +01:00
hoskillua b56500d0fc 4-space -> 2-space indents 2022-11-16 12:51:14 +02:00
albert-github eed54a0ae5 spelling corrections
Some spelling corrections (Directories starting with `O`-`S` , first part),
some backward work
some forward work
2022-11-15 18:45:39 +01:00
Laurent Rineau 04c51a1034 Merge pull request #7034 from sloriot/PMP-coref_open_mesh_case_fix
Fix inconsistency check
2022-11-15 17:01:26 +01:00
Laurent Rineau 868793754b Merge pull request #7034 from sloriot/PMP-coref_open_mesh_case_fix
Fix inconsistency check
2022-11-15 17:00:45 +01:00
Laurent Rineau 48811a4622 Merge pull request #7034 from sloriot/PMP-coref_open_mesh_case_fix
Fix inconsistency check
2022-11-15 16:59:27 +01:00
albert-github 3674c937f7 spelling corrections
Some spelling corrections (Directories starting with `M`-` N`),
some backward work
some forward work
2022-11-15 15:21:01 +01:00
albert-github 45478184de spelling corrections
Some spelling corrections (Directories starting with `E`-` L`),
some backward work
some forward work
2022-11-15 13:39:40 +01:00
hoskillua b0a82c4569 typo fix 2022-11-14 11:37:14 +02:00
hoskillua 59c3605a06 trailing whitespace 2022-11-14 11:28:37 +02:00
hoskillua 6ca7331549 fixes, doc, examples, general cleanup 2022-11-14 11:26:13 +02:00
hoskillua 2ba6628624 minor fix 2022-11-13 17:59:01 +02:00
hoskillua dbd18ed101 trailing whitespaces 2022-11-13 13:34:18 +02:00
hoskillua 2dcb2939b9 compute multiple curvatures at same time + no radius handled 2022-11-13 13:32:38 +02:00
Sébastien Loriot cd4de51a40 fix inconsistency check 2022-11-09 18:17:31 +01:00
hoskillua aff46b6162 incomplete (integrating class for combined curvature computations) 2022-11-09 17:32:42 +02:00
hoskillua 866287a98e minor naming conventions fixes 2022-11-08 20:13:04 +02:00
hoskillua f3aee255b5 dynamic property maps 2022-11-08 19:19:40 +02:00
Jane Tournois 6b4bd0b653 make conversion explicit with CGAL::to_double 2022-11-08 17:43:41 +01:00
Laurent Rineau 92d8d1c805 Merge remote-tracking branch 'cgal/master' into CGAL-allow_Epick_with_float-GF
# Conflicts:
#	Mesh_3/test/Mesh_3/test_meshing_3D_image.cpp
2022-11-08 12:11:06 +01:00
Mael Rouxel-Labbé 83b0b0bdef Merge branch 'Weights-v2.0-GF-5.5.x' into Weights-v2.0-GF-master 2022-11-07 14:23:29 +01:00
Mael Rouxel-Labbé 7564b761ac Merge branch 'Weights-v2.0-GF' into Weights-v2.0-GF-5.5.x 2022-11-07 14:11:10 +01:00
Laurent Rineau 987391d8ee Merge pull request #6930 from MaelRL/BGL-Use_is_valid_descriptor-GF
BGL graph validity improvements
2022-11-07 10:08:34 +01:00
hoskillua af91351ba3 trailing white spaces 2022-11-07 11:00:29 +02:00
hoskillua 8efd947d53 doc fixes 2022-11-07 10:58:45 +02:00
hoskillua 38c66a61e3 typo fixes 2022-11-06 18:23:51 +02:00
hoskillua 48fc5aeebd dynamic property maps 2022-11-06 18:19:39 +02:00
Laurent Rineau 5239daab19
Merge pull request #7010 from afabri/PMP-BGL-shrunk-GF 2022-11-04 10:27:19 +01:00
Andreas Fabri f605c347ae Fixed typo: shrinked -> shrunk 2022-11-04 10:01:53 +01:00
Sébastien Loriot 2c66c24165 handle meshes with non-manifold vertices with shared interface 2022-11-03 15:33:21 +01:00
Laurent Rineau 8e8153c0ac Merge pull request #6871 from afabri/CGAL_assertions-GF
CGAL: No longer per package assertions
2022-11-03 09:44:48 +01:00
Laurent Rineau 56453b7e9f Merge pull request #6953 from afabri/CGAL-Wunused-but-set-variable-GF
Address -Wunused-but-set-variable
2022-11-03 09:44:45 +01:00
Laurent Rineau 2f9e031da7 Fix parts of PMP with Simple_precision_epick 2022-10-28 12:08:11 +02:00
Jane Tournois f5480e6006 fix more float/double conversions
code that uses eigen can use doubles when needed
2022-10-26 18:19:46 +02:00
Sébastien Loriot 0cac6a9da8 Merge remote-tracking branch 'sloriot/PMP-decimation' into PMP-decimation 2022-10-25 14:55:57 +02:00
Sébastien Loriot 890c6eed06 fix copy/paste error of indices + conditional update of corner list 2022-10-21 14:04:19 +02:00
Mael Rouxel-Labbé 91336eb213 Use modern C++ 2022-10-20 17:28:00 +02:00
Mael Rouxel-Labbé 19f847a74b Fix API of cotan functor in shape smoothing 2022-10-20 17:27:39 +02:00
Mael Rouxel-Labbé 6cd5c24f70 Pass traits to the secure Vor-weighted cotan functor 2022-10-20 17:27:26 +02:00
Mael Rouxel-Labbé 9ab7e1ed7f Misc minor code cleaning 2022-10-20 17:21:43 +02:00
Sébastien Loriot 11f6941e98 handle duplicated vertices in input meshes 2022-10-20 14:05:43 +02:00
Andreas Fabri c04dceb71d Merge master 2022-10-14 14:40:58 +01:00
Sébastien Loriot a4bd963c9b copy/paste error 2022-10-13 19:06:56 +02:00
Laurent Rineau 90e2a876e2 Merge pull request #6931 from MaelRL/PMP-remove_degen_fix_bad_removal-GF
Purge to-be-border halfedges from edges-to-collapse sets
2022-10-13 15:17:41 +02:00
Laurent Rineau b232f4bcfd Merge pull request #6942 from sloriot/CGAL-header_clean_up
Clean up in headers
2022-10-13 15:17:39 +02:00
Laurent Rineau 2b5b4be5d4 Merge pull request #6931 from MaelRL/PMP-remove_degen_fix_bad_removal-GF
Purge to-be-border halfedges from edges-to-collapse sets
2022-10-13 15:15:19 +02:00
Andreas Fabri 683805c34a Isotropic remeshing 2022-10-13 08:06:30 +01:00
Andreas Fabri 32efdd9110 isotropic remeshing 2022-10-13 07:34:43 +01:00
Sébastien Loriot e27a7f40c9 handle vertices with the same corner id while allowing non-manifold vertices within a patch 2022-10-12 12:55:47 +02:00
Andreas Fabri 341e1167a8 isotropic remeshing 2022-10-12 09:59:35 +01:00
Andreas Fabri 3e90f9ccf7 mesh_smoothing 2022-10-12 09:28:02 +01:00
Andreas Fabri 9bd49632cd repair_self_intersections 2022-10-12 08:54:56 +01:00
Andreas Fabri c8df65ebf9 repair_degeneracies 2022-10-12 08:11:12 +01:00
Sébastien Loriot 623a5e0814 we must invalidate face_boundaries to take corner changes into account 2022-10-10 16:44:46 +02:00
Sébastien Loriot 276ddda24c handle failure in remeshing of patches with multiple meshes 2022-10-07 18:28:58 +02:00
Sébastien Loriot 24aa3200c3 allow patch remeshing to fail
in such a case, neighbor patches with an interface that changed are
then marked to be processed again
2022-10-07 17:56:41 +02:00
Sébastien Loriot e8c5de51b7 remove useless header to directly include the right file 2022-10-06 15:40:05 +02:00
hoskillua 4f76f267d5 mostly docs and examples, moved utils to internal 2022-10-05 00:38:23 +02:00
Mael Rouxel-Labbé 60d50a8b57 Fix not purging to-be-border halfedges from edges-to-collapse sets 2022-10-04 22:57:37 +02:00
Mael Rouxel-Labbé 34ea88c73d Use is_valid_*_descriptor 2022-10-04 22:22:40 +02:00
Mael Rouxel-Labbé 60ecc51ba7 Code cleaning (no real changes) 2022-10-04 20:43:31 +02:00
Laurent Rineau 6538a18044 Merge pull request #6844 from MaelRL/PMP-Complete_array_based_repair_PS-GF
Complete array-based polygon soup repair
2022-10-04 13:53:24 +02:00
Laurent Rineau af3945337b Merge pull request #6845 from sloriot/PMP-coref_open_mesh_case
PMP corefinement: Handle inconsistency with open mesh as input
2022-10-04 13:53:21 +02:00
Laurent Rineau f0b4b38b9a Merge pull request #6867 from sloriot/PMP-collision_detection_copy
Add default copy constructor and operator=
2022-10-04 13:52:53 +02:00
Laurent Rineau 462eb5eaf3 Merge pull request #6872 from MaelRL/PMP-Fix_keep_LCC-GF
Fix dry-run of keep_largest_CCs dumping the wrong faces
2022-10-04 13:52:49 +02:00
Laurent Rineau a4f6f58e25 Merge pull request #6845 from sloriot/PMP-coref_open_mesh_case
PMP corefinement: Handle inconsistency with open mesh as input
2022-10-04 13:50:24 +02:00
Laurent Rineau 23678d0f7d Merge pull request #6867 from sloriot/PMP-collision_detection_copy
Add default copy constructor and operator=
2022-10-04 13:50:18 +02:00
Laurent Rineau 87f16af6e2 Merge pull request #6872 from MaelRL/PMP-Fix_keep_LCC-GF
Fix dry-run of keep_largest_CCs dumping the wrong faces
2022-10-04 13:50:15 +02:00
Laurent Rineau de80833223 Merge pull request #6845 from sloriot/PMP-coref_open_mesh_case
PMP corefinement: Handle inconsistency with open mesh as input
2022-10-04 13:48:16 +02:00
Laurent Rineau ff2bab36b0 Merge pull request #6867 from sloriot/PMP-collision_detection_copy
Add default copy constructor and operator=
2022-10-04 13:48:11 +02:00
Mael Rouxel-Labbé 9e0a71f7ad Actually cube the threshold value for the volume bound 2022-09-28 13:50:43 +02:00
hoskillua 4197450885 restored compute_normal.h 2022-09-26 02:33:04 +02:00
hoskillua e0c596d29e principal curvatures and directions visualization 2022-09-25 22:03:50 +02:00
albert-github 17a84db90e Some obvious missing quotes
Some obvious missing quotes  (last set)
2022-09-25 18:00:08 +02:00
Mael Rouxel-Labbé 363d1daaef Some more conversions to non-package specific assertions 2022-09-23 15:20:24 +02:00
Mael Rouxel-Labbé f27428c4d9 Improve tests for PMP::keep_large(st)_CC() 2022-09-23 14:54:15 +02:00
Mael Rouxel-Labbé e51bafbfbe Fix dry-run of keep_largest_CCs dumping the wrong faces 2022-09-23 14:53:36 +02:00
Sébastien Loriot 495f2e316a add default copy constructor and operator= 2022-09-21 18:59:18 +02:00
hoskillua 75c7f83c68 whitespaces 2022-09-20 17:21:19 +02:00
hoskillua 3d3b2c30fd testing init 2022-09-20 11:18:13 +02:00
hoskillua 13b056c9d4 minor fixes + handled zero expansion radius 2022-09-17 23:53:18 +02:00
Sébastien Loriot d084d9396f ignore new test for clipping 2022-09-14 10:35:23 +02:00
Sébastien Loriot 6f509a02ad handle inconsistency of classification due to non-closed meshes 2022-09-13 17:19:06 +02:00
Sébastien Loriot d7426630ea set stream precision to the max 2022-09-13 14:33:23 +02:00
Mael Rouxel-Labbé 008227757b Remove traits from polygon hasher's parameters 2022-09-13 13:24:54 +02:00
Mael Rouxel-Labbé e37487e6b2 Fix some internal function documentation 2022-09-13 13:24:28 +02:00
Laurent Rineau 8dd8e0dd11 Merge pull request #6812 from sloriot/PMP-split_visitor
add missing visitor calls in PMP::split()
2022-09-13 12:33:01 +02:00
Laurent Rineau 7d5e498538 Merge pull request #6812 from sloriot/PMP-split_visitor
add missing visitor calls in PMP::split()
2022-09-13 12:32:17 +02:00
Mael Rouxel-Labbé 6cdf3f256f Complete array-based polygon soup reparation: remove more invalid faces 2022-09-13 11:14:33 +02:00
Sébastien Loriot ce1bb34d65 add missing visitor calls in split 2022-08-28 22:08:45 +02:00
hoskillua 2ed69e935f fixing eigen vector definitions
so that it works with other compilers
2022-08-27 18:01:59 +02:00
Laurent Rineau d49ee20965
Merge pull request #6665 from sloriot/CGAL-std_type_traits 2022-08-17 13:56:54 +02:00
Sebastien Loriot d64d243bf5
Merge pull request #6772 from sloriot/PMP-remove_caps_needles_doc
Document remove_almost_degenerate_faces()
2022-08-10 18:31:52 +02:00
hoskillua 5840eaf955 Update interpolated_corrected_curvature_measures.h 2022-08-09 17:10:15 +02:00
hoskillua 5fdebfb28c Documenting new functions + minor doc fixes 2022-08-08 07:41:02 +02:00
hoskillua 4049979648 minor documentation fixes 2022-08-08 07:13:14 +02:00
hoskillua 86ac0fcb74 Documenting Expansion functions 2022-08-08 07:04:37 +02:00
hoskillua a74e05a389 documentation: fixes & improvements 2022-08-08 06:16:05 +02:00
hoskillua 7473a3e2dc Optimizing the expanding functions to compute intersections only once per curvature 2022-08-08 05:05:28 +02:00
hoskillua 85332fed6d according to some of the review comments on the pull 2022-08-05 13:58:52 +02:00
hoskillua c4db1600fd trim whitespaces 2022-08-04 11:01:09 +02:00
hoskillua 24551e2cbb principal curvatures completed (but not properly tested) 2022-08-04 10:51:45 +02:00
Sebastien Loriot beb57433c4
Apply suggestions from code review
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-08-04 10:30:02 +02:00
Sébastien Loriot 861588abe1 Merge 'sloriot/CGAL-std_type_traits' into master 2022-08-03 20:19:51 +02:00
hoskillua 24edaa24b5 principal curvatures (yet to decompose MuXY Matrix) 2022-08-03 18:59:08 +02:00
hoskillua 83093295f5 Principal Curvatures wip 2022-08-03 14:30:52 +02:00
hoskillua 09cb2b1e6d some refactoring + implemented the anisotropic formulas function 2022-08-02 23:12:23 +02:00
Sébastien Loriot d04f42c3b1 Merge remote-tracking branch 'cgal/5.5.x-branch' 2022-08-01 15:53:56 +02:00
Sébastien Loriot 3c24a79336 Merge pull request #6773 from janetournois/PMP-relaxation_avoid_global_function-jtournois
PMP::tangential_relaxation() - avoid using global function barycenter()
2022-08-01 15:52:31 +02:00
Sébastien Loriot 403c1ed975 Merge remote-tracking branch 'cgal/5.4.x-branch' into HEAD 2022-08-01 15:51:53 +02:00
hoskillua 870c27670b minor fixes (typename, doc) 2022-08-01 08:15:18 +02:00
hoskillua 765220a466 removing the switch from measures functions (for optimization) 2022-07-31 20:03:33 +02:00
hoskillua 9635ec1497 minor changes on demo (wip) 2022-07-31 18:55:51 +02:00
hoskillua db753ee6b5 Demo improvements + minor fixes
- Fixed some typos in example file and in comment in display prop plugin
- Added an option in random perturbation plugin to compute normals before hand
- added slider for expanding radius with an exponential range and with max val dependant on max edge length
2022-07-31 00:21:55 +02:00
Jane Tournois c6bc71b254 use construct_midpoint_3_object() instead of CGAL::midpoint() 2022-07-28 15:51:56 +02:00
Jane Tournois d7d439fc48 use construct_barycenter_3_object() instead of CGAL::barycenter() 2022-07-28 14:37:02 +01:00
Sébastien Loriot 184fa0c8a4 fix invalid functor name 2022-07-27 19:28:44 +02:00
Sébastien Loriot 4ffd2d2a09 add missing typename 2022-07-27 19:06:17 +02:00
Sébastien Loriot f075a3ee1e add missing Ref 2022-07-27 15:48:23 +02:00
hoskillua 1a1cfb409e Merge branch 'gsoc2022' of https://github.com/hoskillua/cgal into gsoc2022 2022-07-27 15:44:57 +02:00
hoskillua 1e49d54c24 Merge remote-tracking branch 'cgal-dev/gsoc2022-ICC-hoskillua' into gsoc2022 2022-07-27 15:43:20 +02:00
hoskillua 19076d38cc Merge remote-tracking branch 'upstream/master' into gsoc2022 2022-07-27 15:41:48 +02:00
hoskillua 12a627e23f expanding from and evaluating on vertices instead of faces 2022-07-27 15:40:06 +02:00
Sébastien Loriot 1c42a61fa1 use traits functor 2022-07-27 14:26:28 +02:00
Sébastien Loriot c99008dde1 trailing whitespaces 2022-07-27 13:42:39 +02:00
Sébastien Loriot 8d2a5bcf82 add license header 2022-07-27 13:40:25 +02:00
hoskillua 6b985bfeb8 for boundary faces 2022-07-27 13:25:35 +02:00
hoskillua 48ff36dcc9 fixed some missing typenames 2022-07-27 12:42:38 +02:00
hoskillua 41be3688ae Mean and Gaussian Curvatures + Visualizer (Still wip) 2022-07-26 19:32:17 +02:00
Sébastien Loriot 70b7c627db improve doc 2022-07-26 16:42:24 +02:00
Sébastien Loriot e660b2dd1d fix copy/paste error and use double for parameters to be compatible
with predicates
2022-07-26 15:55:52 +02:00
Sébastien Loriot 5f72bbd623 more doc fixes 2022-07-26 15:48:12 +02:00
Sébastien Loriot f7358a0a0d fix typos in doc 2022-07-26 15:34:21 +02:00
Sébastien Loriot b1ee7ba78e move outside experimental namespace with a better API and doc 2022-07-26 15:06:49 +02:00
hoskillua 66a2624641 minor doc fix
making GT::FT back ticked
2022-07-25 13:31:07 +02:00
hoskillua 063e058988 minor changes regarding the pull review
reordering includes, splitting too long lines, minor addition to doc
regarding review on the pull req
2022-07-22 15:29:19 +02:00
Simon Lopez 102f6fc0fb Improve PMP::split documentation 2022-07-19 16:52:42 +02:00
hoskillua 2778d878ce Merge remote-tracking branch 'upstream/master' into gsoc2022 2022-07-19 03:10:16 +02:00
hoskillua 5af4a28b16 updated doc for interpolated_corrected_measure_mesh() 2022-07-18 22:23:46 +02:00
hoskillua 5cc75c0bc4 Updated Demo Display property plugin, added to license list, 2022-07-18 21:57:42 +02:00
Sébastien Loriot a54033c0c9 add a couple of missing const and typename 2022-07-18 16:32:33 +02:00
hoskillua a5f99699e2 used a face property map for computing measures, added license
will update docs to match
void
    interpolated_corrected_measure_mesh(
        const PolygonMesh& pmesh,
        FaceMeasureMap fmm,
        const Measure_index mu_i,
        NamedParameters& np = parameters::default_values())
{
later if it works
2022-07-18 16:17:03 +02:00
hoskillua b1e191212c doc typos 2022-07-18 04:35:21 +02:00
hoskillua e1961c4340 minor doc fix 2022-07-18 02:48:52 +02:00
hoskillua c3d654b2c3 add documentation for enum 2022-07-18 02:44:14 +02:00
hoskillua 4b0577a2cf added doc (yet to build), used generic GT instead of Epic, made VNM a named parameter (WIP) 2022-07-17 18:46:04 +02:00
hoskillua e63de4f48a implemented computing mu_i over all faces
it works fine, still need to handle if vnm is not given
2022-07-13 07:59:21 +02:00
Sébastien Loriot 9c06085dd0 Merge remote-tracking branch 'cgal/5.5.x-branch' 2022-07-12 18:23:13 +02:00
Sébastien Loriot 1e857506c1 Merge remote-tracking branch 'cgal/5.5.x-branch' 2022-07-12 18:22:02 +02:00
Sébastien Loriot 12795ba29c Merge remote-tracking branch 'cgal/5.4.x-branch' into HEAD 2022-07-12 18:21:16 +02:00
Sébastien Loriot cc50e4464c update to new NP macro name 2022-07-11 13:24:20 +02:00
Sébastien Loriot 8f09664aeb Merge remote-tracking branch 'MaelRL/PMP-Fix_stitch_NP' into 5.5-x-branch 2022-07-11 13:21:54 +02:00
hoskillua 048d38d187 interpolated mu i measures (yet to check )
I will replace ExactPredInexactConstructs with a geometry traits template next ISA
2022-07-10 03:10:01 +02:00
Sébastien Loriot e18878f5a0 Merge remote-tracking branch 'cgal/5.5.x-branch' 2022-07-08 20:28:04 +02:00
Mael Rouxel-Labbé 70143a6304 Complete PMP::stitch_borders documentation (geom traits added to the NPs) 2022-07-07 16:51:19 +02:00
Mael Rouxel-Labbé 9c95b2ccb1 Add proper traits usage to PMP::stitch_borders 2022-07-07 16:51:04 +02:00
Sébastien Loriot b25217ed53 remove unused typedef 2022-07-07 13:42:37 +02:00
Sébastien Loriot ceb8ca70ef fix warning 2022-07-05 14:03:38 +02:00
Mael Rouxel-Labbé 3be8469277 Move build into 'internal' namespace 2022-07-04 11:41:44 +02:00
Mael Rouxel-Labbé 1d47a29224 Add an overload of repair_polygon_soup for array-based soups
which does not call functions that are meaningless for ranges
of fixed size faces
2022-07-04 11:41:44 +02:00
Mael Rouxel-Labbé a691eeff97 Rewrite merge_duplicate_points_in_polygon_soup() without container.insert(...) 2022-07-04 11:41:44 +02:00
Sébastien Loriot 49ca357d49 Merge remote-tracking branch 'cgal/5.5.x-branch' 2022-07-04 10:53:00 +02:00
Sébastien Loriot a4e53600c1 Merge remote-tracking branch 'cgal/5.4.x-branch' 2022-07-04 10:52:16 +02:00
Sebastien Loriot d218b32cf9
Merge pull request #6639 from sloriot/PMP-clip_deg_faces
Handle deg faces in clip with allow_self_intersections
2022-07-04 10:48:30 +02:00
Sebastien Loriot 6d6791456a
Merge pull request #6711 from sloriot/CGAL-constexpr
Add some constexpr for constant functions
2022-07-04 10:48:08 +02:00