Commit Graph

94 Commits

Author SHA1 Message Date
Simon Giraudot d005981b52 Bugfix: use find() to compare string to avoid carriage return problems 2017-05-29 11:08:32 +02:00
Simon Giraudot 800c16f2e1 Warning fix: explicit conversion to size_type 2017-04-07 11:49:59 +02:00
Simon Giraudot af78f66230 Use boost::uint32_t instead of std::size_t as size type 2017-04-05 15:29:53 +02:00
Simon Giraudot 4cfbe98564 Point_set_3: fix documentation bug (concept Index accepts constructor with std::size_t) 2017-04-05 15:18:28 +02:00
Laurent Rineau 7b2a150e84 Fix <CGAL/Surface_mesh/Properties.h> and its uses
The PR #1791 introduced `CGAL::Point_set_3`, and factorized the
`Property_map` implementation of `Surface_mesh` into a new class
template `CGAL::Properties::Property_map<Key, T>`.

The backward compatibility was supposed to be ensured by the fact that
`Surface_mesh<Point>::Property_map<Key,T>` had
`Properties::Property_map<Key, T>` as base class. But that compatibility
was only partial, and there could be ambiguities in the calls to `get`
and `put` with those property maps.

This commit/PR renamed `Properties::Property_map` to
`Properties::Property_map_base`, and added a third parameter, used as
the `Derived` class in the CRTP used by `boost::put_get_helper`. That
way, the `get` and `put` functions are defined directory on the real
class `Surface_mesh::Property_map<Key, T>` and not on its base class.

The same has been modified in `CGAL::Point_set_3`.

That makes the use of `Property_base_base` and `Property_container` a
little trickier, but that removes several ugly non-portable hacks, like
the `reinterpret_cast` that were used to convert a pointer to base class
of the pmap to the pointer the real pmap. Now that is a lot cleaner.

I have verified that the documentation is not modified. Actually, the
PR #1791 did modify the documentation of `Surface_mesh` (see the member
method `add_property_map` for example), and this PR fixes the situation:
the documentation of `Surface_mesh` is put back to the version in
CGAL-4.9.
2017-02-08 14:33:18 +01:00
Simon Giraudot d7eb45c37b Bugfix: point is marked as removed if iterator distance is lesser OR equal to 0 2017-01-30 08:45:22 +01:00
Sébastien Loriot 50510c05ea add include directive for license of all GPL header files
done using:
ack-grep "^GPL" */package_info/*/license.txt -l | awk -F "/" '{print $1}' > /tmp/gpl_packages
for i in `cat /tmp/gpl_packages | \
          grep -v Operations_on_polyhedra | \
          grep -v Algebraic_kernel_for_circles | \
          grep -v Algebraic_kernel_for_spheres | \
          grep -v Polyhedron_IO`;
do
  echo $i
  python Scripts/developer_scripts/add_license_in_pkg_header.py $i
done
python Scripts/developer_scripts/add_license_in_pkg_header.py Operations_on_polyhedra Polygon_mesh_processing
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_circles Circular_kernel_2
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_spheres Circular_kernel_3
python Scripts/developer_scripts/add_license_in_pkg_header.py Polyhedron_IO Polyhedron
2017-01-19 15:20:25 +01:00
Sébastien Loriot f214bc332b Update project names 2017-01-19 11:10:03 +01:00
Sébastien Loriot f3251a5575 fix project names 2017-01-19 11:07:39 +01:00
Maxime Gimeno a01593e0bb Unify the links to the Polyhedron demo in the package descriptions. 2017-01-10 14:56:52 +01:00
Simon Giraudot 1dcd37b7dc Warning fix: implicit conversion 2017-01-06 07:33:30 +01:00
Sébastien Loriot b8dcd5cdac propose user manual improvements 2017-01-05 11:52:19 +01:00
Simon Giraudot dbb58ac53d Display fix, remove linebreaks 2017-01-05 10:34:15 +01:00
Simon Giraudot 7bcb5b02eb Fix warnings 2017-01-05 07:57:05 +01:00
Simon Giraudot f9dcc4b721 Fix warnings 2017-01-04 10:40:24 +01:00
Simon Giraudot d08efe278c Use max precision for stringstream 2016-10-28 14:48:25 +02:00
Simon Giraudot 5b7dea069e Two bug fixes 2016-10-18 15:39:51 +02:00
Simon Giraudot bdbd31ee11 Bugfix: do not define the prototype of Push_property_map beforehand 2016-10-18 15:27:38 +02:00
Simon Giraudot 17b25a50ac Update with latest review 2016-10-14 14:31:06 +02:00
Simon Giraudot 69c6f96727 Fix properties() behavior 2016-10-12 12:16:03 +02:00
Simon Giraudot 8a18e754be Fix boost demangle 2016-10-12 11:33:10 +02:00
Simon Giraudot 3a24b788c4 Fix some warnings/errors from testsuite 2016-10-12 10:36:57 +02:00
Simon Giraudot 6b17b65705 Update manual with latest review 2016-10-12 09:18:45 +02:00
Simon Giraudot 784497ec5b Merge branch 'Point_set_3-GF' of github.com:CGAL/GeometryFactory into Point_set_3-GF 2016-10-11 15:02:45 +02:00
Sébastien Loriot d7773af9fc remove useless config flags 2016-10-11 14:58:42 +02:00
Simon Giraudot 60377f2f10 Bugfix: update outdated method name 2016-10-11 14:22:34 +02:00
Simon Giraudot 8fbacbcf11 Add clear_properties() method 2016-10-11 09:08:58 +02:00
Simon Giraudot 62578b554c Update doc with latest review 2016-10-11 08:54:27 +02:00
Simon Giraudot de818c427e Fixed operator<< 2016-09-30 10:02:40 +02:00
Simon Giraudot 6312281451 Typo correction 2016-09-28 15:31:45 +02:00
Simon Giraudot e877b0f688 Move stream operators to IO 2016-09-28 11:15:29 +02:00
Simon Giraudot bdcfea5d57 Update user manual 2016-09-28 10:50:34 +02:00
Simon Giraudot d097870ecd Update examples 2016-09-28 10:50:22 +02:00
Simon Giraudot d4ab17634e Update reference manual 2016-09-28 10:49:42 +02:00
Simon Giraudot a6b64c907b WIP: operator<< to recover all properties in PLY output 2016-09-27 15:38:30 +02:00
Simon Giraudot 17c3c777fe Example now writes PLY 2016-09-27 15:38:02 +02:00
Simon Giraudot f095e21e60 Bugfix: has_normal_map() instead of has_normals() 2016-09-27 14:37:08 +02:00
Simon Giraudot 0017a02317 Add missing const 2016-09-27 14:36:58 +02:00
Simon Giraudot 21c95b267c Explicit Point_set_3 parameter in PSP overloads 2016-09-27 11:39:17 +02:00
Simon Giraudot 2dc269bc05 Better encapsulation of Index generation 2016-09-27 11:01:18 +02:00
Simon Giraudot 7a870691d8 Update user man with additional review 2016-09-27 10:59:38 +02:00
Simon Giraudot cfbbbd5c4e Convenience PSP overloads 2016-09-26 15:36:16 +02:00
Simon Giraudot 1b9c30e5f1 Do not document ply interpreter 2016-09-26 15:35:46 +02:00
Simon Giraudot 5a0e3ef36e Update examples and tests 2016-09-26 15:35:24 +02:00
Simon Giraudot febe156cea Update user manual with reviews 2016-09-26 15:35:06 +02:00
Simon Giraudot a62ba4c627 Update user manual + features with reviews 2016-09-26 15:34:42 +02:00
Simon Giraudot f631b25cf5 Update other include files 2016-09-26 09:38:00 +02:00
Simon Giraudot 32c88d3c10 Update tests 2016-09-26 09:37:45 +02:00
Simon Giraudot 69da32f097 Update examples 2016-09-26 09:37:30 +02:00
Simon Giraudot 786b79f30f Safer index behavior 2016-09-26 09:37:06 +02:00