songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
35,531 Commits 3 Branches 156 Tags 970 MiB
Commit Graph

52 Commits

Author SHA1 Message Date
Monique Teillaud 25a4f6bce2 fix asked by Ron 2007-10-29 09:12:46 +00:00
Monique Teillaud 158446fe1e todo 2007-10-26 09:09:15 +00:00
Monique Teillaud 2ba48b8eff answer Ron's review and fix many additional minor problems 2007-10-26 08:55:31 +00:00
Monique Teillaud 0894345125 updates 2007-10-25 15:48:34 +00:00
Monique Teillaud 6e3039a475 answers some general comments by Ron, left by Eric as open: 
(+ a few fixes encountered while doing the corrections)

* Another change is realted to the functors XCtriticalPoints_2 and
YCtriticalPoints_2. The best solution in my opinion is to let these 
two functors be optional: any model of the AlgebraicKernel_d_2 concept 
must define a tag named Has_critial_points.

o I think that saying that, for example, Solve_1 is an "AdaptableFunction
  that computes the real roots of a univariate polynomial" is too long.
  Just say that it "Computes the real roots of a univariate polynomial",
  and under a "Refines" subsection states that it is a refinement of
  AdaptableFunction (this is already done for some functor concepts).
o It is fine to be meticulous and state what are the "result_type",
  "argument_type" etc. for the various functors. However, I think that
  stating (for Compare_1 in this case):
    result_type fo (first_argument_type x, second_argument_type y)
  is a bit confusing (the reader has to look back and forth to see what
  these types are). I?d prefer a more direct definition:
    Comparison_result fo (Algebraic_real_1 x, Algebraic_real_1 y)
o I do not like to have a functors that accept two output iterators.
  I think a better implementation is an output iterator whole value type
  is std::pair<A,B>. (See below)
 2007-10-25 15:07:44 +00:00
Eric Berberich e478f855e4 update 2007-10-24 08:33:06 +00:00
Eric Berberich 78f0a33847 applied Ron's suggestions, in particular 
VLine-> StatusLine
get_ -> ""
 2007-10-24 08:27:44 +00:00
Eric Berberich 870f584a7a AKwA_2 refines AK_2 now 2007-10-24 08:26:50 +00:00
Menelaos Karavelas 1e8e04947e stylistic changes 2007-09-09 18:35:48 +00:00
Monique Teillaud c80b9c1fc8 same kind as previous commit 2007-09-03 11:21:34 +00:00
Monique Teillaud 57958f4e66 questions and todo reformatted 2007-09-03 11:20:36 +00:00
Monique Teillaud 513bfe96d2 fix in Solve2 2007-08-16 11:02:06 +00:00
Monique Teillaud 23c4f1459b missing line added 2007-08-08 12:43:12 +00:00
Monique Teillaud aa1f0714e5 proposal for Solve_2 (with a question left in footnote) 2007-08-08 12:33:30 +00:00
Monique Teillaud df7c6842b3 bug fix again 2007-08-08 12:30:24 +00:00
Monique Teillaud 963c6b921f bug fix in make-coprime 1 and 2 
to be checked
 2007-08-08 12:13:05 +00:00
Monique Teillaud 0ba14c659a fixed underfull hbox 2007-08-08 08:04:52 +00:00
Monique Teillaud 0f6278d82d detaails 2007-08-08 08:04:09 +00:00
Monique Teillaud f3de92323b names in \ccCreationVariable{} made consistent 2007-08-07 14:33:57 +00:00
Monique Teillaud d23e3a626a remark 2007-08-07 14:08:45 +00:00
Monique Teillaud f7ff38245e bug fixes in names on functors 2007-08-06 11:46:57 +00:00
Menelaos Karavelas 4103cf4723 ccc -> \ccc 2007-04-25 08:38:40 +00:00
Michael Hemmer 4a7128599e update 2007-03-27 09:33:37 +00:00
Michael Hemmer 4bb7cbfa4b added concept Boundary to AlgebraicKernel_1 
Boundary is a public type in AlgebraicKernel_1
 2007-03-27 09:29:52 +00:00
Michael Hemmer 325e6924f0 wrong name .. sorry 2007-03-27 09:14:59 +00:00
Michael Hemmer e4a5981abd changed name for file AlgebraicReal.tex 2007-03-27 09:14:29 +00:00
Michael Hemmer ceb9db228f typo 2007-03-27 09:06:47 +00:00
Michael Hemmer 389d653575 rename file according to conventions 2007-03-27 09:03:35 +00:00
Michael Hemmer 120e177341 ispell american 2007-03-24 17:30:51 +00:00
Michael Hemmer 34ebee850c added AlgebraicKernel_d_1::AlgebraicRealTraits_1 2007-03-24 17:25:15 +00:00
Michael Hemmer 0025435f6c added lgebraicKernel_d_1::AlgebraicRealTraits_1 2007-03-24 17:23:52 +00:00
Menelaos Karavelas 5446f4643d various changes just after discussions in Graz 2007-03-21 18:59:12 +00:00
Michael Hemmer 748704a1ae added intro.tex 2007-03-15 14:44:24 +00:00
Michael Hemmer 9fe7142cae update 2007-03-14 16:30:11 +00:00
Michael Hemmer f2734620cc update 2007-03-14 16:24:04 +00:00
Michael Hemmer 3249caf48f update 2007-03-14 16:23:27 +00:00
Michael Hemmer 15d88da175 mv TODO to open.tex 2007-03-14 13:30:45 +00:00
Michael Hemmer c97f4b77ae added Compare_1 2007-03-08 14:17:29 +00:00
Eric Berberich 982df69354 update 2007-03-05 13:37:50 +00:00
Eric Berberich 0340f212eb fixed typo 2007-03-05 12:46:20 +00:00
Michael Hemmer 79552d278c keep IsCoprime_1 2007-02-20 15:44:07 +00:00
Michael Hemmer a3c6fc3c13 update AK_1 with respect to dicussions at INRIA 2007-02-20 15:41:31 +00:00
Eric Berberich cf7a9a3ced moved figures 2007-02-11 12:45:05 +00:00
Eric Berberich 6209f1e7f1 update 2007-02-11 12:40:25 +00:00
Eric Berberich ff2af3c58a merge after discussion during 26th CGAL Dev Meeting 2007-02-11 12:27:50 +00:00
Eric Berberich 90d5e739bc fix syntax bug 2007-02-09 10:41:40 +00:00
Eric Berberich d39f2993ec added footnote 2007-02-09 10:27:27 +00:00
Monique Teillaud d30a6892ce construction of sparse polynomials_1 
+ comment on solve_2
 2006-07-21 11:56:15 +00:00
Monique Teillaud 7e5d79edb5 question 2006-07-20 08:22:54 +00:00
Monique Teillaud 0e0b6594b3 fixes 2006-07-20 07:38:31 +00:00