Commit Graph

72671 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé bfdb4a52da Fixed using Weighted_point_creator to construct weighted point
This class is obsolete; kernel functors should be used.
2017-05-22 11:27:02 +02:00
Mael Rouxel-Labbé 6dd3287538 Fixed (almost all) default constructed traits in Mesh_3
Also fixed constructing points/weighted_points not through the traits and
uses of point().point()
2017-05-22 11:27:02 +02:00
Mael Rouxel-Labbé 1242ea4c00 Improved readiblity of Regular_triangulation_2.h (no real changes)
Only whitespace cleaning, indentation fixing, empty lines removal, etc.
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 0a556f9039 Improved readability of Triangulation_2.h (no real changes)
Only whitespace cleaning, indentation fixing, empty lines removal, etc.
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé d5d6383842 Improved readability of Delaunay_triangulation_2.h (no real changes)
Only whitespace cleaning, indentation fixing, empty lines removal, etc.
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 4fba43fa35 Do not provide Bare_point overloads in Regular_triangulation_2
Additional:
-- Simplify the hierarchy_2: there is no need to distinguish between
   Bare_point and Weighted_point, that is the point (!) of the type "Point"
   in Triangulation_2.
-- Use Weighted_point in tests
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé ef262c9d24 Fixed Bare_point / Weighted_point usage in Triangulation_2 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 729c054871 Do not provide Bare_point overloads in Regular_triangulation 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 5833272bd0 Fixed usage of Bare point and Weighted point across Triangulation_3 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 72be6f32d2 Trimmed Regular triangulation euclidean traits (doc version)
Now that the traits is exactly the kernel, there isn't a big need for a lot of
documentation.
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé e041870954 Trimmed Regular triangulation euclidean traits
-- Code added as consequence of disabling implicit conversion between points and
   weighted points implies that defining
     typedef weighted_point point;
   creates ambiguous functors.

   This typedef is nevertheless still used, in Weighted_point_mappers.

-- The traits are not supposed to define Bare_point
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé c597a79fe0 Fixed Triangulation_3's regular test
Constructing weighted points with (x,y,z,w) is ambiguous and that is why it was
disabled.
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 489cb54e3e Removed ambiguous weighted point constructor
This constructor was already cleaned in the branch that this branch
is based upon... I must have messed up a merge conflict...
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé fc62544731 Removed unused typedef 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 8f74332fbd Fixed missing typename 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé eb1a4fc18e Fixed (wrongly) assuming that traits define Bare_point / Weighted_point 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 36387f7c9f Use Skin_surface_3::Bare_point over Weighted_point::Point
Just in case they are different
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 9868b15b77 Fixed documentation of Bare_point and Weighted_point in concept SkinSurface3 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé ac1d7fb0a5 Fixed Triangulation_3's test using Traits::Bare_point/Weighted_point 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 4f81c8c794 Added CGAL_NO_DEPRECATED_CODE macros to Regular_triangulation_euclidean_traits 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 2b0ef47939 Fixed (remaining) Bare_point / Weighted_point wrong usages across Mesh_3 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 11a19f7ae3 Removed Bare_point definition from Mesh_3's Robust_weighted_...etc..._traits
It is not for the traits to define Bare_point. It is defined in the regular
triangulation.

This commit breaks stuff, but it'll be fixed in the following commits.
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 4f6796731b Improved readability of Skin_surface_3
Only indentation and whitespace is changed.

Almost like a skin (sur)facelift !
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé fa4e541637 Removed unused variable 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 3b21e988bb Removed any use of Regular_triangulation_euclidean_traits from Skin surface 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 818bd14790 Fixed Bare_point / Weighted_point across Skin_surface
This also removes the definition of Bare_point from the Skin surface
traits class (as it should be: Skin_surface defines Bare_point)
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé ea14f683d7 Cleaned #if 0 code 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 8d843e6bb8 Removed useless semicolon 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 94f79cf777 Minor doc improvement 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé f36194bcdc Renamed a variable for clarity 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 5de1cb214a Added a test to check Point / Weighted_point conversions
and fixed a previous test that used now-disabled implicit conversions
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 630d6e693a Removed unnecessary semicolons 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé e38b21cf9f Fixed compilation issues resulting from the removal of WP->P implicit conversion 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 62b90dd86b Fixed hide_point()
Hide weighted points since they can be re-inserted afterwards
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 83ab007236 Fixed initialization order warning 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 0efcca2ca8 Make all conversions between Point and Weighted_point explicit
Also doc changes
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 357ba7c04a Use traits rather than .point() to access the bare point of weighted point 2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé b1726903ee Consistently grab the Bare_point typedef from the triangulation
instead of the geometric traits
2017-05-22 11:20:45 +02:00
Mael Rouxel-Labbé 7872621742 Fixed missing typedef
and removed some warnings due to unused typedefs
2017-05-22 11:20:45 +02:00
Jane Tournois 79915ab6d7 remove useless variables 2017-05-22 11:20:45 +02:00
Jane Tournois 4555539a28 remove extra reference
this was leading to (fp == p), and no way to move back to the original
position of v0
2017-05-22 11:20:45 +02:00
Jane Tournois 4381947186 return type should be Bare_point 2017-05-22 11:20:45 +02:00
Jane Tournois f779f776e4 fix one more Bare_point 2017-05-22 11:20:45 +02:00
Jane Tournois ca25e3176c make constructors of Weighted_point explicit
and fix compilation errors
2017-05-22 11:20:45 +02:00
Sébastien Loriot 09f0be4418 using type from the base class 2017-05-22 11:20:45 +02:00
Sébastien Loriot 51bc69cca3 version without partial specialization
the norms says that partial specialization should be
done in a namespace (not inside a class)
2017-05-22 11:20:45 +02:00
Andreas Fabri 499b9fe8e7 make the Polyhedron demo mesh_3_plugin work 2017-05-22 11:20:45 +02:00
Andreas Fabri 556d73819d make it work for the triangulation hierarchy with regular 2017-05-22 11:20:45 +02:00
Andreas Fabri b621a425b5 Do in 2D what we did in 3D 2017-05-22 11:20:45 +02:00
Jane Tournois 26b5162c38 avoid using wp.point(), use Construct_point_3 instead 2017-05-22 11:20:45 +02:00