Commit Graph

50860 Commits

Author SHA1 Message Date
Laurent Rineau c0039287df Fix the detection of BLAS/LAPACK/TAUCS with MSVC
The CMake script was only testing if the sub-directory auxiliary/taucs/
existed. That directory exists in Git for a while, because we ship a README
file in it. Now the CMake script checks for auxiliary/taucs/include/. That
is as naive as before but at least it will work.
2013-03-05 13:54:51 +01:00
Andreas Fabri 91d1deae4d Add some CGAL_USE_TYPE 2013-03-05 12:50:43 +01:00
Andreas Fabri d3a21904d7 Merge branch 'CGAL-fix_warnings-GF' of ssh://scm.cgal.org/var/git/cgal into CGAL-fix_warnings-GF 2013-03-05 12:50:17 +01:00
Laurent Rineau 723b28d39f Fix warnings about incorrect type conversions 2013-03-05 12:44:11 +01:00
Andreas Fabri 70d95f5f1c remove unused typedefs 2013-03-05 11:53:43 +01:00
Andreas Fabri e6d101d9fb remove unused typedefs 2013-03-05 11:50:05 +01:00
Andreas Fabri 75beac0dca remove unused typedefs 2013-03-05 11:46:25 +01:00
Andreas Fabri f09633f71d size_t -> int 2013-03-05 11:35:29 +01:00
Andreas Fabri 570e74964e once -> disable for the 'name was truncated' warning 2013-03-05 11:08:43 +01:00
Andreas Fabri 0a42dc95ca turn a static function into an inlined one 2013-03-05 11:04:54 +01:00
Andreas Fabri b0cffa4c7f ExponentVector is no BackInsertionSequence 2013-03-04 16:38:30 +01:00
Andreas Fabri 3f7f9c432e remove unused typedefs 2013-03-04 16:11:35 +01:00
Andreas Fabri 3ffc10bc4a Merge branch 'CGAL-fix_warnings-GF' of ssh://scm.cgal.org/var/git/cgal into CGAL-fix_warnings-GF 2013-03-04 15:43:26 +01:00
Andreas Fabri 30a8385330 First change: SFace2bool_hash --> SFace2bool_hash&
Second change: Comment parameter 'Shell' as it is only used in a commented code section
2013-03-04 15:30:33 +01:00
Andreas Fabri 1952bf7382 remove unused variables 2013-03-04 14:49:30 +01:00
Andreas Fabri fde05660f2 put entire loop in an #ifndef CGAL_NO_ASSERTIONS 2013-03-04 14:35:02 +01:00
Andreas Fabri b3b1aee424 class -> struct 2013-03-04 14:28:29 +01:00
Andreas Fabri 6eded94b13 remove unused variables 2013-03-04 12:43:25 +01:00
Laurent Rineau 01e83dfb0a Follow-up to the following commit:
| commit f202656ca4
  | Author: Laurent Rineau <laurent.rineau@cgal.org>
  | Date:   Fri Mar 1 10:45:02 2013 +0100
  |
  |     Fix warnings in Aos_2
  |
  |     LLVM/clang can display warnings even for functions that are not used,
  |     during the parsing of the code, before the compilation, when it can.

Aos_2 has two constructors and I had modified the code in only one of them.
2013-03-04 12:09:22 +01:00
Andreas Fabri cd45bc8126 std::size_t -> int 2013-03-04 12:02:53 +01:00
Andreas Fabri 064825b39c remove insert operator 2013-03-01 17:05:44 +01:00
Andreas Fabri 3bcd94aa38 Supress warnings coming from inside Eigen3 2013-03-01 17:04:19 +01:00
Andreas Fabri 5ea77276c6 disable warning decorated name length exceeded, name was truncated 2013-03-01 16:50:53 +01:00
Andreas Fabri 6ac85b1b27 remove unused variable 2013-03-01 16:35:23 +01:00
Andreas Fabri 22e272627b remove unused variable 2013-03-01 16:24:47 +01:00
Andreas Fabri ae26141f46 remove unused variable 2013-03-01 16:22:34 +01:00
Andreas Fabri 34c15d8f70 remove unused private data members 2013-03-01 16:04:29 +01:00
Andreas Fabri feb7a73657 static_cast 2013-03-01 14:26:06 +01:00
Andreas Fabri ce77644138 change the error message as the mail adress of the author isno longer valid 2013-03-01 14:06:08 +01:00
Andreas Fabri a26c1b0e55 0.0 -> 0.0f 2013-03-01 13:45:13 +01:00
Andreas Fabri 8778c753f2 Merge branch 'CGAL-fix_warnings-GF' of ssh://scm.cgal.org/var/git/cgal into CGAL-fix_warnings-GF 2013-03-01 12:49:13 +01:00
Andreas Fabri 28f9063935 had introduced an error. overlaods need the same interface 2013-03-01 12:44:40 +01:00
Andreas Fabri c724f2ff9a CGAL_USE 2013-03-01 11:27:39 +01:00
Andreas Fabri b22839067e static_cast 2013-03-01 11:02:46 +01:00
Laurent Rineau f202656ca4 Fix warnings in Aos_2
LLVM/clang can display warnings even for functions that are not used,
during the parsing of the code, before the compilation, when it can.

For example:

[...]/include/CGAL/Arr_tags.h:93:7: warning: unused variable 'missing__Left_side_category__assuming__Arr_oblivious_side_tag__instead' [-Wunused-variable]
      missing__Left_side_category__assuming__Arr_oblivious_side_tag__instead;
      ^
[...]/include/CGAL/Arr_tags.h:138:7: warning: unused variable 'missing__Bottom_side_category__assuming__Arr_oblivious_side_tag__instead' [-Wunused-variable]
      missing__Bottom_side_category__assuming__Arr_oblivious_side_tag__instead;
      ^
[...]/include/CGAL/Arr_tags.h:181:10: warning: unused variable 'missing__Top_side_category__assuming__Arr_oblivious_side_tag__instead' [-Wunused-variable]
    bool missing__Top_side_category__assuming__Arr_oblivious_side_tag__instead;
         ^
[...]/include/CGAL/Arr_tags.h:226:7: warning: unused variable 'missing__Right_side_category__assuming__Arr_oblivious_side_tag__instead' [-Wunused-variable]
      missing__Right_side_category__assuming__Arr_oblivious_side_tag__instead;
      ^
4 warnings generated.

With this commit, the functions 'missing__*_side_category()' are now
function *templates*. The compiler can not longer warn about the unused
variable. However, I have verified that it does warn if the function is
actually instanciated and used.
2013-03-01 10:45:22 +01:00
Andreas Fabri 9992ccf96c WARNING -> NUMERICAL ISSUES 2013-03-01 10:38:50 +01:00
Andreas Fabri 900ac238a8 add a static_cast 2013-03-01 10:26:29 +01:00
Andreas Fabri 1287047b9d remove the second parameter and not only its variable 2013-03-01 09:53:38 +01:00
Andreas Fabri 9a862fe795 remove unused parameter name 2013-03-01 09:43:21 +01:00
Andreas Fabri 50c4c6e494 bug fix for clang / Most_vexing_parse 2013-03-01 09:15:17 +01:00
Andreas Fabri 2c8c044db5 use variables to avoid clang warning 2013-03-01 09:01:27 +01:00
Andreas Fabri 455190a2e4 removed one parameter too much 2013-03-01 08:55:10 +01:00
Andreas Fabri e8b191fd87 removed unused parameter name 2013-02-28 17:33:06 +01:00
Andreas Fabri b315c05781 avoid 'warning: equality comparison result unused [-Wunused-comparison]' 2013-02-28 17:22:52 +01:00
Andreas Fabri c751ac0cc0 removed unused parameter name 2013-02-28 16:44:40 +01:00
Andreas Fabri 84a7061b15 remove unused parameter name 2013-02-28 16:40:57 +01:00
Andreas Fabri 9a17fce6b1 Remove '&' from the return type, as it would be a reference to a local variable 2013-02-28 09:46:57 +01:00
Andreas Fabri 92ebc695a2 remove unused parameter name 2013-02-28 09:46:55 +01:00
Andreas Fabri 479f78b033 int -> ptrdiff_t/size_t 2013-02-28 09:46:54 +01:00
Andreas Fabri 33549c2e02 static_cast<int> 2013-02-28 09:46:53 +01:00