Commit Graph

267 Commits

Author SHA1 Message Date
Laurent Rineau 3b79468b13 another USBAN error, about uninitialized bool 2023-04-13 17:26:44 +02:00
Laurent Rineau 029b5bead5 Triangulation_3.h: Rewrite/factorize
New functions:
  - `create_hole_outer_map`,
  - `create_triangulation_inner_map`.
  - `copy_triangulation_into_hole`,
  - `fill_auxiliary_triangulation_with_vertices_around_v`
2023-02-06 10:02:25 +01:00
Laurent Rineau 686aff651d Triangulation_3.h: Factorize the two versions of make_hole_3D 2023-02-06 10:02:20 +01:00
Laurent Rineau d940c3ae3f Triangulation_3.h: make_vertex_triple can be static 2023-02-06 10:02:15 +01:00
albert-github c32b1f4127 spelling corrections
Some spelling corrections (Directories starting with `S` rest - `W`),
2022-11-16 13:22:39 +01:00
Andreas Fabri d3fca65ae5 CGAL: No longer per package assertions 2022-09-23 12:49:40 +01:00
Mael Rouxel-Labbé 43378edd1f Minor speed up for T3::operator== 2022-09-02 14:29:15 +02:00
Mael Rouxel-Labbé 7d9d7844b1 Fix T23::operator== for dimension 0 2022-09-02 13:42:33 +02:00
Sébastien Loriot c9c6b30cf0 Merge sloriot/CGAL-std_type_traits into master 2022-06-23 16:35:37 +02:00
Laurent Rineau 782bd1b106 Merge pull request #6622 from kda/initialize
initialize some stack variables
2022-06-15 10:20:55 +02:00
Laurent Rineau 2feb9a29ce Merge pull request #6655 from lrineau/Triangulation_3-fix_use_after_free-GF
Triangulation_3: fix a use-after-free in `T3::remove` and `T3::move*` methods
2022-06-15 10:20:48 +02:00
Laurent Rineau 14b582f83d More use our free of `outer_map` 2022-06-10 09:15:11 +02:00
Sébastien Loriot 4f5f8341cc use std::enable_if_t 2022-06-10 07:37:53 +02:00
Kevin Athey a40be70ff7 change initialized value to -1. 2022-06-08 15:28:25 -07:00
Laurent Rineau f438a2ed3a Fix a use-after-free
In an `unordered_map`, any insertion can invalidate iterators,
when the load factor triggers a rehashing.
2022-06-08 15:52:01 +02:00
Kevin Athey ff749f7fd6 initialize some stack variables 2022-05-27 11:46:34 -07:00
Laurent Rineau ceb41bf206 Fix crash during binary I/O of Triangulation_3 2022-04-27 14:19:21 +02:00
Laurent Rineau bac0822298 Merge pull request #5199 from GilesBathgate/fix-uninitialized-member-triangulation3
Fix uninitialized member in Triangulation_3.h
2021-09-29 11:46:53 +02:00
Sébastien Loriot 5945e48a3e restore sub-directories accidently removed in 98e471849b 2021-09-17 08:14:06 +02:00
Maxime Gimeno d4b0b49f33 Use "real" extensions and fix loading. 2021-08-30 15:41:52 +02:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Sébastien Loriot 1e249afdb3 remove some boost::bind 2021-01-06 12:59:11 +01:00
Giles Bathgate b95de74a7a Fix uninitialized member in Triangulation_3.h 2020-11-18 21:26:59 +00:00
Jane Tournois b87e226ebb Simplex_3 can be dereferenced in range-for-loop (not Cell_handle)
this error was found thanks to a clang warning :
warning: loop variable 's' has type 'const Simplex &' (aka 'const Triangulation_simplex_3&')
but is initialized with type
'CGAL::Triangulation_segment_simplex_iterator_3' resulting in a copy [-Wrange-loop-construct]
2020-11-03 18:53:02 +01:00
Jane Tournois 57250ce637 Merge remote-tracking branch 'cgal/master' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF
# Conflicts:
#	Installation/CHANGES.md
2020-09-28 16:01:05 +02:00
Laurent Rineau 022b1a71d0 Merge branch 'releases/CGAL-5.0-branch' 2020-07-21 15:27:49 +02:00
Laurent Rineau 2e8a59d570 Merge branch 'releases/CGAL-4.14-branch' into releases/CGAL-5.0-branch 2020-07-21 15:25:54 +02:00
Laurent Rineau 1e6a5ac636 Fix the use of Construct_point_3::result in Periodic_3 2020-07-16 15:11:23 +02:00
Maxime Gimeno 41175cd505 WIP 2020-07-16 14:47:41 +02:00
Jane Tournois 9e8d12d9cf Merge remote-tracking branch 'cgal/master' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF
# Conflicts:
#	Installation/CHANGES.md
2020-07-06 06:57:32 +02:00
Laurent Rineau 07eacf5231 Merge pull request #4795 from janetournois/Mesh_3-fix_optimisers_parallel-jtournois
Mesh_3 - fix parallel optimisers
2020-06-30 16:38:05 +02:00
Laurent Rineau ad23db27a3 Merge pull request #4795 from janetournois/Mesh_3-fix_optimisers_parallel-jtournois
Mesh_3 - fix parallel optimisers
2020-06-30 16:36:58 +02:00
Jane Tournois bce4b4e80a Revert "add an assertion in make_canonical"
This reverts commit f55ffabbe0.
In the exuder, it can happen that this function takes the triple
(Vertex_handle(), Vertex_handle(), Vertex_handle())
so the assertion does not hold
2020-06-26 14:57:02 +02:00
Jane Tournois daaf92d0ac rename make_canonical() to make_canonical_oriented_triple()
to make it more explicit
2020-06-19 13:31:51 +02:00
Jane Tournois f55ffabbe0 add an assertion in make_canonical
it also helps to make the code more explicit
2020-06-19 13:31:51 +02:00
Jane Tournois ad9c357f33 add adjacent_vertices_threadsafe and use it in nearest_power_vertex() 2020-06-19 13:31:50 +02:00
Laurent Rineau dcc4fb1cc1 Merge remote-tracking branch 'cgal/master' into CGAL-move_semantic_for_triangulations-GF
# Conflicts:
#	STL_Extension/include/CGAL/Compact_container.h
2020-05-20 09:46:26 +02:00
Jane Tournois 9a722c4ef1
Merge branch 'master' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF 2020-04-20 06:40:24 +02:00
Sébastien Loriot d845d6ce8d Merge remote-tracking branch 'cgal/master' 2020-04-10 18:16:18 +02:00
Mael Rouxel-Labbé c16c1a7ea3 Merge remote-tracking branch 'cgal/master' into CGAL-Optimal_bounding_box-GF 2020-04-10 16:10:11 +02:00
Jane Tournois 163f3c59fb add range iterators 2020-04-07 07:05:19 +02:00
Jane Tournois 1ef0d4b83d segment traverser end() does not need s and t as parameters
the API gets simpler and easier with these changes

+ fix last valid value of the simplex iterator in some cases

after this commit, only the test test_triangulation_on_a_grid() keeps failing
2020-04-03 18:02:37 +02:00
Jane Tournois b9660603b9 add the new API in the code
and adapt examples and tests consistently
2020-04-03 06:52:25 +02:00
Maxime Gimeno b6a5f23e4e remove trailing whitespaces 2020-04-02 15:02:27 +02:00
Maxime Gimeno e02a3fc37e Merge remote-tracking branch 'cgal/master' into TDS-file_input-maxGimeno 2020-04-02 15:00:23 +02:00
Maxime Gimeno 383eb3d147 Merge tag 'master_before_no_tws_nor_tabs' into TDS-file_input-maxGimeno 2020-04-02 14:56:03 +02:00
Sébastien Loriot 86e25f7e71 Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:23:54 +01:00
Sébastien Loriot 9f2eafd06e extra run of the script to remove tabs and trailing whitespaces 2020-03-26 19:17:02 +01:00
Sébastien Loriot 0779373835 extra run of the script to remove tabs and trailing whitespaces
right after the  merge of 4.14 release branch

+ manual fix on one line in:
    * Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
    * .travis/generate_travis.sh
2020-03-26 14:16:06 +01:00