Commit Graph

104985 Commits

Author SHA1 Message Date
Sébastien Loriot 4ecc6671dc increase precision of the result 2023-12-06 12:42:00 +01:00
Mael Rouxel-Labbé b4d465ce85 Add a test 2023-12-05 22:34:00 +01:00
Mael Rouxel-Labbé dd0cc2ee5c Fix a few copy-paste bugs 2023-12-05 22:15:01 +01:00
Sébastien Loriot 95825dba60 fix copy/paste errors 2023-12-05 18:11:27 +01:00
Sébastien Loriot 95b6ef8d2e try working around a warning 2023-12-05 11:19:31 +01:00
Sébastien Loriot 3ebe548cad Revert "prevent out-of-bound warnings"
This reverts commit b87ecf7aab.
2023-12-05 11:18:13 +01:00
Sébastien Loriot b87ecf7aab prevent out-of-bound warnings 2023-12-05 09:06:47 +01:00
Sebastien Loriot 9822b6b085
protect from macro substitution
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2023-11-30 09:20:53 +01:00
Laurent Rineau d314e31e9e Merge branch '5.5.x-branch' into 5.6.x-branch 2023-11-29 17:16:16 +01:00
Laurent Rineau 19e4840023 Merge pull request #7869 from lrineau/Installation-fix_CMake_REGEXP_REPLACE-GF
CMake: fix incorrect use of string(REGEX REPLACE...)
2023-11-29 17:16:09 +01:00
Laurent Rineau 44e740cc93 Merge pull request #7880 from sloriot/BGL-workaround_clang18_error
workaround error with clang++-18
2023-11-29 17:16:06 +01:00
Laurent Rineau 8ee8f27d45 Merge pull request #7869 from lrineau/Installation-fix_CMake_REGEXP_REPLACE-GF
CMake: fix incorrect use of string(REGEX REPLACE...)
2023-11-29 17:15:36 +01:00
Laurent Rineau 894a3db5f5 Merge pull request #7880 from sloriot/BGL-workaround_clang18_error
workaround error with clang++-18
2023-11-29 17:15:33 +01:00
Laurent Rineau 46877d4134 fix two typos 2023-11-29 15:34:36 +01:00
Laurent Rineau 52f8cfffbd Merge remote-tracking branch 'sloriot/CGAL-fix_dh_angle_sign' into pr/sloriot/7892 2023-11-29 15:28:57 +01:00
Laurent Rineau df4eed9302 add tests for the dihedral angle 2023-11-29 15:27:57 +01:00
Sébastien Loriot e3e5bcd344 accomodate handle sign
face orientation was inversed and somehow matched the bug
in the dihedral angle computation function
2023-11-29 15:25:44 +01:00
Sébastien Loriot 4bed66e82f fix description 2023-11-29 13:17:10 +01:00
Sébastien Loriot 5879bb72c6 add comments about the formula 2023-11-29 13:11:21 +01:00
Sébastien Loriot 0e3f3a33d1 test to be fixed --> tetra orientation is 0 2023-11-29 12:27:34 +01:00
Sébastien Loriot 0145bafbc5 update formula
will add comments in a upcoming commit
2023-11-29 12:22:46 +01:00
Sébastien Loriot 6b570f767e fix sign 2023-11-28 18:10:32 +01:00
Andreas Fabri 8f8280ce34 Add structural filtering to Robust circumcenter traits 2023-11-23 19:37:23 +00:00
Andreas Fabri 25e597ac79 Poisson Surface Reconstruction: Enable Structural Filtering 2023-11-23 15:22:20 +00:00
Sébastien Loriot 9e45a2982a workaround error with clang++-18 2023-11-23 09:52:46 +01:00
Laurent Rineau 25ebbab854 Fix incorrect use of string(REGEX REPLACE...) 2023-11-17 15:29:24 +01:00
Laurent Rineau b6d9c444f8 Merge pull request #7797 from janetournois/Tet_remeshing-c3t3_initialization-jtournois
Tetrahedral remeshing - fix internal C3t3

# Conflicts:
#	Tetrahedral_remeshing/include/CGAL/Tetrahedral_remeshing/internal/tetrahedral_adaptive_remeshing_impl.h
2023-11-15 15:37:41 +01:00
Laurent Rineau cc91b5e5a0 Merge pull request #7838 from janetournois/SMDS_3-delete_test_output-jtournois
SMDS_3 - avoid output files for testing
2023-11-15 15:31:32 +01:00
Jane Tournois e4e13e2f57 do not check the graph of features after protection when minimal_size is set
when minimal_size is set, the graph of features is likely to be invalid

or at least inconsistent with the input graph
so checking its topology does not make any sense and could lead to
- assertions failing in debug mode,
- hanging in release mode
2023-11-14 12:28:18 +01:00
Laurent Rineau 08b5c90955 Merge pull request #7784 from janetournois/BGL-warning_fixed-jtournois
BGL - no need to workaround boost 1.54 anymore
2023-11-06 12:37:47 +01:00
Jane Tournois d77935f496 replace ofstream by ostringstream 2023-10-31 11:50:42 +01:00
Laurent Rineau 07d93e2b45 Merge branch '5.5.x-branch' into 5.6.x-branch 2023-10-30 17:12:49 +01:00
Laurent Rineau 0bf610aa8d Merge pull request #7803 from lrineau/CH_3-fix_typo-GF
Convex_hull_3: fix a typo
2023-10-30 17:12:29 +01:00
Laurent Rineau ef8ae2ac36 Merge pull request #7814 from sloriot/P3T3-demo_fix
Fix qhelpgenerator call
2023-10-30 17:12:27 +01:00
Laurent Rineau 24a8000eea Merge pull request #7803 from lrineau/CH_3-fix_typo-GF
Convex_hull_3: fix a typo
2023-10-30 17:12:05 +01:00
Laurent Rineau 66e36bcac0 Merge pull request #7814 from sloriot/P3T3-demo_fix
Fix qhelpgenerator call
2023-10-30 17:12:02 +01:00
Sébastien Loriot 2bdab8c731 removing extra unneeded lines 2023-10-26 08:54:40 +02:00
Sebastien Loriot b2df589e68
Mesh 3: Fix demo tetrahedral filtering with a tetrahedral mesh having many subdomains (#7734)
## Summary of Changes

When a triangulation 3 has many subdomains (more than 24), some will not
be shown.

Changes done : 
 - [x] Lowered maximum number of subdomains allowed in filtering
 - [x] Made filtering work with up to 128 subdomains
 - [x] Made this limit more easy to change

Possible amelioration :
- [ ] Make filtering work with any number of subdomains (using a texture
buffer)

## Release Management

* Affected package(s): Mesh_3
* Issue(s) solved (if any): 
* Feature/Small Feature (if any):
* License and copyright ownership:
2023-10-25 23:32:21 -07:00
Sébastien Loriot 15a8dbf7d9 Merge remote-tracking branch 'cgal/5.5.x-branch' 2023-10-25 17:42:37 +02:00
Sebastien Loriot 8ff56a8af4
Prevent the removal of fixed boundary edges (#7820)
Add a check before calling `remove_degerenate_faces()` to avoid removing
patch border edges
2023-10-25 08:40:07 -07:00
Sebastien Loriot a130c6011a
fix out-of-bound warnings (#7809)
The sanity value was not used so let's set it to 3.
2023-10-25 08:39:36 -07:00
Sebastien Loriot a82f5115a4
Tetrahedral remeshing of a C3t3 - fix default cell selector (#7760)
## Summary of Changes

In the demo, tetrahedral remeshing is called directly on the C3t3. This
PR fixes the default `cell_selector` when remeshing is called on a C3t3.

## Release Management

* Affected package(s): Tetrahedral_remeshing
* License and copyright ownership: unchanged
2023-10-25 08:39:01 -07:00
Sébastien Loriot 21ece823de remove instruction to generate files not used 2023-10-24 09:29:31 +02:00
Sébastien Loriot f2ec9175ac prevent the removal boundary edges (that are constraints) 2023-10-23 14:41:46 +02:00
Laurent Rineau 4ee9d15c9f Merge branch '5.5.x-branch' into 5.6.x-branch
# Conflicts:
#	STL_Extension/include/CGAL/Base_with_time_stamp.h
2023-10-19 14:53:14 +02:00
Laurent Rineau cc50a6c1e7
STL_extension: Fix Base_with_time_stamp (#7807)
## Summary of Changes

Remove the copy constructor of `Base_with_time_stamp`. 
Otherwise we have 'N' in the [Triangulation_2
testsuite](https://cgal.geometryfactory.com/CGAL/testsuite/results-5.5.4-I-169.shtml#Triangulation_2)
for CGAL 5.5.

Note that the copy constructor is not in 5.6 and master. 
Note that this only concerns VC++.

## Release Management

* Affected package(s): STL_extension
* License and copyright ownership:  unchanged
2023-10-19 14:44:45 +02:00
Sébastien Loriot 9cefb1a481 fix out-of-bound warnings 2023-10-19 11:40:35 +02:00
Andreas Fabri 117ccfdd02 STL_extension: Remove copy constructor 2023-10-18 16:24:04 +01:00
Sébastien Loriot 0f45fedf53 remove unused type 2023-10-18 11:59:30 +02:00
Jane Tournois e071250b4d rename debug output file 2023-10-17 16:24:28 +02:00