songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
101,786 Commits 3 Branches 156 Tags 963 MiB
Commit Graph

101786 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé cf12f90cbf Fix broken is_hyperbolic(face/edge) framework 
The previous code tries to handle finite/infinite and hyperbolic/non-hyperbolic
with a single flag, which caused errors to get stuff like finite
but non-hyperbolic edges (see e.g. https://github.com/CGAL/cgal/issues/6869).

In addition, it used tds_data(), which is something that now also
exists in the triangulation_ds_face_base_2 class.

Hence, completely re-implement the hyperbolic stack / query.

 #	../../../../Installation/CHANGES.md.orig
 2022-09-26 16:08:43 +02:00
Mael Rouxel-Labbé 145a817cc1 Remove (broken) HDT2::insert(p, lt, li) from documentation 
The 'lt' is documented to be HDT2::Locate_type, which is wrong, the function's
signature uses HDT2::DT2::Locate_type, and that's for a precise reason:
HDT2::locate() returns location based on hyperbolic simplicies, and not
the underlying DT2 triangulation. So, one might retrieve "OUTSIDE_CONVEX_HULL"
if a query is on a non-hyperbolic Delaunay face, but a finite underlying DT2
face. In that configuration, it'd break the triangulation to do an insertion
with "OUTSIDE_CONVEX_HULL".

The documentation could be fixed, but it is too dangerous so it's best
to just remove it. (Maybe it should also be simply removed
from the triangulation class.)
 2022-09-26 16:07:52 +02:00
Mael Rouxel-Labbé 1e5999419b Add more tests for HDT2::locate() 2022-09-26 15:16:25 +02:00
Mael Rouxel-Labbé a7eedb0c74 Fix `ensuring_hyperbolic_face_handle` not doing anything (dim > 2 is 'false') 2022-09-26 15:15:35 +02:00
Mael Rouxel-Labbé 25df7a7565 Misc tiny improvements 2022-09-26 15:14:29 +02:00
Mael Rouxel-Labbé 98b6b95054 Fix issues in HDT2::locate(): 
- Fix not setting up 'li' when landing on a non hyperbolic face but hyperbolic
  edge
- Fix returning Face_handle()s for some EDGE cases
 2022-09-26 15:11:38 +02:00
Mael Rouxel-Labbé 3f49816e1c Misc HDT2 fixes (broken conflict zones visu, no extra edges, ...) 2022-09-26 14:10:22 +02:00
Mael Rouxel-Labbé c2cbac1a3f Remove unused code/typedefs 2022-09-26 14:07:10 +02:00
Mael Rouxel-Labbé 57e496fd7c Fix upside Y axis 2022-09-26 13:07:24 +02:00
Mael Rouxel-Labbé 1bf6aaeb5a Fix rotated view (horizontal Y axis...) in the demo 2022-09-26 13:07:16 +02:00
Mael Rouxel-Labbé e6acc5f934 Prevent insertion of points outside the unit Poincaré circle 2022-09-25 02:26:03 +02:00
Mael Rouxel-Labbé 0251966b30 Only hyperbolic edges have duals 2022-09-25 01:45:23 +02:00
Mael Rouxel-Labbé 46341243fe Fix visualization of conflict zones 2022-09-25 01:29:36 +02:00
Mael Rouxel-Labbé 4540fe4a1b Disable absent action to simulate insertions 2022-09-25 00:26:27 +02:00
Mael Rouxel-Labbé 816fb2a1c1 Simply return enums 2022-09-24 23:29:24 +02:00
Mael Rouxel-Labbé a1752b8b27 Misc cleaning 2022-09-24 23:29:03 +02:00
Mael Rouxel-Labbé 94900beec6 Do not return point copies in HT2::point() 2022-09-24 16:48:15 +02:00
Mael Rouxel-Labbé c8e029438b Remove superfluous call to ensure_hyperbolic_face_handle() (insert() does it) 2022-09-24 16:46:07 +02:00
Laurent Rineau a9d5e019b7
Merge pull request #6861 from sashashura/patch-1 2022-09-22 14:26:17 +02:00
Laurent Rineau a4a7cc173e Fix typo in CHANGES.md 2022-09-21 14:52:03 +02:00
Laurent Rineau 4888373206 updated crontab (automated commit) 2022-09-21 09:18:02 +02:00
Alex 845caa5ee7 build: harden build_doc.yml permissions 
Signed-off-by: Alex <aleksandrosansan@gmail.com>
 2022-09-20 12:47:49 +02:00
Alex 298c6c1bd6 build: harden filter_testsuite.yml permissions 
Signed-off-by: Alex <aleksandrosansan@gmail.com>
 2022-09-20 12:46:19 +02:00
Laurent Rineau 9fa249a26b updated crontab (automated commit) 2022-09-19 15:18:04 +02:00
Laurent Rineau e1d4a96401 Merge branch '5.5.x-branch' 2022-09-13 12:33:15 +02:00
Laurent Rineau a57fe1843d Merge pull request #6747 from dpapavas/mcf-skeleton-fixed-vertices 
Allow manually fixing a range of vertices, when using  `Mean_curvature_flow_skeletonization`
 2022-09-13 12:33:10 +02:00
Laurent Rineau 743de32052 Merge pull request #6779 from sloriot/Intersections_3-better_tetra_tri 
Simpler implementation of Tet vs. Tri intersection
 2022-09-13 12:33:08 +02:00
Laurent Rineau d0d0b30c12 Merge pull request #6807 from afabri/Parameterization-instantiation-GF 
Parameterization: instanciation ->  instantiation
 2022-09-13 12:33:05 +02:00
Laurent Rineau 0141404f4d Merge pull request #6809 from lrineau/Filtered_kernel-fix__do_intersect__Bbox_3__Triangle_3__static_filters-GF 
Fix static filter of Do_intersect_3(Bbox_3,Triangle_3)
 2022-09-13 12:33:03 +02:00
Laurent Rineau 8dd8e0dd11 Merge pull request #6812 from sloriot/PMP-split_visitor 
add missing visitor calls in PMP::split()
 2022-09-13 12:33:01 +02:00
Laurent Rineau e037898fc1 Merge pull request #6826 from MaelRL/T23-Operator=-GF 
Improvements for Triangulation_23 comparison operators
 2022-09-13 12:32:58 +02:00
Laurent Rineau 47efe91f09 Merge pull request #6827 from MaelRL/AW3_Demo-Add_non_relative_value-GF 
AW3 Plugin: Show both absolute and relative values for alpha & offset
 2022-09-13 12:32:56 +02:00
Laurent Rineau 29ca6bef88 Merge pull request #6833 from sloriot/Doc_needs_python 
Python is mandatory not optional to build the doc
 2022-09-13 12:32:54 +02:00
Laurent Rineau da9d9deadf Merge branch '5.4.x-branch' into 5.5.x-branch 2022-09-13 12:32:28 +02:00
Laurent Rineau 4bc403857d Merge pull request #6779 from sloriot/Intersections_3-better_tetra_tri 
Simpler implementation of Tet vs. Tri intersection
 2022-09-13 12:32:22 +02:00
Laurent Rineau ad2a07e653 Merge pull request #6809 from lrineau/Filtered_kernel-fix__do_intersect__Bbox_3__Triangle_3__static_filters-GF 
Fix static filter of Do_intersect_3(Bbox_3,Triangle_3)
 2022-09-13 12:32:20 +02:00
Laurent Rineau 7d5e498538 Merge pull request #6812 from sloriot/PMP-split_visitor 
add missing visitor calls in PMP::split()
 2022-09-13 12:32:17 +02:00
Laurent Rineau e93011ae2a Merge pull request #6779 from sloriot/Intersections_3-better_tetra_tri 
Simpler implementation of Tet vs. Tri intersection
 2022-09-13 12:31:37 +02:00
Laurent Rineau 4934f2b2e3 Merge pull request #6809 from lrineau/Filtered_kernel-fix__do_intersect__Bbox_3__Triangle_3__static_filters-GF 
Fix static filter of Do_intersect_3(Bbox_3,Triangle_3)
 2022-09-13 12:31:34 +02:00
Laurent Rineau df16e3273e Merge pull request #6812 from sloriot/PMP-split_visitor 
add missing visitor calls in PMP::split()
 2022-09-13 12:31:32 +02:00
Sebastien Loriot d896940470
Cosmetic changes 
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
 2022-09-07 16:08:58 +02:00
Mael Rouxel-Labbé bc9aa692c3 Add a few more tests to Tr-Tet 2022-09-07 16:00:59 +02:00
Sébastien Loriot f0f01b70ba remove trailing whitespace 2022-09-07 08:44:42 +02:00
Sébastien Loriot 5ff93338ae Python is mandatory not optional 2022-09-06 11:26:26 +02:00
Mael Rouxel-Labbé 468c30a7da Fix highly disturbing missing vertical spacer in AW3 Plugin 2022-09-03 14:13:44 +02:00
Mael Rouxel-Labbé 3e237758a2 Various improvements to the AW3 plugin 2022-09-03 14:04:31 +02:00
Mael Rouxel-Labbé db12deb0b2 Misc improvements to stats in the demo 2022-09-03 14:01:10 +02:00
Mael Rouxel-Labbé 25184ee42c add some extra verbose in example 2022-09-03 14:00:32 +02:00
Mael Rouxel-Labbé 46c9fa19ab Add clear() to oracles 2022-09-03 14:00:20 +02:00
Mael Rouxel-Labbé 691313041d Add more tests for T23::operator== 2022-09-02 14:29:41 +02:00