Commit Graph

100822 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé d2b9b5728f Remove unused typedef/variables 2022-07-05 09:46:30 +02:00
Mael Rouxel-Labbé 87d09b6763 Add test for EPICK 2022-07-05 09:42:05 +02:00
Mael Rouxel-Labbé 1c19734490 Add missing header include 2022-07-02 18:02:44 +02:00
Mael Rouxel-Labbé 711d64674a Less_signed_... --> Compare_signed_... in CH3 adapters 2022-07-02 17:19:48 +02:00
Mael Rouxel-Labbé 75441da5ed Remove a disable_warning.h 2022-07-01 23:49:57 +02:00
Mael Rouxel-Labbé 2e330b1342 Improve CH2 tests 2022-07-01 23:49:31 +02:00
Mael Rouxel-Labbé e4e52c8391 Misc doc cleaning 2022-07-01 23:46:10 +02:00
Mael Rouxel-Labbé 13b4060644 Fix eddy/bykat returning collinear vertices on the hull
In these two algorithms, points farthest from a line must be found.
In case of multiple points at the same distance, an "extremity"
of this set of points must be returned.

This was properly documented in the Less_signed_distance_to_line_2
functor of the ConvexHullTraits_2 concept:

[ ... ]
The predicate must provide a total order compatible with convexity,
<I>i.e.</I>, for any line segment \f$ s\f$ one of the endpoints
of \f$ s\f$ is the smallest point among the points on \f$ s\f$,
with respect to the order given by `Less_signed_distance_to_line_2`.
[ ... ]

And specific models did respect this requirement. However, the kernel
is supposed to also be a model of ConvexHullTraits_2, but
Kernel_23::LessSignedDistanceToLine_2 does not require this, and
the models (EPICK, Simple_Cartesian, etc.) do not implement it.
Hence, if a kernel was used as geometric traits for 2D Convex Hull
algorithms, one might not get the expected extreme point when
there are multiple points at the same distance to a line at some
point in the algorithm.

The algorithm recovered, but this created extra points on the hull.

Fixing the functor in the kernel would create an inconsistency
with Kernel_23::Compare_signed_distance_to_line_2, so instead
this commit changes the concept and the code to require
providing Compare_signed_distance_to_line_2 and then uses Less_xy
in the code in case of EQUAL return (that is actually how it was
done in the Convex_hull_2-specific versions of the ConvexHullTraits_2
model).
2022-07-01 13:35:59 +02:00
Mael Rouxel-Labbé 93c47ec702 Use cmp_signed_dist_to_directionC2 for Compare_signed_distance_to_line_2 2022-06-30 16:23:09 +02:00
Mael Rouxel-Labbé 2b245d870e Remove long-deprecated Convex_hull_2 projection traits 2022-06-30 15:20:23 +02:00
Mael Rouxel-Labbé 96e565777f Remove useless "using namespace boost" (boost::bind was replaced with lambdas) 2022-06-30 09:32:45 +02:00
Mael Rouxel-Labbé 6b6bfaae4f Fix CH3 doc links within CH2 2022-06-30 09:31:19 +02:00
Laurent Rineau 386811cb7c Accomodate breaking changes in Github Action actions/github-script@v3
See https://github.com/actions/github-script#breaking-changes-in-v5
2022-06-27 10:00:46 +02:00
Laurent Rineau 352bf23951 Merge pull request #6709 from CGAL/dependabot/github_actions/actions/checkout-3
Bump actions/checkout from 2 to 3
2022-06-24 14:42:37 +02:00
Laurent Rineau 52aee2311d Merge pull request #6708 from CGAL/dependabot/github_actions/actions/github-script-6
Bump actions/github-script from 3 to 6
2022-06-24 14:42:33 +02:00
dependabot[bot] 89898a5f92
Bump actions/checkout from 2 to 3
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-24 07:10:25 +00:00
dependabot[bot] 61f401e04d
Bump actions/github-script from 3 to 6
Bumps [actions/github-script](https://github.com/actions/github-script) from 3 to 6.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](https://github.com/actions/github-script/compare/v3...v6)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-24 07:10:21 +00:00
Laurent Rineau 9c9139ba50
Merge pull request #6706 from turrisxyz/Dependabot-GitHub-Actions 2022-06-24 09:09:45 +02:00
naveen 34dad5ddad chore: Included githubactions in the dependabot config
This should help with keeping the GitHub actions updated on new releases. This will also help with keeping it secure.

Dependabot helps in keeping the supply chain secure https://docs.github.com/en/code-security/dependabot

GitHub actions up to date https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool
Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
2022-06-24 01:30:09 +00:00
Laurent Rineau 2a87fc1d46
Merge pull request #6696 from turrisxyz/Pinned-Dependencies-GitHub 2022-06-23 10:26:15 +02:00
naveen 03023aa08f chore: Set permissions for GitHub actions
Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)

Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
2022-06-23 00:31:13 +00:00
Laurent Rineau 7ba81ca1d5 updated crontab (automated commit) 2022-06-20 16:18:03 +02:00
Laurent Rineau 03508a96f4 Merge branch '5.5.x-branch'
# Conflicts:
#	Installation/include/CGAL/version.h
#	Installation/lib/cmake/CGAL/CGALConfigVersion.cmake
2022-06-15 10:23:16 +02:00
Laurent Rineau 2ceb4f4d97 Merge pull request #6609 from afabri/Polygon-transform-GF
Polygon: Add move semantics
2022-06-15 10:20:58 +02:00
Laurent Rineau 782bd1b106 Merge pull request #6622 from kda/initialize
initialize some stack variables
2022-06-15 10:20:55 +02:00
Laurent Rineau cefa3d9d80 Merge pull request #6648 from sloriot/PMP-do_not_flip_high_triangles
Add an option to a remove_almost_degenerate_faces
2022-06-15 10:20:53 +02:00
Laurent Rineau 58aaa4bdc5 Merge pull request #6653 from MaelRL/AW3-Siggraph_demo-GF
AW3: Visualize and save wrapping iterations
2022-06-15 10:20:50 +02:00
Laurent Rineau 2feb9a29ce Merge pull request #6655 from lrineau/Triangulation_3-fix_use_after_free-GF
Triangulation_3: fix a use-after-free in `T3::remove` and `T3::move*` methods
2022-06-15 10:20:48 +02:00
Laurent Rineau 85ba0e44e4 Merge pull request #6656 from lrineau/PMP-fix_missing_header-GF
PMP.repair_polygon_soup.h: add #include <deque>
2022-06-15 10:20:46 +02:00
Laurent Rineau a79363275e Merge pull request #6659 from afabri/CGAL-fix_boost_doc_URLs-GF
STL_extension: Fix URL to boost libs
2022-06-15 10:20:44 +02:00
Laurent Rineau 3894480daf Merge branch '5.4.x-branch' into 5.5.x-branch 2022-06-15 10:19:07 +02:00
Laurent Rineau 378685ddd2 Merge pull request #6648 from sloriot/PMP-do_not_flip_high_triangles
Add an option to a remove_almost_degenerate_faces
2022-06-15 10:19:02 +02:00
Laurent Rineau 36349f924d Merge pull request #6653 from MaelRL/AW3-Siggraph_demo-GF
AW3: Visualize and save wrapping iterations
2022-06-15 10:19:00 +02:00
Laurent Rineau c2fa2cb9fe Merge pull request #6655 from lrineau/Triangulation_3-fix_use_after_free-GF
Triangulation_3: fix a use-after-free in `T3::remove` and `T3::move*` methods
2022-06-15 10:18:57 +02:00
Laurent Rineau 97bc6192b9 Merge pull request #6656 from lrineau/PMP-fix_missing_header-GF
PMP.repair_polygon_soup.h: add #include <deque>
2022-06-15 10:18:55 +02:00
Laurent Rineau a0aec6d20a Merge pull request #6659 from afabri/CGAL-fix_boost_doc_URLs-GF
STL_extension: Fix URL to boost libs
2022-06-15 10:18:53 +02:00
Laurent Rineau 017614c1f0 Merge pull request #6655 from lrineau/Triangulation_3-fix_use_after_free-GF
Triangulation_3: fix a use-after-free in `T3::remove` and `T3::move*` methods
2022-06-15 10:17:25 +02:00
Laurent Rineau aeb4ed1fc9 Merge pull request #6656 from lrineau/PMP-fix_missing_header-GF
PMP.repair_polygon_soup.h: add #include <deque>
2022-06-15 10:17:23 +02:00
Sébastien Loriot c8654724e2 update test to check we can prevent collapses and flips 2022-06-13 12:41:57 +02:00
Laurent Rineau 2644e14255 updated crontab (automated commit) 2022-06-13 11:18:02 +02:00
Laurent Rineau d9245b9cd6 Remove any mention of result_of in the documentation 2022-06-10 17:26:44 +02:00
Laurent Rineau 198977cf46 Test move construction/assignment of Polygon_with_holes_2 2022-06-10 17:10:26 +02:00
Laurent Rineau 05c9dbfe8c Simplify the code using `=default` for special member functions 2022-06-10 17:10:00 +02:00
Laurent Rineau 1d2381b0f2 Merge branch '5.5.x-branch' 2022-06-10 16:46:05 +02:00
Laurent Rineau d42ef47c7e Merge pull request #6629 from afabri/AABB_tree-fix_private_doc-GF
AABB_tree: Document parameters
2022-06-10 16:45:39 +02:00
Laurent Rineau a9b4bf3ffb Merge pull request #6635 from sloriot/PMP-split_long_edges_np
Add face_patch_map to split_long_edges
2022-06-10 16:45:37 +02:00
Laurent Rineau f4b1adefc7 Merge pull request #6638 from sloriot/Argt-no_boost_pool_alloc
Disable boost pool allocator
2022-06-10 16:45:35 +02:00
Laurent Rineau 89dae9505b Merge pull request #6640 from pentacular/do_intersect_ambiguity
Qualify do_intersect to avoid ambiguous dispatch
2022-06-10 16:45:33 +02:00
Laurent Rineau e5f1bae4ba Merge pull request #6649 from lrineau/fix_issue_6647
CGALConfig.cmake: Warn only if CGAL_TEST_SUITE is set and CGAL_DATA_DIR is not
2022-06-10 16:45:31 +02:00
Laurent Rineau cb26dda800 Merge pull request #6650 from afabri/Boolean_set_operations-disambuguate_do_intersect-GF
Regularized Boolean Set Operations:  Help compiler to disambiguate
2022-06-10 16:45:29 +02:00