a8379e65f9
Renamed uses of invalidate_circumcenter() in accordance with the modified concept
2017-06-01 11:26:05 +02:00
9fd7d90ffd
Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle
...
Based on Kernel_Weighted_point_without...
@ 95c71de2e5
2017-05-30 16:13:34 +02:00
061f112e07
Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle
...
Based on Kernel_Weighted_point_without...
@ 95c71de2e5
2017-05-30 16:13:34 +02:00
5354134469
Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle
2017-05-24 12:18:49 +02:00
4018368e11
Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle
2017-05-24 12:18:49 +02:00
b0162b7ac0
Fixed Point / Point_3 issues in T3 and improved the documentation
...
-- Do not use concept names as template names in the doc
-- Fixed point / point_3 issues and other problems of coherence between concept
and model
-- Fixed some wrong refinement relationships
2017-05-22 11:27:02 +02:00
7185d8fec0
Fixed boost/core/is_same.hpp > boost/type_traits/is_same.hpp
2017-05-22 11:27:02 +02:00
61aa1716af
really use the GT given as a parameter
...
When the geom_traits given as parameter of `circumcenter` and/or
`weighted_circumcenter` was deriving from the cell base GT
(first template parameter), the gt was up-casted to the
cell base GT, and the function construct_circumcenter_3_object()
(or construct_weighted_circumcenter_3_object()) not
called on the right geom traits type --> possibly missing
the actual input of the function (the robust_circumcenter_traits in Mesh_3)
we add a static assert to check at compile time that point types are the same
2017-05-22 11:27:02 +02:00
8ab41b37db
Fixed using default templated class functions
2017-05-22 11:27:02 +02:00
9debfdfd78
Fixed wrong template type (which induced taking references of references)
2017-05-22 11:27:02 +02:00
c37857bd9e
really use the GT given as a parameter
...
When the geom_traits given as parameter of `circumcenter` and/or
`weighted_circumcenter` was deriving from the cell base GT
(first template parameter), the gt was up-casted to the
cell base GT, and the function construct_circumcenter_3_object()
(or construct_weighted_circumcenter_3_object()) not
called on the right geom traits type --> possibly missing
the actual input of the function (the robust_circumcenter_traits in Mesh_3)
we add a static assert to check at compile time that both geom traits
are compatible
2017-05-22 11:27:02 +02:00
ecd7bbdc3e
Changed boost/core/enable_if.hpp to boost/utility/enable_if.hpp
2017-05-22 11:27:02 +02:00
768b3f5b02
Fixed regular cell bases so they actually model the concept
...
Also, they should not use Bare_point / Weighted_point types, which are defined
in the triangulation (much later during compilation).
2017-05-22 11:27:02 +02:00
70e1ac97f6
Fixed Has_nested_type_Bare_point includes
2017-05-22 11:27:02 +02:00
bfe99438cc
Removed an ugly static_cast
2017-05-22 11:27:02 +02:00
9eac14e40c
Misc minor changes
2017-05-22 11:27:02 +02:00
11a5bb7104
Use boost::function_property_map to apply spatial_sort to weighted points
2017-05-22 11:27:02 +02:00
41590d7790
Moved facet dual computation functions from Mesh_3 to Regular_triangulation_3
...
... and improved them and gave them more overloads
2017-05-22 11:27:02 +02:00
66fa6e1be6
Avoid copies by using result_of in boost::bind() return type
...
Copies were previously done on purpose to go around the Lazy kernel, but this
can be done without copies (for all kernels) by using result_of.
2017-05-22 11:27:02 +02:00
6d4b607a2a
Removed obsolete file: Regular_traits_adaptor.h
2017-05-22 11:27:02 +02:00
64f9045991
Removed useless include
2017-05-22 11:27:02 +02:00
67d0dd4b5a
Reorganized Regular_triangulation_3 dual functions
2017-05-22 11:27:02 +02:00
084225735f
Copy boost::bind return object
...
The lazy kernel returns temporaries and gives garbage to compare_xyz_3...
2017-05-22 11:27:02 +02:00
a19ab8e500
Renamed Regular_triangulation base typedef (Base > Tr_Base)
2017-05-22 11:27:02 +02:00
b18b6c1f3e
Removed useless construct_point_3
...
Construct_weighted_circumcenter_3 already returns a Bare_point
2017-05-22 11:27:02 +02:00
5a388d85ac
Comparison result should be of type Comparison_result
...
(it worked anyway since Comparison_result is a Sign internally)
2017-05-22 11:27:02 +02:00
19c1d509e0
Fixed compilation of add_temporary_points_on_far_sphere()
2017-05-22 11:27:02 +02:00
81d3fae011
Adapted the call to spatial_sort() to handle weighted points
...
Downside: we copy points at each comparison, which is terrible! No noticeable
changes when profiling the construction of a triangulation.
We need this copy because of Lazy kernel: despite construct_point_3 having
const Point_3& construct_point_3_object()(const Point_3&)
the Lazy kernel can return some copies.
Other solutions that were not used:
-- Distinguish the Ouput type of Unary_function_to_property map depending on
the type of Kernel (ugly and not safe)
-- Use Weighted_point_mappers traits (but that blood will not be on my hands)
2017-05-22 11:27:02 +02:00
aa03fdc65e
Adapted sorting algorithms based on compare_xyz to handle weighted point vectors
2017-05-22 11:27:02 +02:00
f3c53cc53f
Construct_plane() must use bare points arguments
2017-05-22 11:27:02 +02:00
5d1b88bc7c
Removed hiding-related functions from Triangulation_cell_base_3
...
Triangulation_cell_base_3 cannot be used anymore as a cell base of a regular
triangulation and thus there is no point keeping these functions.
People wishing to disable caching of hidden points in regular triangulations
should use the new policy, see commit b92528171c
2017-05-22 11:27:02 +02:00
5872c22be3
Added a template parameter to Regular_tr_cell_base on hidden points handling
...
Before WP<->P implicit conversion changes, one could choose to not keep hidden
points by using `Triangulation_cell_base_3` as cell base instead of
`Regular_triangulation_cell_base_3`. This is not possible anymore as point types
will conflict.
This changes introduces a new template parameter to pass a policy on whether
to keep or discard hidden points.
It is a breaking change since it is placed before the container template
parameter, but it makes more sense that way and the container type template
was not documented.
2017-05-22 11:27:02 +02:00
320673924a
Removed Weighted_point_mapper_3 and RegTraits_3 shenanigans
...
There is no need anymore for sneaky traits adaptors to make Triangulation_3
a compatible base of Regular_triangulation_3:
- The Point type in Triangulation_3 is obtained through TDS::Vertex::Point (see
commit 13d5e89db5da73
2017-05-22 11:27:02 +02:00
ccb2b32616
Ensured that we call kernel functions with the correct (bare) point type
...
Note that if the type `Point` is already `Point_3`, Construct_point_3 does not
do anything (except in the lazy kernel, but in that case, the running time is
horrible anyway).
2017-05-22 11:27:02 +02:00
1a693a0e89
Deduce Triangulation_3's point type from the TDS
...
Since we have a distinc vertex_base for regular triangulations and that this
regular vertex base defines a type Point, it is redundant to get the Point
type from the Geom_traits.
This also allows to remove the Weighted_point_mapper trick, and pass more easily
custom point types.
2017-05-22 11:27:02 +02:00
84d7f97975
Fixed Regular_traits_adaptor
...
The functor members cannot be references because the Regular_triangulation
might be templated by a traits class that is not simply a Kernel (that is
the case in the package Interpolation).
When that is the case, calling this->K::function_object() might be a call
to a constructor in the base traits class. Thus, the functor members
of Reg_traits_adaptors get initialized to temporaries, which is problematic
because these temporaries are at a much lower scope and thus are quickly
cleaned, leaving us with references to nothing in Reg_traits_adaptor.
2017-05-22 11:27:02 +02:00
729c054871
Do not provide Bare_point overloads in Regular_triangulation
2017-05-22 11:20:45 +02:00
5833272bd0
Fixed usage of Bare point and Weighted point across Triangulation_3
2017-05-22 11:20:45 +02:00
e041870954
Trimmed Regular triangulation euclidean traits
...
-- Code added as consequence of disabling implicit conversion between points and
weighted points implies that defining
typedef weighted_point point;
creates ambiguous functors.
This typedef is nevertheless still used, in Weighted_point_mappers.
-- The traits are not supposed to define Bare_point
2017-05-22 11:20:45 +02:00
4f81c8c794
Added CGAL_NO_DEPRECATED_CODE macros to Regular_triangulation_euclidean_traits
2017-05-22 11:20:45 +02:00
ea14f683d7
Cleaned #if 0 code
2017-05-22 11:20:45 +02:00
62b90dd86b
Fixed hide_point()
...
Hide weighted points since they can be re-inserted afterwards
2017-05-22 11:20:45 +02:00
83ab007236
Fixed initialization order warning
2017-05-22 11:20:45 +02:00
51bc69cca3
version without partial specialization
...
the norms says that partial specialization should be
done in a namespace (not inside a class)
2017-05-22 11:20:45 +02:00
a4ee219f99
remove hybrid operators, that use Bare points and Weighted points in an ambiguous manner
...
this commit only fixes the testsuite of Mesh_3
2017-05-22 11:20:45 +02:00
81ae80c465
WIP: test_meshing_polyhedron_with_features compiles and crashes in odt
2017-05-22 11:20:45 +02:00
c6f741c379
Changes after making Weighted_point_3(const Point_3) explicit
2017-05-22 11:20:45 +02:00
57e6083b29
Disable Point_3(const Weighted_point_3&)
2017-05-22 11:20:45 +02:00
ea5f9934e2
The Weighted_point_mapper becomes a traits class; test_regular_3.cpp passes
2017-05-22 11:20:45 +02:00
aaed0f6737
Fixed using default templated member functions
2017-05-16 17:49:32 +02:00
91c35808f9
Fixed using default templated member functions
2017-05-16 17:49:32 +02:00
f45c008721
Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle
...
Using afabri/Kernel_Weighted_point_without_conversion-GF
@ 5c2a089e3e
2017-05-16 17:48:07 +02:00
dbc98ac410
Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle
...
Using afabri/Kernel_Weighted_point_without_conversion-GF
@ 5c2a089e3e
2017-05-16 17:48:07 +02:00
40d6a3e68a
Change comment to avoid warning
2017-05-16 10:17:41 +02:00
266775bafa
Silenced depreciation warnings from Regular_triangulation_euclidean_traits_23
2017-05-16 10:17:41 +02:00
cd2a562ffa
Fixed improper guards against the inclusion of deprecated headers
2017-05-16 10:17:41 +02:00
c353f0f49c
Added CGAL_NO_DEPRECATED_CODE macros to Regular_triangulation_euclidean_traits
2017-05-16 10:17:41 +02:00
d07976b2ac
All triangulations now use Perturbation_order in tests using symbolic perturbations
2017-05-15 17:13:38 +02:00
de3874f1ef
All triangulations now use Perturbation_order in tests using symbolic perturbations
2017-05-15 17:13:38 +02:00
5c2a089e3e
Fixed boost/core/is_same.hpp > boost/type_traits/is_same.hpp
2017-05-13 22:21:59 +02:00
01b2d61493
(Re)-added the unhide_point() function that is required for P3T3
2017-05-12 17:08:36 +02:00
23bd6c65ea
(Re)-added the unhide_point() function that is required for P3T3
2017-05-12 17:08:36 +02:00
2f0f955a59
Merge branch 'Kernel_Weighted_point_without_conversion-GF' of github.com:afabri/cgal into Kernel_Weighted_point_without_conversion-GF
2017-05-12 13:12:47 +02:00
6ed6af00a0
really use the GT given as a parameter
...
When the geom_traits given as parameter of `circumcenter` and/or
`weighted_circumcenter` was deriving from the cell base GT
(first template parameter), the gt was up-casted to the
cell base GT, and the function construct_circumcenter_3_object()
(or construct_weighted_circumcenter_3_object()) not
called on the right geom traits type --> possibly missing
the actual input of the function (the robust_circumcenter_traits in Mesh_3)
we add a static assert to check at compile time that point types are the same
2017-05-12 13:07:00 +02:00
b88bee84b2
Fixed using default templated class functions
2017-05-12 12:23:49 +02:00
9f865e87bb
Fixed wrong template type (which induced taking references of references)
2017-05-12 12:21:39 +02:00
bf425a46e6
Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle
...
Strongly breaks P3T3, will be fixed in the next commits
2017-05-11 17:45:15 +02:00
37fad1a242
Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle
...
Strongly breaks P3T3, will be fixed in the next commits
2017-05-11 17:45:15 +02:00
13d8a6879f
Changed boost/core/enable_if.hpp to boost/utility/enable_if.hpp
2017-05-11 14:25:18 +02:00
f2a308d9f1
Fixed regular cell bases so they actually model the concept
...
Also, they should not use Bare_point / Weighted_point types, which are defined
in the triangulation (much later during compilation).
2017-05-10 16:35:28 +02:00
46b489b2b5
Fixed Has_nested_type_Bare_point includes
2017-05-10 12:33:43 +02:00
97b789a741
Merge branch 'Kernel_Weighted_point_without_conversion-GF-old' into Kernel_Weighted_point_without_conversion-GF
2017-05-10 12:32:46 +02:00
be441f8dd1
Removed an ugly static_cast
2017-05-01 16:15:40 +02:00
169d0be212
Misc minor changes
2017-05-01 16:15:31 +02:00
d6576d1857
Use boost::function_property_map to apply spatial_sort to weighted points
2017-05-01 16:14:57 +02:00
6610dc7116
Moved facet dual computation functions from Mesh_3 to Regular_triangulation_3
...
... and improved them and gave them more overloads
2017-04-28 17:51:22 +02:00
5e9bad8e5d
Avoid copies by using result_of in boost::bind() return type
...
Copies were previously done on purpose to go around the Lazy kernel, but this
can be done without copies (for all kernels) by using result_of.
2017-04-28 17:30:37 +02:00
37d7d0ab2e
Removed obsolete file: Regular_traits_adaptor.h
2017-04-28 17:26:19 +02:00
2e78fee32e
Removed useless include
2017-04-28 17:24:44 +02:00
31f82720e8
Reorganized Regular_triangulation_3 dual functions
2017-04-28 15:00:29 +02:00
fe3c728a42
Copy boost::bind return object
...
The lazy kernel returns temporaries and gives garbage to compare_xyz_3...
2017-04-28 14:38:27 +02:00
88f97d2974
Renamed Regular_triangulation base typedef (Base > Tr_Base)
2017-04-27 16:31:35 +02:00
3681ec4460
Removed useless construct_point_3
...
Construct_weighted_circumcenter_3 already returns a Bare_point
2017-04-27 16:13:48 +02:00
4c96e75a8d
Comparison result should be of type Comparison_result
...
(it worked anyway since Comparison_result is a Sign internally)
2017-04-27 14:23:41 +02:00
863a223860
Fixed compilation of add_temporary_points_on_far_sphere()
2017-04-27 14:01:58 +02:00
2a06660a2b
Adapted the call to spatial_sort() to handle weighted points
...
Downside: we copy points at each comparison, which is terrible! No noticeable
changes when profiling the construction of a triangulation.
We need this copy because of Lazy kernel: despite construct_point_3 having
const Point_3& construct_point_3_object()(const Point_3&)
the Lazy kernel can return some copies.
Other solutions that were not used:
-- Distinguish the Ouput type of Unary_function_to_property map depending on
the type of Kernel (ugly and not safe)
-- Use Weighted_point_mappers traits (but that blood will not be on my hands)
2017-04-27 13:56:01 +02:00
9651371c6f
Adapted sorting algorithms based on compare_xyz to handle weighted point vectors
2017-04-27 13:52:20 +02:00
7108383498
Construct_plane() must use bare points arguments
2017-04-27 12:03:47 +02:00
d9666bd342
Removed hiding-related functions from Triangulation_cell_base_3
...
Triangulation_cell_base_3 cannot be used anymore as a cell base of a regular
triangulation and thus there is no point keeping these functions.
People wishing to disable caching of hidden points in regular triangulations
should use the new policy, see commit b92528171c
2017-04-27 11:50:54 +02:00
b92528171c
Added a template parameter to Regular_tr_cell_base on hidden points handling
...
Before WP<->P implicit conversion changes, one could choose to not keep hidden
points by using `Triangulation_cell_base_3` as cell base instead of
`Regular_triangulation_cell_base_3`. This is not possible anymore as point types
will conflict.
This changes introduces a new template parameter to pass a policy on whether
to keep or discard hidden points.
It is a breaking change since it is placed before the container template
parameter, but it makes more sense that way and the container type template
was not documented.
2017-04-27 11:42:34 +02:00
450c78e814
Removed Weighted_point_mapper_3 and RegTraits_3 shenanigans
...
There is no need anymore for sneaky traits adaptors to make Triangulation_3
a compatible base of Regular_triangulation_3:
- The Point type in Triangulation_3 is obtained through TDS::Vertex::Point (see
commit 13d5e89db5da73
2017-04-27 08:44:32 +02:00
db5da73483
Ensured that we call kernel functions with the correct (bare) point type
...
Note that if the type `Point` is already `Point_3`, Construct_point_3 does not
do anything (except in the lazy kernel, but in that case, the running time is
horrible anyway).
2017-04-27 00:25:12 +02:00
13d5e895ac
Deduce Triangulation_3's point type from the TDS
...
Since we have a distinc vertex_base for regular triangulations and that this
regular vertex base defines a type Point, it is redundant to get the Point
type from the Geom_traits.
This also allows to remove the Weighted_point_mapper trick, and pass more easily
custom point types.
2017-04-27 00:21:47 +02:00
ac63b66286
Fixed Regular_traits_adaptor
...
The functor members cannot be references because the Regular_triangulation
might be templated by a traits class that is not simply a Kernel (that is
the case in the package Interpolation).
When that is the case, calling this->K::function_object() might be a call
to a constructor in the base traits class. Thus, the functor members
of Reg_traits_adaptors get initialized to temporaries, which is problematic
because these temporaries are at a much lower scope and thus are quickly
cleaned, leaving us with references to nothing in Reg_traits_adaptor.
2017-04-18 15:16:43 +02:00
dce8bb77ba
Merge pull request #2053 from cjamin/Mesh_3-code_improvements-cjamin
...
Mesh_3: code improvements + bug fix
2017-04-14 18:32:05 +02:00
f1c1cd26c4
Do not provide Bare_point overloads in Regular_triangulation
2017-04-14 16:49:50 +02:00
5856c7de2b
Fixed usage of Bare point and Weighted point across Triangulation_3
2017-04-14 16:48:31 +02:00
3c9063cd88
Trimmed Regular triangulation euclidean traits
...
-- Code added as consequence of disabling implicit conversion between points and
weighted points implies that defining
typedef weighted_point point;
creates ambiguous functors.
This typedef is nevertheless still used, in Weighted_point_mappers.
-- The traits are not supposed to define Bare_point
2017-04-14 15:39:30 +02:00
863584e863
Added CGAL_NO_DEPRECATED_CODE macros to Regular_triangulation_euclidean_traits
2017-04-14 10:59:42 +02:00
2b8684c874
Cleaned #if 0 code
2017-04-12 15:06:03 +02:00
2c79d6e939
Fixed hide_point()
...
Hide weighted points since they can be re-inserted afterwards
2017-04-11 17:04:34 +02:00
77c83642f2
Fixed initialization order warning
2017-04-11 17:04:03 +02:00
2ee5b13e6f
Merge branch 'Kernel_Weighted_point_without_conversion-GF-old' into Kernel_Weighted_point_without_conversion-GF
...
Using Kernel-Fix_weighted_point-GF @ 8703f5c122
2017-04-11 17:01:25 +02:00
93311493c4
Merge pull request #1998 from afabri/CGAL-test_license_check-GF
...
CGAL: Test the license check mechanism
2017-04-07 12:06:23 +02:00
8cbbe0e165
Remove dependencies of Triangulation_3 on Triangulation_2
2017-04-06 11:08:37 +02:00
9a41173936
Added documentation for Robust_weighted_circumcenter_filtered_traits_3
2017-03-28 13:32:12 +02:00
b966dea483
Added documentation for Robust_weighted_circumcenter_filtered_traits_3
2017-03-28 13:32:12 +02:00
6ea82bbe2a
Unnecessary double "if" blocks
2017-03-09 17:46:46 +01:00
ac0dfe3465
version without partial specialization
...
the norms says that partial specialization should be
done in a namespace (not inside a class)
2017-03-06 12:10:24 +01:00
30fe153651
remove hybrid operators, that use Bare points and Weighted points in an ambiguous manner
...
this commit only fixes the testsuite of Mesh_3
2017-03-03 12:14:30 +01:00
741838b9c4
WIP: test_meshing_polyhedron_with_features compiles and crashes in odt
2017-03-02 15:51:41 +01:00
30b7f131d7
Changes after making Weighted_point_3(const Point_3) explicit
2017-02-17 16:38:39 +01:00
c55e391f97
WIP: works with one thread
2017-02-17 16:37:11 +01:00
4922f9e86d
Disable Point_3(const Weighted_point_3&)
2017-02-15 14:33:31 +01:00
45241b92a2
Moved Robust weighted filtered circumcenter traits out of Mesh_3
...
Also, these traits do not derive from Regular_euclidean_traits anymore.
2017-02-13 18:13:19 +01:00
f63f0b801e
Moved Robust weighted filtered circumcenter traits out of Mesh_3
...
Also, these traits do not derive from Regular_euclidean_traits anymore.
2017-02-13 18:13:19 +01:00
2fab595c19
The Weighted_point_mapper becomes a traits class; test_regular_3.cpp passes
2017-02-08 16:24:14 +01:00
a77272be94
Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle
2017-02-03 16:52:51 +01:00
e9398450ab
Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle
2017-02-03 16:52:51 +01:00
50510c05ea
add include directive for license of all GPL header files
...
done using:
ack-grep "^GPL" */package_info/*/license.txt -l | awk -F "/" '{print $1}' > /tmp/gpl_packages
for i in `cat /tmp/gpl_packages | \
grep -v Operations_on_polyhedra | \
grep -v Algebraic_kernel_for_circles | \
grep -v Algebraic_kernel_for_spheres | \
grep -v Polyhedron_IO`;
do
echo $i
python Scripts/developer_scripts/add_license_in_pkg_header.py $i
done
python Scripts/developer_scripts/add_license_in_pkg_header.py Operations_on_polyhedra Polygon_mesh_processing
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_circles Circular_kernel_2
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_spheres Circular_kernel_3
python Scripts/developer_scripts/add_license_in_pkg_header.py Polyhedron_IO Polyhedron
2017-01-19 15:20:25 +01:00
fe5e925367
Merge pull request #1701 from afabri/Convex_hull_3-FaceGraph-GF
...
Convex_hull_3: Switch to FaceGraph
2016-12-30 15:14:34 +01:00
bbf430b0b1
Merge pull request #585 from afabri/Kernel-Weighted_point-GF
...
Introduce Kernel::Weighted_point_3 together with functors
2016-12-20 19:52:02 +01:00
9ee11501ac
Changes after the review by Sebastien
2016-11-30 10:03:00 +01:00
12328929b2
Update LCC tests: now they are done both for CMap and GMap.
2016-11-29 11:43:38 +01:00
2ab268965f
LCC for CMap and GMap; incremental builder; save and load; test.
2016-11-29 11:43:36 +01:00
38f799e82b
star -> link
2016-11-26 10:49:02 +01:00
683490b2aa
star -> link
2016-11-26 10:46:54 +01:00
e5e0cdd5f9
fix a typedef
2016-11-22 17:48:53 +01:00
2a27d4ff38
Fix the Vertex_remover
2016-11-22 16:03:13 +01:00
e26e60dd6c
Add Default to Convex_hull_graph_traits_3; BGLize some code
2016-11-22 12:27:18 +01:00
af1cc4058a
fixes
2016-11-21 18:39:05 +01:00
4d4db0cd70
Move star_to_face_graph() to Triangulation_3
2016-11-21 17:51:41 +01:00
b978fa8fdd
Fix the typedef for the Bare_point
2016-11-21 15:49:43 +01:00
d35c6c913d
Use Weighted_point_mapper_3
2016-11-21 15:33:27 +01:00
4ab59919e6
Use Regular_triangulation_vertex_base_3
2016-11-20 19:06:08 +01:00
310845f01e
Add class Regular_triangulation_vertex_base_3
2016-11-19 11:07:52 +01:00
64832a0d1d
Change template parameter: K -> K_ to help VC++
2016-11-19 08:22:30 +01:00
2835e361c8
Fix the constructors of RT euclidian traits class
...
@janetournois @afabri
That commit will fix both runtime errors in Interpolation and
compilation errors in KDS:
- in Interpolation, the traits class carries a normal vector: it needs
to be passed to the RT traits class as well,
- Same in KDS: the compilation error was saying that the constructor
of RT_euclidian_traits_3 must initialize it base class.
2016-11-18 17:55:05 +01:00
57f0b33eb6
Fix Alpha_shapes_3
...
Alpha_shapes_3 needs to know a lot about its template parameter `Dt`. To
simplify the code, I have chosen to make the typedef `Tr_Base` public in
3D Delaunay and Regular triangulations.
2016-11-18 17:36:50 +01:00
3b5e069325
add constructors to Regular_triangulation_euclidean_traits_3,
...
and fix constructors from Regular_triangulation_3
Revert "introduce Has_nested_type_Bare_point to keep backward compatible"
This reverts part of the commit 98b43b1a49fb2dfb3baee0a532bf5d097f2f4ebd.
2016-11-03 14:57:10 +01:00
0f569a8fd6
introduce Has_nested_type_Bare_point to keep backward compatible
...
it is needed when Regular_triangulation_euclidean_traits is used the first
template parameter for Regular_triangulation (both 2d and 3d)
2016-11-03 14:57:10 +01:00
3353d4d64d
Kernel now refines RegularTriangulationTraits_3
...
ie all CGAL kernels are now models of `RegularTriangulationTraits_3`.
2016-11-03 14:55:39 +01:00
306323d45c
make doc and doc consistent
...
- add "model of Concept" as much as possible in the modified classes/concepts
- fix some links
- update package description of Kernel_23
2016-11-03 14:55:39 +01:00
6af2db1b91
Use Power_side_of_bounded_power_sphere instead of Side_of_bounded_orthogonal_sphere
...
both functors made the same computation, up the sign of the result.
The return type now is CGAL::Bounded_side, which makes things easier
to understand and use
2016-11-03 14:55:39 +01:00
dbb2cc3598
Sign -> Bounded_side; typo in code
2016-11-03 14:53:54 +01:00
ad9d2c369c
Rename tests following Olivier's recommendations
2016-11-03 14:53:54 +01:00
4bcd272a99
compute dual only after infinity test has been performed
2016-11-03 13:10:27 +01:00
ea50fb811d
Cleanup. The 2D and 3D triangulation testsuite pass
2016-11-03 13:07:50 +01:00
9e94ee6178
Change the Power_test
2016-11-03 13:07:17 +01:00
1375cd5c0a
Rename Compute_critical_squared_radius_3 to Compute_power_distance_to_power_sphere_3
2016-11-03 13:07:17 +01:00
34eb29cac5
Documentation
2016-11-03 13:07:17 +01:00
871471b2d8
Remove Weighted_point_triangulation_traits_3
2016-11-03 13:07:17 +01:00
ea6e48e1e4
Don't use the internal traits adapter
2016-11-03 13:07:17 +01:00
5edd015669
Use Weighted_point_triangulation_traits_3
2016-11-03 13:06:42 +01:00
10d9d28d1b
Add Weighted_point_triangulation_traits_3
2016-11-03 13:06:02 +01:00
2d15b06d5e
Remove #ifdef 0 from debugging
2016-11-03 13:06:02 +01:00
42435c2d21
Simplify the use of static filters for Regular triangulations
2016-11-03 13:06:02 +01:00
d0a7c9574c
Simplify the use of static filters for Regular triangulations
2016-11-03 13:06:02 +01:00
6a8f77c5ff
Added CGAL::Weighted_point_3<K> and the predicates and constructions of the Regular Traits to the kernel
...
- The Regular 3 testsuite passes
- only 3D
- not documented
2016-11-03 13:04:43 +01:00
2fbce8a8db
Remove spaces.
2016-10-06 08:26:16 -04:00
7620635cfe
* Bugfix in correct_invalid_attributes in LCC
...
* Remove deprecated code in LCC (that should be removed for CGAL 4.9)
2016-10-06 08:19:04 -04:00
3fac1b31f0
Fix typos (and compilation errors!)
2016-10-03 12:12:46 +02:00
cf8c1a6cdf
Dispatch import functions to Polyhedron, T2, T3
2016-09-30 15:23:15 +02:00
91c6426ae2
Move info_check from T3 to T2
2016-09-30 15:22:28 +02:00
21ad968457
Fix package Triangulation_3: Add #include
2016-09-30 15:22:27 +02:00
fa6ecf39be
Merge branch 'Triangulation-add_regular_tri-cjamin_mglisse-old' into Triangulation-add_regular_tri-cjamin_mglisse
2016-09-09 12:55:43 +02:00
7f3772a50b
replace the usage of raw pointer as property map
...
It was deprecated in boost 1.55
http://www.boost.org/users/history/version_1_55_0.html
2016-07-13 13:53:00 +02:00
9487c71ad1
Merge branch 'Triangulation-add_regular_tri-cjamin_mglisse-old' into Triangulation-add_regular_tri-cjamin_mglisse
2016-05-18 19:41:22 +02:00
1f5fb012ba
Merge pull request #1015 from afabri/Mesh_3-accelerations-GF
...
Accelerate vertex removal in a 3D triangulation and saving a mesh
2016-04-22 15:24:06 +02:00
abd9bfb125
std::map -> boost::unordered_map
2016-04-15 20:54:51 +02:00
535c5bb5b2
Speed-up Triangulation_3::read_cells...
...
... by a factor 5 for big triangulations! The old code was using:
std::map<size_t, Vertex_handle> V;
std::map<size_t, Cell_handle> C;
whereas the indices are contiguous: from 0 to n. `std::vector` is a lot
better for that use case!
2016-04-06 16:03:55 +02:00
64644c8c49
Init the doubles to avoid a warning
2016-03-02 16:31:52 +01:00
5e57abdc50
Merge remote-tracking branch 'cgal/releases/CGAL-4.7-branch' into HEAD
2016-02-18 17:01:59 +01:00
4c477c853c
Accelerete 3D version of inexact_locate as we do it for 2D
2016-02-15 10:57:59 +01:00
760c852430
Fix Periodic_3_regular_triangulation_filtered_traits_3.
...
We need RT::Exact_traits and RT::Filtering_traits.
2016-01-17 20:11:37 +01:00
194dfbf38f
Fix P3RT3::Self : the typedef must provide K to P3RTT3, not RT<K>.
2016-01-17 20:03:30 +01:00
0e6291687e
Periodic_3_regular_triangulation_traits_3 inherites from Regular_triangulation_euclidean_traits_3<K>.
2016-01-17 20:03:30 +01:00
bad32a2446
Add P3RT3::insert(beginIt, endIt).
2016-01-17 20:03:20 +01:00
20dd524de8
Merge branch 'Triangulation-add_regular_tri-cjamin_mglisse-old' into Triangulation-add_regular_tri-cjamin_mglisse
2015-12-08 17:16:16 +01:00
b623100175
split the dual() functions; make the power test check for the absence of weights
2015-12-08 11:27:14 +01:00
4318feeca0
remove deprecated class since CGAL 3.6
2015-11-24 01:15:21 +01:00
003b435a46
Merge branch 'Triangulation-add_regular_tri-cjamin_mglisse-old' into Triangulation-add_regular_tri-cjamin_mglisse
2015-11-20 11:53:44 +01:00
b6c1581456
Fix type
2015-10-28 11:06:46 +01:00
ebf4192456
Add missing copy constructor + improve code/formatting
2015-10-27 12:25:14 +01:00
6fc4dd7dd3
Enable parallel insertion of points with info
...
There was a bug preventing the parallelism to be activated when
using points with info
2015-10-27 12:17:58 +01:00
37ff880fb8
Merge pull request #58 from dfunke/ParallelInsertionWithInfo
...
Enable parallel insertion of points with info
2015-10-22 09:48:56 +02:00
8081234930
Merge branch 'Triangulation-add_regular_tri-cjamin_mglisse-old' into Triangulation-add_regular_tri-cjamin_mglisse
2015-10-16 10:59:18 +02:00
bcb523ba3e
Merge branch 'Triangulation-add_regular_tri-cjamin_mglisse-old' into Triangulation-add_regular_tri-cjamin_mglisse
2015-09-09 14:21:30 +02:00
91543fd382
move header files to TDS_2 and TDS_3
2015-08-23 15:36:12 +02:00
9f14949e69
add missing protecting guards
2015-07-29 08:44:14 +02:00
62906461f2
fix out of array bound warning
2015-07-21 09:12:12 +02:00
b0eae3bebe
remove explicit copy constructor
2015-06-26 17:40:57 +02:00
51eb954081
correct profiler branch name
2015-04-22 13:11:39 +02:00
1c78d67a0f
correct comment
2015-04-22 13:11:21 +02:00
77e2f38d6c
move addition and deletion of tempoary points on far sphere into own methods
2015-04-22 13:10:15 +02:00
8d29fc6e6e
Enable parallel insertion of points with info
2015-04-16 17:40:05 +02:00
5f8ca65abf
Merge branch 'Triangulation-add_regular_tri-cjamin_mglisse-old' into Triangulation-add_regular_tri-cjamin_mglisse
2015-03-25 13:48:38 +01:00
434766c22b
Merge branch 'releases/CGAL-4.5-branch'
...
Approved by the Release Manager.
2015-01-30 11:30:49 +01:00
72e0a3e677
Fix warnings about signed/unsigned
...
The code involved is about TBB.
2015-01-21 12:59:07 +01:00
2f4bb69e0a
Merge branch 'Triangulation-add_regular_tri-cjamin_mglisse-old' into Triangulation-add_regular_tri-cjamin_mglisse
2014-12-18 10:59:01 +01:00
c6de2a50b2
Merge branch 'Triangulation-higher_dimensions-odevil_shornus-old' into Triangulation-higher_dimensions-odevil_shornus
2014-11-20 19:19:23 +01:00
545fe18310
add missing typedef for compilation on Linux
2014-10-03 17:11:08 +02:00
9e921b1d48
add typedef requested as documented
2014-10-02 11:28:43 +02:00
d874698109
fix implementation of Delaunay_triangulation_cell_base_3
2014-10-02 10:49:16 +02:00
03253edf19
Merge branch 'Triangulation-add_regular_tri-cjamin_mglisse-old' into Triangulation-add_regular_tri-cjamin_mglisse
2014-09-09 14:35:38 +02:00
8f259e5dea
Merge branch 'Triangulation-higher_dimensions-odevil_shornus-old' into Triangulation-higher_dimensions-odevil_shornus
2014-09-09 11:20:33 +02:00
3deb8e7910
Merge branch 'Mesh_3-compare_index-GF-old' into Mesh_3-compare_index-GF
...
Create an integration branch for 'Mesh_3-compare_index-GF': a new branch
created from 'master', where I merged the previous version of
'Mesh_3-compare_index-GF'.
There was a conflict with two features recently merged into 'master' for
CGAL-4.5:
- the move of two files from include/CGAL/Mesh_3/ to include/CGAL/. See
the small feature:
http://cgal.org/wiki/Features/Small_Features/New_constructor_in_Label_mesh_domain_3_and_new_function_wrapper
- parallelism for Triangulation_3 and Mesh_3:
http://cgal.org/wiki/Features/Parallel_Mesh_3
Conflicts:
Combinatorial_map/include/CGAL/Cell_attribute.h
Mesh_3/include/CGAL/Implicit_mesh_domain_3.h
Mesh_3/include/CGAL/Labeled_image_mesh_domain_3.h
Mesh_3/include/CGAL/Mesh_3/Sliver_perturber.h
Mesh_3/include/CGAL/Polyhedral_mesh_domain_3.h
Mesh_3/test/Mesh_3/test_meshing_3D_image.cpp
Mesh_3/test/Mesh_3/test_meshing_polyhedron.cpp
Mesh_3/test/Mesh_3/test_meshing_polyhedron_with_features.cpp
Polyhedron/demo/Polyhedron/Polyhedron_type.h
STL_Extension/include/CGAL/Compact_container.h
STL_Extension/test/STL_Extension/test_Compact_container.cpp
I also modified the following files during the conflict resolution:
Linear_cell_complex/include/CGAL/Cell_attribute_with_point.h
Mesh_3/include/CGAL/Labeled_mesh_domain_3.h
Mesh_3/include/CGAL/Polyhedral_mesh_domain_with_features_3.h
2014-07-18 15:47:14 +02:00
fbf824c711
Merge branch 'Mesh_3-parallel-cjamin'
...
This branch introduces parallel algorithms in Triangulation_3 and Mesh_3,
as well as a Concurrent_compact_container. The corresponding features are:
https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Parallel_triangulation_3
https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Parallel_Mesh_3
Tested in CGAL-4.5-Ic-98.
Approved by the Release Manager.
2014-07-17 19:08:24 +02:00
aa1aa597bb
Restore commit a09ed468 with a bug fix
...
"Thread-safe version of incident_cells and incident_facets"
2014-07-15 20:13:30 +02:00
13bb5e38aa
remove unused parameters
2014-07-09 16:02:45 +02:00
d0b222bfac
Fix a bug in finite_adjacent_vertices when dimension()==0
...
When tr.dimension()==0, tr.finite_adjacent_vertices(...)
returned infinite things.
2014-07-08 15:44:26 +02:00
078e89f55f
Add the possibility to remove the far points
...
The far points are added by the parallel version to reduce the contention
on the infinite vertex
2014-07-08 15:37:59 +02:00
da4cf8fc1d
Fix gcc warnings (reorder + unused variables & typedef...)
2014-07-03 15:54:39 +02:00
0a4267b7ce
Temporarily revert "Thread-safe version of incident_cells and incident_facets"
2014-07-03 15:41:02 +02:00
65e8d40e33
Fix warning
2014-07-03 09:26:25 +02:00
982f140911
Use tbb::task_scheduler_init::default_num_threads...
...
... instead of boost:🧵 :hardware_concurrency
2014-07-02 15:10:34 +02:00
55ff0a9404
Add a warning in comments
2014-07-02 10:49:44 +02:00
5a6623c3fa
Move typedef since Vector_3 is not available in all kernels
...
TODO: find a better fix later
2014-07-01 17:00:05 +02:00
e3abf7fc40
Merge branch 'Mesh_3-parallel-cjamin-old' into Mesh_3-parallel-cjamin
2014-07-01 10:38:14 +02:00
7af8f8b768
Fix compilation with GCC
2014-06-30 19:58:44 +02:00
82c89aa58e
Fix template params
2014-06-30 15:52:24 +02:00
a09ed46810
Thread-safe version of incident_cells and incident_facets
2014-06-23 10:45:26 +02:00
48a8abb278
Use Face_circulator for incident_cells_2
2014-06-23 09:20:57 +02:00
9f5927af61
Move function from C3T3_helpers to TDS
...
Move C3T3_helpers::get_incident_cells_without_using_tds_data to TDS::incident_cells_threadsafe
2014-06-23 08:21:09 +02:00
0230e979e2
Merge branch 'CGAL-use_leda-GF-OLD' into CGAL-use_leda-GF
...
Conflicts:
Arrangement_on_surface_2/test/Arrangement_on_surface_2/construction_test_suite_generator.cpp
Arrangement_on_surface_2/test/Arrangement_on_surface_2/test_construction.cpp
Documentation/doc/Installation.txt
Kernel_23/include/CGAL/Exact_predicates_exact_constructions_kernel.h
2014-06-18 22:50:06 +02:00
30e47d01a1
Added the ability to export the surface
2014-06-17 14:54:10 +02:00
eebad0e1a4
Add applications to help comparison between T2/T3 and Td
2014-06-16 19:35:04 +02:00
c496b52d0c
The documentation of the member function swap is added.
...
rhs is renamed other in this member function.
2014-06-04 14:38:34 +02:00
250c079439
Implement the copy-and-swap idiom for the assigment operator.
2014-06-04 14:04:52 +02:00
144545cbf2
Fix Regular_triangulation_cell_base_with_weighted_circumcenter_3.
...
The default value for the template parameter 'Cell base' is replaced by
Regular_triangulation_cell_base_3. (The doc is updated.)
The operator= is fixed.
A test file is added for this class.
Trivial bug-fix for master
2014-06-03 19:34:29 +02:00
7145f7db0b
Replaced some C++11 lambda functions by functors +change mutex (static=>member)
2014-06-03 18:18:12 +02:00
05efa677a1
Merge branch 'Triangulation-higher_dimensions-odevil_shornus-old' into Triangulation-higher_dimensions-odevil_shornus
...
Conflicts:
NewKernel_d/include/CGAL/NewKernel_d/Cartesian_LA_functors.h
NewKernel_d/test/NewKernel_d/Epick_d.cpp
2014-05-28 14:53:26 +02:00
c9c8335811
More code clean-up
2014-05-27 13:46:34 +02:00
ce17a717c7
Restore some profiling code and remove some
2014-05-27 13:33:33 +02:00
2f78d27bd3
Code clean-up
2014-05-27 13:21:16 +02:00
dfe800bc40
Clean-up debug code (global lock)
2014-05-27 12:16:29 +02:00
3fa09693a3
Merge branch 'Mesh_3-compare_index-GF-old' into Mesh_3-compare_index-GF
...
Conflicts:
Mesh_3/include/CGAL/Mesh_3/Detect_features_in_polyhedra.h
Mesh_3/include/CGAL/Mesh_domain_with_polyline_features_3.h
Mesh_3/include/CGAL/Mesh_polyhedron_3.h
Mesh_3/test/Mesh_3/test_meshing_polylines_only.cpp
STL_Extension/include/CGAL/Compact_container.h
STL_Extension/test/STL_Extension/test_Compact_container.cpp
2014-05-21 18:24:17 +02:00
f3c00442fd
Merge branch 'Mesh_3-parallel-cjamin-old' into Mesh_3-parallel-cjamin
2014-05-14 19:05:40 +02:00
db3a642de4
Missing include
2014-05-14 17:35:16 +02:00
7e00af50f5
Merge branch 'Triangulation_3-faster_incident_edges-GF'
...
Approved by the release manager
2014-05-14 17:03:41 +02:00
e97506adb7
Merge branch 'Triangulation_3-regular_cell_base_with_circumcenter-GF'
...
Resolve conflicts in Mesh_3/include/CGAL/Mesh_3/config.h
This branch implements the small feature described here :
https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/circumcenter%28%29_in_RT3_cell_base
It makes consistent implementations of dual(cell) in RT3 and DT3 :
they both return cell->circumcenter(gt) now
Approved by the release manager
2014-05-13 14:52:13 +02:00
8bc6e6136d
fix a warning from clang. Actually highlighted a real error : gt was missing
2014-05-12 14:55:11 +02:00
3d0e6f2a4f
boost::unorerdered_set::reserve() was only introduced with Boost 1.50
2014-05-09 11:08:38 +02:00
1ff9694206
int -> std::size_t
2014-05-08 13:41:33 +02:00
3cc64eb19e
Call unordered_set::reserve()
2014-05-07 11:51:25 +02:00
2ed094d23c
cleanup
2014-05-07 11:14:36 +02:00
d1a6046fcd
Vertex_extractor gets a partial specialisation for Vertex::Has_visited
2014-05-07 11:00:05 +02:00
09876e23fa
Add bool visited to the Vertex in order to avoid a map
2014-04-29 14:04:27 +02:00
3812e53d64
Add flat_set
2014-04-29 06:47:32 +02:00
d74653ece0
Replace std::map by boost::unordered_map in TDS_3::incident_edges
2014-04-28 16:18:13 +02:00
Mael Rouxel-Labbé
Jane Tournois
Sébastien Loriot
Andreas Fabri
Laurent Rineau
Clement Jamin
Guillaume Damiand
Aymeric PELLE
Sebastien Loriot
Daniel Funke