Commit Graph

210 Commits

Author SHA1 Message Date
albert-github 3674c937f7 spelling corrections
Some spelling corrections (Directories starting with `M`-` N`),
some backward work
some forward work
2022-11-15 15:21:01 +01:00
Andreas Fabri c352a9cd28 Address -Wunused-but-set-variable 2022-10-11 07:45:45 +01:00
Laurent Rineau 8a1c379e04 Merge pull request #6683 from lrineau/Nef_S2-fix_use_after_free-GF
Nef_S2: Fix a use-after-free
2022-06-29 09:50:39 +02:00
Laurent Rineau 6e8f312437 Fix a use-after-free
In the expression `M[--L.end()] = M[start];`, the hash map `M` can be
rehashed during the evaluation of the expression. That can lead to a
use-after-free when the reference to `M[start]` is loaded, and the evaluation
of `M[--L.end()]` triggers a rehash, and invalidates the reference to
`M[start]`.
2022-06-20 11:58:40 +02:00
Sebastien Loriot 0e0b813736
Merge pull request #6471 from GilesBathgate/Nef_3-performance_stdmap-GilesBathgate
Nef_3: Performance std::map -> std::unordered_map
2022-05-13 15:47:24 +02:00
Giles Bathgate 8770c7a0cd
Update Nef_S2/include/CGAL/Nef_S2/ID_support_handler.h
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2022-05-10 12:06:32 +01:00
Andreas Fabri 2a5fcdcfb1 Add reserve() in generic code and change comment to avoid warning 2022-04-13 12:59:21 +01:00
Giles Bathgate 9cdf8ba469 Use cross product instead of Plane_Plane intersection line 2022-04-02 18:10:06 +01:00
Sébastien Loriot 99f0598f3e Merge pull request #6378 from GilesBathgate/Nef_3-performance_sphere_circle-GilesBathgate
Nef_3: Sphere circle constructors.
2022-03-29 17:45:52 +02:00
Giles Bathgate 16bed97ec5 Remove sizing of hash tables in copy constructors, size just grows 2022-03-17 20:21:12 +00:00
Andreas Fabri 9a50014cc3 locally tested :< 2022-03-17 14:08:23 +01:00
Andreas Fabri bfebf2cd6f Change at two more places 2022-03-17 13:48:26 +01:00
Giles Bathgate 42cff9ee28 Use new kernel functors 2022-03-14 21:46:30 +00:00
Giles Bathgate 34da7cc64c Init hashtable size in Sphere_map 2022-03-11 21:27:32 +00:00
Giles Bathgate 933604b1e6 Init hashtable size in SNC_structure 2022-03-11 21:27:32 +00:00
Giles Bathgate ada0800a4f Prepare code for improvements to Kernel functors 2022-03-10 23:51:15 +00:00
Giles Bathgate 5136fea47a Rotate the parameters to orthogonal_vector, keep same parity of the permutation 2022-03-10 21:08:45 +00:00
Giles Bathgate 9e7e555024 Use functor instead of global function, tidy degenerate case 2022-03-09 17:42:00 +00:00
Giles Bathgate 1e26a739c5 Rename tag to Assume_d_equal_0 2022-03-08 08:18:16 +00:00
Giles Bathgate 57e9fa449d Add comment, and use is_zero 2022-03-04 17:35:00 +00:00
Giles Bathgate c6ae1fb238 Use conventional method for calling base members 2022-03-03 19:45:06 +00:00
Giles Bathgate a0d5fae2bd Add Origin based constructor to sphere_point and avoid conditional constructor 2022-03-03 18:55:37 +00:00
Mael Rouxel-Labbé 521c72d57e Fix typos 2021-10-04 13:34:07 +02:00
Sébastien Loriot 142fac63b5 Merge pull request #5699 from GilesBathgate/Nef_3-snc_decorator_deduplication-GilesBathgate
Remove duplicate code in SNC_const_decorator/SNC_decorator
2021-06-25 09:47:59 +02:00
Giles Bathgate 0572bc5f25 Rename pole function to orthogonal_pole 2021-06-13 17:03:52 +01:00
Giles Bathgate 6fb1928ab4 Use CGAL::ORIGIN instead of Point_3(0,0,0) in Sphere_segment 2021-06-13 17:03:52 +01:00
Giles Bathgate cb26fcb831 Remove code duplication in Sphere_segment 2021-06-13 17:03:50 +01:00
Giles Bathgate 5e3c93fa45 Add required headers to Sphere_segment 2021-06-13 17:03:05 +01:00
Laurent Rineau e3d5fccf5b Merge pull request #5684 from GilesBathgate/Nef_3-performance_snc_constructor-GilesBathgate
Nef_3 performance - has_on_after_intersection in SNC_constructor
2021-05-19 17:24:08 +02:00
Laurent Rineau 2c4a5db3ce Merge pull request #5631 from GilesBathgate/STL_ext-fix_uncaught_exceptions_cleanup-GilesBathgate
Fix uncaught exceptions cleanup
2021-05-18 18:14:14 +02:00
Giles Bathgate 77054d4f2a Remove duplicate code in SNC_const_decorator/SNC_decorator 2021-05-10 18:26:29 +01:00
Giles Bathgate a6b05d083e Use has_on_after_intersection in Sphere_segment 2021-05-07 22:59:28 +01:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Sébastien Loriot fb6f703b55 IO namespace for files in IO directories 2021-05-04 14:36:06 +02:00
Giles Bathgate 5ecd85248a Fix capitalisation of macro name. 2021-04-28 21:03:45 +01:00
Giles Bathgate 0ef8127c71 The CGAL_NOEXCEPT macro is no longer needed 2021-04-28 21:03:00 +01:00
Laurent Rineau 31b817c419 Merge pull request #5233 from GilesBathgate/fix-uncaught-exceptions
Fix uncaught exceptions
2021-04-06 15:13:16 +02:00
Laurent Rineau de704d8bb9 Merge pull request #5522 from afabri/Nef_3-accelerate_do_intersect_internally-GF
Nef_3: Do not test has_on for a point where we know that it will be true
2021-04-06 15:13:07 +02:00
Laurent Rineau 1686e05d3f Merge pull request #5438 from GilesBathgate/performance-object-index
Calculate indices only when required.
2021-03-24 15:05:34 +01:00
Andreas Fabri 2334ec5f4b s gets constructed from a vertex some lines above 2021-03-10 18:40:03 +00:00
Andreas Fabri 6d9ff5978e Do not test has_on for a constructed point where we know that it will be true 2021-03-10 16:19:32 +00:00
Laurent Rineau 85ca8bf2d7 Merge pull request #5157 from GilesBathgate/sphere-predicates-tidy
Possible technical debt in sphere_predicates.h
2021-02-18 21:02:40 +01:00
Giles Bathgate 9c6712c3b1 Calculate indices correctly when trace enabled 2021-02-08 19:32:33 +00:00
Giles Bathgate 87d114137f Calculate indices only when required in check_integrity_and_topological_planarity 2021-02-07 09:52:45 +00:00
Laurent Rineau e1870c1522 Merge pull request #5371 from maxGimeno/Fix_Nesf_2_parser-maxGimeno
Fix OOB issues in Nef_*
2021-02-05 16:10:29 +01:00
Maxime Gimeno 2e592e0027 Fix typo and use setstate 2021-01-20 08:38:33 +01:00
Maxime Gimeno 9e291e6bbf replace cerr by CGAL_warning_msg 2021-01-19 14:04:54 +01:00
Maxime Gimeno 618b409b0f Fix Nef_2 and Nef_S2 IO 2021-01-18 15:40:40 +01:00
Giles Bathgate e222a423af Fix uncaught exception in Nef_polyhedron_S2.h 2020-11-29 11:30:21 +00:00
Giles Bathgate 35c148078c Fix uncaught exception in Sphere_map.h 2020-11-28 20:26:00 +00:00