Commit Graph

2122 Commits

Author SHA1 Message Date
Laurent Rineau f14ab371ae Test move-assignments 2021-02-01 23:17:46 +01:00
Laurent Rineau de8bf2fd87 Fix Triangulation_hierarchy_3::operator=(Triangulation_hierarchy_3&&) 2021-02-01 23:17:21 +01:00
Laurent Rineau fe99ad3a2f Check that a moved-from triangulation can be assigned 2021-02-01 21:06:47 +01:00
Laurent Rineau 3b0cea9a47 Check that clear() can be called on a moved-from triangulation 2021-02-01 20:43:42 +01:00
Laurent Rineau 0e0c536c02 Do not test is_valid(): a moved-from triangulation is not valid
A moved-from triangulation do not have the infinite vertex, and it is
of dimension -2. That is a valid TDS, but not a valid CGAL
triangulation.
2021-02-01 20:42:49 +01:00
Laurent Rineau ba9f226891 Add tests for move constructors 2021-02-01 14:47:18 +01:00
Laurent Rineau f218fb8d3a Fix the segfault in the previous commit (WIP: Second try) 2021-02-01 14:46:42 +01:00
Sébastien Loriot f69be333f0 Merge remote-tracking branch 'cgal/5.2.x-branch' into CGAL-remove_bind 2021-01-29 18:44:50 +01:00
Laurent Rineau b4256accb9 WIP: Second try
Something is off, because the test suite does not pass.
2021-01-28 16:04:27 +01:00
Laurent Rineau ce75d010e9 First try: use nullptr as a criterion to detect a moved-from object 2021-01-28 14:19:22 +01:00
Maxime Gimeno a85cf6ed52 Move the include in the ifdef 2021-01-26 09:45:18 +01:00
Laurent Rineau 929eb4fdf9 Merge pull request #5317 from afabri/Triangulation_3-dont_divide_by_enum_in_hierarchy-GF
Triangulation_3: Construct double to avoid VC++ warning C5055
2021-01-21 16:26:25 +01:00
Maxime Gimeno 04753381e5 Rename file and add ::Qt 2021-01-12 13:22:34 +01:00
Maxime Gimeno 95192d6d4b factorize context initialization 2021-01-12 13:08:58 +01:00
Maxime Gimeno 17e83d573d Fix demos 2021-01-08 11:40:09 +01:00
Maxime Gimeno 3d1c41fd14 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2021-01-07 15:05:28 +01:00
Maxime Gimeno 2a212bb2a8 Upgrade non-compatibility sahders in Basic_viewer to glsl 150 and add a context creation before the creation of the QApp in draw_xxx examples 2021-01-07 13:06:40 +01:00
Laurent Rineau d6f76d4f87 Merge pull request #5299 from maxGimeno/Checks_in_github-maxGimeno
CI: Add Checks in GitHub Actions
2021-01-06 16:11:08 +01:00
Laurent Rineau fee181b6eb Merge pull request #5299 from maxGimeno/Checks_in_github-maxGimeno
CI: Add Checks in GitHub Actions
2021-01-06 16:04:47 +01:00
Sébastien Loriot 1e249afdb3 remove some boost::bind 2021-01-06 12:59:11 +01:00
Andreas Fabri 24c9ef34b7 Constrcut double to avoid VC++ warning C5055 2021-01-01 10:38:31 +00:00
Maxime Gimeno fc4fc891e7 Fix dependencies 2020-12-29 14:33:49 +01:00
Maxime Gimeno 7a568c6a0c Fmore fixes 2020-12-01 15:08:56 +01:00
Maxime Gimeno 493f034fda Fix some warnings 2020-11-23 11:06:59 +01:00
Giles Bathgate b95de74a7a Fix uninitialized member in Triangulation_3.h 2020-11-18 21:26:59 +00:00
Maxime Gimeno 3b70343590 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-11-16 16:19:43 +01:00
Maxime Gimeno 8e23d5c482 Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-11-10 09:00:41 +01:00
Jane Tournois 10a28d1262 attempt to fix "variable used non initialized" 2020-11-05 11:13:26 +01:00
Jane Tournois b87e226ebb Simplex_3 can be dereferenced in range-for-loop (not Cell_handle)
this error was found thanks to a clang warning :
warning: loop variable 's' has type 'const Simplex &' (aka 'const Triangulation_simplex_3&')
but is initialized with type
'CGAL::Triangulation_segment_simplex_iterator_3' resulting in a copy [-Wrange-loop-construct]
2020-11-03 18:53:02 +01:00
Jane Tournois 667171927a fix uninitialized parameter, and member, warnings 2020-11-03 17:57:30 +01:00
Jane Tournois 41e1e40827 fix the case ...-vertex-cell-end 2020-10-29 11:59:02 +01:00
Jane Tournois 9152be7543 remove useless and undocumented include 2020-10-27 15:32:34 +01:00
Jane Tournois d48aa33305 fix degenerate some degenerate cases
in particular iterations ending with :
- cell-vertex-facet
- vertex-edge-vertex
- cell-vertex-facet
2020-10-27 15:32:01 +01:00
Jane Tournois 52a2265bda remove useless comments 2020-10-20 14:08:03 +02:00
Maxime Gimeno bebd60c12b Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-10-20 09:53:54 +02:00
Jane Tournois 2bf4da4edc Merge branch 'master' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF
# Conflicts:
#	Installation/CHANGES.md
2020-10-19 16:27:04 +02:00
Jane Tournois 478cd5be9f remove outdated doxygen parameters 2020-10-13 17:40:29 +02:00
Jane Tournois ca4526983d reintroduce complete test 2020-10-13 17:13:01 +02:00
Mael Rouxel-Labbé f55ef7dd50 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-10-09 18:36:17 +02:00
Jane Tournois c76f41b92b segment intersects cells, not the other way around 2020-09-29 10:17:31 +02:00
Jane Tournois f7806b63ea do not duplicate point creation that blur the examples 2020-09-28 18:14:56 +02:00
Jane Tournois 57250ce637 Merge remote-tracking branch 'cgal/master' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF
# Conflicts:
#	Installation/CHANGES.md
2020-09-28 16:01:05 +02:00
Jane Tournois 5c8df6672a remove CGAL_CFG_MATCHING_BUG_ variants
the "matching bug" of msvc has been fixed since at least vs 2015
2020-09-25 14:25:14 +02:00
Mael Rouxel-Labbé 8682f9bafb Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-08-24 11:45:17 +02:00
Maxime Gimeno 9c15f2c9dc Use FeatureSummary in the demo, and remove CGAL_FOUND 2020-08-04 12:46:17 +02:00
Laurent Rineau 022b1a71d0 Merge branch 'releases/CGAL-5.0-branch' 2020-07-21 15:27:49 +02:00
Laurent Rineau 2e8a59d570 Merge branch 'releases/CGAL-4.14-branch' into releases/CGAL-5.0-branch 2020-07-21 15:25:54 +02:00
Sébastien Loriot a92692160b please old libstd version (prior to 6) having issues with tuple and init-list 2020-07-21 11:26:53 +02:00
Sébastien Loriot 0a530e39e7 remove extra const 2020-07-20 15:28:50 +02:00
Laurent Rineau 1e6a5ac636 Fix the use of Construct_point_3::result in Periodic_3 2020-07-16 15:11:23 +02:00
Maxime Gimeno 41175cd505 WIP 2020-07-16 14:47:41 +02:00
Jane Tournois e7bfe4cb6f add missing license header 2020-07-06 15:27:16 +02:00
Jane Tournois f5128ae1c6 fix release number in doc 2020-07-06 10:28:14 +02:00
Jane Tournois 5f9d38df29 reintroduce (fixed) grid test 2020-07-06 08:19:30 +02:00
Jane Tournois ea3ef4f1b7 ltnext can also be OUTSIDE_AFFINE_HULL, not necessarily facet
in particular when query segment ends on a vertex
2020-07-06 08:19:12 +02:00
Jane Tournois 9e8d12d9cf Merge remote-tracking branch 'cgal/master' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF
# Conflicts:
#	Installation/CHANGES.md
2020-07-06 06:57:32 +02:00
Jane Tournois 99ea974425 remove unnecessary includes 2020-07-06 06:54:05 +02:00
Jane Tournois 3ec4c5460a fix license header 2020-07-06 06:53:49 +02:00
Jane Tournois 4eb10d8323 fix license header 2020-07-06 06:44:00 +02:00
Laurent Rineau 07eacf5231 Merge pull request #4795 from janetournois/Mesh_3-fix_optimisers_parallel-jtournois
Mesh_3 - fix parallel optimisers
2020-06-30 16:38:05 +02:00
Laurent Rineau ad23db27a3 Merge pull request #4795 from janetournois/Mesh_3-fix_optimisers_parallel-jtournois
Mesh_3 - fix parallel optimisers
2020-06-30 16:36:58 +02:00
Jane Tournois bce4b4e80a Revert "add an assertion in make_canonical"
This reverts commit f55ffabbe0.
In the exuder, it can happen that this function takes the triple
(Vertex_handle(), Vertex_handle(), Vertex_handle())
so the assertion does not hold
2020-06-26 14:57:02 +02:00
Laurent Rineau bcf8409e46 Merge pull request #4611 from rathod-sahaab/replace-throws-with-noexcept
replaced throw() with noexcept
2020-06-23 18:50:20 +02:00
Mael Rouxel-Labbé 9cca59ba36 Actually use the new IO functions + some example improvements 2020-06-23 18:24:39 +02:00
Mael Rouxel-Labbé 24d2ee9c75 Use the new IO functions in Point_set_3 / PSP_3 examples 2020-06-21 15:06:20 +02:00
Jane Tournois 3b8c06f836 fix adjacent_vertices_threadsafe
internal::Has_member_visited<Vertex> is not threadsafe
2020-06-19 13:31:52 +02:00
Jane Tournois daaf92d0ac rename make_canonical() to make_canonical_oriented_triple()
to make it more explicit
2020-06-19 13:31:51 +02:00
Jane Tournois f55ffabbe0 add an assertion in make_canonical
it also helps to make the code more explicit
2020-06-19 13:31:51 +02:00
Jane Tournois ad9c357f33 add adjacent_vertices_threadsafe and use it in nearest_power_vertex() 2020-06-19 13:31:50 +02:00
Maxime Gimeno ea53a8d70d Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-06-17 14:25:21 +02:00
Maxime Gimeno 25c8313859 Replace IO functions in examples and fix Surface_mesh read_OFF() 2020-06-16 14:36:24 +02:00
Maxime Gimeno 08ce5f17a8 Fix more warnings 2020-06-15 10:37:58 +02:00
Laurent Rineau 9b8ecd720b Merge pull request #4636 from sgiraudot/CMake-Third_party_imported_targets-GF
CMake: Use Imported Targets for 3rd Party Libs
2020-06-05 17:54:14 +02:00
Laurent Rineau dcc4fb1cc1 Merge remote-tracking branch 'cgal/master' into CGAL-move_semantic_for_triangulations-GF
# Conflicts:
#	STL_Extension/include/CGAL/Compact_container.h
2020-05-20 09:46:26 +02:00
Maxime Gimeno 049439fa6b Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-04-30 16:47:58 +02:00
Simon Giraudot 1dd6a665a1 Merge remote-tracking branch 'mine/CMake-Third_party_imported_targets-GF' into CMake-Third_party_imported_targets-GF 2020-04-20 09:09:32 +02:00
Jane Tournois 9a722c4ef1
Merge branch 'master' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF 2020-04-20 06:40:24 +02:00
Jane Tournois 12c9169000 implementation history 2020-04-16 15:05:02 +02:00
Jane Tournois 570b8cfe42 remove all \cgalModifBegin and \cgalModifEnd 2020-04-16 14:35:52 +02:00
Jane Tournois 0e45fdc64e use "permanent" coplanar_orientation() and collinear()
instead of generating it on the fly each time
2020-04-16 14:18:01 +02:00
Simon Giraudot 12a51af61f Fixes for imported targets 2020-04-15 15:02:49 +02:00
Simon Giraudot 421096fd7f Use imported targets everywhere 2020-04-15 14:06:13 +02:00
Jane Tournois 2105aebb13 add missing data 2020-04-14 15:11:50 +02:00
Sébastien Loriot a49881536d fix compilation errors and warnings 2020-04-10 18:30:50 +02:00
Sébastien Loriot d845d6ce8d Merge remote-tracking branch 'cgal/master' 2020-04-10 18:16:18 +02:00
Sébastien Loriot 2876ad9af1 remove trailing whitespaces 2020-04-10 18:15:32 +02:00
Jane Tournois e2df1a83aa temporarily disable a test 2020-04-10 16:36:16 +02:00
Mael Rouxel-Labbé c16c1a7ea3 Merge remote-tracking branch 'cgal/master' into CGAL-Optimal_bounding_box-GF 2020-04-10 16:10:11 +02:00
Jane Tournois 1c6ef8dc8e fix examples in doc 2020-04-07 08:07:17 +02:00
Jane Tournois 163f3c59fb add range iterators 2020-04-07 07:05:19 +02:00
Jane Tournois a69d3f1188 replace all the std::get<i>(tuple) by private accessors
the code gets easier to read and write
2020-04-06 13:23:39 +02:00
Jane Tournois 2eadd494a8 replace CGAL::cpp11::tuple by std::tuple 2020-04-06 07:02:21 +02:00
Jane Tournois 1ef0d4b83d segment traverser end() does not need s and t as parameters
the API gets simpler and easier with these changes

+ fix last valid value of the simplex iterator in some cases

after this commit, only the test test_triangulation_on_a_grid() keeps failing
2020-04-03 18:02:37 +02:00
Jane Tournois 082cf96409 add segment cell iterator description in the doc 2020-04-03 15:06:18 +02:00
Jane Tournois 5377911c81 add input data 2020-04-03 07:31:06 +02:00
Jane Tournois 101262fcd7 doc : add iterator type and value type for both iterators 2020-04-03 07:12:25 +02:00
Jane Tournois b9660603b9 add the new API in the code
and adapt examples and tests consistently
2020-04-03 06:52:25 +02:00
Maxime Gimeno b6a5f23e4e remove trailing whitespaces 2020-04-02 15:02:27 +02:00
rathod-sahaab dbbee667af replaced throw() with noexcept 2020-04-02 18:31:00 +05:30
Maxime Gimeno e02a3fc37e Merge remote-tracking branch 'cgal/master' into TDS-file_input-maxGimeno 2020-04-02 15:00:23 +02:00
Maxime Gimeno 383eb3d147 Merge tag 'master_before_no_tws_nor_tabs' into TDS-file_input-maxGimeno 2020-04-02 14:56:03 +02:00
Jane Tournois 3aae44f631 apply Monique's doc review 2020-04-02 07:44:53 +02:00
Maxime Gimeno abc623d5a8 clean-up 2020-04-01 15:03:43 +02:00
Jane Tournois a1b292e805 Merge remote-tracking branch 'cgal/master' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF 2020-04-01 13:52:57 +01:00
Maxime Gimeno 69a2a23cc6 rename IO functions in point_set packages 2020-04-01 14:33:14 +02:00
Maxime Gimeno 4e6fb685c6 Merge remote-tracking branch 'mine/CGAL_IO-maxGimeno' into HEAD 2020-03-27 11:11:10 +01:00
Maxime Gimeno 9c0648a004 Merge tag 'master_before_no_tws_nor_tabs' into CGAL_IO-maxGimeno 2020-03-27 11:05:43 +01:00
Sébastien Loriot d1a323c730 extra run of the script to remove tabs and trailing whitespaces 2020-03-26 19:24:14 +01:00
Sébastien Loriot 86e25f7e71 Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:23:54 +01:00
Sébastien Loriot 9f2eafd06e extra run of the script to remove tabs and trailing whitespaces 2020-03-26 19:17:02 +01:00
Sébastien Loriot 35b83deffd Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:16:25 +01:00
Sébastien Loriot 8bb22d5b2c extra run of the script to remove tabs and trailing whitespaces
right after the merge of the 5.0 release branch

+ manual fix of the files (indentation was changed in the meantime):
   * Spatial_sorting/include/CGAL/Multiscale_sort.h
   * Spatial_sorting/test/Spatial_sorting/test_multiscale.cpp
2020-03-26 14:26:59 +01:00
Sébastien Loriot 8b153fb495 Merge branch 'cgal/releases/CGAL-5.0-branch'
whitespace+tab removal, merged with option -Xignore-space-change
2020-03-26 14:22:32 +01:00
Sébastien Loriot 0779373835 extra run of the script to remove tabs and trailing whitespaces
right after the  merge of 4.14 release branch

+ manual fix on one line in:
    * Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
    * .travis/generate_travis.sh
2020-03-26 14:16:06 +01:00
Sébastien Loriot 0a46621dc6 Merge branch 'cgal/releases/CGAL-4.14-branch'
whitespace+tab removal, merged with option -Xignore-all-space
2020-03-26 13:28:46 +01:00
Sébastien Loriot 590612a563 run the script to remove tabs and trailing whitespaces 2020-03-26 13:25:16 +01:00
Mael Rouxel-Labbé 2556196dad Merge remote-tracking branch 'cgal/master' into CGAL-Optimal_bounding_box-GF 2020-03-23 08:59:49 +01:00
Sébastien Loriot 149c7a4afc Merge remote-tracking branch 'cgal/releases/CGAL-5.0-branch' 2020-03-19 16:29:33 +01:00
Sébastien Loriot d10359d09e Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' 2020-03-19 16:27:55 +01:00
Mael Rouxel-Labbé 30d4754a04 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-03-17 09:03:12 +01:00
Mael Rouxel-Labbé 100304667d Remove CGAL::internal::boost_::function_property_map
This file was duplicated from BOOST 1.64 because it appeared in a boost
release that was younger than the oldest boost release supported by CGAL
when the file was first required.

The minimum boost version (1.57) now required by CGAL is younger
than the version in which the file appeared in boost (1.51)
and it can thus be removed.
2020-03-12 20:58:44 +01:00
Mael Rouxel-Labbé a846a1e19c Remove long-deprecated convex_hull_3_to_polyhedron_3()
Use convex_hull_3_to_face_graph()
2020-03-10 14:20:17 +01:00
Mael Rouxel-Labbé fe1fd95d23 Fix always returning by copy when it is possible to return by reference 2020-03-09 15:31:51 +01:00
Maxime Gimeno 52cf9815e4 Remove free function and fix TDS3 test 2020-02-28 15:33:03 +01:00
Maxime Gimeno a7a768cae9 more doc fixes 2020-02-28 09:09:55 +01:00
Maxime Gimeno 74a38bd616 Fixes in the doc 2020-02-27 11:43:31 +01:00
Maxime Gimeno 14669c213c Doc 2020-02-26 12:32:05 +01:00
Maxime Gimeno 66cd3401f9 Add a generic function in TDS_3 that takes a boolean argument to decide how to take care of the infinite_vertex, and use it in the T3 functions. 2020-02-26 10:57:55 +01:00
Laurent Rineau 7508a6f93c Merge remote-tracking branch 'cgal/master' into CGAL-move_semantic_for_triangulations-GF 2020-02-12 17:05:49 +01:00
Laurent Rineau 24082a7114 Fix compilation errors, with a few compiler
```
include/CGAL/Triangulation_hierarchy_3.h:163:23: error: invalid use of 'this' at top level
     noexcept(noexcept(this->Tr_Base::swap(tr)))
                       ^~~~
```

That is actually the subject of a C++ Defect:
http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1207

Anyway, this was used only for the `noexcept` specification of `swap`
functions, and I no longer use `swap` for the move semantic. I can
remove those noexcept` specifications.
2020-02-12 16:30:26 +01:00
Guillaume Damiand 72cb67bfff Allows to deal with weighted points. 2020-02-12 10:34:15 +01:00
Mael 35f895db66
Merge branch 'master' into Spatial_sort-parallel-GF 2020-02-06 12:00:33 +01:00
Laurent Rineau 4261d4635b Less use of swap 2020-02-04 10:12:29 +01:00
Laurent Rineau 20bb2c8428 Add move-semantic to CT_plus_2 and Tr_hierarchy_2 2020-01-31 16:28:07 +01:00
Laurent Rineau 290c3a2011 I forgot Triangulation_hierarchy_3 (Fast_location)!
Note that a move-from object of class `Triangulation_hierarchy_3` is
not really valid. I have just verified that it can be destroyed. Even
a call to `clear()` on a moved-from hierarchy will segfault!

To be fixed later...
2020-01-31 13:22:11 +01:00
Laurent Rineau b311ab59ed [modernize-use-nullptr] (clang-tidy) 2020-01-31 12:11:16 +01:00
Laurent Rineau 2717864bd7 Fix warnings cppcoreguidelines-special-member-functions (clang-tidy)
- Remove trivial copy-constructors that prevents the compiler to
  generate the other special member functions.
2020-01-31 12:08:05 +01:00
Laurent Rineau b56cdcb743 Add move-semantic to CGAL (non-periodic) 3D triangulations
- For `Triangulation_3`, the rule-of-zero cannot be used, because of
  the infinite vertex. A special copy-constructor and copy-assignment
  operators are required. But one can `= default the move-constructor
  and move-assignment operator, as well as the destructor.
- For `Delaunay_triangulation_3`, the rule-of-zero is
  sufficient. Nothing to do.
- For `Regular_triangulation_3`, the `hidden_point_visitor` data
  member is a function that is constructed with the `this` pointer, so
  the rule-of-zero cannot be used. Probably the move-constructor
  and move-assignment operator could be explicitly defaulted.
2020-01-31 12:01:43 +01:00
Jane Tournois e8de87a141 traverser documentation
Merge commit 'a09e3bfb278deb0630d1dac5c799ecd41fe428ca' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF

# Conflicts:
#	Triangulation_3/doc/Triangulation_3/CGAL/Triangulation_3.h
2020-01-28 16:05:24 +01:00
Jane Tournois e54cc309d4 doc 2020-01-28 15:35:17 +01:00
Maxime Gimeno 35600534f0 fixes 2020-01-21 10:05:19 +01:00
Jane Tournois a09e3bfb27 WIP on Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF: 145ed35cd0 doc after Monique's review 2020-01-20 16:02:04 +00:00
Mael Rouxel-Labbé 828e47f61e Fix some header includes 2020-01-17 17:55:53 +01:00
Maxime Gimeno 85712ba28c WIP replacing tbb deprecated includes. 2020-01-14 15:03:20 +01:00
Maxime Gimeno 7964028590 More doc 2020-01-13 15:48:38 +01:00
Maxime Gimeno 065a7ac0c6 Add a test for file_input() 2020-01-10 13:14:31 +01:00
Maxime Gimeno 9fe491adfb Update license header 2020-01-10 11:54:48 +01:00
Maxime Gimeno 82bcfb7087 Add license and remove need for operator(const C&), which cannot be called. 2020-01-09 10:01:31 +01:00
Maxime Gimeno 2bfdc8398f Move the file_input.h file to Triangulation_3 and write some doc. Unify with the API of copy_tds() and adapt the c3t3_io plugin. 2020-01-08 16:37:39 +01:00
Laurent Rineau 674627937c Merge pull request #4389 from lrineau/DT_3-issue4388-GF
Fix  DT3 parallel performance loss (issue #4388)
2019-12-17 09:16:52 +01:00