Commit Graph

102 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé e1b7c4726e Replace boost::optional with std::optional
See https://github.com/CGAL/cgal/pull/7526
2025-01-16 13:45:12 +01:00
Laurent Rineau 797c056577 Prevent_deref, major changes
Now the second parameter is the `reference` type and no longer the `value_type`.
2024-05-21 08:53:48 +02:00
albert-github a0320dd7b4 Merge branch 'master' into feature/issue_7395
# Conflicts:
#	Polyhedron/doc/Polyhedron/Concepts/PolyhedronItems_3.h
2023-07-13 10:33:18 +02:00
albert-github 301728a8a9 issue #7395 Improvement of layout of model relations
- Completed the cgalModels part
2023-07-09 12:43:36 +02:00
Laurent Rineau 7e2e444825 Merge branch 'Triangulation_3-fix_simplex_traverser-GF' into Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6 2023-06-21 10:19:52 +02:00
Laurent Rineau 28ab0b7c3e another bug-fix
Jane and I thought that case

  vertex-vertex with `ch_next != Cell_handle()`

was not possible. Let's patch that.
2023-06-21 10:19:39 +02:00
Laurent Rineau d5f521c78c commit improvement to debugging code 2023-06-20 18:28:36 +02:00
Laurent Rineau 53d82e5007 Merge branch 'Triangulation_3-fix_simplex_traverser-GF' into Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6 2023-06-20 17:31:31 +02:00
Laurent Rineau 4a7f9269dc another bug fix?! 2023-06-20 17:31:13 +02:00
Laurent Rineau ad9efd0e18 Merge branch '5.6.x-branch' into Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6
# Conflicts:
#	STL_Extension/include/CGAL/Base_with_time_stamp.h
#	Triangulation_3/include/CGAL/Triangulation_3/internal/Triangulation_segment_traverser_3_impl.h
#	Triangulation_3/test/Triangulation_3/CMakeLists.txt
2023-06-20 16:03:30 +02:00
Laurent Rineau 4f94c70740 typos 2023-06-19 17:15:42 +02:00
Laurent Rineau 6edb602729 factorize code when cells are traversed 2023-06-19 17:11:19 +02:00
Laurent Rineau 14ff8c6af5 fix bugs 2023-06-19 17:06:10 +02:00
Laurent Rineau dcfd783953 change/fix some oddities in the code 2023-06-16 18:07:22 +02:00
Laurent Rineau 5a0c09d667 factorize/reformat the code
The cases `chnext == {}` and `chnext != {}` were actually very
similar.
2023-06-16 17:48:32 +02:00
Laurent Rineau 6b835a1799 use triangulation().tds().has_vertex to avoid dummies 2023-06-16 15:35:18 +02:00
Laurent Rineau 5c81b975ae triangulation() is now a reference 2023-06-16 15:33:02 +02:00
Laurent Rineau 80a4064350 chprev/chnext 2023-06-16 15:23:50 +02:00
Laurent Rineau 8207105503 fix accidental use of std::optional (boost:: instead) 2023-06-15 18:07:52 +02:00
Laurent Rineau c7130e0c58 fix test case 131I 2023-06-15 16:41:07 +02:00
Laurent Rineau 00aa91967b `prev` then `cur` is more logic 2023-06-15 12:33:00 +02:00
Laurent Rineau e574a3a191 fix case 132I 2023-06-15 12:32:35 +02:00
Laurent Rineau 9cd8f0e8e1 fix case 12 2023-06-15 11:32:41 +02:00
Laurent Rineau b9eea8ec0d bug-fix test case 121 2023-06-14 21:12:15 +02:00
Laurent Rineau d5f5a6e2cd buf-fix for case 032I 2023-06-13 17:19:03 +02:00
Jane Tournois c7f75a9030 wip fixes for simplex traverser
* test_segment_simplex_traverser_3 first failing test is now "032"
* the geometric intersection test fails because of doubles
2023-05-16 18:35:54 +02:00
Jane Tournois 4bf7c45c8b replace std::tuple Simplex with a struct
and then avoid all std std::get<i>(simplex), hard to read
2023-05-15 13:06:37 +02:00
Jane Tournois 087492b72d replace dealing with OUTSIDE_AFFINE_HULL
with tests on cell_iterator == end()
2023-05-12 16:13:30 +02:00
Laurent Rineau f181a8b7f7 additional bug-fix 2023-05-11 18:08:16 +02:00
Laurent Rineau 7260a9497c Add debug tool
Protected by the macro CGAL_DEBUG_TRIANGULATION_SEGMENT_TRAVERSER_3
2023-05-11 16:18:16 +02:00
Laurent Rineau 59d7a6306b cosmetic changes 2023-05-11 11:53:13 +02:00
Laurent Rineau 7a2c543b06 replace assert(false) by CGAL_unreachable() 2023-05-11 11:49:57 +02:00
Laurent Rineau dd738bf029 bug fix for the simplex traverser 2023-05-04 14:58:05 +02:00
albert-github c32b1f4127 spelling corrections
Some spelling corrections (Directories starting with `S` rest - `W`),
2022-11-16 13:22:39 +01:00
Andreas Fabri d3fca65ae5 CGAL: No longer per package assertions 2022-09-23 12:49:40 +01:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Jane Tournois 667171927a fix uninitialized parameter, and member, warnings 2020-11-03 17:57:30 +01:00
Jane Tournois 41e1e40827 fix the case ...-vertex-cell-end 2020-10-29 11:59:02 +01:00
Jane Tournois d48aa33305 fix degenerate some degenerate cases
in particular iterations ending with :
- cell-vertex-facet
- vertex-edge-vertex
- cell-vertex-facet
2020-10-27 15:32:01 +01:00
Sébastien Loriot 0a530e39e7 remove extra const 2020-07-20 15:28:50 +02:00
Jane Tournois e7bfe4cb6f add missing license header 2020-07-06 15:27:16 +02:00
Jane Tournois ea3ef4f1b7 ltnext can also be OUTSIDE_AFFINE_HULL, not necessarily facet
in particular when query segment ends on a vertex
2020-07-06 08:19:12 +02:00
Jane Tournois 99ea974425 remove unnecessary includes 2020-07-06 06:54:05 +02:00
Jane Tournois 4eb10d8323 fix license header 2020-07-06 06:44:00 +02:00
Sébastien Loriot a49881536d fix compilation errors and warnings 2020-04-10 18:30:50 +02:00
Sébastien Loriot 2876ad9af1 remove trailing whitespaces 2020-04-10 18:15:32 +02:00
Jane Tournois a69d3f1188 replace all the std::get<i>(tuple) by private accessors
the code gets easier to read and write
2020-04-06 13:23:39 +02:00
Jane Tournois 2eadd494a8 replace CGAL::cpp11::tuple by std::tuple 2020-04-06 07:02:21 +02:00
Jane Tournois 1ef0d4b83d segment traverser end() does not need s and t as parameters
the API gets simpler and easier with these changes

+ fix last valid value of the simplex iterator in some cases

after this commit, only the test test_triangulation_on_a_grid() keeps failing
2020-04-03 18:02:37 +02:00
Jane Tournois b9660603b9 add the new API in the code
and adapt examples and tests consistently
2020-04-03 06:52:25 +02:00