Commit Graph

110910 Commits

Author SHA1 Message Date
Sébastien Loriot e3b813389d rename 2025-03-27 16:11:18 +01:00
Sébastien Loriot fc3299462d improve description and update function name 2025-03-27 13:50:31 +01:00
Sébastien Loriot d51af86a65 update changes 2025-03-25 23:51:20 +01:00
Sébastien Loriot 86bf5305c8 add a way to collect input coplanar faces after corefinement 2025-03-25 23:47:51 +01:00
Sébastien Loriot 6257109821 Merge remote-tracking branch 'cgal/6.0.x-branch' 2025-03-24 11:55:32 +01:00
Sebastien Loriot 6a2c2752c2
SMDS: Allow whitespace in the line (#8793)
## Summary of Changes

Make the function `read_MEDIT()`  more tolerant.

TODO:
- [ ] Add tests

## Release Management

* Affected package(s): SMDS_3
* License and copyright ownership:  unchanged
2025-03-24 11:53:52 +01:00
Sébastien Loriot cf301c4d22 Merge pull request #8786 from efifogel/Aos_2-fixes-efif
Fixed do_intersect() of curves (provided by Edkirito).
2025-03-24 11:51:09 +01:00
Sebastien Loriot 1c948d21a5
Tetrahedral_remeshing - fix edges accidentally removed from complex (#8785)
## Summary of Changes

Fixes for split step in tetrahedral remeshing :
+ Some complex edges could get removed from complex before checking that
the splitting operation was totally allowed
+ it could happen that midpoint would invert sub-cells during split, for
very small volumes. This PR proposes a trick to try other possible
refinement points

## Release Management

* Affected package(s): Tetrahedral_remeshing
* License and copyright ownership: unchanged
2025-03-24 11:49:43 +01:00
Sébastien Loriot e463bcaec1 Merge pull request #8713 from efifogel/Aos_2-traits_concept-efif
Aos 2 traits concept efif
2025-03-24 11:45:17 +01:00
Sebastien Loriot bcdd46aed5
restore coherent orientation of faces (#8791)
This has been broken in 6.0
2025-03-24 11:43:10 +01:00
Sebastien Loriot f7f3f10346
Spelling correction (#8788)
Spelling correction
2025-03-24 11:42:42 +01:00
Andreas Fabri 648b2bf004 SMDS: Allow whitespace in the line 2025-03-20 16:52:02 +01:00
Sébastien Loriot 652f35794d restore coherant orientation of faces 2025-03-20 10:53:53 +01:00
Andreas Fabri feaa60ff81 Remove name of parameter which is only there for matching a function 2025-03-19 08:40:49 +01:00
Jane Tournois fcfae432e5 trailing whitespaces 2025-03-18 16:53:42 +01:00
Jane Tournois 1e553a2e90 for tetrahedra with very-very small volume (like 1e-15), split at midpoint can invert orientation
this commit introduces a heuristic to try other split points, close to midpoint, and hope
to find one that do not invert any incident tetrahedron to the edge to be split
2025-03-18 16:44:01 +01:00
Sébastien Loriot 03dd5e0122 colinear -> collinear 2025-03-17 17:59:49 +01:00
albert-github e7fcddb270 Spelling correction
Spelling correction
2025-03-17 17:54:48 +01:00
Laurent Rineau ab56f763cd sort 3rd party libs by name 2025-03-17 14:18:46 +01:00
Sebastien Loriot d24b862fcd
Early exits in compare squared distance to improve performance (#8758)
_Please use the following template to help us managing pull requests._

## Summary of Changes

compare_squared_distance are know wrote specifically for each pair of
objects instead of simply calling compare and squared_distance improving
performance.
Add test and benchmark for compare_squared_distance.
Add global functions to call compare_squared_distance.

## Release Management

* Affected package(s): Distance_3
* Issue(s) solved (if any):
* Feature/Small Feature (if any):
* Link to compiled documentation (obligatory for small feature) [*wrong
link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg)
* License and copyright ownership:
2025-03-17 13:52:33 +01:00
Sebastien Loriot e4d5ce2210
missing eol 2025-03-17 13:50:24 +01:00
Sébastien Loriot e37d5f639e Merge remote-tracking branch 'cgal/6.0.x-branch' into master 2025-03-17 10:13:50 +01:00
Sébastien Loriot 46a4ddb88f Merge remote-tracking branch 'cgal/5.6.x-branch' into cgal/6.0.x-branch 2025-03-17 10:13:05 +01:00
Sébastien Loriot dbcc15af3f fix warning 2025-03-17 09:19:02 +01:00
Sebastien Loriot 5451674075
Aos 2 dcel extension efif (#8710)
## Summary of Changes

The changes fix a bug in the extensions of vertex and halfedge types of
the DCEL when used to instantiate Arrangement_with_history_2 or similar
arrangement classes that derive from Arrangement_2.
Typically, only the face type is extended or all the 3 types (vertex,
halfedge, and face) are extended, and for such extensions we have
dedicated class templates. The bug shows up when trying to extend any
other subset of the 3 types, and apparently, this hasn't been used much
with Arrangement_with_history_2.

## Release Management

* Affected package(s): Arrangement_on_surface_2
* Issue(s) solved (if any): NA
* Feature/Small Feature (if any): NA
* Link to compiled documentation: NA
* License and copyright ownership: TAU
2025-03-17 09:11:49 +01:00
Efi Fogel f1b82b9dcc Enhanced to test intersection with (non x-monotone) curves 2025-03-17 10:10:17 +02:00
Sébastien Loriot a3266b3527 missing backtick 2025-03-17 09:07:48 +01:00
Sébastien Loriot f68d7f6ea2 remove extra template keyword 2025-03-17 08:56:30 +01:00
Efi Fogel 30e5d27ffc Added comment of a fix in the 2D Arrangement on Surface package 2025-03-15 12:09:10 +02:00
Efi Fogel b0ca5f2789 Fixed do_intersect() of curves (provided by Edkirito). 2025-03-15 12:04:27 +02:00
Sebastien Loriot 25d28c0e2f
Mesh_2: Fixes of write_VTU() (#8774)
## Summary of Changes

Add warning that the stream must be opened with `std::ios::binary`.
Deal with a potentially empty vector of faces.

## Release Management

* Affected package(s): Mesh_2
* License and copyright ownership:  unchanged
2025-03-14 20:10:20 +01:00
Sebastien Loriot 2f511f0330
fix issue #8773 "c3t3 -> binary -> c3t3 -> vtu writes invalid vtu files" (#8778)
## Summary of Changes

fix issue #8773: c3t3 -> binary -> c3t3 -> vtu writes invalid vtu files

When a c3t3 is loaded, its far vertices were not loaded correctly.

## Release Management

* Affected package(s): Mesh_3/SMDS_3
* Issue(s) solved (if any): fix #0000, fix #8773
* License and copyright ownership: maintenance by GF
2025-03-14 20:09:42 +01:00
Sebastien Loriot 82bd9a01ff
fix an issue with the offset meshing plugin (#8779) 2025-03-14 20:09:22 +01:00
Jane Tournois 9687034ac3 move `remove_from_complex(e)` after checking orientation
otherwise it may happen that `e` is removed from complex, then Vertex_handle()
is returned to cancel split, and `e` is not re-added to the complex
2025-03-14 15:53:14 +01:00
Sébastien Loriot 0ecfcb9962 typo 2025-03-12 14:40:09 +01:00
Laurent Rineau a3e64cffbc fix an issue with the offset meshing plugin 2025-03-10 17:21:08 +01:00
Laurent Rineau 4f4f78979d
remove verbose macros 2025-03-10 17:18:09 +01:00
Laurent Rineau 2bd90e5d9c fix issue #8773 "c3t3 -> binary -> c3t3 -> vtu writes invalid vtu files"
When a c3t3 is loaded, its far vertices were not loaded correctly.
2025-03-10 17:12:41 +01:00
Léo Valque 676495c5c1 limit to 1M pair tested in bench_thingi10K 2025-03-07 18:12:42 +01:00
Sébastien Loriot ad7e4754aa Merge remote-tracking branch 'cgal/6.0.x-branch' into master 2025-03-07 17:26:54 +01:00
Sébastien Loriot fd9068d403 Merge remote-tracking branch 'cgal/5.6.x-branch' into cgal/6.0.x-branch 2025-03-07 17:25:57 +01:00
Sebastien Loriot ee6beddac3
Make it possible to enter target coordinates to move a point (#8755)
## Summary of Changes

Modifying coordinates in the files and reloading is painful, so this PR
adds a way to specify new coordinates from the selection item:



https://github.com/user-attachments/assets/965f6c65-0936-4778-a9ac-8e8acb237774



## Release Management

* Affected package(s): `Lab`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): - 
* License and copyright ownership: no change
2025-03-07 17:18:21 +01:00
Sebastien Loriot 73041ed1f2
KSP: Repairing EPECK support in KSP (#8753)
## Summary of Changes

Re-enabling EPECK support in KSP 

## Release Management

* Affected package(s): KSP, KSR
2025-03-07 17:16:58 +01:00
Sebastien Loriot 273ffde7bf
T2: avoid maybe uninitialized warning (#8751)
## Summary of Changes

We know that the variable `i` will be set by `is_edge()`, we try to
indicate it with a `CGAL_assume()` but that does not help the compiler,
so let's just initialize it. We get the warning
[here](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-I-95/Triangulation_2/TestReport_lrineau_Ubuntu-latest-GCC6-Release.gz).

I am wondering if the `CGAL_assertion()` I have put makes sense. 

## Release Management

* Affected package(s): Triangulation_2
* License and copyright ownership: unchanged
2025-03-07 17:16:06 +01:00
Sebastien Loriot 82aa7d0c3d
Lab - Fixes for C3t3 IO in `.vtu` format (#8757)
## Summary of Changes
* Subdomain indices can be 0 or negative, just the cells with subdomain
0 are not added to the complex.
* make binary status of the opened `ofstream` consistent with call to
`CGAL::IO::output_to_vtu()`

## Release Management

* Affected package(s): CGAL Lab
* License and copyright ownership: unchanged
2025-03-07 17:14:34 +01:00
Sebastien Loriot 1ae4d84114
Mesh_3 - fix the use of `edge_min_size` at corners (#8766)
## Summary of Changes

Properly use `minimal_weight` (i.e. `edge_min_size`) in
`insert_corners()`.

## Release Management

* Affected package(s): Mesh_3
* License and copyright ownership: unchanged
2025-03-07 17:14:04 +01:00
Sebastien Loriot 4f2f518e6d
Deal with dimension != 2 (#8767)
Fixes for #8748
2025-03-07 17:12:14 +01:00
Sebastien Loriot 9e00c35dab
CGAL: Do not include basic.h in examples (#8749)
## Summary of Changes

Examples are not supposed to ` #include <CGAL/basic.h>`.

## Release Management

* Affected package(s): Arrangements
* License and copyright ownership:  unchanged
2025-03-07 17:11:31 +01:00
Andreas Fabri 1cecefe1c8 Mesh_2: Fixes of write_VTU 2025-03-07 07:37:28 +00:00
Sebastien Loriot f1ebfd1f08 fix issue on macOS 2025-03-06 16:11:34 +01:00