Commit Graph

110887 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé e4f30b79fa Fix & clean SDG_2 2025-03-16 14:25:48 +01:00
Mael Rouxel-Labbé c5d51c4909 Fix compilation in periodic triangulations 2025-03-16 14:25:04 +01:00
Mael Rouxel-Labbé 8e0b7a5827 Fix compilation in Partition_2 2025-03-16 14:24:18 +01:00
Mael Rouxel-Labbé a98d5149de Remove useless header includes 2025-03-16 13:33:44 +01:00
Mael Rouxel-Labbé ed50e36c68 Fix typo in typedef making the type be K::Bounded_side instead of CGAL::Bounded_side 2025-03-16 13:31:16 +01:00
Mael Rouxel-Labbé a06a6a35b9 Use std::invoke_result and not result_type to get the return type 2025-03-16 13:27:07 +01:00
Mael Rouxel-Labbé 13842b219f Fix periodic predicates relying on a result_type typedef 2025-03-16 13:26:31 +01:00
Mael Rouxel-Labbé 96524bdf2b Use std::invoke, CGAL::cpp20, ... 2025-03-15 22:52:44 +01:00
Mael Rouxel-Labbé f9001833b1 Merge remote-tracking branch 'cgal/master' into Kernel_23-Fix_dangling_ref_in_CC3-GF 2025-03-15 14:09:28 +01:00
Sebastien Loriot 25d28c0e2f
Mesh_2: Fixes of write_VTU() (#8774)
## Summary of Changes

Add warning that the stream must be opened with `std::ios::binary`.
Deal with a potentially empty vector of faces.

## Release Management

* Affected package(s): Mesh_2
* License and copyright ownership:  unchanged
2025-03-14 20:10:20 +01:00
Sebastien Loriot 2f511f0330
fix issue #8773 "c3t3 -> binary -> c3t3 -> vtu writes invalid vtu files" (#8778)
## Summary of Changes

fix issue #8773: c3t3 -> binary -> c3t3 -> vtu writes invalid vtu files

When a c3t3 is loaded, its far vertices were not loaded correctly.

## Release Management

* Affected package(s): Mesh_3/SMDS_3
* Issue(s) solved (if any): fix #0000, fix #8773
* License and copyright ownership: maintenance by GF
2025-03-14 20:09:42 +01:00
Sebastien Loriot 82bd9a01ff
fix an issue with the offset meshing plugin (#8779) 2025-03-14 20:09:22 +01:00
Sébastien Loriot 0ecfcb9962 typo 2025-03-12 14:40:09 +01:00
Laurent Rineau a3e64cffbc fix an issue with the offset meshing plugin 2025-03-10 17:21:08 +01:00
Laurent Rineau 4f4f78979d
remove verbose macros 2025-03-10 17:18:09 +01:00
Laurent Rineau 2bd90e5d9c fix issue #8773 "c3t3 -> binary -> c3t3 -> vtu writes invalid vtu files"
When a c3t3 is loaded, its far vertices were not loaded correctly.
2025-03-10 17:12:41 +01:00
Sébastien Loriot ad7e4754aa Merge remote-tracking branch 'cgal/6.0.x-branch' into master 2025-03-07 17:26:54 +01:00
Sébastien Loriot fd9068d403 Merge remote-tracking branch 'cgal/5.6.x-branch' into cgal/6.0.x-branch 2025-03-07 17:25:57 +01:00
Sebastien Loriot ee6beddac3
Make it possible to enter target coordinates to move a point (#8755)
## Summary of Changes

Modifying coordinates in the files and reloading is painful, so this PR
adds a way to specify new coordinates from the selection item:



https://github.com/user-attachments/assets/965f6c65-0936-4778-a9ac-8e8acb237774



## Release Management

* Affected package(s): `Lab`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): - 
* License and copyright ownership: no change
2025-03-07 17:18:21 +01:00
Sebastien Loriot 73041ed1f2
KSP: Repairing EPECK support in KSP (#8753)
## Summary of Changes

Re-enabling EPECK support in KSP 

## Release Management

* Affected package(s): KSP, KSR
2025-03-07 17:16:58 +01:00
Sebastien Loriot 273ffde7bf
T2: avoid maybe uninitialized warning (#8751)
## Summary of Changes

We know that the variable `i` will be set by `is_edge()`, we try to
indicate it with a `CGAL_assume()` but that does not help the compiler,
so let's just initialize it. We get the warning
[here](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-I-95/Triangulation_2/TestReport_lrineau_Ubuntu-latest-GCC6-Release.gz).

I am wondering if the `CGAL_assertion()` I have put makes sense. 

## Release Management

* Affected package(s): Triangulation_2
* License and copyright ownership: unchanged
2025-03-07 17:16:06 +01:00
Sebastien Loriot 82aa7d0c3d
Lab - Fixes for C3t3 IO in `.vtu` format (#8757)
## Summary of Changes
* Subdomain indices can be 0 or negative, just the cells with subdomain
0 are not added to the complex.
* make binary status of the opened `ofstream` consistent with call to
`CGAL::IO::output_to_vtu()`

## Release Management

* Affected package(s): CGAL Lab
* License and copyright ownership: unchanged
2025-03-07 17:14:34 +01:00
Sebastien Loriot 1ae4d84114
Mesh_3 - fix the use of `edge_min_size` at corners (#8766)
## Summary of Changes

Properly use `minimal_weight` (i.e. `edge_min_size`) in
`insert_corners()`.

## Release Management

* Affected package(s): Mesh_3
* License and copyright ownership: unchanged
2025-03-07 17:14:04 +01:00
Sebastien Loriot 4f2f518e6d
Deal with dimension != 2 (#8767)
Fixes for #8748
2025-03-07 17:12:14 +01:00
Sebastien Loriot 9e00c35dab
CGAL: Do not include basic.h in examples (#8749)
## Summary of Changes

Examples are not supposed to ` #include <CGAL/basic.h>`.

## Release Management

* Affected package(s): Arrangements
* License and copyright ownership:  unchanged
2025-03-07 17:11:31 +01:00
Andreas Fabri 1cecefe1c8 Mesh_2: Fixes of write_VTU 2025-03-07 07:37:28 +00:00
Sébastien Loriot 48d8f54796 use previous vertex as hint 2025-03-03 18:22:05 +01:00
Sébastien Loriot 1b189f40fd check should be on the dimension not the number of points 2025-03-03 16:27:24 +01:00
Jane Tournois de16b71eba use minimal_weight (i.e. edge_min_size) in insert_corners() 2025-03-03 14:52:04 +00:00
Sébastien Loriot 138b06ca11 add missing include 2025-03-03 10:15:51 +01:00
Jane Tournois d6018ee8ca open the ofstream in binary mode to be consistent with BINARY parameter in CGAL::IO::output_to_vtu() 2025-02-27 16:52:12 +01:00
Jane Tournois 2d4c17a088 deal with cells with subdomain_index 0 2025-02-27 15:13:20 +01:00
Mael Rouxel-Labbé ab082b29f1 Make it possible to enter target coordinates in Selection item's "Move Point" 2025-02-26 00:11:08 +01:00
Sven Oesau 24a31124b1 repairing EPECK support in KSP 2025-02-24 12:15:58 +01:00
Andreas Fabri f557b1ca6e T2: avoid maybe uninitialized warning 2025-02-24 07:31:43 +00:00
Sebastien Loriot 299a89f212
Added a precondition for Arrangement_on_surface_2::merge_edge(e1, e2) (#8742)
Added a precondition for merge_edge(e1, e2) that requires that two
halfedges have the same direction.

## Summary of Changes

The title says it all

## Release Management

* Affected package(s): Arrangement_on_surface_2
* Issue(s) solved (if any): fix #8659
* Feature/Small Feature (if any): 
* Link to compiled documentation:
* License and copyright ownership: TAU
2025-02-24 06:38:09 +01:00
Andreas Fabri 29e99af954 A test file 2025-02-23 14:05:40 +00:00
Andreas Fabri c716539b2a CGAL: Do not include basic.h in examples 2025-02-23 08:25:11 +00:00
Sebastien Loriot 18f0405065
Spelling correction (#8746)
Spelling correction
2025-02-21 06:56:19 +01:00
Sebastien Loriot 65202060af
Spelling correction (#8747)
Spelling correction

As this is a spelling correction is in code (and outside my normal realm
of PRs) I created a separate PR for it. I cannot test it, b I'm quite
confident that it won't lead to problems. I think the old name contained
a typo.
2025-02-21 06:55:34 +01:00
albert-github cb1f3fb37a Spelling correction
Spelling correction

As this is a spelling correction is in code (and outside my normal realm of PRs) I created a separate PR for it.
I cannot test it,  b I'm quite confident that it won't lead to problems. I think the old name contained a typo.
2025-02-19 11:38:14 +01:00
albert-github cc9ab04a27 Spelling correction
Spelling correction
2025-02-19 11:29:09 +01:00
Sébastien Loriot 4f9bf703e3 Merge remote-tracking branch 'cgal/6.0.x-branch' in master 2025-02-19 07:19:25 +01:00
Sébastien Loriot f7629fa682 Merge remote-tracking branch 'cgal/5.6.x-branch' into cgal/6.0.x-branch 2025-02-19 07:18:41 +01:00
Sebastien Loriot 133b48b55c
Polyline_simplification: Fix Detection of Unremovable Vertices (#8736)
## Summary of Changes

We missed a variation of overlapping constraints.

## Release Management

* Affected package(s): Polyline_simplification 
* Issue(s) solved (if any): fix #8735
* License and copyright ownership:  unchanged
2025-02-19 07:17:21 +01:00
Sebastien Loriot ad215de1f0
Incorrect rendered formulas (#8732)
The formula in Documentation/doc/biblio/cgal_manual.bib
```
 @article{cgal:cgm-fobbo-11,
   title={Fast Oriented Bounding Box Optimization on the Rotation Group $\SO(3, \mathrm{R})$},
   author={Chang, Chia-Tche and Gorissen, Bastien and Melchior, Samuel},

```
renders incorrectly (see Optimal_bounding_box/citelist.html) as there is
no command `\SO` in LaTeX

The formula in doc/Kernel_d/CGAL/Kernel_d/Aff_transformation_d.h
```
\pre \f$ sin_num^2 + cos_num^2 = den^2\f$ and \f$ 0 \leq e_1 < e_2 < d\f$.
```
renders in an unexpected way (see
Kernel_d/classCGAL_1_1Aff__transformation__d.html) as the `_` is seen as
subscript operator in LaTeX
2025-02-19 07:15:02 +01:00
Sebastien Loriot 8c8618ad04
Remove check doc todos (#8738)
We can consider them as done now
2025-02-19 07:13:33 +01:00
Sebastien Loriot 838f4b8b12
Cmap add test gdamiand (#8737)
## Summary of Changes

Solve a bug for CMap and GMap when we iterate on an empty map with an
iterator that needs to mark cells, and when using index version.

## Release Management

* Affected package(s): CMap GMap
2025-02-19 07:12:54 +01:00
Efi Fogel 40646af54e Added missing const to some traits operators 2025-02-18 17:40:01 +02:00
Efi Fogel 31f271b88c Added a precondition for merge_edge(e1, e2) that requires that two halfedges have the same direction. 2025-02-17 10:17:11 +02:00