Commit Graph

3622 Commits

Author SHA1 Message Date
Sébastien Loriot 24611ab4ed fix assertion 2020-03-24 08:53:00 +01:00
Maxime Gimeno c3bcf9cbfe Changes after review 2020-03-23 16:11:08 +01:00
Maxime Gimeno bc956295da Add face_patch_map as NP to split_connected_components() to allow giving an existing map to the function and avoid having to recompute it. 2020-03-23 13:24:21 +01:00
Mael Rouxel-Labbé af1c69354b Merge remote-tracking branch 'cgal/master' into PMP-Make_remove_self_intersections_local-GF 2020-03-20 15:44:51 +01:00
Sébastien Loriot 6b69e12c87 Merge remote-tracking branch 'cgal/releases/CGAL-5.0-branch' 2020-03-20 15:09:44 +01:00
Sébastien Loriot df1e7d3235 Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' 2020-03-20 15:09:07 +01:00
Maxime Gimeno 9ecbd05a4c update fimap + default concurrency tag 2020-03-20 14:01:40 +01:00
Mael de563e9844
Merge branch 'master' into PMP-new_functions-GF 2020-03-20 08:48:39 +01:00
Sébastien Loriot 954d23a64c Merge pull request #4418 from sloriot/PMP-soup_to_mesh_add_vpm
PMP: Add `point_map` and `vertex_point_map` to `polygon_soup_to_polygon_mesh`
2020-03-19 16:22:58 +01:00
Mael Rouxel-Labbé 016ad2e4f0 Use actual named parameter name in clip figure's caption 2020-03-19 09:05:49 +01:00
Maxime Gimeno d7ea0de1af Add tests for split and split_plane. 2020-03-18 11:49:21 +01:00
Mael 38abfdfa1f
Tiny clarification 2020-03-18 08:51:09 +01:00
Mael 5bf302092d
Update comments 2020-03-18 08:49:05 +01:00
Sébastien Loriot 8eeee9c9a8 Update from master after default initialized index maps
Merge-commit + default map fixes
2020-03-18 08:10:54 +01:00
Mael Rouxel-Labbé 72bfe2c96d Use the new index map BGL API 2020-03-17 20:29:48 +01:00
Mael Rouxel-Labbé d84bf86b61 Clean indentation (no other changes) 2020-03-17 20:19:46 +01:00
Mael Rouxel-Labbé c95082deca Fix doc of NP face_index_map 2020-03-17 20:13:18 +01:00
Mael Rouxel-Labbé 44f683db8e Fix bad merge resolution 2020-03-17 20:07:28 +01:00
Mael Rouxel-Labbé 618a72b739 Merge remote-tracking branch 'cgal/master' into PMP-soup_to_mesh_add_vpm 2020-03-17 20:00:31 +01:00
Mael 8ee3ec8f7b
Merge branch 'master' into PMP-Add_split_to_clip-GF 2020-03-17 19:47:28 +01:00
Sebastien Loriot 1454b9903c
Merge pull request #4209 from maxGimeno/PMP-Default_pmap-maxGimeno
PMP: Default Property_maps for Index_maps
2020-03-17 18:27:55 +01:00
Sébastien Loriot cc1bd20c7c Merge pull request #4356 from sgiraudot/Documentation-Update_cmake_variables-GF
Third party libs: improve documentation + introduce new CMake functions
2020-03-17 18:19:40 +01:00
Sébastien Loriot e437fe049a fix link 2020-03-17 16:04:38 +01:00
Sébastien Loriot dc85217d5a fixes after @afabri's review 2020-03-17 15:49:46 +01:00
Sébastien Loriot 2378b0199d "fix position" 2020-03-17 11:38:27 +01:00
Sébastien Loriot f4b5f4f7a0 add sentense in the user manual 2020-03-17 11:31:04 +01:00
Sébastien Loriot d8e2691bfa typo 2020-03-17 11:10:21 +01:00
Sébastien Loriot b032917945 more doc 2020-03-17 11:09:08 +01:00
Sébastien Loriot 440f9f1e77 remove todo that it does not worth implement 2020-03-17 10:49:33 +01:00
Sébastien Loriot b26905f2e6 doc requirement on vpm 2020-03-17 10:31:51 +01:00
Sébastien Loriot 6b8f85495f remove extra spaces 2020-03-17 10:24:57 +01:00
Sébastien Loriot 8d00b92bba add precondition 2020-03-17 10:20:04 +01:00
Sébastien Loriot e9c9359f9a fix indentation 2020-03-17 10:19:34 +01:00
Sébastien Loriot d44dad60c2 still collect faces if cc_handled as it is used to set the volume id 2020-03-17 09:50:52 +01:00
Sebastien Loriot 9e72d43784
Apply suggestions from code review
Co-Authored-By: Mael <mael.rouxel.labbe@geometryfactory.com>
2020-03-17 08:21:50 +01:00
Sébastien Loriot 32813dc976 Merge remote-tracking branch 'cgal/releases/CGAL-5.0-branch' 2020-03-16 16:32:47 +01:00
Sebastien Loriot fc14d200ff
Merge pull request #4578 from sloriot/PMP-doc_clip_default
PMP: Document default values in clip()
2020-03-16 16:30:53 +01:00
Sébastien Loriot cf99ea072d Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' 2020-03-16 16:19:38 +01:00
Maxime Gimeno 701a7f6774 Doc fixes and cpp11 2020-03-16 12:08:49 +01:00
Mael Rouxel-Labbé 9f909ce0da Also allow arrays to be used in PM_to_PS 2020-03-14 21:59:02 +01:00
Mael d94dace5e9
Fix typo (PMP)
Co-Authored-By: Sebastien Loriot <sloriot.ml@gmail.com>
2020-03-13 18:37:47 +01:00
Mael Rouxel-Labbé c56c0a604d Clarify description of function parameter 2020-03-13 10:40:16 +01:00
Sébastien Loriot 3d66c590bd doc default values 2020-03-13 05:18:05 +01:00
Maxime Gimeno 2424d54e30 Merge remote-tracking branch 'cgal/master' into PMP-new_functions-GF 2020-03-12 12:10:44 +01:00
Maxime Gimeno fcf6245e48 Fix some doc 2020-03-12 12:09:15 +01:00
Maxime Gimeno fe4fd26735 Fix doc 2020-03-12 09:18:05 +01:00
Mael Rouxel-Labbé 1b9b960e09 Index maps must be initialized when passed via Named Parameters 2020-03-11 16:45:21 +01:00
Sébastien Loriot 2280bea679 add missing inline 2020-03-10 10:57:52 +01:00
Mael Rouxel-Labbé 23c3da94b0 Fix using now-removed named parameter helper 2020-03-10 09:07:37 +01:00
Mael Rouxel-Labbé 63e1a33a4f Add missing #include 2020-03-10 09:07:23 +01:00
Mael Rouxel-Labbé ff8a21f6e6 Minor doc rephrase (dynamic pmap is not always non-constant time access) 2020-03-09 11:49:21 +01:00
Mael Rouxel-Labbé 544dbb441a Add more information about index maps in BGL/PMP's NamedParameters.txt 2020-03-09 10:53:48 +01:00
Mael Rouxel-Labbé e8757d451a Clarify doc of PMP::clip
The face_index_map must be writable or stay well-initialized throughout
creation and deletion of faces.
2020-03-09 10:02:44 +01:00
Mael Rouxel-Labbé 645d81d298 Clean documentation
These mentions can be regrouped in the namedparameters.txt file
2020-03-09 09:59:41 +01:00
Mael Rouxel-Labbé 550138a116 Update PMP::clip tests (the pmaps must be initialized) 2020-03-09 09:58:48 +01:00
Mael Rouxel-Labbé 54b5f74edd Remove obsolete call dispatcher mechanism
Which also was kinda broken: if a face index map was actually passed as
named parameter, it would be ignored.
2020-03-09 09:57:13 +01:00
Mael Rouxel-Labbé d7f24b98e8 Correctly initialize face index maps in coref/autoref 2020-03-09 09:56:55 +01:00
Mael Rouxel-Labbé 84186fc78f Allow face index maps of different type in Face_graph_output_builder
+ don't take references to property maps
2020-03-09 09:55:58 +01:00
Mael Rouxel-Labbé 9d5ce20393 Clean doc 2020-03-06 18:16:37 +01:00
Mael Rouxel-Labbé 38da5ae2c4 Rename 'faces' parameter to avoid conflict with function 'faces(FaceGraph)' 2020-03-06 15:30:39 +01:00
Mael Rouxel-Labbé ad62f89a20 Use the new index map initializer functions and fix doc 2020-03-06 15:25:38 +01:00
Mael Rouxel-Labbé 798a476d63 Merge branch 'PMP-Default_pmap-maxGimeno-old' into PMP-Default_pmap-maxGimeno 2020-03-06 13:20:00 +01:00
Mael Rouxel-Labbé 3d7b084c66 Merge branch 'PMP-Fix_merge_duplicated_vertices-GF-old' into PMP-Fix_merge_duplicated_vertices-GF 2020-03-06 12:59:36 +01:00
Mael 150d6cbe44 Uniformize todos 2020-03-06 12:18:32 +01:00
Mael Rouxel-Labbé e3efff2d7e Disable remove_self_intersections examples/tests 2020-03-06 12:15:11 +01:00
Mael Rouxel-Labbé 8d4313f7a8 Merge branch 'PMP-Make_remove_self_intersections_local-GF-old' into PMP-Make_remove_self_intersections_local-GF 2020-03-06 12:13:30 +01:00
Mael Rouxel-Labbé 0133e9f2f9 Merge branch 'PMP-soup_to_mesh_add_vpm-old' into PMP-soup_to_mesh_add_vpm 2020-03-06 11:41:31 +01:00
Mael Rouxel-Labbé 4a77f29804 Replace index map validity runtime check with an assertion 2020-03-05 17:02:25 +01:00
Mael Rouxel-Labbé 96b6cd002b Remove obsolete call to index map initializations
These maps are obtained using get_initialized_face_index_map(g, np)
2020-03-05 15:32:02 +01:00
Laurent Rineau 79699f9fc2 Merge pull request #4259 from MaelRL/PMP-Snapping_improvements-GF
PMP: Improvements for snapping
2020-03-05 15:06:46 +01:00
Jane Tournois 21ee697498 merge both `if` conditions 2020-03-05 15:02:55 +01:00
Laurent Rineau b281902cf9 Merge pull request #4551 from MaelRL/CGAL-Fix_todo_doc_warning-GF
PMP: Fix doxygen warnings
2020-03-05 14:52:03 +01:00
Jane Tournois dd2c0e4e89 consider surface patches border halfedges as PATCH_BORDERS
surface patch borders should be considered similarly to constrained edges,
so that they still represent the same polyline after remeshing
+ it is what is documented
2020-03-05 12:27:20 +01:00
Mael Rouxel-Labbé 14582b1be9 Fix compilation (wrong mesh type) 2020-03-05 11:42:54 +01:00
Mael Rouxel-Labbé ca68f22f8d Update usage of internal index map initializer to new API 2020-03-04 14:20:56 +01:00
Mael Rouxel-Labbé 432d5c724a Improve usages of get_initialized_xxx_index_map 2020-03-04 13:37:09 +01:00
Mael Rouxel-Labbé 889108e253 Update get_initialize_xxx_index_map usages to new API 2020-03-04 12:58:42 +01:00
Mael Rouxel-Labbé c4ea4d9d99 More doc fixes 2020-03-02 13:35:43 +01:00
Mael Rouxel-Labbé d5892508c3 Store the squared lengths, avoid sqrt calls 2020-03-02 13:33:43 +01:00
Mael Rouxel-Labbé 8b53222ce2 Avoid asserting deep down when test parameters aren't passed 2020-03-02 12:51:18 +01:00
Mael Rouxel-Labbé 05703c10b9 Fix somes issues in the doc of PMP::distance.h 2020-03-02 12:43:09 +01:00
Mael Rouxel-Labbé 8ed12b7ec0 Add undocumented template parameters 2020-03-02 12:13:15 +01:00
Mael Rouxel-Labbé 83dbc1345f Use const& to points 2020-03-02 12:13:02 +01:00
Mael Rouxel-Labbé b57a1d7378 Replace BOOST_FOREACH by modern for loop 2020-03-02 12:12:30 +01:00
Mael Rouxel-Labbé 7ffb30838d Uniformize member names 2020-03-02 12:11:48 +01:00
Mael Rouxel-Labbé d1da11a502 Avoid some copies of named parameters 2020-03-02 12:10:35 +01:00
Mael Rouxel-Labbé 1c3e412cfd Rename template parameter for clarity 2020-03-02 11:44:21 +01:00
Mael Rouxel-Labbé a17d6a853e Fix includes 2020-03-02 11:42:54 +01:00
Mael Rouxel-Labbé 6b58618ba6 Clean code (indentation, trailing whitespace etc.) 2020-03-02 11:42:36 +01:00
Mael Rouxel-Labbé 71f2474944 Fix leftover '///' that ought to be '//'
Causes issues with Doxygen
2020-03-02 09:42:54 +01:00
Mael Rouxel-Labbé c6fa8c03b5 Uniformize todos 2020-03-02 09:42:35 +01:00
Mael 6b147c89a0
Fix doc 2020-02-28 13:59:42 +01:00
Mael 733fd95df7
Misc cleaning 2020-02-28 13:58:19 +01:00
Mael Rouxel-Labbé badbee5c31 Minor doc fixes 2020-02-28 13:27:44 +01:00
Mael Rouxel-Labbé 09efb802c3 Add a line about PMP::PM_to_PS to the user manual + link in ref manual 2020-02-28 13:07:02 +01:00
Mael Rouxel-Labbé 994b4858b2 Doc fixes 2020-02-28 12:56:38 +01:00
Mael Rouxel-Labbé 26463ded7a Update NPs using default constructed default values to new API
+ misc cleaning
2020-02-28 11:55:17 +01:00
Mael Rouxel-Labbé fb64638173 Clean example/test 2020-02-27 16:10:09 +01:00
Mael Rouxel-Labbé 09cb327ac3 Use dummy initialization to silence a warning 2020-02-27 09:19:49 +01:00
Mael Rouxel-Labbé 5f542ffa00 Remove snap examples from PMP-examples' CMakeLists.txt (for now) 2020-02-26 08:58:26 +01:00